Skip to content

Commit

Permalink
Reland [lldb] Fix TestThreadStepOut.py after "Flush local value map o…
Browse files Browse the repository at this point in the history
…n every instruction"

The original patch got reverted as a dependency of cf1c774 .
That patch got relanded so it's also necessary to reland this patch.

Original summary:

After cf1c774, Clang seems to generate code
that is more similar to icc/Clang, so we can use the same line numbers for
all compilers in this test.
  • Loading branch information
Teemperor committed Jan 21, 2021
1 parent 060b51e commit ed2853d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,8 @@ def setUp(self):
self.bkpt_string = '// Set breakpoint here'
self.breakpoint = line_number('main.cpp', self.bkpt_string)

if "gcc" in self.getCompiler() or self.isIntelCompiler():
self.step_out_destination = line_number(
'main.cpp', '// Expect to stop here after step-out (icc and gcc)')
else:
self.step_out_destination = line_number(
'main.cpp', '// Expect to stop here after step-out (clang)')
self.step_out_destination = line_number(
'main.cpp', '// Expect to stop here after step-out.')

def step_out_single_thread_with_cmd(self):
self.step_out_with_cmd("this-thread")
Expand Down
4 changes: 2 additions & 2 deletions lldb/test/API/functionalities/thread/step_out/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ thread_func ()
pseudo_barrier_wait(g_barrier);

// Do something
step_out_of_here(); // Expect to stop here after step-out (clang)
step_out_of_here();

// Return
return NULL; // Expect to stop here after step-out (icc and gcc)
return NULL; // Expect to stop here after step-out.
}

int main ()
Expand Down

0 comments on commit ed2853d

Please sign in to comment.