From f49c0f83aa482a476140c66f32f57449b992bb94 Mon Sep 17 00:00:00 2001 From: Denis Zobnin Date: Wed, 10 Feb 2016 11:23:48 +0000 Subject: [PATCH] Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type. This patch is to upgrade FunctionTypeUnwrapper for correct processing of AttributedType. Fixes PR25786. Patch by Alexander Makarov. Differential Revision: http://reviews.llvm.org/D15373 llvm-svn: 260373 --- clang/lib/Sema/SemaType.cpp | 7 +++++++ clang/test/CodeGen/pr25786.c | 11 +++++++++++ clang/test/Sema/pr25786.c | 12 ++++++++++++ 3 files changed, 30 insertions(+) create mode 100644 clang/test/CodeGen/pr25786.c create mode 100644 clang/test/Sema/pr25786.c diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp index c51255c934dc8..cabb5bc0e0af4 100644 --- a/clang/lib/Sema/SemaType.cpp +++ b/clang/lib/Sema/SemaType.cpp @@ -5370,6 +5370,7 @@ namespace { struct FunctionTypeUnwrapper { enum WrapKind { Desugar, + Attributed, Parens, Pointer, BlockPointer, @@ -5402,6 +5403,9 @@ namespace { } else if (isa(Ty)) { T = cast(Ty)->getPointeeType(); Stack.push_back(Reference); + } else if (isa(Ty)) { + T = cast(Ty)->getEquivalentType(); + Stack.push_back(Attributed); } else { const Type *DTy = Ty->getUnqualifiedDesugaredType(); if (Ty == DTy) { @@ -5450,6 +5454,9 @@ namespace { // information. return wrap(C, Old->getUnqualifiedDesugaredType(), I); + case Attributed: + return wrap(C, cast(Old)->getEquivalentType(), I); + case Parens: { QualType New = wrap(C, cast(Old)->getInnerType(), I); return C.getParenType(New); diff --git a/clang/test/CodeGen/pr25786.c b/clang/test/CodeGen/pr25786.c new file mode 100644 index 0000000000000..612da7e8a3690 --- /dev/null +++ b/clang/test/CodeGen/pr25786.c @@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple i686-unknown-linux-gnu -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK-OK + +void (__attribute__((regparm(3), stdcall)) *pf) (); +void (__attribute__((regparm(2), stdcall)) foo)(int a) { +} +// CHECK: @pf = common global void (...)* null +// CHECK: define void @foo(i32 %a) + +// CHECK-OK: @pf = common global void (...)* null +// CHECK-OK: define x86_stdcallcc void @foo(i32 inreg %a) diff --git a/clang/test/Sema/pr25786.c b/clang/test/Sema/pr25786.c new file mode 100644 index 0000000000000..2ce65311a24fe --- /dev/null +++ b/clang/test/Sema/pr25786.c @@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -DTEST -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple i686-unknown-linux-gnu -fsyntax-only -verify %s + +#if TEST +void (__attribute__((regparm(3), stdcall)) *pf) (); //expected-warning {{calling convention 'stdcall' ignored for this target}} +void (__attribute__((regparm(2), stdcall)) foo)(int a) { //expected-warning {{calling convention 'stdcall' ignored for this target}} +} +#else +//expected-no-diagnostics +void (__attribute__((regparm(3), stdcall)) *pf) (); +void (__attribute__((regparm(2), stdcall)) foo)(int a) {} +#endif