diff --git a/clang-tools-extra/clang-query/tool/ClangQuery.cpp b/clang-tools-extra/clang-query/tool/ClangQuery.cpp index 0c471def2e140d..5cfa0acf9120a1 100644 --- a/clang-tools-extra/clang-query/tool/ClangQuery.cpp +++ b/clang-tools-extra/clang-query/tool/ClangQuery.cpp @@ -35,7 +35,6 @@ #include "llvm/Support/CommandLine.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Signals.h" -#include "llvm/Support/WithColor.h" #include #include @@ -87,14 +86,7 @@ bool runCommandsInFile(const char *ExeName, std::string const &FileName, int main(int argc, const char **argv) { llvm::sys::PrintStackTraceOnErrorSignal(argv[0]); - llvm::Expected OptionsParser = - CommonOptionsParser::create(argc, argv, ClangQueryCategory, - llvm::cl::OneOrMore); - - if (!OptionsParser) { - llvm::WithColor::error() << llvm::toString(OptionsParser.takeError()); - return 1; - } + CommonOptionsParser OptionsParser(argc, argv, ClangQueryCategory); if (!Commands.empty() && !CommandFiles.empty()) { llvm::errs() << argv[0] << ": cannot specify both -c and -f\n"; @@ -107,8 +99,8 @@ int main(int argc, const char **argv) { return 1; } - ClangTool Tool(OptionsParser->getCompilations(), - OptionsParser->getSourcePathList()); + ClangTool Tool(OptionsParser.getCompilations(), + OptionsParser.getSourcePathList()); std::vector> ASTs; int Status = Tool.buildASTs(ASTs); int ASTStatus = 0; diff --git a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp index aca16b0d6d819a..665d1002683448 100644 --- a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp +++ b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp @@ -23,7 +23,6 @@ #include "llvm/Support/Process.h" #include "llvm/Support/Signals.h" #include "llvm/Support/TargetSelect.h" -#include "llvm/Support/WithColor.h" using namespace clang::ast_matchers; using namespace clang::driver; @@ -334,14 +333,8 @@ getVfsFromFile(const std::string &OverlayFile, int clangTidyMain(int argc, const char **argv) { llvm::InitLLVM X(argc, argv); - llvm::Expected OptionsParser = - CommonOptionsParser::create(argc, argv, ClangTidyCategory, - cl::ZeroOrMore); - if (!OptionsParser) { - llvm::WithColor::error() << llvm::toString(OptionsParser.takeError()); - return 1; - } - + CommonOptionsParser OptionsParser(argc, argv, ClangTidyCategory, + cl::ZeroOrMore); llvm::IntrusiveRefCntPtr BaseFS( new vfs::OverlayFileSystem(vfs::getRealFileSystem())); @@ -372,7 +365,7 @@ int clangTidyMain(int argc, const char **argv) { SmallString<256> ProfilePrefix = MakeAbsolute(StoreCheckProfile); StringRef FileName("dummy"); - auto PathList = OptionsParser->getSourcePathList(); + auto PathList = OptionsParser.getSourcePathList(); if (!PathList.empty()) { FileName = PathList.front(); } @@ -440,7 +433,7 @@ int clangTidyMain(int argc, const char **argv) { ClangTidyContext Context(std::move(OwningOptionsProvider), AllowEnablingAnalyzerAlphaCheckers); std::vector Errors = - runClangTidy(Context, OptionsParser->getCompilations(), PathList, BaseFS, + runClangTidy(Context, OptionsParser.getCompilations(), PathList, BaseFS, EnableCheckProfile, ProfilePrefix); bool FoundErrors = llvm::find_if(Errors, [](const ClangTidyError &E) { return E.DiagLevel == ClangTidyError::Error; diff --git a/clang-tools-extra/test/clang-query/invalid-command-line.cpp b/clang-tools-extra/test/clang-query/invalid-command-line.cpp deleted file mode 100644 index 10ab43198b4e29..00000000000000 --- a/clang-tools-extra/test/clang-query/invalid-command-line.cpp +++ /dev/null @@ -1,4 +0,0 @@ -// RUN: not clang-query --invalid-arg 2>&1 | FileCheck %s - -// CHECK: error: [CommonOptionsParser]: clang-query: Unknown command line argument '--invalid-arg'. Try: 'clang-query --help' -// CHECK-NEXT: clang-query: Did you mean '--extra-arg'? diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/invalid-command-line.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/invalid-command-line.cpp deleted file mode 100644 index 90b3f5200059c9..00000000000000 --- a/clang-tools-extra/test/clang-tidy/infrastructure/invalid-command-line.cpp +++ /dev/null @@ -1,4 +0,0 @@ -// RUN: not clang-tidy --invalid-arg 2>&1 | FileCheck %s - -// CHECK: error: [CommonOptionsParser]: clang-tidy: Unknown command line argument '--invalid-arg'. Try: 'clang-tidy --help' -// CHECK-NEXT: clang-tidy: Did you mean '--extra-arg'?