diff --git a/clang-tools-extra/clangd/ClangdServer.cpp b/clang-tools-extra/clangd/ClangdServer.cpp index 4f1fe8f5b08be4..64ccbe417c24d9 100644 --- a/clang-tools-extra/clangd/ClangdServer.cpp +++ b/clang-tools-extra/clangd/ClangdServer.cpp @@ -367,7 +367,7 @@ tweakSelection(const Range &Sel, const InputsAndAST &AST) { auto End = positionToOffset(AST.Inputs.Contents, Sel.end); if (!End) return End.takeError(); - return Tweak::Selection(AST.AST, *Begin, *End); + return Tweak::Selection(AST.Inputs.Index, AST.AST, *Begin, *End); } void ClangdServer::enumerateTweaks(PathRef File, Range Sel, diff --git a/clang-tools-extra/clangd/refactor/Tweak.cpp b/clang-tools-extra/clangd/refactor/Tweak.cpp index 4f3c40d1eb13ec..2dc091ed762a89 100644 --- a/clang-tools-extra/clangd/refactor/Tweak.cpp +++ b/clang-tools-extra/clangd/refactor/Tweak.cpp @@ -9,6 +9,7 @@ #include "Logger.h" #include "Path.h" #include "SourceCode.h" +#include "index/Index.h" #include "llvm/ADT/None.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/STLExtras.h" @@ -44,9 +45,10 @@ void validateRegistry() { } } // namespace -Tweak::Selection::Selection(ParsedAST &AST, unsigned RangeBegin, - unsigned RangeEnd) - : AST(AST), SelectionBegin(RangeBegin), SelectionEnd(RangeEnd), +Tweak::Selection::Selection(const SymbolIndex *Index, ParsedAST &AST, + unsigned RangeBegin, unsigned RangeEnd) + : Index(Index), AST(AST), SelectionBegin(RangeBegin), + SelectionEnd(RangeEnd), ASTSelection(AST.getASTContext(), AST.getTokens(), RangeBegin, RangeEnd) { auto &SM = AST.getSourceManager(); Code = SM.getBufferData(SM.getMainFileID()); diff --git a/clang-tools-extra/clangd/refactor/Tweak.h b/clang-tools-extra/clangd/refactor/Tweak.h index 42b7fb0684e8de..de655abd98c7b1 100644 --- a/clang-tools-extra/clangd/refactor/Tweak.h +++ b/clang-tools-extra/clangd/refactor/Tweak.h @@ -24,6 +24,7 @@ #include "Protocol.h" #include "Selection.h" #include "SourceCode.h" +#include "index/Index.h" #include "clang/Tooling/Core/Replacement.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/StringMap.h" @@ -46,9 +47,12 @@ class Tweak { public: /// Input to prepare and apply tweaks. struct Selection { - Selection(ParsedAST &AST, unsigned RangeBegin, unsigned RangeEnd); + Selection(const SymbolIndex *Index, ParsedAST &AST, unsigned RangeBegin, + unsigned RangeEnd); /// The text of the active document. llvm::StringRef Code; + /// The Index for handling codebase related queries. + const SymbolIndex *Index = nullptr; /// Parsed AST of the active file. ParsedAST * /// A location of the cursor in the editor. diff --git a/clang-tools-extra/clangd/unittests/TweakTesting.cpp b/clang-tools-extra/clangd/unittests/TweakTesting.cpp index 39d5e899b4dc44..3331a3d937155a 100644 --- a/clang-tools-extra/clangd/unittests/TweakTesting.cpp +++ b/clang-tools-extra/clangd/unittests/TweakTesting.cpp @@ -63,7 +63,7 @@ std::pair rangeOrPoint(const Annotations &A) { cantFail(positionToOffset(A.code(), SelectionRng.end))}; } -MATCHER_P5(TweakIsAvailable, TweakID, Ctx, Header, ExtraArgs, ExtraFiles, +MATCHER_P6(TweakIsAvailable, TweakID, Ctx, Header, ExtraArgs, ExtraFiles, Index, (TweakID + (negation ? " is unavailable" : " is available")).str()) { std::string WrappedCode = wrap(Ctx, arg); Annotations Input(WrappedCode); @@ -74,7 +74,7 @@ MATCHER_P5(TweakIsAvailable, TweakID, Ctx, Header, ExtraArgs, ExtraFiles, TU.ExtraArgs = ExtraArgs; TU.AdditionalFiles = std::move(ExtraFiles); ParsedAST AST = TU.build(); - Tweak::Selection S(AST, Selection.first, Selection.second); + Tweak::Selection S(Index, AST, Selection.first, Selection.second); auto PrepareResult = prepareTweak(TweakID, S); if (PrepareResult) return true; @@ -96,7 +96,7 @@ std::string TweakTest::apply(llvm::StringRef MarkedCode, TU.Code = Input.code(); TU.ExtraArgs = ExtraArgs; ParsedAST AST = TU.build(); - Tweak::Selection S(AST, Selection.first, Selection.second); + Tweak::Selection S(Index.get(), AST, Selection.first, Selection.second); auto T = prepareTweak(TweakID, S); if (!T) { @@ -132,7 +132,7 @@ std::string TweakTest::apply(llvm::StringRef MarkedCode, ::testing::Matcher TweakTest::isAvailable() const { return TweakIsAvailable(llvm::StringRef(TweakID), Context, Header, ExtraArgs, - ExtraFiles); + ExtraFiles, Index.get()); } std::vector TweakTest::expandCases(llvm::StringRef MarkedCode) { diff --git a/clang-tools-extra/clangd/unittests/TweakTesting.h b/clang-tools-extra/clangd/unittests/TweakTesting.h index 34e355290a6047..ffcf5a0c7ea2aa 100644 --- a/clang-tools-extra/clangd/unittests/TweakTesting.h +++ b/clang-tools-extra/clangd/unittests/TweakTesting.h @@ -10,9 +10,11 @@ #define LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_TWEAKTESTING_H #include "TestTU.h" +#include "index/Index.h" #include "llvm/ADT/StringMap.h" #include "gmock/gmock.h" #include "gtest/gtest.h" +#include #include namespace clang { @@ -66,6 +68,9 @@ class TweakTest : public ::testing::Test { // Context in which snippets of code should be placed to run tweaks. CodeContext Context = File; + // Index to be passed into Tweak::Selection. + std::unique_ptr Index = nullptr; + // Apply the current tweak to the range (or point) in MarkedCode. // MarkedCode will be wrapped according to the Context. // - if the tweak produces edits, returns the edited code (without markings)