Revert "[NFC] Add checks for self-assignment."

This reverts commit 8ac137a. The code does not compile.
llvm · Jul 24, 2023 · fa39c0a · fa39c0a
1 parent 32e7d42
commit fa39c0a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 20 deletions.
diff --git a/clang/lib/AST/APValue.cpp b/clang/lib/AST/APValue.cpp
@@ -390,13 +390,11 @@ APValue &APValue::operator=(const APValue &RHS) {
 }
 
 APValue &APValue::operator=(APValue &&RHS) {
-  if (this != RHS) {
-    if (Kind != None && Kind != Indeterminate)
-      DestroyDataAndMakeUninit();
-    Kind = RHS.Kind;
-    Data = RHS.Data;
-    RHS.Kind = None;
-  }
+  if (Kind != None && Kind != Indeterminate)
+    DestroyDataAndMakeUninit();
+  Kind = RHS.Kind;
+  Data = RHS.Data;
+  RHS.Kind = None;
   return *this;
 }
 

diff --git a/clang/lib/CodeGen/CGDebugInfo.h b/clang/lib/CodeGen/CGDebugInfo.h
@@ -832,10 +832,8 @@ class ApplyDebugLocation {
 
   // Define copy assignment operator.
   ApplyDebugLocation &operator=(ApplyDebugLocation &&Other) {
-    if (this != Other) {
-      CGF = Other.CGF;
-      Other.CGF = nullptr;
-    }
+    CGF = Other.CGF;
+    Other.CGF = nullptr;
     return *this;
   }
 

diff --git a/clang/lib/Interpreter/Value.cpp b/clang/lib/Interpreter/Value.cpp
@@ -201,17 +201,16 @@ Value &Value::operator=(const Value &RHS) {
 }
 
 Value &Value::operator=(Value &&RHS) noexcept {
-  if (this != RHS) {
-    if (IsManuallyAlloc)
-      ValueStorage::getFromPayload(getPtr())->Release();
+  if (IsManuallyAlloc)
+    ValueStorage::getFromPayload(getPtr())->Release();
 
-    Interp = std::exchange(RHS.Interp, nullptr);
-    OpaqueType = std::exchange(RHS.OpaqueType, nullptr);
-    ValueKind = std::exchange(RHS.ValueKind, K_Unspecified);
-    IsManuallyAlloc = std::exchange(RHS.IsManuallyAlloc, false);
+  Interp = std::exchange(RHS.Interp, nullptr);
+  OpaqueType = std::exchange(RHS.OpaqueType, nullptr);
+  ValueKind = std::exchange(RHS.ValueKind, K_Unspecified);
+  IsManuallyAlloc = std::exchange(RHS.IsManuallyAlloc, false);
+
+  Data = RHS.Data;
 
-    Data = RHS.Data;
-  }
   return *this;
 }