Skip to content

Commit

Permalink
[flang] fix shared library builds after D136428
Browse files Browse the repository at this point in the history
https://reviews.llvm.org/D136428 introduced the need for FIRBuilder
library to link against HLFIRDialect to satisfy shared builds.

The PrintFlangFunctionNames failure is unrelated, it is a build
race because many of the headers included in FrontendAction are
tablegen generated. So PrintFlangFunctionNames must wait until its
headers can be safely used. See
https://lab.llvm.org/buildbot/#/builders/191/builds/10340
  • Loading branch information
jeanPerier committed Oct 21, 2022
1 parent 5b56763 commit fb8886d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions flang/examples/PrintFlangFunctionNames/CMakeLists.txt
Expand Up @@ -6,5 +6,6 @@ add_llvm_library(flangPrintFunctionNames

DEPENDS
acc_gen
flangFrontend
omp_gen
)
2 changes: 2 additions & 0 deletions flang/lib/Optimizer/Builder/CMakeLists.txt
Expand Up @@ -24,10 +24,12 @@ add_flang_library(FIRBuilder
DEPENDS
FIRDialect
FIRSupport
HLFIRDialect
${dialect_libs}

LINK_LIBS
FIRDialect
FIRSupport
HLFIRDialect
${dialect_libs}
)

0 comments on commit fb8886d

Please sign in to comment.