From fb8ca8a1ec54a209bc101cedfa69815f78f165fc Mon Sep 17 00:00:00 2001 From: Jonas Hahnfeld Date: Thu, 27 Sep 2018 17:27:48 +0000 Subject: [PATCH] Fix greedy FileCheck expression in test/Driver/mips-abi.c 'ld{{.*}}"' seems to match the complete line for me which is failing the test. Only allow an optional '.exe' for Windows systems as most other tests do. Another possibility would be to collapse the greedy expression with the next check to avoid matching the full line. Differential Revision: https://reviews.llvm.org/D52619 llvm-svn: 343240 --- clang/test/Driver/mips-abi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/test/Driver/mips-abi.c b/clang/test/Driver/mips-abi.c index f6987c13e5c6f..066b81bd9561f 100644 --- a/clang/test/Driver/mips-abi.c +++ b/clang/test/Driver/mips-abi.c @@ -169,7 +169,7 @@ // TARGET-O32: "-triple" "mips-unknown-linux-gnu" // TARGET-O32: "-target-cpu" "mips32r2" // TARGET-O32: "-target-abi" "o32" -// TARGET-O32: ld{{.*}}" +// TARGET-O32: ld{{(.exe)?}}" // TARGET-O32: "-m" "elf32btsmip" // RUN: %clang -target mips-linux-gnu -mabi=n32 -### %s 2>&1 \ @@ -177,7 +177,7 @@ // TARGET-N32: "-triple" "mips64-unknown-linux-gnu" // TARGET-N32: "-target-cpu" "mips64r2" // TARGET-N32: "-target-abi" "n32" -// TARGET-N32: ld{{.*}}" +// TARGET-N32: ld{{(.exe)?}}" // TARGET-N32: "-m" "elf32btsmipn32" // RUN: %clang -target mips-linux-gnu -mabi=64 -### %s 2>&1 \ @@ -185,5 +185,5 @@ // TARGET-N64: "-triple" "mips64-unknown-linux-gnu" // TARGET-N64: "-target-cpu" "mips64r2" // TARGET-N64: "-target-abi" "n64" -// TARGET-N64: ld{{.*}}" +// TARGET-N64: ld{{(.exe)?}}" // TARGET-N64: "-m" "elf64btsmip"