21 changes: 9 additions & 12 deletions clang/lib/Sema/TreeTransform.h
Original file line number Diff line number Diff line change
Expand Up @@ -6051,8 +6051,8 @@ QualType TreeTransform<Derived>::TransformFunctionProtoType(
if (auto NewExtParamInfos =
ExtParamInfos.getPointerOrNull(ParamTypes.size())) {
if (!EPI.ExtParameterInfos ||
llvm::makeArrayRef(EPI.ExtParameterInfos, TL.getNumParams())
!= llvm::makeArrayRef(NewExtParamInfos, ParamTypes.size())) {
llvm::ArrayRef(EPI.ExtParameterInfos, TL.getNumParams()) !=
llvm::ArrayRef(NewExtParamInfos, ParamTypes.size())) {
EPIChanged = true;
}
EPI.ExtParameterInfos = NewExtParamInfos;
Expand All @@ -6063,7 +6063,7 @@ QualType TreeTransform<Derived>::TransformFunctionProtoType(

QualType Result = TL.getType();
if (getDerived().AlwaysRebuild() || ResultType != T->getReturnType() ||
T->getParamTypes() != llvm::makeArrayRef(ParamTypes) || EPIChanged) {
T->getParamTypes() != llvm::ArrayRef(ParamTypes) || EPIChanged) {
Result = getDerived().RebuildFunctionProtoType(ResultType, ParamTypes, EPI);
if (Result.isNull())
return QualType();
Expand Down Expand Up @@ -7212,12 +7212,10 @@ TreeTransform<Derived>::TransformObjCTypeParamType(TypeLocBuilder &TLB,
QualType Result = TL.getType();
if (getDerived().AlwaysRebuild() ||
OTP != T->getDecl()) {
Result = getDerived().RebuildObjCTypeParamType(OTP,
TL.getProtocolLAngleLoc(),
llvm::makeArrayRef(TL.getTypePtr()->qual_begin(),
TL.getNumProtocols()),
TL.getProtocolLocs(),
TL.getProtocolRAngleLoc());
Result = getDerived().RebuildObjCTypeParamType(
OTP, TL.getProtocolLAngleLoc(),
llvm::ArrayRef(TL.getTypePtr()->qual_begin(), TL.getNumProtocols()),
TL.getProtocolLocs(), TL.getProtocolRAngleLoc());
if (Result.isNull())
return QualType();
}
Expand Down Expand Up @@ -7337,7 +7335,7 @@ TreeTransform<Derived>::TransformObjCObjectType(TypeLocBuilder &TLB,
Result = getDerived().RebuildObjCObjectType(
BaseType, TL.getBeginLoc(), TL.getTypeArgsLAngleLoc(), NewTypeArgInfos,
TL.getTypeArgsRAngleLoc(), TL.getProtocolLAngleLoc(),
llvm::makeArrayRef(TL.getTypePtr()->qual_begin(), TL.getNumProtocols()),
llvm::ArrayRef(TL.getTypePtr()->qual_begin(), TL.getNumProtocols()),
TL.getProtocolLocs(), TL.getProtocolRAngleLoc());

if (Result.isNull())
Expand Down Expand Up @@ -7900,8 +7898,7 @@ TreeTransform<Derived>::TransformGCCAsmStmt(GCCAsmStmt *S) {
template<typename Derived>
StmtResult
TreeTransform<Derived>::TransformMSAsmStmt(MSAsmStmt *S) {
ArrayRef<Token> AsmToks =
llvm::makeArrayRef(S->getAsmToks(), S->getNumAsmToks());
ArrayRef<Token> AsmToks = llvm::ArrayRef(S->getAsmToks(), S->getNumAsmToks());

bool HadError = false, HadChange = false;

Expand Down
14 changes: 7 additions & 7 deletions clang/lib/Serialization/ASTReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ bool ASTReader::ReadLexicalDeclContextStorage(ModuleFile &M,
auto &Lex = LexicalDecls[DC];
if (!Lex.first) {
Lex = std::make_pair(
&M, llvm::makeArrayRef(
&M, llvm::ArrayRef(
reinterpret_cast<const llvm::support::unaligned_uint32_t *>(
Blob.data()),
Blob.size() / 4));
Expand Down Expand Up @@ -1548,8 +1548,8 @@ bool ASTReader::ReadSLocEntry(int ID) {
if (NumFileDecls && ContextObj) {
const DeclID *FirstDecl = F->FileSortedDecls + Record[6];
assert(F->FileSortedDecls && "FILE_SORTED_DECLS not encountered yet ?");
FileDeclIDs[FID] = FileDeclsInfo(F, llvm::makeArrayRef(FirstDecl,
NumFileDecls));
FileDeclIDs[FID] =
FileDeclsInfo(F, llvm::ArrayRef(FirstDecl, NumFileDecls));
}

const SrcMgr::ContentCache &ContentCache =
Expand Down Expand Up @@ -1683,7 +1683,7 @@ Token ASTReader::ReadToken(ModuleFile &F, const RecordDataImpl &Record,
Toks.reserve(NumTokens);
for (unsigned I = 0; I < NumTokens; ++I)
Toks.push_back(ReadToken(F, Record, Idx));
Info->Toks = llvm::makeArrayRef(Toks).copy(PP.getPreprocessorAllocator());
Info->Toks = llvm::ArrayRef(Toks).copy(PP.getPreprocessorAllocator());
Tok.setAnnotationValue(static_cast<void *>(Info));
break;
}
Expand Down Expand Up @@ -8035,8 +8035,8 @@ void ASTReader::UpdateSema() {
PragmaAlignPackStack.front().PushLocation);
DropFirst = true;
}
for (const auto &Entry : llvm::makeArrayRef(PragmaAlignPackStack)
.drop_front(DropFirst ? 1 : 0)) {
for (const auto &Entry :
llvm::ArrayRef(PragmaAlignPackStack).drop_front(DropFirst ? 1 : 0)) {
SemaObj->AlignPackStack.Stack.emplace_back(
Entry.SlotLabel, Entry.Value, Entry.Location, Entry.PushLocation);
}
Expand Down Expand Up @@ -8067,7 +8067,7 @@ void ASTReader::UpdateSema() {
DropFirst = true;
}
for (const auto &Entry :
llvm::makeArrayRef(FpPragmaStack).drop_front(DropFirst ? 1 : 0))
llvm::ArrayRef(FpPragmaStack).drop_front(DropFirst ? 1 : 0))
SemaObj->FpPragmaStack.Stack.emplace_back(
Entry.SlotLabel, Entry.Value, Entry.Location, Entry.PushLocation);
if (FpPragmaCurrentLocation.isInvalid()) {
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Serialization/ASTWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5307,7 +5307,7 @@ void ASTWriter::WriteDeclUpdatesBlocks(RecordDataImpl &OffsetsRecord) {
break;

case UPD_ADDED_ATTR_TO_RECORD:
Record.AddAttributes(llvm::makeArrayRef(Update.getAttr()));
Record.AddAttributes(llvm::ArrayRef(Update.getAttr()));
break;
}
}
Expand Down
7 changes: 3 additions & 4 deletions clang/lib/Serialization/ASTWriterDecl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ namespace clang {

ArrayRef<DeclID> LazySpecializations;
if (auto *LS = Common->LazySpecializations)
LazySpecializations = llvm::makeArrayRef(LS + 1, LS[0]);
LazySpecializations = llvm::ArrayRef(LS + 1, LS[0]);

// Add a slot to the record for the number of specializations.
unsigned I = Record.size();
Expand Down Expand Up @@ -907,7 +907,7 @@ void ASTDeclWriter::VisitObjCImplementationDecl(ObjCImplementationDecl *D) {
Record.push_back(D->NumIvarInitializers);
if (D->NumIvarInitializers)
Record.AddCXXCtorInitializers(
llvm::makeArrayRef(D->init_begin(), D->init_end()));
llvm::ArrayRef(D->init_begin(), D->init_end()));
Code = serialization::DECL_OBJC_IMPLEMENTATION;
}

Expand Down Expand Up @@ -2522,8 +2522,7 @@ void ASTRecordWriter::AddFunctionDefinition(const FunctionDecl *FD) {
if (auto *CD = dyn_cast<CXXConstructorDecl>(FD)) {
Record->push_back(CD->getNumCtorInitializers());
if (CD->getNumCtorInitializers())
AddCXXCtorInitializers(
llvm::makeArrayRef(CD->init_begin(), CD->init_end()));
AddCXXCtorInitializers(llvm::ArrayRef(CD->init_begin(), CD->init_end()));
}
AddStmt(FD->getBody());
}
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ static bool forEachDriverJob(
Argv.push_back(Arg.c_str());

const std::unique_ptr<driver::Compilation> Compilation(
Driver->BuildCompilation(llvm::makeArrayRef(Argv)));
Driver->BuildCompilation(llvm::ArrayRef(Argv)));
if (!Compilation)
return false;

Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Tooling/DumpTool/ClangSrcLocDump.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ int main(int argc, const char **argv) {
"ast-api-dump-tool", OFS);

std::unique_ptr<clang::driver::Compilation> Comp(
Driver->BuildCompilation(llvm::makeArrayRef(Argv)));
Driver->BuildCompilation(llvm::ArrayRef(Argv)));
if (!Comp)
return 1;

Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ struct TransferableCommand {
TmpArgv.push_back(S.c_str());
ClangCLMode = !TmpArgv.empty() &&
driver::IsClangCL(driver::getDriverMode(
TmpArgv.front(), llvm::makeArrayRef(TmpArgv).slice(1)));
TmpArgv.front(), llvm::ArrayRef(TmpArgv).slice(1)));
ArgList = {TmpArgv.begin(), TmpArgv.end()};
}

Expand Down
8 changes: 4 additions & 4 deletions clang/lib/Tooling/Syntax/BuildTree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ class syntax::TreeBuilder {
assert(Last.isValid());
assert(First == Last ||
TBTM.sourceManager().isBeforeInTranslationUnit(First, Last));
return llvm::makeArrayRef(findToken(First), std::next(findToken(Last)));
return llvm::ArrayRef(findToken(First), std::next(findToken(Last)));
}

ArrayRef<syntax::Token>
Expand Down Expand Up @@ -552,7 +552,7 @@ class syntax::TreeBuilder {
assert(Tokens.back().kind() != tok::eof);
// We never consume 'eof', so looking at the next token is ok.
if (Tokens.back().kind() != tok::semi && Tokens.end()->kind() == tok::semi)
return llvm::makeArrayRef(Tokens.begin(), Tokens.end() + 1);
return llvm::ArrayRef(Tokens.begin(), Tokens.end() + 1);
return Tokens;
}

Expand Down Expand Up @@ -768,7 +768,7 @@ class BuildTreeVisitor : public RecursiveASTVisitor<BuildTreeVisitor> {
// Build TemplateDeclaration nodes if we had template parameters.
auto ConsumeTemplateParameters = [&](const TemplateParameterList &L) {
const auto *TemplateKW = Builder.findToken(L.getTemplateLoc());
auto R = llvm::makeArrayRef(TemplateKW, DeclarationRange.end());
auto R = llvm::ArrayRef(TemplateKW, DeclarationRange.end());
Result =
foldTemplateDeclaration(R, TemplateKW, DeclarationRange, nullptr);
DeclarationRange = R;
Expand Down Expand Up @@ -1639,7 +1639,7 @@ class BuildTreeVisitor : public RecursiveASTVisitor<BuildTreeVisitor> {
auto Return = Builder.getRange(ReturnedType.getSourceRange());
const auto *Arrow = Return.begin() - 1;
assert(Arrow->kind() == tok::arrow);
auto Tokens = llvm::makeArrayRef(Arrow, Return.end());
auto Tokens = llvm::ArrayRef(Arrow, Return.end());
Builder.markChildToken(Arrow, syntax::NodeRole::ArrowToken);
if (ReturnDeclarator)
Builder.markChild(ReturnDeclarator, syntax::NodeRole::Declarator);
Expand Down
12 changes: 6 additions & 6 deletions clang/lib/Tooling/Syntax/ComputeReplacements.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void enumerateTokenSpans(const syntax::Tree *Root,
process(Root);
// Report the last span to the user.
if (SpanBegin)
Callback(llvm::makeArrayRef(SpanBegin, SpanEnd), SpanIsOriginal);
Callback(llvm::ArrayRef(SpanBegin, SpanEnd), SpanIsOriginal);
}

private:
Expand All @@ -52,7 +52,7 @@ void enumerateTokenSpans(const syntax::Tree *Root,
}
// Report the current span to the user.
if (SpanBegin)
Callback(llvm::makeArrayRef(SpanBegin, SpanEnd), SpanIsOriginal);
Callback(llvm::ArrayRef(SpanBegin, SpanEnd), SpanIsOriginal);
// Start recording a new span.
SpanBegin = STM.getToken(L->getTokenKey());
SpanEnd = SpanBegin + 1;
Expand Down Expand Up @@ -118,17 +118,17 @@ syntax::computeReplacements(const TokenBufferTokenManager &TBTM,
// We are looking at a span of original tokens.
if (NextOriginal != Tokens.begin()) {
// There is a gap, record a replacement or deletion.
emitReplacement(llvm::makeArrayRef(NextOriginal, Tokens.begin()));
emitReplacement(llvm::ArrayRef(NextOriginal, Tokens.begin()));
} else {
// No gap, but we may have pending insertions. Emit them now.
emitReplacement(llvm::makeArrayRef(NextOriginal, /*Length=*/0));
emitReplacement(llvm::ArrayRef(NextOriginal, /*Length=*/(size_t)0));
}
NextOriginal = Tokens.end();
});

// We might have pending replacements at the end of file. If so, emit them.
emitReplacement(llvm::makeArrayRef(
NextOriginal, Buffer.expandedTokens().drop_back().end()));
emitReplacement(
llvm::ArrayRef(NextOriginal, Buffer.expandedTokens().drop_back().end()));

return Replacements;
}
20 changes: 10 additions & 10 deletions clang/lib/Tooling/Syntax/Tokens.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@ TokenBuffer::expandedForSpelled(llvm::ArrayRef<syntax::Token> Spelled) const {
// Avoid returning empty ranges.
if (ExpandedBegin == ExpandedEnd)
return {};
return {llvm::makeArrayRef(ExpandedTokens.data() + ExpandedBegin,
ExpandedTokens.data() + ExpandedEnd)};
return {llvm::ArrayRef(ExpandedTokens.data() + ExpandedBegin,
ExpandedTokens.data() + ExpandedEnd)};
}

llvm::ArrayRef<syntax::Token> TokenBuffer::spelledTokens(FileID FID) const {
Expand Down Expand Up @@ -496,7 +496,7 @@ TokenBuffer::spelledForExpanded(llvm::ArrayRef<syntax::Token> Expanded) const {
return std::nullopt;
if (LastMapping && LastMapping->EndExpanded != LastExpanded)
return std::nullopt;
return llvm::makeArrayRef(
return llvm::ArrayRef(
FirstMapping ? File.SpelledTokens.data() + FirstMapping->BeginSpelled
: FirstSpelled,
LastMapping ? File.SpelledTokens.data() + LastMapping->EndSpelled
Expand All @@ -506,10 +506,10 @@ TokenBuffer::spelledForExpanded(llvm::ArrayRef<syntax::Token> Expanded) const {
TokenBuffer::Expansion TokenBuffer::makeExpansion(const MarkedFile &F,
const Mapping &M) const {
Expansion E;
E.Spelled = llvm::makeArrayRef(F.SpelledTokens.data() + M.BeginSpelled,
F.SpelledTokens.data() + M.EndSpelled);
E.Expanded = llvm::makeArrayRef(ExpandedTokens.data() + M.BeginExpanded,
ExpandedTokens.data() + M.EndExpanded);
E.Spelled = llvm::ArrayRef(F.SpelledTokens.data() + M.BeginSpelled,
F.SpelledTokens.data() + M.EndSpelled);
E.Expanded = llvm::ArrayRef(ExpandedTokens.data() + M.BeginExpanded,
ExpandedTokens.data() + M.EndExpanded);
return E;
}

Expand Down Expand Up @@ -574,8 +574,8 @@ syntax::spelledTokensTouching(SourceLocation Loc,
bool AcceptRight = Right != Tokens.end() && Right->location() <= Loc;
bool AcceptLeft =
Right != Tokens.begin() && (Right - 1)->endLocation() >= Loc;
return llvm::makeArrayRef(Right - (AcceptLeft ? 1 : 0),
Right + (AcceptRight ? 1 : 0));
return llvm::ArrayRef(Right - (AcceptLeft ? 1 : 0),
Right + (AcceptRight ? 1 : 0));
}

llvm::ArrayRef<syntax::Token>
Expand Down Expand Up @@ -982,7 +982,7 @@ std::string TokenBuffer::dumpForTests() const {
OS << "expanded tokens:\n"
<< " ";
// (!) we do not show '<eof>'.
DumpTokens(OS, llvm::makeArrayRef(ExpandedTokens).drop_back());
DumpTokens(OS, llvm::ArrayRef(ExpandedTokens).drop_back());
OS << "\n";

std::vector<FileID> Keys;
Expand Down
4 changes: 2 additions & 2 deletions clang/lib/Tooling/Tooling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ bool ToolInvocation::run() {

// We already have a cc1, just create an invocation.
if (CommandLine.size() >= 2 && CommandLine[1] == "-cc1") {
ArrayRef<const char *> CC1Args = makeArrayRef(Argv).drop_front();
ArrayRef<const char *> CC1Args = ArrayRef(Argv).drop_front();
std::unique_ptr<CompilerInvocation> Invocation(
newInvocation(&*Diagnostics, CC1Args, BinaryName));
if (Diagnostics->hasErrorOccurred())
Expand All @@ -382,7 +382,7 @@ bool ToolInvocation::run() {
if (!Files->getFileSystemOpts().WorkingDir.empty())
Driver->setCheckInputsExist(false);
const std::unique_ptr<driver::Compilation> Compilation(
Driver->BuildCompilation(llvm::makeArrayRef(Argv)));
Driver->BuildCompilation(llvm::ArrayRef(Argv)));
if (!Compilation)
return false;
const llvm::opt::ArgStringList *const CC1Args = getCC1Arguments(
Expand Down
4 changes: 2 additions & 2 deletions clang/tools/diagtool/DiagnosticNames.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static const DiagnosticRecord BuiltinDiagnosticsByName[] = {
};

llvm::ArrayRef<DiagnosticRecord> diagtool::getBuiltinDiagnosticsByName() {
return llvm::makeArrayRef(BuiltinDiagnosticsByName);
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}


Expand Down Expand Up @@ -103,5 +103,5 @@ GroupRecord::diagnostics() const {
}

llvm::ArrayRef<GroupRecord> diagtool::getDiagnosticGroups() {
return llvm::makeArrayRef(OptionTable);
return llvm::ArrayRef(OptionTable);
}
2 changes: 1 addition & 1 deletion clang/tools/diagtool/FindDiagnosticID.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ int FindDiagnosticID::run(unsigned int argc, char **argv,

std::vector<const char *> Args;
Args.push_back("diagtool find-diagnostic-id");
for (const char *A : llvm::makeArrayRef(argv, argc))
for (const char *A : llvm::ArrayRef(argv, argc))
Args.push_back(A);

llvm::cl::HideUnrelatedOptions(FindDiagnosticIDOptions);
Expand Down
9 changes: 4 additions & 5 deletions clang/tools/driver/driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,11 @@ static int ExecuteCC1Tool(SmallVectorImpl<const char *> &ArgV) {
StringRef Tool = ArgV[1];
void *GetExecutablePathVP = (void *)(intptr_t)GetExecutablePath;
if (Tool == "-cc1")
return cc1_main(makeArrayRef(ArgV).slice(1), ArgV[0], GetExecutablePathVP);
return cc1_main(ArrayRef(ArgV).slice(1), ArgV[0], GetExecutablePathVP);
if (Tool == "-cc1as")
return cc1as_main(makeArrayRef(ArgV).slice(2), ArgV[0],
GetExecutablePathVP);
return cc1as_main(ArrayRef(ArgV).slice(2), ArgV[0], GetExecutablePathVP);
if (Tool == "-cc1gen-reproducer")
return cc1gen_reproducer_main(makeArrayRef(ArgV).slice(2), ArgV[0],
return cc1gen_reproducer_main(ArrayRef(ArgV).slice(2), ArgV[0],
GetExecutablePathVP);
// Reject unknown tools.
llvm::errs() << "error: unknown integrated tool '" << Tool << "'. "
Expand Down Expand Up @@ -394,7 +393,7 @@ int clang_main(int Argc, char **Argv) {
// Finally, our -cc1 tools don't care which tokenization mode we use because
// response files written by clang will tokenize the same way in either mode.
bool ClangCLMode =
IsClangCL(getDriverMode(Args[0], llvm::makeArrayRef(Args).slice(1)));
IsClangCL(getDriverMode(Args[0], llvm::ArrayRef(Args).slice(1)));
enum { Default, POSIX, Windows } RSPQuoting = Default;
for (const char *F : Args) {
if (strcmp(F, "--rsp-quoting=posix") == 0)
Expand Down
13 changes: 6 additions & 7 deletions clang/tools/libclang/CIndex.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3798,7 +3798,7 @@ clang_parseTranslationUnit_Impl(CXIndex CIdx, const char *source_filename,

// Configure the diagnostics.
std::unique_ptr<DiagnosticOptions> DiagOpts = CreateAndPopulateDiagOpts(
llvm::makeArrayRef(command_line_args, num_command_line_args));
llvm::ArrayRef(command_line_args, num_command_line_args));
IntrusiveRefCntPtr<DiagnosticsEngine> Diags(
CompilerInstance::createDiagnostics(DiagOpts.release()));

Expand Down Expand Up @@ -3881,7 +3881,7 @@ clang_parseTranslationUnit_Impl(CXIndex CIdx, const char *source_filename,

LibclangInvocationReporter InvocationReporter(
*CXXIdx, LibclangInvocationReporter::OperationKind::ParseOperation,
options, llvm::makeArrayRef(*Args), /*InvocationArgs=*/std::nullopt,
options, llvm::ArrayRef(*Args), /*InvocationArgs=*/std::nullopt,
unsaved_files);
std::unique_ptr<ASTUnit> Unit(ASTUnit::LoadFromCommandLine(
Args->data(), Args->data() + Args->size(),
Expand Down Expand Up @@ -3968,7 +3968,7 @@ enum CXErrorCode clang_parseTranslationUnit2FullArgv(
noteBottomOfStack();
result = clang_parseTranslationUnit_Impl(
CIdx, source_filename, command_line_args, num_command_line_args,
llvm::makeArrayRef(unsaved_files, num_unsaved_files), options, out_TU);
llvm::ArrayRef(unsaved_files, num_unsaved_files), options, out_TU);
};

llvm::CrashRecoveryContext CRC;
Expand Down Expand Up @@ -4499,7 +4499,7 @@ int clang_reparseTranslationUnit(CXTranslationUnit TU,
CXErrorCode result;
auto ReparseTranslationUnitImpl = [=, &result]() {
result = clang_reparseTranslationUnit_Impl(
TU, llvm::makeArrayRef(unsaved_files, num_unsaved_files), options);
TU, llvm::ArrayRef(unsaved_files, num_unsaved_files), options);
};

llvm::CrashRecoveryContext CRC;
Expand Down Expand Up @@ -8387,9 +8387,8 @@ int clang_getCursorPlatformAvailability(CXCursor cursor, int *always_deprecated,
getCursorPlatformAvailabilityForDecl(D, always_deprecated, deprecated_message,
always_unavailable, unavailable_message,
AvailabilityAttrs);
for (const auto &Avail :
llvm::enumerate(llvm::makeArrayRef(AvailabilityAttrs)
.take_front(availability_size))) {
for (const auto &Avail : llvm::enumerate(
llvm::ArrayRef(AvailabilityAttrs).take_front(availability_size))) {
availability[Avail.index()].Platform =
cxstring::createDup(Avail.value()->getPlatform()->getName());
availability[Avail.index()].Introduced =
Expand Down
2 changes: 1 addition & 1 deletion clang/tools/libclang/CIndexCodeCompletion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ CXCodeCompleteResults *clang_codeCompleteAt(CXTranslationUnit TU,
auto CodeCompleteAtImpl = [=, &result]() {
result = clang_codeCompleteAt_Impl(
TU, complete_filename, complete_line, complete_column,
llvm::makeArrayRef(unsaved_files, num_unsaved_files), options);
llvm::ArrayRef(unsaved_files, num_unsaved_files), options);
};

llvm::CrashRecoveryContext CRC;
Expand Down
5 changes: 2 additions & 3 deletions clang/tools/libclang/Indexing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -903,9 +903,8 @@ int clang_indexSourceFileFullArgv(
result = clang_indexSourceFile_Impl(
idxAction, client_data, index_callbacks, index_callbacks_size,
index_options, source_filename, command_line_args,
num_command_line_args,
llvm::makeArrayRef(unsaved_files, num_unsaved_files), out_TU,
TU_options);
num_command_line_args, llvm::ArrayRef(unsaved_files, num_unsaved_files),
out_TU, TU_options);
};

llvm::CrashRecoveryContext CRC;
Expand Down
2 changes: 1 addition & 1 deletion clang/unittests/Driver/ToolChainTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ TEST(ToolChainTest, PostCallback) {
TEST(GetDriverMode, PrefersLastDriverMode) {
static constexpr const char *Args[] = {"clang-cl", "--driver-mode=foo",
"--driver-mode=bar", "foo.cpp"};
EXPECT_EQ(getDriverMode(Args[0], llvm::makeArrayRef(Args).slice(1)), "bar");
EXPECT_EQ(getDriverMode(Args[0], llvm::ArrayRef(Args).slice(1)), "bar");
}

struct SimpleDiagnosticConsumer : public DiagnosticConsumer {
Expand Down
41 changes: 20 additions & 21 deletions clang/unittests/Introspection/IntrospectionTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc())

// clang-format off
EXPECT_EQ(
llvm::makeArrayRef(ExpectedRanges),
llvm::ArrayRef(ExpectedRanges),
(ArrayRef<std::pair<std::string, SourceRange>>{
STRING_LOCATION_STDPAIR(MethodDecl, getExceptionSpecSourceRange()),
STRING_LOCATION_STDPAIR(MethodDecl, getNameInfo().getSourceRange()),
Expand Down Expand Up @@ -384,7 +384,7 @@ void ns::A::foo() {}
llvm::sort(ExpectedLocations);

EXPECT_EQ(
llvm::makeArrayRef(ExpectedLocations),
llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR(NNS, getBeginLoc()),
STRING_LOCATION_STDPAIR(NNS, getEndLoc()),
Expand Down Expand Up @@ -962,7 +962,7 @@ struct D : Templ<T...> {

// clang-format off
EXPECT_EQ(
llvm::makeArrayRef(ExpectedLocations),
llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR(CtorInit, getBaseClassLoc().getAs<clang::ElaboratedTypeLoc>().getNamedTypeLoc().getAs<clang::TemplateSpecializationTypeLoc>().getLAngleLoc()),
STRING_LOCATION_STDPAIR(CtorInit, getBaseClassLoc().getAs<clang::ElaboratedTypeLoc>().getNamedTypeLoc().getAs<clang::TemplateSpecializationTypeLoc>().getRAngleLoc()),
Expand Down Expand Up @@ -1329,7 +1329,7 @@ int foo();

// clang-format off
EXPECT_EQ(
llvm::makeArrayRef(ExpectedLocations),
llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR(TL, getAs<clang::FunctionTypeLoc>().getLParenLoc()),
STRING_LOCATION_STDPAIR(TL, getAs<clang::FunctionTypeLoc>().getLocalRangeBegin()),
Expand Down Expand Up @@ -1393,7 +1393,7 @@ int* i;

// clang-format off
EXPECT_EQ(
llvm::makeArrayRef(ExpectedLocations),
llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR(TL, getAs<clang::PointerTypeLoc>().getPointeeLoc().getAs<clang::BuiltinTypeLoc>().getBuiltinLoc()),
STRING_LOCATION_STDPAIR(TL, getAs<clang::PointerTypeLoc>().getPointeeLoc().getAs<clang::BuiltinTypeLoc>().getNameLoc()),
Expand Down Expand Up @@ -1505,7 +1505,7 @@ class Foo

// clang-format off
EXPECT_EQ(
llvm::makeArrayRef(ExpectedLocations),
llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR((&NI), getBeginLoc()),
STRING_LOCATION_STDPAIR((&NI), getEndLoc()),
Expand Down Expand Up @@ -1571,20 +1571,19 @@ void foo()
llvm::sort(ExpectedLocations);

EXPECT_EQ(
llvm::makeArrayRef(ExpectedLocations),
llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR(Member, getBeginLoc()),
STRING_LOCATION_STDPAIR(Member, getEndLoc()),
STRING_LOCATION_STDPAIR(Member, getExprLoc()),
STRING_LOCATION_STDPAIR(Member, getLAngleLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberNameInfo().getBeginLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberNameInfo().getEndLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberNameInfo().getLoc()),
STRING_LOCATION_STDPAIR(Member, getOperatorLoc()),
STRING_LOCATION_STDPAIR(Member, getRAngleLoc()),
STRING_LOCATION_STDPAIR(Member, getTemplateKeywordLoc())
}));
STRING_LOCATION_STDPAIR(Member, getBeginLoc()),
STRING_LOCATION_STDPAIR(Member, getEndLoc()),
STRING_LOCATION_STDPAIR(Member, getExprLoc()),
STRING_LOCATION_STDPAIR(Member, getLAngleLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberNameInfo().getBeginLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberNameInfo().getEndLoc()),
STRING_LOCATION_STDPAIR(Member, getMemberNameInfo().getLoc()),
STRING_LOCATION_STDPAIR(Member, getOperatorLoc()),
STRING_LOCATION_STDPAIR(Member, getRAngleLoc()),
STRING_LOCATION_STDPAIR(Member, getTemplateKeywordLoc())}));

auto ExpectedRanges = FormatExpected<SourceRange>(Result.RangeAccessors);

Expand Down Expand Up @@ -1624,7 +1623,7 @@ class Foo

llvm::sort(ExpectedLocations);

EXPECT_EQ(llvm::makeArrayRef(ExpectedLocations),
EXPECT_EQ(llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR((&NI), getBeginLoc()),
STRING_LOCATION_STDPAIR((&NI), getEndLoc()),
Expand Down Expand Up @@ -1666,7 +1665,7 @@ long double operator"" _identity ( long double val )

llvm::sort(ExpectedLocations);

EXPECT_EQ(llvm::makeArrayRef(ExpectedLocations),
EXPECT_EQ(llvm::ArrayRef(ExpectedLocations),
(ArrayRef<std::pair<std::string, SourceLocation>>{
STRING_LOCATION_STDPAIR((&NI), getBeginLoc()),
STRING_LOCATION_STDPAIR((&NI), getCXXLiteralOperatorNameLoc()),
Expand Down
2 changes: 1 addition & 1 deletion clang/unittests/Lex/LexerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ TEST_F(LexerTest, RawAndNormalLexSameForLineComments) {
SrcBuffer.data(), SrcBuffer.data(),
SrcBuffer.data() + SrcBuffer.size());

auto ToksView = llvm::makeArrayRef(Toks);
auto ToksView = llvm::ArrayRef(Toks);
clang::Token T;
EXPECT_FALSE(ToksView.empty());
while (!L.LexFromRawLexer(T)) {
Expand Down
2 changes: 1 addition & 1 deletion clang/unittests/Lex/PPDependencyDirectivesTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ TEST_F(PPDependencyDirectivesTest, MacroGuard) {
Input, DepDirectivesObjects.back()->Tokens,
DepDirectivesObjects.back()->Directives);
EXPECT_FALSE(Err);
return llvm::makeArrayRef(DepDirectivesObjects.back()->Directives);
return llvm::ArrayRef(DepDirectivesObjects.back()->Directives);
};

auto PPOpts = std::make_shared<PreprocessorOptions>();
Expand Down
23 changes: 11 additions & 12 deletions clang/unittests/Tooling/Syntax/TokensTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ class TokenCollectorTest : public ::testing::Test {
llvm::ArrayRef<T> Range, Eq F) {
assert(Subrange.size() >= 1);
if (Range.size() < Subrange.size())
return llvm::makeArrayRef(Range.end(), Range.end());
return llvm::ArrayRef(Range.end(), Range.end());
for (auto Begin = Range.begin(), Last = Range.end() - Subrange.size();
Begin <= Last; ++Begin) {
auto It = Begin;
Expand All @@ -200,10 +200,10 @@ class TokenCollectorTest : public ::testing::Test {
if (!F(*ItSub, *It))
goto continue_outer;
}
return llvm::makeArrayRef(Begin, It);
return llvm::ArrayRef(Begin, It);
continue_outer:;
}
return llvm::makeArrayRef(Range.end(), Range.end());
return llvm::ArrayRef(Range.end(), Range.end());
}

/// Finds a subrange in \p Tokens that match the tokens specified in \p Query.
Expand All @@ -222,15 +222,14 @@ class TokenCollectorTest : public ::testing::Test {
return Q == T.text(*SourceMgr);
};
// Find a match.
auto Found =
findSubrange(llvm::makeArrayRef(QueryTokens), Tokens, TextMatches);
auto Found = findSubrange(llvm::ArrayRef(QueryTokens), Tokens, TextMatches);
if (Found.begin() == Tokens.end()) {
ADD_FAILURE() << "could not find the subrange for " << Query;
std::abort();
}
// Check that the match is unique.
if (findSubrange(llvm::makeArrayRef(QueryTokens),
llvm::makeArrayRef(Found.end(), Tokens.end()), TextMatches)
if (findSubrange(llvm::ArrayRef(QueryTokens),
llvm::ArrayRef(Found.end(), Tokens.end()), TextMatches)
.begin() != Tokens.end()) {
ADD_FAILURE() << "match is not unique for " << Query;
std::abort();
Expand Down Expand Up @@ -838,10 +837,10 @@ TEST_F(TokenBufferTest, ExpansionsOverlapping) {
Buffer.expansionStartingAt(Foo2.data()),
ValueIs(IsExpansion(SameRange(Foo2.drop_back()),
SameRange(findExpanded("3 + 4 2").drop_back()))));
EXPECT_THAT(Buffer.expansionsOverlapping(
llvm::makeArrayRef(Foo1.begin(), Foo2.end())),
ElementsAre(IsExpansion(SameRange(Foo1.drop_back()), _),
IsExpansion(SameRange(Foo2.drop_back()), _)));
EXPECT_THAT(
Buffer.expansionsOverlapping(llvm::ArrayRef(Foo1.begin(), Foo2.end())),
ElementsAre(IsExpansion(SameRange(Foo1.drop_back()), _),
IsExpansion(SameRange(Foo2.drop_back()), _)));

// Function-like macro expansions.
recordTokens(R"cpp(
Expand All @@ -866,7 +865,7 @@ TEST_F(TokenBufferTest, ExpansionsOverlapping) {
for (const auto &T : ID2.drop_front())
EXPECT_EQ(Buffer.expansionStartingAt(&T), std::nullopt);

EXPECT_THAT(Buffer.expansionsOverlapping(llvm::makeArrayRef(
EXPECT_THAT(Buffer.expansionsOverlapping(llvm::ArrayRef(
findSpelled("1 + 2").data(), findSpelled("4").data())),
ElementsAre(IsExpansion(SameRange(ID1), _),
IsExpansion(SameRange(ID2), _)));
Expand Down
6 changes: 3 additions & 3 deletions clang/unittests/Tooling/Syntax/TreeTestBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ ArrayRef<syntax::Token> tokens(syntax::Node *N,
const TokenBufferTokenManager &STM) {
assert(N->isOriginal() && "tokens of modified nodes are not well-defined");
if (auto *L = dyn_cast<syntax::Leaf>(N))
return llvm::makeArrayRef(STM.getToken(L->getTokenKey()), 1);
return llvm::ArrayRef(STM.getToken(L->getTokenKey()), 1);
auto *T = cast<syntax::Tree>(N);
return llvm::makeArrayRef(STM.getToken(T->findFirstLeaf()->getTokenKey()),
STM.getToken(T->findLastLeaf()->getTokenKey()) + 1);
return llvm::ArrayRef(STM.getToken(T->findFirstLeaf()->getTokenKey()),
STM.getToken(T->findLastLeaf()->getTokenKey()) + 1);
}
} // namespace

Expand Down
2 changes: 1 addition & 1 deletion clang/unittests/Tooling/ToolingTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ struct CommandLineExtractorTest : public ::testing::Test {
const llvm::opt::ArgStringList *
extractCC1Arguments(llvm::ArrayRef<const char *> Argv) {
const std::unique_ptr<driver::Compilation> Compilation(
Driver.BuildCompilation(llvm::makeArrayRef(Argv)));
Driver.BuildCompilation(llvm::ArrayRef(Argv)));

return getCC1Arguments(Diags.get(), Compilation.get());
}
Expand Down