30 changes: 15 additions & 15 deletions libc/test/src/__support/File/platform_file_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ TEST(LlvmLibcPlatformFileTest, CreateWriteCloseAndReadBack) {
File *file = openfile(FILENAME, "w");
ASSERT_FALSE(file == nullptr);
ASSERT_EQ(file->write(TEXT, TEXT_SIZE).value, TEXT_SIZE);
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "r");
ASSERT_FALSE(file == nullptr);
Expand All @@ -38,7 +38,7 @@ TEST(LlvmLibcPlatformFileTest, CreateWriteCloseAndReadBack) {
ASSERT_EQ(file->read(data, TEXT_SIZE).value, size_t(0));
ASSERT_TRUE(file->iseof());

ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, CreateWriteSeekAndReadBack) {
Expand All @@ -58,22 +58,22 @@ TEST(LlvmLibcPlatformFileTest, CreateWriteSeekAndReadBack) {
ASSERT_EQ(file->read(data, TEXT_SIZE).value, size_t(0));
ASSERT_TRUE(file->iseof());

ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, CreateAppendCloseAndReadBack) {
constexpr char FILENAME[] = "testdata/create_append_close_and_readback.test";
File *file = openfile(FILENAME, "w");
ASSERT_FALSE(file == nullptr);
ASSERT_EQ(file->write(TEXT, TEXT_SIZE).value, TEXT_SIZE);
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "a");
ASSERT_FALSE(file == nullptr);
constexpr char APPEND_TEXT[] = " Append Text";
constexpr size_t APPEND_TEXT_SIZE = sizeof(APPEND_TEXT) - 1;
ASSERT_EQ(file->write(APPEND_TEXT, APPEND_TEXT_SIZE).value, APPEND_TEXT_SIZE);
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "r");
ASSERT_FALSE(file == nullptr);
Expand All @@ -87,15 +87,15 @@ TEST(LlvmLibcPlatformFileTest, CreateAppendCloseAndReadBack) {
ASSERT_EQ(file->read(data, READ_SIZE).value, size_t(0));
ASSERT_TRUE(file->iseof());

ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, CreateAppendSeekAndReadBack) {
constexpr char FILENAME[] = "testdata/create_append_seek_and_readback.test";
File *file = openfile(FILENAME, "w");
ASSERT_FALSE(file == nullptr);
ASSERT_EQ(file->write(TEXT, TEXT_SIZE).value, TEXT_SIZE);
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "a+");
ASSERT_FALSE(file == nullptr);
Expand All @@ -113,7 +113,7 @@ TEST(LlvmLibcPlatformFileTest, CreateAppendSeekAndReadBack) {
ASSERT_EQ(file->read(data, APPEND_TEXT_SIZE).value, size_t(0));
ASSERT_TRUE(file->iseof());

ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, LargeFile) {
Expand All @@ -131,7 +131,7 @@ TEST(LlvmLibcPlatformFileTest, LargeFile) {
for (int i = 0; i < REPEAT; ++i) {
ASSERT_EQ(file->write(write_data, DATA_SIZE).value, DATA_SIZE);
}
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "r");
ASSERT_FALSE(file == nullptr);
Expand All @@ -146,7 +146,7 @@ TEST(LlvmLibcPlatformFileTest, LargeFile) {
ASSERT_EQ(file->read(data, 1).value, size_t(0));
ASSERT_TRUE(file->iseof());

ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, ReadSeekCurAndRead) {
Expand All @@ -156,7 +156,7 @@ TEST(LlvmLibcPlatformFileTest, ReadSeekCurAndRead) {
constexpr char CONTENT[] = "1234567890987654321";
ASSERT_EQ(sizeof(CONTENT) - 1,
file->write(CONTENT, sizeof(CONTENT) - 1).value);
ASSERT_EQ(0, File::cleanup(file));
ASSERT_EQ(0, file->close());

file = openfile(FILENAME, "r");
ASSERT_FALSE(file == nullptr);
Expand All @@ -173,7 +173,7 @@ TEST(LlvmLibcPlatformFileTest, ReadSeekCurAndRead) {
ASSERT_EQ(file->read(data, READ_SIZE - 1).value, READ_SIZE - 1);
ASSERT_STREQ(data, "9098");

ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, IncorrectOperation) {
Expand All @@ -185,21 +185,21 @@ TEST(LlvmLibcPlatformFileTest, IncorrectOperation) {
ASSERT_EQ(file->read(data, 1).value, size_t(0)); // Cannot read
ASSERT_FALSE(file->iseof());
ASSERT_TRUE(file->error());
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "r");
ASSERT_FALSE(file == nullptr);
ASSERT_EQ(file->write(data, 1).value, size_t(0)); // Cannot write
ASSERT_FALSE(file->iseof());
ASSERT_TRUE(file->error());
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);

file = openfile(FILENAME, "a");
ASSERT_FALSE(file == nullptr);
ASSERT_EQ(file->read(data, 1).value, size_t(0)); // Cannot read
ASSERT_FALSE(file->iseof());
ASSERT_TRUE(file->error());
ASSERT_EQ(File::cleanup(file), 0);
ASSERT_EQ(file->close(), 0);
}

TEST(LlvmLibcPlatformFileTest, StdOutStdErrSmokeTest) {
Expand Down