20 changes: 10 additions & 10 deletions llvm/test/Linker/comdat.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,30 +3,30 @@ target datalayout = "e-m:w-p:32:32-i64:64-f80:32-n8:16:32-S32"
target triple = "i686-pc-windows-msvc"

$foo = comdat largest
@foo = global i32 42, comdat $foo
@foo = global i32 42, comdat($foo)

define i32 @bar() comdat $foo {
define i32 @bar() comdat($foo) {
ret i32 42
}

$qux = comdat largest
@qux = global i64 12, comdat $qux
@qux = global i64 12, comdat($qux)

define i32 @baz() comdat $qux {
define i32 @baz() comdat($qux) {
ret i32 12
}

$any = comdat any
@any = global i64 6, comdat $any
@any = global i64 6, comdat($any)

; CHECK: $qux = comdat largest
; CHECK: $foo = comdat largest
; CHECK: $any = comdat any

; CHECK: @qux = global i64 12, comdat $qux
; CHECK: @any = global i64 6, comdat $any
; CHECK: @foo = global i64 43, comdat $foo
; CHECK: @qux = global i64 12, comdat{{$}}
; CHECK: @any = global i64 6, comdat{{$}}
; CHECK: @foo = global i64 43, comdat{{$}}
; CHECK-NOT: @in_unselected_group = global i32 13, comdat $qux

; CHECK: define i32 @baz() comdat $qux
; CHECK: define i32 @bar() comdat $foo
; CHECK: define i32 @baz() comdat($qux)
; CHECK: define i32 @bar() comdat($foo)
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat2.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ target datalayout = "e-m:w-p:32:32-i64:64-f80:32-n8:16:32-S32"
target triple = "i686-pc-windows-msvc"

$foo = comdat samesize
@foo = global i32 42, comdat $foo
@foo = global i32 42, comdat($foo)
; CHECK: Linking COMDATs named 'foo': invalid selection kinds!
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat3.ll
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; RUN: not llvm-link %s %p/Inputs/comdat2.ll -S -o - 2>&1 | FileCheck %s

$foo = comdat largest
@foo = global i32 43, comdat $foo
@foo = global i32 43, comdat($foo)
; CHECK: Linking COMDATs named 'foo': can't do size dependent selection without DataLayout!
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat4.ll
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; RUN: not llvm-link %s %p/Inputs/comdat3.ll -S -o - 2>&1 | FileCheck %s

$foo = comdat noduplicates
@foo = global i64 43, comdat $foo
@foo = global i64 43, comdat($foo)
; CHECK: Linking COMDATs named 'foo': noduplicates has been violated!
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat5.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ target datalayout = "e-m:w-p:32:32-i64:64-f80:32-n8:16:32-S32"
target triple = "i686-pc-windows-msvc"

$foo = comdat samesize
@foo = global i32 42, comdat $foo
@foo = global i32 42, comdat($foo)
; CHECK: Linking COMDATs named 'foo': SameSize violated!
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat6.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
target datalayout = "e-m:w-p:32:32-i64:64-f80:32-n8:16:32-S32"

$foo = comdat largest
@foo = linkonce_odr unnamed_addr constant [1 x i8*] [i8* bitcast (void ()* @bar to i8*)], comdat $foo
@foo = linkonce_odr unnamed_addr constant [1 x i8*] [i8* bitcast (void ()* @bar to i8*)], comdat($foo)

; CHECK: @foo = alias getelementptr inbounds ([2 x i8*]* @some_name, i32 0, i32 1)

Expand Down
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat7.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

$c1 = comdat largest

define void @c1() comdat $c1 {
define void @c1() comdat($c1) {
ret void
}
; CHECK: GlobalVariable required for data dependent selection!
2 changes: 1 addition & 1 deletion llvm/test/Linker/comdat8.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

$c1 = comdat largest

@some_name = private unnamed_addr constant i32 42, comdat $c1
@some_name = private unnamed_addr constant i32 42, comdat($c1)
@c1 = alias i8* inttoptr (i32 ptrtoint (i32* @some_name to i32) to i8*)

; CHECK: COMDAT key involves incomputable alias size.
8 changes: 4 additions & 4 deletions llvm/test/Linker/comdat9.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@

$c = comdat any
@a = alias void ()* @f
define internal void @f() comdat $c {
define internal void @f() comdat($c) {
ret void
}

; CHECK-DAG: $c = comdat any
; CHECK-DAG: @a = alias void ()* @f
; CHECK-DAG: define internal void @f() comdat $c
; CHECK-DAG: define internal void @f() comdat($c)

$f2 = comdat largest
define internal void @f2() comdat $f2 {
define internal void @f2() comdat($f2) {
ret void
}

; CHECK-DAG: $f2 = comdat largest
; CHECK-DAG: define internal void @f2() comdat $f2
; CHECK-DAG: define internal void @f2() comdat {
4 changes: 2 additions & 2 deletions llvm/test/Linker/constructor-comdat.ll
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ $_ZN3fooIiEC5Ev = comdat any
@_ZN3fooIiEC1Ev = weak_odr alias void ()* @_ZN3fooIiEC2Ev
; CHECK: @_ZN3fooIiEC1Ev = weak_odr alias void ()* @_ZN3fooIiEC2Ev

; CHECK: define weak_odr void @_ZN3fooIiEC2Ev() comdat $_ZN3fooIiEC5Ev {
define weak_odr void @_ZN3fooIiEC2Ev() comdat $_ZN3fooIiEC5Ev {
; CHECK: define weak_odr void @_ZN3fooIiEC2Ev() comdat($_ZN3fooIiEC5Ev) {
define weak_odr void @_ZN3fooIiEC2Ev() comdat($_ZN3fooIiEC5Ev) {
ret void
}
4 changes: 2 additions & 2 deletions llvm/test/Linker/visibility.ll
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ $c1 = comdat any
; CHECK-DAG: @v3 = hidden global i32 0
@v3 = protected global i32 0

; CHECK-DAG: @v4 = hidden global i32 1, comdat $c1
@v4 = global i32 1, comdat $c1
; CHECK-DAG: @v4 = hidden global i32 1, comdat($c1)
@v4 = global i32 1, comdat($c1)

; Aliases
; CHECK: @a1 = hidden alias i32* @v1
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/Transforms/GlobalDCE/pr20981.ll
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ $c1 = comdat any
@a1 = linkonce_odr alias void ()* @f1
; CHECK: @a1 = linkonce_odr alias void ()* @f1

define linkonce_odr void @f1() comdat $c1 {
define linkonce_odr void @f1() comdat($c1) {
ret void
}
; CHECK: define linkonce_odr void @f1() comdat $c1
; CHECK: define linkonce_odr void @f1() comdat($c1)

define void @g() {
call void @f1()
Expand Down
8 changes: 4 additions & 4 deletions llvm/test/Transforms/GlobalOpt/pr21191.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
$c = comdat any
; CHECK: $c = comdat any

define linkonce_odr void @foo() comdat $c {
define linkonce_odr void @foo() comdat($c) {
ret void
}
; CHECK: define linkonce_odr void @foo() comdat $c
; CHECK: define linkonce_odr void @foo() comdat($c)

define linkonce_odr void @bar() comdat $c {
define linkonce_odr void @bar() comdat($c) {
ret void
}
; CHECK: define linkonce_odr void @bar() comdat $c
; CHECK: define linkonce_odr void @bar() comdat($c)

define void @zed() {
call void @foo()
Expand Down
6 changes: 3 additions & 3 deletions llvm/test/Transforms/GlobalOpt/preserve-comdats.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

$comdat_global = comdat any

@comdat_global = weak_odr global i8 0, comdat $comdat_global
@comdat_global = weak_odr global i8 0, comdat($comdat_global)
@simple_global = internal global i8 0
; CHECK: @comdat_global = weak_odr global i8 0, comdat $comdat_global
; CHECK: @comdat_global = weak_odr global i8 0, comdat{{$}}
; CHECK: @simple_global = internal global i8 42

@llvm.global_ctors = appending global [2 x { i32, void ()*, i8* }] [
Expand All @@ -20,7 +20,7 @@ define void @init_comdat_global() {
}
; CHECK: define void @init_comdat_global()

define internal void @init_simple_global() comdat $comdat_global {
define internal void @init_simple_global() comdat($comdat_global) {
store i8 42, i8* @simple_global
ret void
}
Expand Down
8 changes: 4 additions & 4 deletions llvm/test/Transforms/Inline/pr21206.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
$c = comdat any
; CHECK: $c = comdat any

define linkonce_odr void @foo() comdat $c {
define linkonce_odr void @foo() comdat($c) {
ret void
}
; CHECK: define linkonce_odr void @foo() comdat $c
; CHECK: define linkonce_odr void @foo() comdat($c)

define linkonce_odr void @bar() comdat $c {
define linkonce_odr void @bar() comdat($c) {
ret void
}
; CHECK: define linkonce_odr void @bar() comdat $c
; CHECK: define linkonce_odr void @bar() comdat($c)

define void()* @zed() {
ret void()* @foo
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/Verifier/comdat.ll
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s

$v = comdat any
@v = common global i32 0, comdat $v
@v = common global i32 0, comdat($v)
; CHECK: 'common' global may not be in a Comdat!
2 changes: 1 addition & 1 deletion llvm/test/Verifier/comdat2.ll
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s

$v = comdat any
@v = private global i32 0, comdat $v
@v = private global i32 0, comdat($v)
; CHECK: comdat global value has private linkage
4 changes: 2 additions & 2 deletions llvm/test/tools/gold/Inputs/comdat.ll
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
$c2 = comdat any

@v1 = weak_odr global i32 41, comdat $c2
define weak_odr protected i32 @f1(i8* %this) comdat $c2 {
@v1 = weak_odr global i32 41, comdat($c2)
define weak_odr protected i32 @f1(i8* %this) comdat($c2) {
bb20:
store i8* %this, i8** null
br label %bb21
Expand Down
12 changes: 6 additions & 6 deletions llvm/test/tools/gold/comdat.ll
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

$c1 = comdat any

@v1 = weak_odr global i32 42, comdat $c1
define weak_odr i32 @f1(i8*) comdat $c1 {
@v1 = weak_odr global i32 42, comdat($c1)
define weak_odr i32 @f1(i8*) comdat($c1) {
bb10:
br label %bb11
bb11:
Expand All @@ -27,15 +27,15 @@ bb11:
; CHECK: $c1 = comdat any
; CHECK: $c2 = comdat any

; CHECK: @v1 = weak_odr global i32 42, comdat $c1
; CHECK: @v1 = weak_odr global i32 42, comdat($c1)

; CHECK: @r11 = global i32* @v1{{$}}
; CHECK: @r12 = global i32 (i8*)* @f1{{$}}

; CHECK: @r21 = global i32* @v1{{$}}
; CHECK: @r22 = global i32 (i8*)* @f1{{$}}

; CHECK: @v11 = internal global i32 41, comdat $c2
; CHECK: @v11 = internal global i32 41, comdat($c2)

; CHECK: @a11 = alias i32* @v1{{$}}
; CHECK: @a12 = alias bitcast (i32* @v1 to i16*)
Expand All @@ -49,14 +49,14 @@ bb11:
; CHECK: @a23 = alias i32 (i8*)* @f12{{$}}
; CHECK: @a24 = alias bitcast (i32 (i8*)* @f12 to i16*)

; CHECK: define weak_odr protected i32 @f1(i8*) comdat $c1 {
; CHECK: define weak_odr protected i32 @f1(i8*) comdat($c1) {
; CHECK-NEXT: bb10:
; CHECK-NEXT: br label %bb11{{$}}
; CHECK: bb11:
; CHECK-NEXT: ret i32 42
; CHECK-NEXT: }

; CHECK: define internal i32 @f12(i8* %this) comdat $c2 {
; CHECK: define internal i32 @f12(i8* %this) comdat($c2) {
; CHECK-NEXT: bb20:
; CHECK-NEXT: store i8* %this, i8** null
; CHECK-NEXT: br label %bb21
Expand Down