343 changes: 343 additions & 0 deletions llvm/test/DebugInfo/MIR/X86/machinesink.mir
Original file line number Diff line number Diff line change
@@ -0,0 +1,343 @@
# RUN: llc -mtriple=x86_64-unknown-unknown -run-pass=machine-sink -o - %s | FileCheck %s
# In the first test, check various things when we sink machine instructions:
# a) DBG_VALUEs should sink with defs
# b) Undefs should be left behind
# c) DBG_VALUEs not immediately following the defining inst should sink too
# d) If we generate debug-use-before-defs through sinking, and can copy
# propagate to a different value, we should do that.
#
# Test two checks DBG_VALUEs do not sink past a DBG_VALUE in the same block
# that redefines the variable location, while three checks that copy-propagation
# happens in the same scenario.
#
# Test four: if we sink a DBG_VALUE via an intermediate block, no spurious
# DBG_VALUE $noreg's should appear along the way.
--- |
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

@x = common local_unnamed_addr global i32 0, align 4, !dbg !0

; Function Attrs: noreturn nounwind uwtable
define void @Process(i32* nocapture readonly %p) local_unnamed_addr !dbg !9 {
; Stripped
entry:
br label %nou
nou:
br label %exit
exit:
ret void
}

define void @test2(i32* nocapture readonly %p) local_unnamed_addr !dbg !101 {
; Stripped
entry:
br label %block1
block1:
br label %exit
exit:
ret void
}

define void @test3(i32* nocapture readonly %p) local_unnamed_addr !dbg !201 {
; Stripped
entry:
br label %block1
block1:
br label %exit
exit:
ret void
}

define void @test4(i32* nocapture readonly %p) local_unnamed_addr !dbg !301 {
; Stripped
entry:
br label %block1
block1:
br label %block2
block2:
br label %exit
combined:
br label %branch1
branch1:
br label %exit
exit:
ret void
}

; Function Attrs: nounwind readnone
declare void @llvm.dbg.value(metadata, i64, metadata, metadata)

!llvm.dbg.cu = !{!1}
!llvm.module.flags = !{!6, !7}
!llvm.ident = !{!8}

!0 = !DIGlobalVariableExpression(var: !DIGlobalVariable(name: "x", scope: !1, file: !2, line: 1, type: !5, isLocal: false, isDefinition: true), expr: !DIExpression())
!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, producer: "clang", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !3, globals: !4)
!2 = !DIFile(filename: "t.c", directory: "")
!3 = !{}
!4 = !{!0}
!5 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
!6 = !{i32 2, !"Dwarf Version", i32 4}
!7 = !{i32 2, !"Debug Info Version", i32 3}
!8 = !{!"clang version 4.0.0 "}
!9 = distinct !DISubprogram(name: "Process", scope: !2, file: !2, line: 2, type: !10, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: true, unit: !1, retainedNodes: !15)
!10 = !DISubroutineType(types: !11)
!11 = !{null, !12}
!12 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !13, size: 64)
!13 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !14)
!14 = !DIBasicType(name: "unsigned int", size: 32, encoding: DW_ATE_unsigned)
!15 = !{!16}
!16 = !DILocalVariable(name: "p", arg: 1, scope: !9, file: !2, line: 2, type: !12)
!17 = !DIExpression()
!18 = !DILocation(line: 2, column: 34, scope: !9)
!28 = !DILexicalBlockFile(scope: !9, file: !2, discriminator: 1)
!101 = distinct !DISubprogram(name: "test2", scope: !2, file: !2, line: 2, type: !10, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: true, unit: !1, retainedNodes: !102)
!102 = !{!103}
!103 = !DILocalVariable(name: "q", arg: 1, scope: !101, file: !2, line: 2, type: !12)
!104 = !DILocation(line: 1, column: 1, scope: !101)
!201 = distinct !DISubprogram(name: "test2", scope: !2, file: !2, line: 2, type: !10, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: true, unit: !1, retainedNodes: !202)
!202 = !{!203}
!203 = !DILocalVariable(name: "r", arg: 1, scope: !201, file: !2, line: 2, type: !12)
!204 = !DILocation(line: 1, column: 1, scope: !201)
!301 = distinct !DISubprogram(name: "test2", scope: !2, file: !2, line: 2, type: !10, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: true, unit: !1, retainedNodes: !302)
!302 = !{!303}
!303 = !DILocalVariable(name: "s", arg: 1, scope: !301, file: !2, line: 2, type: !12)
!304 = !DILocation(line: 1, column: 1, scope: !301)

; CHECK: [[VARNUM:![0-9]+]] = !DILocalVariable(name: "p",
; CHECK: [[VAR2NUM:![0-9]+]] = !DILocalVariable(name: "q",
; CHECK: [[VAR3NUM:![0-9]+]] = !DILocalVariable(name: "r",
; CHECK: [[VAR4NUM:![0-9]+]] = !DILocalVariable(name: "s",

...
---
name: Process
tracksRegLiveness: true
liveins:
- { reg: '$rdi', virtual-reg: '%2' }
- { reg: '$rsi', virtual-reg: '%2' }
body: |
bb.0.entry:
successors: %bb.1.nou(0x80000000), %bb.2.exit
liveins: $rdi, $esi
; This block should have the vreg copy sunk from it, the DBG_VALUE with it,
; and a copy-prop'd DBG_VALUE left over.
; CHECK-LABEL: bb.0.entry:
; CHECK: [[ARG0VREG:%[0-9]+]]:gr64 = COPY $rdi
; CHECK-NEXT: CMP32ri $esi, 0
; CHECK-NEXT: DBG_VALUE [[ARG0VREG]], $noreg, [[VARNUM]]
; CHECK-NEXT: JCC_1 %bb.1, 4
; CHECK-NEXT: JMP_1
%2:gr64 = COPY $rdi
%5:gr64 = COPY %2
CMP32ri $esi, 0, implicit-def $eflags
DBG_VALUE %5, $noreg, !16, !17, debug-location !18
JCC_1 %bb.1.nou, 4, implicit $eflags
JMP_1 %bb.2.exit
bb.1.nou:
successors: %bb.2.exit(0x80000000)
; This block should receive the sunk copy and DBG_VALUE
; CHECK-LABEL: bb.1.nou:
; CHECK: [[SUNKVREG:%[0-9]+]]:gr64 = COPY [[ARG0VREG]]
; CHECK-NEXT: DBG_VALUE [[SUNKVREG]], $noreg, [[VARNUM]]
; CHECK-NEXT: ADD64ri8
; CHECK-NEXT: JMP_1
%1:gr64 = ADD64ri8 %5, 4, implicit-def dead $eflags
JMP_1 %bb.2.exit
bb.2.exit:
; The DBG_VALUE below should have its operand copy-propagated after
; the copy to %5 is sunk.
; CHECK-LABEL: bb.2.exit:
; CHECK: DBG_VALUE [[ARG0VREG]], $noreg, [[VARNUM]]
; CHECK-NEXT: $rax = MOV64rr [[ARG0VREG]]
; CHECK-NEXT: RET 0
DBG_VALUE %5, _, !16, !17, debug-location !18
$rax = MOV64rr %2
RET 0
...
---
name: test2
tracksRegLiveness: true
liveins:
- { reg: '$rdi', virtual-reg: '%2' }
- { reg: '$rsi', virtual-reg: '%2' }
body: |
bb.0.entry:
successors: %bb.1.block1, %bb.2.exit
liveins: $rdi, $esi
; This block should _not_ have the first DBG_VALUE sunk out from it, as it
; would pass a later DBG_VALUE of the same variable location. An undef
; DBG_VALUE should be left behind though.
; CHECK-LABEL: bb.0.entry:
; CHECK: [[TEST2VREG:%[0-9]+]]:gr64 = COPY $rdi
; CHECK-NEXT: CMP32ri $esi, 0
; CHECK-NEXT: DBG_VALUE $noreg, $noreg, [[VAR2NUM]]
; CHECK-NEXT: CMP32ri $esi, 0
; CHECK-NEXT: DBG_VALUE 0, $noreg, [[VAR2NUM]]
; CHECK-NEXT: JCC_1 %bb.1, 4
; CHECK-NEXT: JMP_1
%2:gr64 = COPY $rdi
%5:gr64 = ADD64ri8 %2, 1, implicit-def dead $eflags
CMP32ri $esi, 0, implicit-def $eflags
DBG_VALUE %5, $noreg, !103, !17, debug-location !104
CMP32ri $esi, 0, implicit-def $eflags
DBG_VALUE 0, $noreg, !103, !17, debug-location !104
JCC_1 %bb.1.block1, 4, implicit $eflags
JMP_1 %bb.2.exit
bb.1.block1:
successors: %bb.2.exit
; This block should receive no DBG_VALUE.
; CHECK-LABEL: bb.1.block1:
; CHECK-NOT: DBG_VALUE
; CHECK: [[SUNKVREG2:%[0-9]+]]:gr64 = ADD64ri8 [[TEST2VREG]]
; CHECK-NOT: DBG_VALUE
; CHECK-NEXT: ADD64ri8
; CHECK: JMP_1 %bb.2
%1:gr64 = ADD64ri8 %5, 4, implicit-def dead $eflags
JMP_1 %bb.2.exit
bb.2.exit:
$rax = MOV64rr %2
RET 0
...
---
name: test3
tracksRegLiveness: true
liveins:
- { reg: '$rdi', virtual-reg: '%2' }
- { reg: '$rsi', virtual-reg: '%2' }
body: |
bb.0.entry:
successors: %bb.1.block1, %bb.2.exit
liveins: $rdi, $esi
; The copy from %2 to %5 will sink into a later block, and the first
; DBG_VALUE cannot pass the second. But, we should be able to recover
; the variable location through copy propagation.
; CHECK-LABEL: bb.0.entry:
; CHECK: [[TEST3VREG:%[0-9]+]]:gr64 = COPY $rdi
; CHECK-NEXT: CMP32ri $esi, 0
; CHECK-NEXT: DBG_VALUE [[TEST3VREG]], $noreg, [[VAR3NUM]]
; CHECK-NEXT: CMP32ri $esi, 0
; CHECK-NEXT: DBG_VALUE 0, $noreg, [[VAR3NUM]]
; CHECK-NEXT: JCC_1 %bb.1, 4
; CHECK-NEXT: JMP_1
%2:gr64 = COPY $rdi
%5:gr64 = COPY %2
CMP32ri $esi, 0, implicit-def $eflags
DBG_VALUE %5, $noreg, !203, !17, debug-location !204
CMP32ri $esi, 0, implicit-def $eflags
DBG_VALUE 0, $noreg, !203, !17, debug-location !204
JCC_1 %bb.1.block1, 4, implicit $eflags
JMP_1 %bb.2.exit
bb.1.block1:
successors: %bb.2.exit
; This block should receive no DBG_VALUE.
; CHECK-LABEL: bb.1.block1:
; CHECK-NOT: DBG_VALUE
; CHECK: COPY [[TEST3VREG]]
; CHECK-NOT: DBG_VALUE
; CHECK-NEXT: ADD64ri8
; CHECK: JMP_1 %bb.2
%1:gr64 = ADD64ri8 %5, 4, implicit-def dead $eflags
JMP_1 %bb.2.exit
bb.2.exit:
$rax = MOV64rr %2
RET 0
...
---
name: test4
tracksRegLiveness: true
liveins:
- { reg: '$rdi', virtual-reg: '%2' }
- { reg: '$rsi', virtual-reg: '%2' }
body: |
bb.0.entry:
successors: %bb.1.block1, %bb.2.block2
liveins: $rdi, $esi
; The DBG_VALUE here should sink through several blocks, but not leave any
; additional DBG_VALUE $noregs on its way.
; CHECK-LABEL: bb.0.entry:
; CHECK: [[TEST4VREG:%[0-9]+]]:gr64 = COPY $rdi
; CHECK-NEXT: CMP32ri $esi, 0
; CHECK-NEXT: DBG_VALUE $noreg, $noreg, [[VAR4NUM]]
; CHECK-NEXT: JCC_1 %bb.1, 4
; CHECK-NEXT: JMP_1
%2:gr64 = COPY $rdi
%5:gr64 = ADD64ri8 %2, 1, implicit-def dead $eflags
CMP32ri $esi, 0, implicit-def $eflags
DBG_VALUE %5, $noreg, !303, !17, debug-location !304
JCC_1 %bb.1.block1, 4, implicit $eflags
JMP_1 %bb.2.block2
bb.1.block1:
successors: %bb.3.combined
liveins: $esi
; CHECK-LABEL: bb.1.block1
; CHECK-NOT: DBG_VALUE
; CHECK: JMP_1 %bb.3
JMP_1 %bb.3.combined
bb.2.block2:
successors: %bb.3.combined
liveins: $esi
; CHECK-LABEL: bb.2.block2
; CHECK-NOT: DBG_VALUE
; CHECK: JMP_1 %bb.3
JMP_1 %bb.3.combined
bb.3.combined:
successors: %bb.4.branch1, %bb.5.exit
liveins: $esi
; CHECK-LABEL: bb.3.combined
; CHECK-NOT: DBG_VALUE
; CHECK: JCC_1 %bb.4, 4, implicit $eflags
; CHECK-NEXT: JMP_1 %bb.5
CMP32ri $esi, 1, implicit-def $eflags
JCC_1 %bb.4.branch1, 4, implicit $eflags
JMP_1 %bb.5.exit
bb.4.branch1:
successors: %bb.5.exit
; This block should receive the sunk copy and DBG_VALUE.
; CHECK-LABEL: bb.4.branch1:
; CHECK-NOT: DBG_VALUE
; CHECK: [[TEST4VREG2:%[0-9]+]]:gr64 = ADD64ri8 [[TEST4VREG]], 1
; CHECK-NEXT: DBG_VALUE [[TEST4VREG2]], $noreg, [[VAR4NUM]]
; CHECK-NEXT: ADD64ri8
; CHECK: JMP_1 %bb.5
%1:gr64 = ADD64ri8 %5, 4, implicit-def dead $eflags
JMP_1 %bb.5.exit
bb.5.exit:
; CHECK-LABEL: bb.5.exit
; CHECK-NOT: DBG_VALUE
; CHECK: RET 0
$rax = MOV64rr %2
RET 0
...
3 changes: 3 additions & 0 deletions llvm/test/DebugInfo/MIR/X86/postra-subreg-sink.mir
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ body: |
; CHECK: successors: %bb.1(0x80000000)
; CHECK: liveins: $edi
; CHECK: DBG_VALUE $edi, $noreg, ![[BARVAR]]
; CHECK-NEXT: DBG_VALUE $edi, $noreg, ![[ARGVAR]]
; CHECK-NEXT: DBG_VALUE $noreg, $noreg, ![[BAZVAR]]
; CHECK-NEXT: renamable $cl = MOV8ri 1
; CHECK-NEXT: DBG_VALUE $noreg, $noreg, ![[FOOVAR]]
; CHECK-NEXT: JMP_1 %bb.1
; CHECK: bb.1.return:
; CHECK: liveins: $cl, $edi
Expand Down
105 changes: 105 additions & 0 deletions llvm/test/DebugInfo/MIR/X86/sink-leaves-undef.mir
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
# RUN: llc %s -o - -run-pass=machine-sink -mtriple=x86_64-- | FileCheck %s
# This is a copy of test/CodeGen/X86/MachineSink-DbgValue.ll, where we
# additionally test that when the MOV32rm defining %0 is sunk, it leaves
# an 'undef' DBG_VALUE behind to terminate earlier location ranges.
--- |
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-apple-macosx10.7.0"

; Function Attrs: nounwind readonly ssp uwtable
define i32 @foo(i32 %i, i32* nocapture %c) !dbg !4 {
call void @llvm.dbg.value(metadata i32 %i, metadata !9, metadata !DIExpression()), !dbg !14
%ab = load i32, i32* %c, align 1, !dbg !15
call void @llvm.dbg.value(metadata i32* %c, metadata !10, metadata !DIExpression()), !dbg !16
call void @llvm.dbg.value(metadata i32 %ab, metadata !12, metadata !DIExpression()), !dbg !15
%cd = icmp eq i32 %i, 42, !dbg !17
br i1 %cd, label %bb1, label %bb2, !dbg !17

bb1: ; preds = %0
%gh = add nsw i32 %ab, 2, !dbg !18
br label %bb2, !dbg !18

bb2: ; preds = %bb1, %0
%.0 = phi i32 [ %gh, %bb1 ], [ 0, %0 ]
ret i32 %.0, !dbg !19
}

; Function Attrs: nounwind readnone speculatable
declare void @llvm.dbg.value(metadata, metadata, metadata)

; Function Attrs: nounwind
declare void @llvm.stackprotector(i8*, i8**)

!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!3}

!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "Apple clang version 3.0 (tags/Apple/clang-211.10.1) (based on LLVM 3.0svn)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, retainedTypes: !2)
!1 = !DIFile(filename: "a.c", directory: "/private/tmp")
!2 = !{}
!3 = !{i32 1, !"Debug Info Version", i32 3}
!4 = distinct !DISubprogram(name: "foo", scope: !1, file: !1, line: 2, type: !5, virtualIndex: 6, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !8)
!5 = !DISubroutineType(types: !6)
!6 = !{!7}
!7 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
!8 = !{!9, !10, !12}
!9 = !DILocalVariable(name: "i", arg: 1, scope: !4, file: !1, line: 2, type: !7)
!10 = !DILocalVariable(name: "c", arg: 2, scope: !4, file: !1, line: 2, type: !11)
!11 = !DIDerivedType(tag: DW_TAG_pointer_type, scope: !0, baseType: !7, size: 64, align: 64)
!12 = !DILocalVariable(name: "a", scope: !13, file: !1, line: 3, type: !7)
!13 = distinct !DILexicalBlock(scope: !4, file: !1, line: 2, column: 25)
!14 = !DILocation(line: 2, column: 13, scope: !4)
!15 = !DILocation(line: 3, column: 14, scope: !13)
!16 = !DILocation(line: 2, column: 22, scope: !4)
!17 = !DILocation(line: 4, column: 3, scope: !13)
!18 = !DILocation(line: 5, column: 5, scope: !13)
!19 = !DILocation(line: 7, column: 1, scope: !13)
; CHECK: ![[VARNUM:[0-9]+]] = !DILocalVariable(name: "a",
...
---
name: foo
alignment: 4
tracksRegLiveness: true
registers:
- { id: 0, class: gr32 }
- { id: 1, class: gr32 }
- { id: 2, class: gr32 }
- { id: 3, class: gr32 }
- { id: 4, class: gr64 }
- { id: 5, class: gr32 }
- { id: 6, class: gr32 }
liveins:
- { reg: '$edi', virtual-reg: '%3' }
- { reg: '$rsi', virtual-reg: '%4' }
body: |
bb.0 (%ir-block.0):
successors: %bb.1, %bb.2
liveins: $edi, $rsi
; CHECK-LABEL: bb.0 (%ir-block.0):
; CHECK: DBG_VALUE $noreg, $noreg, ![[VARNUM]]
DBG_VALUE $edi, $noreg, !9, !DIExpression(), debug-location !14
DBG_VALUE $rsi, $noreg, !10, !DIExpression(), debug-location !16
%4:gr64 = COPY $rsi
DBG_VALUE %4, $noreg, !10, !DIExpression(), debug-location !16
%3:gr32 = COPY $edi
DBG_VALUE %3, $noreg, !9, !DIExpression(), debug-location !14
%0:gr32 = MOV32rm %4, 1, $noreg, 0, $noreg, debug-location !15 :: (load 4 from %ir.c, align 1)
DBG_VALUE %0, $noreg, !12, !DIExpression(), debug-location !15
%5:gr32 = MOV32r0 implicit-def dead $eflags
%6:gr32 = SUB32ri8 %3, 42, implicit-def $eflags, debug-location !17
JCC_1 %bb.2, 5, implicit $eflags, debug-location !17
JMP_1 %bb.1, debug-location !17
bb.1.bb1:
; CHECK-LABEL: bb.1.bb1:
; CHECK: %[[VREG:[0-9]+]]:gr32 = MOV32rm
; CHECK-NEXT: DBG_VALUE %[[VREG]], $noreg, ![[VARNUM]]
; CHECK-NEXT: ADD32ri8
%1:gr32 = nsw ADD32ri8 %0, 2, implicit-def dead $eflags, debug-location !18
bb.2.bb2:
%2:gr32 = PHI %5, %bb.0, %1, %bb.1
$eax = COPY %2, debug-location !19
RET 0, $eax, debug-location !19
...