16 changes: 9 additions & 7 deletions mlir/test/EDSC/builder-api-test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,17 @@ using namespace mlir::edsc::intrinsics;

static MLIRContext &globalContext() {
static thread_local MLIRContext context(/*loadAllDialects=*/false);
static thread_local bool init_once = [&]() {
context.getOrLoadDialect<AffineDialect>();
context.getOrLoadDialect<scf::SCFDialect>();
context.getOrLoadDialect<linalg::LinalgDialect>();
context.getOrLoadDialect<StandardOpsDialect>();
context.getOrLoadDialect<vector::VectorDialect>();
static thread_local bool initOnce = [&]() {
// clang-format off
context.loadDialect<AffineDialect,
scf::SCFDialect,
linalg::LinalgDialect,
StandardOpsDialect,
vector::VectorDialect>();
// clang-format on
return true;
}();
(void)init_once;
(void)initOnce;
context.allowUnregisteredDialects();
return context;
}
Expand Down
3 changes: 1 addition & 2 deletions mlir/test/lib/Transforms/TestGpuMemoryPromotion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ class TestGpuMemoryPromotionPass
: public PassWrapper<TestGpuMemoryPromotionPass,
OperationPass<gpu::GPUFuncOp>> {
void getDependentDialects(DialectRegistry &registry) const override {
registry.insert<StandardOpsDialect>();
registry.insert<scf::SCFDialect>();
registry.insert<StandardOpsDialect, scf::SCFDialect>();
}

void runOnOperation() override {
Expand Down
12 changes: 7 additions & 5 deletions mlir/test/lib/Transforms/TestLinalgTransforms.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,13 @@ struct TestLinalgTransforms
TestLinalgTransforms(const TestLinalgTransforms &pass) {}

void getDependentDialects(DialectRegistry &registry) const override {
registry.insert<AffineDialect>();
registry.insert<scf::SCFDialect>();
registry.insert<StandardOpsDialect>();
registry.insert<vector::VectorDialect>();
registry.insert<gpu::GPUDialect>();
// clang-format off
registry.insert<AffineDialect,
scf::SCFDialect,
StandardOpsDialect,
vector::VectorDialect,
gpu::GPUDialect>();
// clang-format on
}

void runOnFunction() override;
Expand Down
4 changes: 1 addition & 3 deletions mlir/test/lib/Transforms/TestVectorTransforms.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,7 @@ struct TestVectorTransferFullPartialSplitPatterns
const TestVectorTransferFullPartialSplitPatterns &pass) {}

void getDependentDialects(DialectRegistry &registry) const override {
registry.insert<AffineDialect>();
registry.insert<linalg::LinalgDialect>();
registry.insert<scf::SCFDialect>();
registry.insert<AffineDialect, linalg::LinalgDialect, scf::SCFDialect>();
}

Option<bool> useLinalgOps{
Expand Down
6 changes: 3 additions & 3 deletions mlir/tools/mlir-tblgen/DialectGen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ static void emitDialectDecl(Dialect &dialect,
/// Build the list of dependent dialects
std::string dependentDialectRegistrations;
{
llvm::raw_string_ostream dialects_os(dependentDialectRegistrations);
llvm::raw_string_ostream dialectsOs(dependentDialectRegistrations);
for (StringRef dependentDialect : dialect.getDependentDialects())
dialects_os << llvm::formatv(dialectRegistrationTemplate,
dependentDialect);
dialectsOs << llvm::formatv(dialectRegistrationTemplate,
dependentDialect);
}
// Emit the start of the decl.
std::string cppName = dialect.getCppClassName();
Expand Down
6 changes: 3 additions & 3 deletions mlir/tools/mlir-tblgen/PassGen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ static void emitPassDecl(const Pass &pass, raw_ostream &os) {
StringRef defName = pass.getDef()->getName();
std::string dependentDialectRegistrations;
{
llvm::raw_string_ostream dialects_os(dependentDialectRegistrations);
llvm::raw_string_ostream dialectsOs(dependentDialectRegistrations);
for (StringRef dependentDialect : pass.getDependentDialects())
dialects_os << llvm::formatv(dialectRegistrationTemplate,
dependentDialect);
dialectsOs << llvm::formatv(dialectRegistrationTemplate,
dependentDialect);
}
os << llvm::formatv(passDeclBegin, defName, pass.getBaseClass(),
pass.getArgument(), dependentDialectRegistrations);
Expand Down
4 changes: 2 additions & 2 deletions mlir/unittests/IR/DialectTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ TEST(DialectDeathTest, MultipleDialectsWithSameNamespace) {

// Registering a dialect with the same namespace twice should result in a
// failure.
context.getOrLoadDialect<TestDialect>();
ASSERT_DEATH(context.getOrLoadDialect<AnotherTestDialect>(), "");
context.loadDialect<TestDialect>();
ASSERT_DEATH(context.loadDialect<AnotherTestDialect>(), "");
}

} // end namespace