llvm-upgrade gets sign wrong on long syntax call instructions

[asl]

Bugzilla Link	1312
Resolution	FIXED
Resolved on	Feb 22, 2010 12:51
Version	trunk
OS	Linux
Attachments	File in question

Extended Description

Consider attached file. It was generated via llvm-gcc 1.9.

llvm-upgrade rejects it:

./llvm-upgrade < test.ll
llvm-upgrade: :22: error: Reference to an invalid definition: 'tmp' of
type 'i32'
llvm-upgrade: parse failed.

[llvmbot]

Nice catch, Anton.

This was a subtle bug that only showed up in long syntax call instructions. The
code was using the signedness of the FunctionType ("composite") instead of the
signedness of the FunctionType's result type ("signed"). Consequently it didn't
find a matching (signed, "%tmp") when it looked it up because it had been stored
as (composite, "%tmp").

Fortunately, an easy fix:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070402/046950.html