PointerAlignment: Right interaction with AlignConsecutiveDeclarations

[llvmbot]

Bugzilla Link	27353
Version	trunk
OS	All
Reporter	LLVM Bugzilla Contributor
CC	@mkurdej

Extended Description

Repro:

$ cat sample.c
int* a;
unsigned long long x;
double* b;

$ clang-format -style="{PointerAlignment: Right, AlignConsecutiveDeclarations: true}" sample.c
int *              a;
unsigned long long x;
double *           b;

Expected/desired output is:

int                *a;
unsigned long long  x;
double             *b;

[llvmbot]

+1

I'd like to get this fixed as well.

With current implementation, AlignConsecutiveDeclarations breaks PointerAlignment.

[llvmbot]

In the code (clang/lib/Format/WhitespaceManager.cpp:449) contains a comment about this. It states it is unclear how

  const char* const* v1;
  float const* v2;
  SomeVeryLongType const& v3;

should be aligned. Does everyone agree that

  const char *const      *v1;
  float const            *v2;
  SomeVeryLongType const &v3;

is correct?

Or does anyone want:

const char *const *v1;

Or something else?

[llvmbot]

Addressed by https://reviews.llvm.org/D27651

[mkurdej]

https://reviews.llvm.org/D103245

[mydeveloperday]

Close by 3e333cc