scan-build mishandles CFDictionaryCreate

[llvmbot]

Bugzilla Link	2519
Resolution	FIXED
Resolved on	Nov 07, 2018 00:22
Version	unspecified
OS	MacOS X
Attachments	Test program. Use make static-analysis to run the analyzer.
Reporter	LLVM Bugzilla Contributor
CC	@tkremenek

Extended Description

The static analyzer flags false memory leaks on some objects that the program under analysis actually does release, if it does so using CFRelease.

The problem seems to be related to putting the object into a CF collection before releasing it. The program also releases the collection, also using CFRelease. Simply creating a CF object and releasing it is not enough to reproduce the bug.

[llvmbot]

assigned to @tkremenek

[tkremenek]

The bug was that the analyzer wasn't properly handling the keys and values being passed to CFDictionaryCreate. _value was being passed by reference, and its value was invalidated by the object referred to was considered leaked.

This is now fixed:

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080707/006438.html

The change is in checker-59 (now available).