Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] 4.0.0 Release Blockers #30970

Closed
zmodem opened this issue Jan 13, 2017 · 63 comments
Closed

[meta] 4.0.0 Release Blockers #30970

zmodem opened this issue Jan 13, 2017 · 63 comments
Assignees
Labels

Comments

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Jan 13, 2017

Bugzilla Link 31622
Resolution FIXED
Resolved on Mar 13, 2017 13:48
Version 4.0
OS All
Depends On #28059 #29604 #29632 #30123 #30534 #30535 #30547 #30605 #30673 #30729 #30954 #30974 #30976 #30986 #30992 #31020 #31021 #31033 #31036 #31037 #31040 #31058 #31059 #31071 #31075 #31077 #31081 #31088 #31092 #31093 #31099 #31109 #31111 #31117 #31121 #31128 #31130 #31152 #31156 #31171 #31173 #31180 #31181 #31191 #31193 #31229 #31237 #31309 #31311 #31313 #31331 #31346 #31361
CC @compnerd,@rovka,@DimitryAndric,@EdSchouten,@jsonn,@joker-eph,@RKSimon,@rengolin,@vchuravy

Extended Description

This is the tracking bug for blockers of the 4.0.0 release.

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Jan 13, 2017

assigned to @zmodem

@DimitryAndric
Copy link
Collaborator

@DimitryAndric DimitryAndric commented Jan 13, 2017

Please merge the fix for bug 31606, e.g. r291955 ("Generalize our tentative DR resolution for inheriting copy/move constructors to better match the pre-P0136R1 behavior")

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Jan 14, 2017

Please merge the fix for bug 31606, e.g. r291955 ("Generalize our tentative
DR resolution for inheriting copy/move constructors to better match the
pre-P0136R1 behavior")

It's on my list, Richard just wanted it to bake on trunk for a bit before we merge. Thanks.

@jsonn
Copy link
Contributor

@jsonn jsonn commented Jan 16, 2017

May I merge r292119 please? We hit this recently with -Wsystem-header builds, it's a left-over bug from the five-digit-revision age.

@jsonn
Copy link
Contributor

@jsonn jsonn commented Jan 17, 2017

r292244 is a fix for a recent regression reported on NetBSD, i.e. -march=native -mno-sse41 would assert for no good reason. May I merge it?

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Jan 18, 2017

May I merge r292119 please? We hit this recently with -Wsystem-header
builds, it's a left-over bug from the five-digit-revision age.

r292244 is a fix for a recent regression reported on NetBSD, i.e.
-march=native -mno-sse41 would assert for no good reason. May I merge it?

OK to both.

@dylanmckay
Copy link
Member

@dylanmckay dylanmckay commented Jan 19, 2017

I've added bug 31685 so that we can merge the fix for bug 30543

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 25, 2017

Please merge the fix for bug 27685 - already fixed on master, but not on the branch

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 25, 2017

I'm not sure if we want to consider bug 31756 a release blocker, as it requires xray to identify setups that inhibit the use of rdtscp. I've asked Dean to comment here about it.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 25, 2017

Bug 31547 is relatively serious for those of us who have to work with libgcc for compatibility reasons. It breaks e.g. building GNU sed 4.3 with clang on a Linux system using libgcc.

IMO this should be fixed for the release.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 26, 2017

I'd like to request merging two revisions:

  • [libunwind] r292723 from bug #​30879 -- this fixes exception handling on x86 Linux for me;

  • [lld] r293078 from bug #​31745 -- this fixes stand-alone build with shared libraries.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 27, 2017

I think XRay bug 31756 should not be considered a release blocker. There's quite a bit of work to do to probe and work-around the lack of rdtscp, and I wouldn't want to be blocking the release contingent on that being addressed.

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Jan 27, 2017

I'd like to request merging two revisions:

  • [libunwind] r292723 from bug #​30879 -- this fixes exception handling on
    x86 Linux for me;

Merged as r293298

  • [lld] r293078 from bug #​31745 -- this fixes stand-alone build with shared
    libraries.

r293289

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 28, 2017

Will llgo be released with 4.0 (It does have a release_40 branch and a 4.0.0rc1 tag, but isn't listed anywhere...)?

If so, should add bug 31786 to the blockers -- the fixes attached there are needed to make llgo compile on Linux.

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Jan 28, 2017

Will llgo be released with 4.0 (It does have a release_40 branch and a
4.0.0rc1 tag, but isn't listed anywhere...)?

If so, should add bug 31786 to the blockers -- the fixes attached there are
needed to make llgo compile on Linux.

I didn't tag or branch it, and I don't see any branch here: http://llvm.org/svn/llvm-project/llgo/branches/

I don't think llgo is part of the release process.

@vchuravy
Copy link
Contributor

@vchuravy vchuravy commented Jan 29, 2017

I would like to nominate rL293230 for inclusion into LLVM 4.0 it is a small fix that allows LLVM to build with the Intel 2017 toolchain.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jan 30, 2017

I'd like to request that r292624 - "[mips] Fix debug information for __thread variable"
and r292117 - "[mips] Correct c.cond.fmt instruction definition" be merged for 4.0.

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Jan 31, 2017

I would like to nominate rL293230 for inclusion into LLVM 4.0 it is a small
fix that allows LLVM to build with the Intel 2017 toolchain.

I've replied on the commit email.

I'd like to request that r292624 - "[mips] Fix debug information for
__thread variable"

r293664

and r292117 - "[mips] Correct c.cond.fmt instruction definition" be merged
for 4.0.

r293665.

@EdSchouten
Copy link
Contributor

@EdSchouten EdSchouten commented Mar 5, 2017

One of our users discovered a problem with SafeStack. I suspect it may be too late to get it fixed for 4.0, but added it to this tracking bug to ensure it won't get lost.

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Mar 6, 2017

One of our users discovered a problem with SafeStack. I suspect it may be
too late to get it fixed for 4.0, but added it to this tracking bug to
ensure it won't get lost.

It sounds like the revision that regressed that was in 3.9 too, so it's not a regression and too late for 4.0. I'll change it to be a 4.0.1 blocker instead.

@zmodem
Copy link
Collaborator Author

@zmodem zmodem commented Mar 13, 2017

The release has shipped, so closing this.

For 4.0.1 blockers, use llvm/llvm-bugzilla-archive#32061 .

@nhaehnle
Copy link
Collaborator

@nhaehnle nhaehnle commented Nov 26, 2021

mentioned in issue #30974

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Nov 26, 2021

mentioned in issue #30976

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Nov 26, 2021

mentioned in issue #30986

@DimitryAndric
Copy link
Collaborator

@DimitryAndric DimitryAndric commented Nov 26, 2021

mentioned in issue #30992

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Nov 26, 2021

mentioned in issue #31021

@DimitryAndric
Copy link
Collaborator

@DimitryAndric DimitryAndric commented Nov 26, 2021

mentioned in issue #31020

@dylanmckay
Copy link
Member

@dylanmckay dylanmckay commented Nov 26, 2021

mentioned in issue #31033

@arsenm
Copy link
Contributor

@arsenm arsenm commented Nov 26, 2021

mentioned in issue #31036

@arsenm
Copy link
Contributor

@arsenm arsenm commented Nov 26, 2021

mentioned in issue #31037

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet