sanitizers broken on freebsd in 8.0.0-rc2

[zmodem]

Bugzilla Link	40761
Resolution	FIXED
Resolved on	Aug 09, 2019 03:16
Version	8.0
OS	FreeBSD
Blocks	#40566 #41819
CC	@arichardson,@DimitryAndric,@emaste,@seanm

Extended Description

Dimitry reported that the sanitizers are broken on FreeBsd in 8.0.0-rc2: http://lists.llvm.org/pipermail/llvm-dev/2019-February/130236.html

"Unfortunately I had to disable compiler-rt for this test run, as most of the sanitizers are totally broken. They get into an endless recursive loop between AsanTSDGet() and the __tls_get_addr() interceptor, and crash with DEADLYSIGNAL due to stack overflow. I haven't found the time to further diagnose this."

[zmodem]

Dimitry hit this and looked at it also in rc1: http://lists.llvm.org/pipermail/llvm-dev/2019-February/129906.html

[zmodem]

+emaste for more FreeBSD people.

I think this is currently the only hard blocked for the release. Do you think you'll have time to look into this any time soon, or do you know someone who could?

[llvmbot]

It looks like this revision is related:

https://reviews.llvm.org/D55596 Reimplement Thread Static Data ASan routines with TLS

According to a tester it worked on FreeBSD. If you think that it has to be reverted for this OS, feel free to do it, but keep in mind that NetBSD must use the TLS version.

[zmodem]

Ed, Dimitry: ping? Do you think any of you will have to bisect or otherwise investigate this soon, or can you find someone who can work on it?

[DimitryAndric]

Ed, Dimitry: ping? Do you think any of you will have to bisect or otherwise
investigate this soon, or can you find someone who can work on it?

I won't have time to work on it at all, unfortunately.

[zmodem]

http://lists.llvm.org/pipermail/release-testers/2019-February/000869.html has some details on the errors Dimitry was seeing.

[zmodem]

and see also http://lists.llvm.org/pipermail/llvm-dev/2019-February/130386.html

[zmodem]

Sadly we will have to release without fixes for this (see email threads). Unblocking.

[arichardson]

Proposed fix: https://reviews.llvm.org/D55596

[arichardson]

Sorry that was the wrong URL. The proposed fix is https://reviews.llvm.org/D65221
If this is accepted we can hopefully get the fix into 9.0.

[arichardson]

Fixed in https://reviews.llvm.org/rL367442. Could we also get this committed to the release branch?

[zmodem]

Fixed in https://reviews.llvm.org/rL367442. Could we also get this committed
to the release branch?

Absolutely! Merged in r367524.

Dimitry: I hope this will make all tests in rc2.

[DimitryAndric]

Fixed in https://reviews.llvm.org/rL367442. Could we also get this committed
to the release branch?

Absolutely! Merged in r367524.

Dimitry: I hope this will make all tests in rc2.

It looks promising, but I still have to apply a few fixes to make the sanitizer tests compile at all, and some lit-related fixups to make the dynamic library path stuff work. And TSan is still completely broken. I will follow up on the mailing list.

[arichardson]

Fix for TSAN on FreeBSD: https://reviews.llvm.org/D65705

[zmodem]

Fix for TSAN on FreeBSD: https://reviews.llvm.org/D65705

That landed in r368103 and was merged to release_90 in r368426.