Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] 9.0.0 Release Blockers #41819

Closed
tstellar opened this issue Jul 1, 2019 · 114 comments
Closed

[meta] 9.0.0 Release Blockers #41819

tstellar opened this issue Jul 1, 2019 · 114 comments
Assignees
Labels
bugzilla

Comments

@tstellar
Copy link
Collaborator Author

@tstellar tstellar commented Jul 1, 2019

assigned to @zmodem

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Jul 26, 2019

Hans could we consider #40038 to be a blocker for 9.0?

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Jul 26, 2019

Hans could we consider #40038 to be a
blocker for 9.0?

Yes, added it.

@modocache
Copy link
Member

@modocache modocache commented Jul 30, 2019

I added llvm/llvm-bugzilla-archive#42827 as a blocker, please triage as appropriate. Thank you!

@jdoerfert
Copy link
Member

@jdoerfert jdoerfert commented Jul 31, 2019

Hans could we consider #40038 to be a
blocker for 9.0?

Yes, added it.

Fixed in r367387. Do I need to create a new bug as a merge request?

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Aug 6, 2019

Fixed in r367387. Do I need to create a new bug as a merge request?

(Forgot to reply here: no, I've merged it already as commented on the bug.)

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Aug 7, 2019

I'd like to nominate #42266 as blocker. I'm hoping it's easy and low risk for someone who knows the right part of the build system.

@jsonn
Copy link
Contributor

@jsonn jsonn commented Aug 7, 2019

Please merge r368104 (clang) and r367750 (LLVM) part. This fixes a regression since the 8.0 release. One part for addressing the issues for -O0 is still under review, but improving the situation for optimized builds is already a huge step.

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Aug 9, 2019

Please merge r368104 (clang) and r367750 (LLVM) part. This fixes a
regression since the 8.0 release. One part for addressing the issues for -O0
is still under review, but improving the situation for optimized builds is
already a huge step.

I started with the LLVM patch, but it doesn't apply cleanly on the branch, for example, RISCVTargetLowering::getConstraintType() didn't exist when we branched.

Jörg or Bill, could you prepare a patch that applies cleanly against the branch?

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Aug 9, 2019

Please merge r368104 (clang) and r367750 (LLVM) part. This fixes a
regression since the 8.0 release. One part for addressing the issues for -O0
is still under review, but improving the situation for optimized builds is
already a huge step.

I started with the LLVM patch, but it doesn't apply cleanly on the branch,
for example, RISCVTargetLowering::getConstraintType() didn't exist when we
branched.

Jörg or Bill, could you prepare a patch that applies cleanly against the
branch?

Actually, I just ended up merging r367403 to unblock it.

I've merged r367750 in r368421 and r368104(+368202) in r368422.

@beccadax
Copy link
Contributor

@beccadax beccadax commented Aug 16, 2019

Should #42366 be a blocker? A reviewer of the fix suggested it should be.

@zoecarver
Copy link
Contributor

@zoecarver zoecarver commented Aug 18, 2019

is_base_of_union.pass.cpp fails in C++03. Maybe it should be a release blocker?

@zoecarver
Copy link
Contributor

@zoecarver zoecarver commented Aug 19, 2019

Nevermind, that is just on apple-clang-11.0.

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Aug 20, 2019

Should #42366 be a blocker? A reviewer
of the fix suggested it should be.

Yes, that seems reasonable. I see it's marked as a blocker now.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Aug 29, 2019

Can llvm/llvm-bugzilla-archive#42924 be considered a blocker? It is causing timeouts for us when building with AddressSanitizer.

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Aug 30, 2019

Can llvm/llvm-bugzilla-archive#42924 be considered a blocker? It
is causing timeouts for us when building with AddressSanitizer.

Sorry, I think it's too late to do anything about it for 9.0.0. I've put in on my list of things for 9.0.1.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Sep 2, 2019

Please #42188 Clang-cl -std=c++17 doesn't handle the constexpr symbol correctly. I looked at the recent clang commit. No one seems to be dealing with this issue. If this release is not blocked, clang 9.0 may fail on Windows.

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Sep 2, 2019

Please #42188 Clang-cl -std=c++17
doesn't handle the constexpr symbol correctly. I looked at the recent clang
commit. No one seems to be dealing with this issue. If this release is not
blocked, clang 9.0 may fail on Windows.

Sorry, here is a correction, clang-cl -std=c++14 (9.0) did not handle constexpr, not -std=c++17.

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Sep 2, 2019

Please #42188 Clang-cl -std=c++17
doesn't handle the constexpr symbol correctly. I looked at the recent clang
commit. No one seems to be dealing with this issue. If this release is not
blocked, clang 9.0 may fail on Windows.

Sorry, here is a correction, clang-cl -std=c++14 (9.0) did not handle
constexpr, not -std=c++17.

I had not seen this before. I'll take a look and reply on the bug.

@JosephTremoulet
Copy link
Member

@JosephTremoulet JosephTremoulet commented Sep 5, 2019

I'd like to request that 43229 get triaged, and considered for 9.0.1 if not 9.0.0 . Thanks.

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Sep 6, 2019

I'd like to request that 43229 get triaged, and considered for 9.0.1 if not
9.0.0 . Thanks.

I've put it on my 9.0.1 list.

@zmodem
Copy link
Collaborator

@zmodem zmodem commented Sep 19, 2019

The -final tag is in.

9.0.1 blockers are tracked by llvm/llvm-bugzilla-archive#43360

@tstellar
Copy link
Collaborator Author

@tstellar tstellar commented Nov 27, 2021

mentioned in issue #41820

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Nov 27, 2021

mentioned in issue #41858

@aheejin
Copy link
Member

@aheejin aheejin commented Nov 27, 2021

mentioned in issue #41920

@ldalessa
Copy link

@ldalessa ldalessa commented Nov 27, 2021

mentioned in issue #41931

@bsdkurt
Copy link
Mannequin

@bsdkurt bsdkurt mannequin commented Nov 27, 2021

mentioned in issue #41948

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Nov 27, 2021

mentioned in issue #41991

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Nov 27, 2021

mentioned in issue #42010

@sam-mccall
Copy link
Collaborator

@sam-mccall sam-mccall commented Nov 27, 2021

mentioned in issue #42014

@adalava adalava mannequin mentioned this issue Aug 30, 2019
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla
Projects
None yet
Development

No branches or pull requests