Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression(368987): Assertion `(!RPI.isPaired() || RPI.Reg2 != AArch64::FP || RPI.Reg1 == AArch64::LR) && "FrameRecord must be allocated together with LR"' when building ffmpeg #42361

Closed
nico opened this issue Aug 16, 2019 · 2 comments
Labels
backend:AArch64 bugzilla

Comments

@nico
Copy link
Contributor

@nico nico commented Aug 16, 2019

Bugzilla Link 43016
Resolution FIXED
Resolved on Aug 30, 2019 04:54
Version trunk
OS All
CC @Arnaud-de-Grandmaison-ARM,@sdesmalen-arm,@smithp35

Extended Description

See https://bugs.chromium.org/p/chromium/issues/detail?id=994463#c2 for a standalone repo (too big for bugzilla)

@nico
Copy link
Contributor Author

@nico nico commented Aug 16, 2019

$ llvm/utils/git-svn/git-llvm push
Pushing 1 monorepo commit:
55f6d4dd665 Revert r368987, it caused #42361 .
Sending llvm/trunk/lib/Target/AArch64/AArch64CallingConvention.td
Sending llvm/trunk/lib/Target/AArch64/AArch64FrameLowering.cpp
Sending llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.cpp
Sending llvm/trunk/test/CodeGen/AArch64/aarch64-dynamic-stack-layout.ll
Sending llvm/trunk/test/CodeGen/AArch64/aarch64-vector-pcs.mir
Sending llvm/trunk/test/CodeGen/AArch64/addsub-constant-folding.ll
Sending llvm/trunk/test/CodeGen/AArch64/alloca.ll
Sending llvm/trunk/test/CodeGen/AArch64/arm64-alloca-frame-pointer-offset.ll
Sending llvm/trunk/test/CodeGen/AArch64/cgp-usubo.ll
Sending llvm/trunk/test/CodeGen/AArch64/fast-isel-sp-adjust.ll
Sending llvm/trunk/test/CodeGen/AArch64/irg_sp_tagp.ll
Sending llvm/trunk/test/CodeGen/AArch64/regress-w29-reserved-with-fp.ll
Sending llvm/trunk/test/CodeGen/AArch64/reverse-csr-restore-seq.mir
Sending llvm/trunk/test/CodeGen/AArch64/seh-finally.ll
Sending llvm/trunk/test/CodeGen/AArch64/shadow-call-stack.ll
Sending llvm/trunk/test/CodeGen/AArch64/sink-copy-for-shrink-wrap.ll
Sending llvm/trunk/test/CodeGen/AArch64/spill-stack-realignment.mir
Sending llvm/trunk/test/CodeGen/AArch64/sponentry.ll
Sending llvm/trunk/test/CodeGen/AArch64/stack-guard-reassign.ll
Sending llvm/trunk/test/CodeGen/AArch64/stack-guard-vaarg.ll
Sending llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-constmask-innerouter.ll
Sending llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-constmask-interleavedbits.ll
Sending llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-constmask-interleavedbytehalves.ll
Sending llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-constmask-lowhigh.ll
Sending llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll
Sending llvm/trunk/test/CodeGen/AArch64/unreachable-emergency-spill-slot.mir
Sending llvm/trunk/test/CodeGen/AArch64/win64_vararg.ll
Sending llvm/trunk/test/CodeGen/AArch64/wineh-frame5.mir
Sending llvm/trunk/test/CodeGen/AArch64/wineh-frame7.mir
Sending llvm/trunk/test/CodeGen/AArch64/wineh-try-catch-realign.ll
Sending llvm/trunk/test/CodeGen/AArch64/wineh-try-catch.ll
Sending llvm/trunk/test/CodeGen/AArch64/wineh_shrinkwrap.mir
Transmitting file data ................................done
Committing transaction...
Committed revision 369080.
Committed 55f6d4dd665 to svn.

@sdesmalen-arm
Copy link
Collaborator

@sdesmalen-arm sdesmalen-arm commented Aug 16, 2019

The patch relanded in https://reviews.llvm.org/rGf28e1128d9ef, and addresses the assertion-failure in this bug report.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AArch64 bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants