apt packages have exports for FileCheck but don't ship it

[weliveindetail]

Bugzilla Link	43035
Resolution	FIXED
Resolved on	Aug 28, 2019 06:04
Version	9.0
OS	Linux
CC	@zmodem,@sylvestre

[weliveindetail]

assigned to @sylvestre

[weliveindetail]

Quick repro:

> docker pull weliveindetail/llvm09-apt-exports-repro:19.04
> docker run -it weliveindetail/llvm09-apt-exports-repro:19.04 /bin/bash
# cmake -G Ninja -B /home/jitfromscratch-release -DCMAKE_BUILD_TYPE=Release /home/jitfromscratch
[...]

CMake Error at /usr/lib/llvm-9/lib/cmake/llvm/LLVMExports.cmake:1335 (message):
  The imported target "FileCheck" references the file

     "/usr/lib/llvm-9/bin/FileCheck"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/usr/lib/llvm-9/lib/cmake/llvm/LLVMExports.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  /usr/lib/llvm-9/cmake/LLVMConfig.cmake:245 (include)
  CMakeLists.txt:31 (find_package)

I created the image like this:

> docker run -it ubuntu:19.04
# apt-get update
# apt-get install -y --no-install-recommends ca-certificates wget gnupg software-properties-common
# wget https://apt.llvm.org/llvm-snapshot.gpg.key
# apt-key add llvm-snapshot.gpg.key
# apt-add-repository "deb http://apt.llvm.org/disco/ llvm-toolchain-disco-9 main"
# apt-get update
# apt-get install -y --no-install-recommends build-essential git cmake cmake-data ninja-build zlib1g-dev llvm-9-dev
# git clone https://github.com/weliveindetail/JitFromScratch.git /home/jitfromscratch
# cd /home/jitfromscratch
# git fetch origin llvm90/master
# git checkout llvm90/master
# cmake -G Ninja -B /home/jitfromscratch-release -DCMAKE_BUILD_TYPE=Release .

[weliveindetail]

How were the releases in the apt packages built? I can reproduce this on Ubuntu 18.04 and 19.04.

IIUC we shouldn't have FileCheck here (same for llvm-PerfectShuffle;count;not;yaml-bench?):

lib/cmake/llvm/LLVMConfig.cmake
244: set(LLVM_EXPORTED_TARGETS ...;FileCheck;...)

lib/cmake/llvm/LLVMExports.cmake
19:foreach(_expectedTarget ...;FileCheck;...)
1083:# Create imported target FileCheck
1084:add_executable(FileCheck IMPORTED)

I remember having see this issue at some point. I can try to investigate for a few hours during the week.

[weliveindetail]

LLVM_INSTALL_UTILS=ON causes FileCheck and others to be listed in LLVMExports.cmake

Was it used to build the apt packages?

[zmodem]

LLVM_INSTALL_UTILS=ON causes FileCheck and others to be listed in
LLVMExports.cmake

Was it used to build the apt packages?

+Sylvestre who knows might know.

[weliveindetail]

Still reproducible

[sylvestre]

Yeah, I have been on holidays.
Don't hesitate to submit a patch next time ;)

[sylvestre]

I am not sure what you mean by "Don't ship it"

FileCheck is installed in the llvm-{7,8,9,...}-tools packages

[weliveindetail]

LLVMExports.cmake from the llvm-9-dev package lists FileCheck & co, but doesn't include the binaries for them.

[sylvestre]

Because it is shipped as part of llvm-9-tools
% dpkg -S FileCheck
[...]
llvm-9-tools: /usr/lib/llvm-9/bin/FileCheck

In command #​1
just replace the install by

apt-get install -y --no-install-recommends build-essential git cmake cmake-data ninja-build zlib1g-dev llvm-9-dev llvm-9-tools

[zmodem]

Sylvestre: it's unclear to me if there is a problem here. Should the bug be marked wonfix? Or is there a dependency between packages missing?

In any case, I'm guessing this isn't a blocker for the release from the llvm side.

[weliveindetail]

bionic llvm-8-dev (working)

[weliveindetail]

bionic llvm-9-dev (broken)

[weliveindetail]

I attached the file in question. Please compare yourself if you want. If the change is on purpose, please explain how external projects are supposed to import LLVM from the apt release.

[sylvestre]

I am sorry but what should I see in the llvm-*-dev-LLVMExports.cmake files ?

Why don't you just add llvm-9-tools in the list of deps ?