Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --mlir-print-op-on-diagnostic the default for command line developer tools #44175

Closed
joker-eph opened this issue Feb 7, 2020 · 2 comments
Assignees
Labels
bugzilla mlir:core

Comments

@joker-eph
Copy link
Collaborator

@joker-eph joker-eph commented Feb 7, 2020

Bugzilla Link 44830
Resolution FIXED
Resolved on Apr 05, 2020 10:18
Version unspecified
OS All
CC @jpienaar,@River707

Extended Description

When feed IR to a tool like mlir-opt and going through transformations, the verifier failure are confusing:

input_to-tf-shape-inference.mlir:115:15: error: 'tf.Shape' op requires dynamic shape result for unranked operand
%27 = "tf.Shape"(%26) {T = i32, _output_shapes = ["tfshape$dim { size: 1 }"], device = "", out_type = i32} : (tensor<?xi32>) -> tensor<1xi32>

The IR displayed is actually extracted from the source file, and the actual operation that is failing the verifier may be entirely different.

It seems that for developers (or when IR is the input), the verifier would be better printing the current instruction.

@joker-eph
Copy link
Collaborator Author

@joker-eph joker-eph commented Feb 7, 2020

assigned to @River707

@joker-eph
Copy link
Collaborator Author

@joker-eph joker-eph commented Apr 5, 2020

Fixed in 79afdfa

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla mlir:core
Projects
None yet
Development

No branches or pull requests

1 participant