Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flang] fircg_Dialect should use prefixed accessors #58090

Closed
River707 opened this issue Sep 30, 2022 · 3 comments
Closed

[Flang] fircg_Dialect should use prefixed accessors #58090

River707 opened this issue Sep 30, 2022 · 3 comments
Assignees
@clementval
Labels
flang:ir

Comments

@River707
Copy link
Contributor

The raw accessor form for dialects is going away soon, and fircg_Dialect is the only flang dialect that hasn't been flipped (as far as I could tell). The accessors can be flipped by removing the following:

  let emitAccessorPrefix = kEmitAccessorPrefix_Raw;

and then updating any API changes that come out of that.
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 30, 2022

@llvm/issue-subscribers-flang-ir

@clementval
Copy link
Contributor

Patch up for review here: https://reviews.llvm.org/D135061

clementval added a commit that referenced this issue Oct 3, 2022
@clementval
[flang][NFC] Use prefixed accessors for fircg dialect
a89b048 
The raw accessor is going away soon so switch to prefixed accessors in the
fircg dialect. The main dialect was switched some months ago.

#58090

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D135061
@clementval
Copy link
Contributor

a89b048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clementval clementval

Labels
flang:ir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clementval @River707 @llvmbot