You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried running modernize-concat-nested-namespaces on the entire PyTorch repo and found some edge cases.
Specifically,
namespacea {
namespaceb {
}
/* IMPORTANT IFDEF AND MACROS HERE */
}
Where any important ifdef logic or macros are deleted in the fixit (which breaks compilation later), which is definitely not ideal. It would be great if the check didn't apply the fixit where important non-namespace comments, macros, or other code is not deleted.