Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule to unit-tests for the RVV intrinsics #61179

Open
eopXD opened this issue Mar 4, 2023 · 3 comments
Open

Submodule to unit-tests for the RVV intrinsics #61179

eopXD opened this issue Mar 4, 2023 · 3 comments

Comments

@eopXD
Copy link
Member

eopXD commented Mar 4, 2023

We conventionally just put everything we need into the monorepo. I am wondering if we can link a submodule to unit test under https://github.com/riscv-non-isa/rvv-intrinsic-doc/tree/master/auto-generated/llvm-api-tests to avoid the two places be out-of-sync.

CC: @asb @kito-cheng @topperc

@asb
Copy link
Contributor

asb commented Mar 6, 2023

As you suggest, I don't think there's any use of git submodules at all within LLVM right now. I could be wrong, but I'd imagine the bar to add the first submodule is quite high in terms of community buy in, especially in light of the fairly wide-spread view that git submodules are awkward to use.

It's been a while since I used git submodules so perhaps things have changed, but wouldn't you also need to regularly update the submodule reference to point to the latest rvv-intrinsic-doc commit?

In my personal view, given the barriers to introducing submodules for the first time I don't think the benefit is high enough and it might be easier if you just have a script to sync. I'd welcome other thoughts though!

@Endilll
Copy link
Contributor

Endilll commented Oct 2, 2023

https://github.com/llvm/llvm-test-suite may have a lower bar for submodules than monorepo does.

@llvmbot
Copy link
Member

llvmbot commented Oct 2, 2023

@llvm/issue-subscribers-backend-risc-v

We conventionally just put everything we need into the monorepo. I am wondering if we can link a submodule to unit test under https://github.com/riscv-non-isa/rvv-intrinsic-doc/tree/master/auto-generated/llvm-api-tests to avoid the two places be out-of-sync.

CC: @asb @kito-cheng @topperc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants