You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As you suggest, I don't think there's any use of git submodules at all within LLVM right now. I could be wrong, but I'd imagine the bar to add the first submodule is quite high in terms of community buy in, especially in light of the fairly wide-spread view that git submodules are awkward to use.
It's been a while since I used git submodules so perhaps things have changed, but wouldn't you also need to regularly update the submodule reference to point to the latest rvv-intrinsic-doc commit?
In my personal view, given the barriers to introducing submodules for the first time I don't think the benefit is high enough and it might be easier if you just have a script to sync. I'd welcome other thoughts though!
We conventionally just put everything we need into the monorepo. I am wondering if we can link a submodule to unit test under https://github.com/riscv-non-isa/rvv-intrinsic-doc/tree/master/auto-generated/llvm-api-tests to avoid the two places be out-of-sync.
We conventionally just put everything we need into the monorepo. I am wondering if we can link a submodule to unit test under https://github.com/riscv-non-isa/rvv-intrinsic-doc/tree/master/auto-generated/llvm-api-tests to avoid the two places be out-of-sync.
CC: @asb @kito-cheng @topperc
The text was updated successfully, but these errors were encountered: