clang/utils/TableGen/ClangOptionDocEmitter.cpp:220: Pointless string copy ? #94373
Open
Description
Static analyser cppcheck says:
clang/utils/TableGen/ClangOptionDocEmitter.cpp:220:41: performance: Function parameter 'Heading' should be passed by const reference. [passedByValue]
Source code is
void emitHeading(int Depth, std::string Heading, raw_ostream &OS) {
Maybe better code:
void emitHeading(int Depth, const std::string & Heading, raw_ostream &OS) {
Activity