P0941R2: Integrating feature-test macros into the C++ WD #99986

Activity

1. cjdb

   added

   libc++libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

   c++20

   on Jul 22, 2024
2. llvmbot commented on Jul 22, 2024

   

   llvmbot

   on Jul 22, 2024

   Member

   More actions

   @llvm/issue-subscribers-c-20

   Author: Christopher Di Bella (cjdb)

   Details
3. ldionne

   added this to libc++ Standards Conformanceon Jul 24, 2024
4. cjdb

   added

   good first issuehttps://github.com/llvm/llvm-project/contributehttps://github.com/llvm/llvm-project/contribute

   on Jul 24, 2024
5. llvmbot commented on Jul 24, 2024

   

   llvmbot

   on Jul 24, 2024

   Member

   More actions

   Hi!

   This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

   1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
   2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
   3. Fix the issue locally.
   4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
   5. Create a Git commit.
   6. Run git clang-format HEAD~1 to format your changes.
   7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

   If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.
6. llvmbot commented on Jul 24, 2024

   

   llvmbot

   on Jul 24, 2024

   Member

   More actions

   @llvm/issue-subscribers-good-first-issue

   Author: Christopher Di Bella (cjdb)

   Details

   **Link:** https://wg21.link/p0941r2
7. ldionne

   added

   wg21-paperIssues representing the implementation of a WG21 paperIssues representing the implementation of a WG21 paper

   on Jul 30, 2024
8. cjdb

   added

   potentially good for outreachConsider this issue as a good first issue for someone that has spoken to an experienced LLVM devConsider this issue as a good first issue for someone that has spoken to an experienced LLVM dev

   and removed

   good first issuehttps://github.com/llvm/llvm-project/contributehttps://github.com/llvm/llvm-project/contribute

   on Aug 1, 2024
9. ldionne

   changed the title [-]Complete 'P0941R2 Integrating feature-test macros into the C++ WD'[/-] [+]P0941R2: Integrating feature-test macros into the C++ WD[/+] on Aug 1, 2024
10. ldionne

    moved this to Todo in libc++ Standards Conformanceon Aug 21, 2024
11. ldionne

    moved this from Todo to In Progress in libc++ Standards Conformanceon Aug 21, 2024
12. frederick-vs-ja commented on Jan 20, 2025

    

    frederick-vs-ja

    on Jan 20, 2025

    Contributor

    More actions

    Currently still blocked on:

    • __cpp_lib_math_special_functions (P0226R1, P0226R1: Mathematical Special Functions for C++17 #99939)
    • __cpp_lib_parallel_algorithm (P0024R2, P0024R2: The Parallelism TS Should be Standardized #99938)

    I guess we should set __cpp_lib_execution after commit ebc05b9 (https://reviews.llvm.org/D141888). WDYT @philnik777?
13. philnik777 commented on Jan 20, 2025

    

    philnik777

    on Jan 20, 2025

    Contributor

    More actions

    @frederick-vs-ja I'm not quite sure why there are both __cpp_lib_parallel_algorithm and __cpp_lib_execution, so I'm not sure I want to set either of them until all of the PSTL is implemented.