Jump to conversation
Unresolved conversations (3)
@overmighty overmighty Jul 30, 2024
You wrote `LIST_ADD_TESTS` instead of `LIST_DIV_TESTS`, so the preprocessor didn't replace the macro, and Clang thought you were declaring a function and that `LIBC_NAMESPACE::ddivl` was meant to be the type of an unnamed function parameter. The log view on the Buildkite website only displays the last 2 MB of data. You can view the error messages if you download the raw log: <details><summary>Relevant part of the Buildkite log</summary> <pre><code>_bk;t=1722365638958 [2610/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638959 [2611/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexpl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638959 [2611/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638959 [2612/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbl_test.__unit__.__build___bk;t=1722365638959 [2612/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638962 [2613/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexp_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638962 [2613/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__build__.dir/fmax_test.cpp.o_bk;t=1722365638963 [2614/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexpf_test.__unit__.__build___bk;t=1722365638963 [2614/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638963 [2615/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.copysignf_test.__unit__.__build___bk;t=1722365638964 [2615/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638964 [2616/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.copysignf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638964 [2616/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638964 [2617/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.frexpl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638964 [2617/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxl_test.__unit__.__build__.dir/fmaxl_test.cpp.o_bk;t=1722365638965 [2618/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbf_test.__unit__.__build___bk;t=1722365638965 [2618/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxl_test.__unit__.__NO_FMA_OPT.__build__.dir/fmaxl_test.cpp.o_bk;t=1722365638966 [2619/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__build__.dir/fmin_test.cpp.o_bk;t=1722365638966 [2619/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638967 [2620/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmin_test.cpp.o_bk;t=1722365638967 [2620/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638967 [2621/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.frexpf_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638967 [2621/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.sqrtf_test.__unit__.__build__.dir/sqrtf_test.cpp.o_bk;t=1722365638968 [2622/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbf_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638968 [2622/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.sqrt_test.__unit__.__build__.dir/sqrt_test.cpp.o_bk;t=1722365638968 [2623/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638968 [2623/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.sqrtl_test.__unit__.__build__.dir/sqrtl_test.cpp.o_bk;t=1722365638973 [2624/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fminl_test.__unit__.__NO_FMA_OPT.__build__.dir/fminl_test.cpp.o_bk;t=1722365638973 [2624/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fminl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638978 [2625/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexp_test.__unit__.__build___bk;t=1722365638978 [2625/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrtf_test.__unit__.__build__.dir/generic_sqrtf_test.cpp.o_bk;t=1722365638979 [2626/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmin_test.cpp.o_bk;t=1722365638979 [2626/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638980 [2627/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogb_test.__unit__.__build___bk;t=1722365638980 [2627/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrtf_test.__unit__.__NO_FMA_OPT.__build__.dir/generic_sqrtf_test.cpp.o_bk;t=1722365638986 [2628/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__build__.dir/fmin_test.cpp.o_bk;t=1722365638986 [2628/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__build___bk;t=1722365638987 [2629/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogb_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638987 [2629/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrt_test.__unit__.__build__.dir/generic_sqrt_test.cpp.o_bk;t=1722365638989 [2630/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.logb_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638989 [2630/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrt_test.__unit__.__NO_FMA_OPT.__build__.dir/generic_sqrt_test.cpp.o_bk;t=1722365638990 [2631/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fminl_test.__unit__.__build__.dir/fminl_test.cpp.o_bk;t=1722365638990 [2631/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fminl_test.__unit__.__build___bk;t=1722365638992 [2632/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638992 [2632/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmaxf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638993 [2633/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638993 [2633/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638994 [2634/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638995 [2634/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638996 [2635/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638997 [2635/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638999 [2636/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638999 [2636/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365639000 [2637/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxl_test.__unit__.__build__.dir/fmaxl_test.cpp.o_bk;t=1722365639000 [2637/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmaxl_test.__unit__.__build___bk;t=1722365639002 [2638/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o_bk;t=1722365639002 _bk;t=1722365639002FAILED: projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o _bk;t=1722365639002CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/build/projects/libc/test/src/math -I/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math -I/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc -isystem /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/build/projects/libc/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG -mavx2 -mfma -fpie -march=native -fno-exceptions -fno-rtti -std=c++17 -MD -MT projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o -MF projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o.d -o projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o -c /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math/ddivl_test.cpp _bk;t=1722365639003/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math/ddivl_test.cpp:13:53: error: no type named 'ddivl' in namespace '__llvm_libc_20_0_0_git' _bk;t=1722365639003LIST_ADD_TESTS(double, long double, LIBC_NAMESPACE::ddivl) _bk;t=1722365639003 ~~~~~~~~~~~~~~~~^ _bk;t=1722365639003/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math/ddivl_test.cpp:13:59: error: expected function body after function declarator _bk;t=1722365639003LIST_ADD_TESTS(double, long double, LIBC_NAMESPACE::ddivl) _bk;t=1722365639003 ^ _bk;t=17223656390032 errors generated. </code></pre></details> By the way, I tried to change it to `LIST_DIV_TESTS` and then the MPFR test failed due to incorrect results.
Outdated
libc/test/src/math/ddivl_test.cpp
overmighty aaryanshukla
@overmighty overmighty Jul 29, 2024
You can just remove this new line so that this PR doesn't change newhdrgen at all. ```suggestion ```
Outdated
libc/newhdrgen/yaml_to_classes.py
@overmighty overmighty Jul 24, 2024
There were previously no `float128` entrypoints in this file.
Outdated
libc/config/windows/entrypoints.txt
Resolved conversations (46)
@overmighty overmighty Aug 1, 2024
```suggestion | ddiv | N/A | N/A | | N/A | |check|\* | 7.12.14.4 | F.10.11 | ```
Outdated
libc/docs/math/index.rst
aaryanshukla
@overmighty overmighty Jul 30, 2024
I missed the fact that these were MPFR tests using `float128`. `float128` isn't supported for MPFR tests as I mentioned on your other PR.
Outdated
libc/test/src/math/daddf128_test.cpp
aaryanshukla
@overmighty overmighty Jul 30, 2024
Tue told me he meant both baremetal Arm and baremetal RISC-V when he said not to enable entrypoints for baremetal.
Outdated
libc/config/baremetal/riscv/entrypoints.txt
@overmighty overmighty Jul 29, 2024
```suggestion DEPENDS libc.src.math.ddivf128 ```
Outdated
libc/test/src/math/CMakeLists.txt
overmighty aaryanshukla
@overmighty overmighty Jul 29, 2024
Kind of nitpicky, but technically I think this should be in its own PR, since: > Once you have a patch ready, it is time to submit it. The patch should: > - [...] > - not contain any unrelated changes > - be an isolated change. Independent changes should be submitted as separate patches as this makes reviewing easier. https://llvm.org/docs/Contributing.html#how-to-submit-a-patch I don't know if this gets a pass for being such a small change or not. @lntue
Outdated
libc/docs/math/index.rst
overmighty lntue
aaryanshukla
@overmighty overmighty Jul 29, 2024
None of the tests directly depend on the FPUtil.generic.* stuff. Not just `daddl_test`. ```suggestion DEPENDS libc.src.math.daddf128 ) add_fp_unittest( ddivf128_test NEED_MPFR SUITE libc-math-unittests SRCS ddivf128_test.cpp HDRS DivTest.h DEPENDS libc.src.math.ddivf128 ) add_fp_unittest( ddivf128_test NEED_MPFR SUITE libc-math-unittests SRCS ddivf128_test.cpp HDRS DivTest.h DEPENDS libc.src.math.ddivf128 ```
Outdated
libc/test/src/math/CMakeLists.txt
@overmighty overmighty Jul 29, 2024
I didn't notice the missing dependency here before. ```suggestion DEPENDS libc.src.__support.macros.properties.types libc.src.__support.FPUtil.generic.div ```
Outdated
libc/src/math/generic/CMakeLists.txt
@lntue lntue Jul 25, 2024
sync your PR to head to resolve the merge conflict.
Outdated
libc/newhdrgen/yaml_to_classes.py
@lntue lntue Jul 24, 2024
`daddf128` and `ddivf128` should be under the `LIBC_TYPES_HAS_FLOAT128` guard below.
Outdated
libc/config/linux/x86_64/entrypoints.txt
@lntue lntue Jul 24, 2024
Don't enable entrypoints for baremetal yet, since we cannot test them downstream, and we don't want to revert the whole PR if downstream baremetal bots fail.
Outdated
libc/config/baremetal/arm/entrypoints.txt
@overmighty overmighty Jul 24, 2024
Very tiny nit: blank line. ```suggestion ```
Outdated
libc/src/math/generic/CMakeLists.txt
@overmighty overmighty Jul 24, 2024
`ddivl` doesn't use `float128`. ```suggestion DEPENDS libc.src.__support.FPUtil.generic.div ```
libc/src/math/generic/CMakeLists.txt
@overmighty overmighty Jul 24, 2024
`daddl` doesn't use `float128`. ```suggestion DEPENDS libc.src.__support.FPUtil.generic.add_sub ```
Outdated
libc/src/math/generic/CMakeLists.txt
@overmighty overmighty Jul 24, 2024
Existing code transitively includes .../properties/types.h from src/math/\<function\>.h, so I would do the same. ```suggestion ```
Outdated
libc/src/math/generic/ddivf128.cpp
@overmighty overmighty Jul 24, 2024
Existing code transitively includes .../properties/types.h from src/math/\<function\>.h, so I would do the same. ```suggestion ```
Outdated
libc/src/math/generic/daddf128.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Implementation header for daddl ------------------------*- C++ -*-===// ```
Outdated
libc/src/math/daddl.h
@overmighty overmighty Jul 24, 2024
There were previously no `float128` entrypoints in this file either so there might be an issue with `float128` on this target too.
Outdated
libc/config/darwin/x86_64/entrypoints.txt
@overmighty overmighty Jul 24, 2024
The unit tests themselves don't use `libc.src.__support.FPUtil.generic.add_sub`. ```suggestion DEPENDS libc.src.math.daddl ```
Outdated
libc/test/src/math/CMakeLists.txt
overmighty
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Unittests for daddl -----------------------------------------------===// ```
Outdated
libc/test/src/math/smoke/daddl_test.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Unittests for daddf128 --------------------------------------------===// ```
Outdated
libc/test/src/math/smoke/daddf128_test.cpp
@overmighty overmighty Jul 24, 2024
The smoke tests themselves don't use `libc.src.__support.FPUtil.generic.add_sub`. ```suggestion DEPENDS libc.src.math.daddl ```
Outdated
libc/test/src/math/smoke/CMakeLists.txt
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Unittests for ddivl -----------------------------------------------===// ```
Outdated
libc/test/src/math/ddivl_test.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Unittests for daddl -----------------------------------------------===// ```
Outdated
libc/test/src/math/daddl_test.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Unittests for daddf128 --------------------------------------------===// ```
Outdated
libc/test/src/math/daddf128_test.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting.
Outdated
libc/src/math/generic/ddivl.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting.
Outdated
libc/src/math/generic/ddivf128.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting.
Outdated
libc/src/math/generic/daddl.cpp
@overmighty overmighty Jul 24, 2024
Nit: formatting.
Outdated
libc/src/math/generic/daddf128.cpp
@overmighty overmighty Jul 24, 2024
Maybe `fadd` fixes should be moved to another, small PR.
Outdated
libc/src/math/generic/CMakeLists.txt
@overmighty overmighty Jul 24, 2024
Maybe `fadd` fixes should be moved to another, small PR.
Outdated
libc/src/math/fadd.h
@overmighty overmighty Jul 24, 2024
Nit: formatting.
Outdated
libc/src/math/ddivl.h
@overmighty overmighty Jul 24, 2024
We used to include libc/src/__support/macros/properties/types.h instead of including float128.h directly.
Outdated
libc/src/math/ddivf128.h
@overmighty overmighty Jul 24, 2024
Nit: formatting.
libc/src/math/ddivf128.h
@overmighty overmighty Jul 24, 2024
Nit: formatting.
Outdated
libc/src/math/daddl.h
@overmighty overmighty Jul 24, 2024
We used to include libc/src/__support/macros/properties/types.h instead of including float128.h directly.
Outdated
libc/src/math/daddf128.h
@overmighty overmighty Jul 24, 2024
Nit: formatting. ```suggestion //===-- Implementation header for daddf128 ----------------------*- C++ -*-===// ```
Outdated
libc/src/math/daddf128.h
@overmighty overmighty Jul 24, 2024
`daddf128` and `ddivf128` should be LLVM libc extensions, so they should be moved to libc/spec/llvm_libc_ext.td. C23 only defines these: ```c double daddl(long double x, long double y); _FloatM fMaddfN(_FloatN x, _FloatN y); // M < N double ddivl(long double x, long double y); _FloatM fMdivfN(_FloatN x, _FloatN y); // M < N ``` Also, `daddf128` and `ddivf128` should be guarded by `LIBC_TYPES_HAS_FLOAT128`. ```suggestion FunctionSpec<"daddl", RetValSpec<DoubleType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>, FunctionSpec<"ddivl", RetValSpec<DoubleType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>, ```
Outdated
libc/spec/stdc.td
overmighty
@overmighty overmighty Jul 24, 2024
Why does this PR make changes to newhdrgen?
Outdated
libc/newhdrgen/yaml_to_classes.py
aaryanshukla
@overmighty overmighty Jul 24, 2024
`float128` entrypoints should be moved into the `if(LIBC_TYPES_HAS_FLOAT128)` below.
Outdated
libc/config/linux/x86_64/entrypoints.txt
@overmighty overmighty Jul 24, 2024
`float128` is not supported on RISC-V.
Outdated
libc/config/linux/riscv/entrypoints.txt
overmighty
@overmighty overmighty Jul 24, 2024
`float128` is not supported on 32-bit Arm.
Outdated
libc/config/linux/arm/entrypoints.txt
overmighty
@overmighty overmighty Jul 24, 2024
`float128` entrypoints should be moved into the `if(LIBC_TYPES_HAS_FLOAT128)` below. ```suggestion libc.src.math.daddl libc.src.math.ddivl ```
Outdated
libc/config/linux/aarch64/entrypoints.txt
@overmighty overmighty Jul 24, 2024
`float128` is not supported on AMDGPU and NVPTX. clang/lib/Basic/Targets/AMDGPU.cpp technically sets `HasFloat128` to true if the host target has it, but there are comments that explain the situation: https://github.com/llvm/llvm-project/blob/10ff2bcb5eaf169b0d9f6f12851ccae339a54aaf/clang/lib/Basic/Targets/AMDGPU.cpp#L351-L375
Outdated
libc/config/gpu/entrypoints.txt
overmighty
@overmighty overmighty Jul 24, 2024
I think `arm` here is actually AArch64, as I don't think macOS ever supported 32-bit Arm, but there were no `float128` entrypoints in this file yet, so I'm not sure if there is an issue with `float128` on macOS or not.
Outdated
libc/config/darwin/arm/entrypoints.txt
@overmighty overmighty Jul 24, 2024
`float128` is not supported on RISC-V. ```suggestion libc.src.math.daddl libc.src.math.ddivl ```
Outdated
libc/config/baremetal/riscv/entrypoints.txt
@overmighty overmighty Jul 24, 2024
`float128` is not supported on 32-bit Arm. ```suggestion libc.src.math.daddl libc.src.math.ddivl ```
Outdated
libc/config/baremetal/arm/entrypoints.txt
aaryanshukla overmighty