From e5041855af20b5475b45ee9073643b434af4d52e Mon Sep 17 00:00:00 2001 From: Xiaoyang Liu Date: Thu, 19 Sep 2024 22:16:31 -0400 Subject: [PATCH 1/2] [libc++] LWG4025: Move assignment operator of 'std::expected' should not be conditionally deleted --- libcxx/include/__expected/expected.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libcxx/include/__expected/expected.h b/libcxx/include/__expected/expected.h index f4ad455a19ea5..e04e17d1ebe69 100644 --- a/libcxx/include/__expected/expected.h +++ b/libcxx/include/__expected/expected.h @@ -1493,8 +1493,6 @@ class expected<_Tp, _Err> : private __expected_void_base<_Err> { return *this; } - _LIBCPP_HIDE_FROM_ABI constexpr expected& operator=(expected&&) = delete; - _LIBCPP_HIDE_FROM_ABI constexpr expected& operator=(expected&& __rhs) noexcept(is_nothrow_move_assignable_v<_Err> && is_nothrow_move_constructible_v<_Err>) requires(is_move_assignable_v<_Err> && is_move_constructible_v<_Err>) From 8e1de55f3ad382ec4cebb953a39521b09861296d Mon Sep 17 00:00:00 2001 From: Xiaoyang Liu Date: Thu, 19 Sep 2024 22:24:42 -0400 Subject: [PATCH 2/2] [libc++] LWG4025: Move assignment operator of 'std::expected' should not be conditionally deleted --- libcxx/docs/Status/Cxx2cIssues.csv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcxx/docs/Status/Cxx2cIssues.csv b/libcxx/docs/Status/Cxx2cIssues.csv index bde203ea12f14..a62c4992020a0 100644 --- a/libcxx/docs/Status/Cxx2cIssues.csv +++ b/libcxx/docs/Status/Cxx2cIssues.csv @@ -50,7 +50,7 @@ "`LWG4013 `__","``lazy_split_view::outer-iterator::value_type`` should not provide default constructor","2024-03 (Tokyo)","","","" "`LWG4016 `__","container-insertable checks do not match what container-inserter does","2024-03 (Tokyo)","","","" "`LWG4023 `__","Preconditions of ``std::basic_streambuf::setg/setp``","2024-03 (Tokyo)","|Complete|","19.0","" -"`LWG4025 `__","Move assignment operator of ``std::expected`` should not be conditionally deleted","2024-03 (Tokyo)","","","" +"`LWG4025 `__","Move assignment operator of ``std::expected`` should not be conditionally deleted","2024-03 (Tokyo)","|Complete|","20.0","" "`LWG4030 `__","Clarify whether arithmetic expressions in ``[numeric.sat.func]`` are mathematical or C++","2024-03 (Tokyo)","|Nothing To Do|","","" "`LWG4031 `__","``bad_expected_access`` member functions should be ``noexcept``","2024-03 (Tokyo)","|Complete|","16.0","" "`LWG4035 `__","``single_view`` should provide ``empty``","2024-03 (Tokyo)","|Complete|","19.0",""