```suggestion for (; next < end; next += size) if (compar(key, next) == 0) return const_cast<cpp::byte *>(next); ```

Can we just not declare `next` as `const`? If anything, `end` should be `const` and `next` should not?

```suggestion for (; next < end; next += size) if (compar(key, next) == 0) // According to IEEE Std 1003.1-2024 we are expected to accept a const // reference to base, but return a non-const reference to the element it // contains. return const_cast<cpp::byte *>(next); ```

```suggestion constexpr size_t len = 3; int list[len] = {1, 2, 3}; ```

```suggestion int list[3] = {1, 2, 3}; size_t len = 3; ```

```suggestion constexpr size_t len = 3; int list[len] = {1, 2, 3}; ```

```suggestion constexpr size_t len = 3; int list[len] = {1, 2, 3}; ```

This could also be: ```suggestion return *reinterpret_cast<int *>(a) == *reinterpret_cast<int *>(b); ``` which I think is more straightforward for what the compare function is doing.

```suggestion #include <stddef.h> // size_t ```

Does POSIX say anything about these parameters being `nullptr`? Perhaps we should check the 4 pointer members first before attempting to dereference any of them?

```suggestion if (compar(key, next) == 0) return next; ``` https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

Usually with interfaces that accept the number of members and a size, there's a potential for `*nmemb * size` to overflow, which should be checked by the library function. We should do that here. We seem to have a `mul_overflow` helper fn in __support/memory_size.h, perhaps that should be moved to __support/math_extras.h with the others, then used here?

You'd have to declare a type for the function pointer first, then use that as an ArgSpec. If you look at how other functions that have function pointer parameters, such as bsearch or qsort, those should provide an example.

These first two parameters need to be `const void *`. If you do a full build, you can `find <build dir> -name search.h` and check that the function signature generated matches the spec.

The indentation looks off here. Can you triple check it please? One thing I highly recommend is modifying your editor to visually differentiate between tabs and spaces.