Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][XeGPU][Draft] XeGPU distribution patterns for load_nd, store_nd, and create_nd_tdesc. #119783

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

charithaintc
Copy link
Contributor

@charithaintc charithaintc commented Dec 12, 2024

This version avoid distributing the tensor_desc.

This depends on outstanding PR #119264

@charithaintc charithaintc changed the title [MLIR][XeGPU] Xegpu distribution patterns for load_nd, store_nd, and create_nd_tdesc. [MLIR][XeGPU][Draft] Xegpu distribution patterns for load_nd, store_nd, and create_nd_tdesc. Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 331f3cc94b3c66eebf5ec462a8f1ee0d7704dd26 e7ca3cd82e0e4b705fcbd2f235bf005e52630995 --extensions h,cpp -- mlir/lib/Dialect/XeGPU/Transforms/XeGPUDistribute.cpp mlir/test/lib/Dialect/XeGPU/TestXeGPUTransforms.cpp mlir/include/mlir/Dialect/XeGPU/Transforms/Transforms.h mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp mlir/tools/mlir-opt/mlir-opt.cpp
View the diff from clang-format here.
diff --git a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
index f0e67df3ee..84c0bf15c7 100644
--- a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
+++ b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
@@ -283,7 +283,8 @@ LogicalResult LoadNdOp::verify() {
 
   // if (tdescShape != valueShape)
   //   return emitOpError() << "Result shape doesn't match TensorDesc shape."
-  //                        << "The expected shape is " << makeString(tdescShape)
+  //                        << "The expected shape is " <<
+  //                        makeString(tdescShape)
   //                        << ". But the given shape is "
   //                        << makeString(valueShape) << ".\n";
   return success();

@charithaintc charithaintc changed the title [MLIR][XeGPU][Draft] Xegpu distribution patterns for load_nd, store_nd, and create_nd_tdesc. [MLIR][XeGPU][Draft] XeGPU distribution patterns for load_nd, store_nd, and create_nd_tdesc. Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants