Skip to content

[llvm-readobj] Avoid repeated hash lookups (NFC) #129657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

[llvm-readobj] Avoid repeated hash lookups (NFC) #129657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions llvm/tools/llvm-readobj/COFFDumper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,10 +645,11 @@ void COFFDumper::cacheRelocations() {
for (const SectionRef &S : Obj->sections()) {
const coff_section *Section = Obj->getCOFFSection(S);

append_range(RelocMap[Section], S.relocations());
auto &RM = RelocMap[Section];
append_range(RM, S.relocations());

// Sort relocations by address.
llvm::sort(RelocMap[Section], [](RelocationRef L, RelocationRef R) {
llvm::sort(RM, [](RelocationRef L, RelocationRef R) {
return L.getOffset() < R.getOffset();
});
}
Expand Down Expand Up @@ -1270,14 +1271,15 @@ void COFFDumper::printCodeViewSymbolSection(StringRef SectionName,
reportError(errorCodeToError(EC), Obj->getFileName());

W.printString("LinkageName", LinkageName);
if (FunctionLineTables.count(LinkageName) != 0) {
auto [It, Inserted] =
FunctionLineTables.try_emplace(LinkageName, Contents);
if (!Inserted) {
// Saw debug info for this function already?
reportError(errorCodeToError(object_error::parse_failed),
Obj->getFileName());
return;
}

FunctionLineTables[LinkageName] = Contents;
FunctionNames.push_back(LinkageName);
break;
}
Expand Down
Loading