Filter out configuration file from compile commands #131099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwk
changed the title
|
@llvm/pr-subscribers-clang Author: Konrad Kleine (kwk) ChangesThe commands to run the compilation when printed with
Full diff: https://github.com/llvm/llvm-project/pull/131099.diff 1 Files Affected:
diff --git a/clang/utils/perf-training/perf-helper.py b/clang/utils/perf-training/perf-helper.py
index 80c6356d0497c..29904aded5ab0 100644
--- a/clang/utils/perf-training/perf-helper.py
+++ b/clang/utils/perf-training/perf-helper.py
@@ -237,6 +237,7 @@ def get_cc1_command_for_args(cmd, env):
or ln.startswith("InstalledDir:")
or ln.startswith("LLVM Profile Note")
or ln.startswith(" (in-process)")
+ or ln.startswith("Configuration file:")
or " version " in ln
):
continue
|
kwk
changed the title
The commands to run the compilation when printed with `-###` contain various irrelevant lines for the perf-training. Most of them are filtered out already but when configured with `CLANG_CONFIG_FILE_SYSTEM_DIR` a new line like the following is added and needs to be filtered out: `Configuration file: /etc/clang/x86_64-redhat-linux-gnu-clang.cfg`
kwk
force-pushed
the
filter-out-configuration-line
branch
from
db5d475 to
e43271e
Compare
|
@aaupov ping |
There was a problem hiding this comment.
Pull Request Overview
This PR extends the filtering of verbosity in compile commands by excluding configuration file paths output when using CLANG_CONFIG_FILE_SYSTEM_DIR.
- Added a new filter condition to ignore lines starting with "Configuration file:"
- Updates the filtering logic in the perf-helper.py script to reduce irrelevant output
| @@ -237,6 +237,7 @@ def get_cc1_command_for_args(cmd, env): | |||
| or ln.startswith("InstalledDir:") | |||
| or ln.startswith("LLVM Profile Note") | |||
| or ln.startswith(" (in-process)") | |||
| or ln.startswith("Configuration file:") | |||
There was a problem hiding this comment.
[nitpick] Consider consolidating similar filter conditions into a configurable array or list to simplify future modifications and improve readability.
Copilot uses AI. Check for mistakes.
aaupov
approved these changes
Jun 6, 2025
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
The commands to run the compilation when printed with `-###` contain various irrelevant lines for the perf-training. Most of them are filtered out already but when configured with `CLANG_CONFIG_FILE_SYSTEM_DIR` a new line like the following is added and needs to be filtered out: `Configuration file: /etc/clang/x86_64-redhat-linux-gnu-clang.cfg`
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
The commands to run the compilation when printed with `-###` contain various irrelevant lines for the perf-training. Most of them are filtered out already but when configured with `CLANG_CONFIG_FILE_SYSTEM_DIR` a new line like the following is added and needs to be filtered out: `Configuration file: /etc/clang/x86_64-redhat-linux-gnu-clang.cfg`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands to run the compilation when printed with
-###containvarious irrelevant lines for the perf-training. Most of them are
filtered out already but when configured with
CLANG_CONFIG_FILE_SYSTEM_DIRa new line like the following isadded and needs to be filtered out:
Configuration file: /etc/clang/x86_64-redhat-linux-gnu-clang.cfg