[libc][math][c++23] Add bfloat16 support in LLVM libc - #144463
Merged
Conversation
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
…_type Signed-off-by: krishna2803 <kpandey81930@gmail.com>
…n type Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
…d headers Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
…lization for MPFRNumber Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
lntue
reviewed
Jun 17, 2025
lntue
reviewed
Jun 17, 2025
| } | ||
| } | ||
|
|
||
| constexpr bool operator==(const BFloat16 other) const { |
Contributor
There was a problem hiding this comment.
we should implement floating point equality of the same type in FPBits, and it should follow IEEE 754 rules for equality (aka not bit identical in some cases).
lntue
reviewed
Jun 17, 2025
lntue
left a comment
lntue
left a comment
Contributor
There was a problem hiding this comment.
Add unit tests to make sure the class and the MPFR utility work.
Signed-off-by: krishna2803 <kpandey81930@gmail.com>
overmighty
reviewed
Jul 8, 2025
overmighty
left a comment
overmighty
left a comment
Member
There was a problem hiding this comment.
Some last comments and then this PR should be ready to merge unless we get more requests from Tue.
Co-authored-by: OverMighty <its.overmighty@gmail.com>
Co-authored-by: OverMighty <its.overmighty@gmail.com>
Co-authored-by: OverMighty <its.overmighty@gmail.com>
Signed-off-by: Krishna Pandey <kpandey81930@gmail.com>
Signed-off-by: Krishna Pandey <kpandey81930@gmail.com>
overmighty
reviewed
Jul 8, 2025
Co-authored-by: OverMighty <its.overmighty@gmail.com>
overmighty
reviewed
Jul 8, 2025
Signed-off-by: Krishna Pandey <kpandey81930@gmail.com>
Member
|
If you just change the tests to use the |
Signed-off-by: Krishna Pandey <kpandey81930@gmail.com>
overmighty
approved these changes
Jul 9, 2025
overmighty
left a comment
overmighty
left a comment
Member
There was a problem hiding this comment.
Last nits for real this time, but LGTM otherwise.
| } | ||
| } | ||
|
|
||
| TEST_F(LlvmLibcBfloat16ToFloatTest, SpecialIntegers) { |
Member
There was a problem hiding this comment.
Nit: this only tests conversion from integer to bfloat16 so the test suite could have a more fitting name, e.g., LlvmLibcBfloat16ConversionTest, with test names ToFloatPositiveRange, ToFloatNegativeRange, and FromInteger.
Signed-off-by: Krishna Pandey <kpandey81930@gmail.com>
Co-authored-by: OverMighty <its.overmighty@gmail.com>
lntue
approved these changes
Jul 9, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/215/builds/710 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/131/builds/25780 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/179/builds/25813 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/25782 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/93/builds/25287 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/147/builds/24707 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/43/builds/25123 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/9065 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/183/builds/15780 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/188/builds/16804 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/19169 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/196/builds/9931 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/182/builds/12289 Here is the relevant piece of the build log for the reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables support for BFloat16 type in LLVM libc along with support for testing BFloat16 functions via MPFR.
cc @overmighty @lntue