Skip to content

[libc] Fix incorrect macro usage in shared/sign.h - #150140

Merged
jhuber6 merged 1 commit into
llvm:mainfrom
leandrolcampos:LibcSharedSign
Jul 23, 2025
Merged

[libc] Fix incorrect macro usage in shared/sign.h#150140
jhuber6 merged 1 commit into
llvm:mainfrom
leandrolcampos:LibcSharedSign

Conversation

@leandrolcampos

Copy link
Copy Markdown
Contributor

This patch corrects the using-declaration in libc/shared/sign.h.

The previous change (#150083) incorrectly used the LIBC_NAMESPACE_DECL macro. This is corrected to use LIBC_NAMESPACE.

@llvmbot llvmbot added the libc label Jul 22, 2025
@llvmbot

llvmbot commented Jul 22, 2025

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-libc

Author: Leandro Lacerda (leandrolcampos)

Changes

This patch corrects the using-declaration in libc/shared/sign.h.

The previous change (#150083) incorrectly used the LIBC_NAMESPACE_DECL macro. This is corrected to use LIBC_NAMESPACE.


Full diff: https://github.com/llvm/llvm-project/pull/150140.diff

1 Files Affected:

  • (modified) libc/shared/sign.h (+1-1)
diff --git a/libc/shared/sign.h b/libc/shared/sign.h
index faa8648b96439..2029b52b89441 100644
--- a/libc/shared/sign.h
+++ b/libc/shared/sign.h
@@ -15,7 +15,7 @@
 namespace LIBC_NAMESPACE_DECL {
 namespace shared {
 
-using LIBC_NAMESPACE_DECL::Sign;
+using LIBC_NAMESPACE::Sign;
 
 } // namespace shared
 } // namespace LIBC_NAMESPACE_DECL

@jhuber6
jhuber6 merged commit 8f410b4 into llvm:main Jul 23, 2025
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
This patch corrects the `using`-declaration in `libc/shared/sign.h`.

The previous change (llvm#150083) incorrectly used the `LIBC_NAMESPACE_DECL`
macro. This is corrected to use `LIBC_NAMESPACE`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants