diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp index 0b94b1044f072..b16c9989fbbb4 100644 --- a/clang/lib/Sema/AnalysisBasedWarnings.cpp +++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp @@ -467,6 +467,41 @@ struct TransferFunctions : public StmtVisitor { AllValuesAreNoReturn = false; } } + + void VisitCXXOperatorCallExpr(CXXOperatorCallExpr *CE) { + if (CE->getOperator() == OO_Call && CE->getNumArgs() > 0) { + Expr *Obj = CE->getArg(0)->IgnoreParenCasts(); + if (auto *MTE = dyn_cast(Obj)) + Obj = MTE->getSubExpr(); + if (auto *DRE = dyn_cast(Obj)) { + auto *D = dyn_cast(DRE->getDecl()); + if (D->hasInit()) + Obj = D->getInit(); + } + Visit(Obj); + } + VisitCallExpr(CE); + } + + void VisitLambdaExpr(LambdaExpr *LE) { + for (const LambdaCapture &Capture : LE->captures()) + if (Capture.capturesVariable()) + if (const VarDecl *VD = dyn_cast(Capture.getCapturedVar())) + if (VD == Var) + if (Capture.getCaptureKind() == LCK_ByRef) + AllValuesAreNoReturn = false; + } + + void VisitMaterializeTemporaryExpr(MaterializeTemporaryExpr *MTE) { + Visit(MTE->getSubExpr()); + } + + void VisitExprWithCleanups(FullExpr *FE) { Visit(FE->getSubExpr()); } + + void VisitCXXConstructExpr(CXXConstructExpr *CE) { + if (CE->getNumArgs() > 0) + Visit(CE->getArg(0)); + } }; } // namespace diff --git a/clang/test/SemaCXX/noreturn-vars.cpp b/clang/test/SemaCXX/noreturn-vars.cpp index ca65fcf5ca31d..9b23dc96d9ae0 100644 --- a/clang/test/SemaCXX/noreturn-vars.cpp +++ b/clang/test/SemaCXX/noreturn-vars.cpp @@ -225,3 +225,50 @@ extern void abc_02(func_type *); abc_02(&func_ptr); func_ptr(); } // expected-warning {{function declared 'noreturn' should not return}} + +[[noreturn]] void test_lambda_capture_ref() { + func_type func_ptr = noret; + [&func_ptr]() { func_ptr = ordinary; } (); + func_ptr(); +} // expected-warning {{function declared 'noreturn' should not return}} + +[[noreturn]] void test_lambda_var_capture_ref() { + func_type func_ptr = noret; + auto LF = [&func_ptr](){func_ptr = ordinary; }; + LF(); + func_ptr(); +} // expected-warning {{function declared 'noreturn' should not return}} + +[[noreturn]] void test_lambda_capture_ref_all() { + func_type func_ptr = noret; + [&]() { func_ptr = ordinary; } (); + func_ptr(); +} // expected-warning {{function declared 'noreturn' should not return}} + +[[noreturn]] void test_lambda_var_capture_ref_all() { + func_type func_ptr = noret; + auto LF = [&](){func_ptr = ordinary; }; + LF(); + func_ptr(); +} // expected-warning {{function declared 'noreturn' should not return}} + +[[noreturn]] void lambda_capture_by_value() { + func_type func_ptr = noret; + auto LF = [func_ptr](){ return func_ptr; }; + LF(); + func_ptr(); +} + +[[noreturn]] void lambda_pass_by_ref() { + func_type func_ptr = noret; + auto LF = [](func_type &fptr){ fptr = ordinary; }; + LF(func_ptr); + func_ptr(); +} // expected-warning {{function declared 'noreturn' should not return}} + +[[noreturn]] void lambda_pass_by_value() { + func_type func_ptr = noret; + auto LF = [](func_type fptr){ fptr = ordinary; }; + LF(func_ptr); + func_ptr(); +}