diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td index 59beac7d64154..9798015400a81 100644 --- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td +++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td @@ -1051,6 +1051,8 @@ def EmitC_MemberOp : EmitC_Op<"member"> { ```mlir %0 = "emitc.member" (%arg0) {member = "a"} : (!emitc.lvalue>) -> !emitc.lvalue + %1 = "emitc.member" (%arg0) {member = "b"} + : (!emitc.lvalue>) -> !emitc.array<2xi32> ``` }]; @@ -1058,7 +1060,7 @@ def EmitC_MemberOp : EmitC_Op<"member"> { Arg:$member, EmitC_LValueOf<[EmitC_OpaqueType]>:$operand ); - let results = (outs EmitC_LValueOf<[EmitCType]>); + let results = (outs AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType]>); } def EmitC_MemberOfPtrOp : EmitC_Op<"member_of_ptr"> { @@ -1073,6 +1075,9 @@ def EmitC_MemberOfPtrOp : EmitC_Op<"member_of_ptr"> { %0 = "emitc.member_of_ptr" (%arg0) {member = "a"} : (!emitc.lvalue>>) -> !emitc.lvalue + %1 = "emitc.member_of_ptr" (%arg0) {member = "b"} + : (!emitc.lvalue>>) + -> !emitc.array<2xi32> ``` }]; @@ -1080,7 +1085,7 @@ def EmitC_MemberOfPtrOp : EmitC_Op<"member_of_ptr"> { Arg:$member, EmitC_LValueOf<[EmitC_OpaqueType,EmitC_PointerType]>:$operand ); - let results = (outs EmitC_LValueOf<[EmitCType]>); + let results = (outs AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType]>); } def EmitC_ConditionalOp : EmitC_Op<"conditional", diff --git a/mlir/test/Dialect/EmitC/ops.mlir b/mlir/test/Dialect/EmitC/ops.mlir index acee0a8d53fe4..fec8431262f37 100644 --- a/mlir/test/Dialect/EmitC/ops.mlir +++ b/mlir/test/Dialect/EmitC/ops.mlir @@ -286,8 +286,11 @@ func.func @assign_global(%arg0 : i32) { func.func @member_access(%arg0: !emitc.lvalue>, %arg1: !emitc.lvalue>, %arg2: !emitc.lvalue>>) { %0 = "emitc.member" (%arg0) {member = "a"} : (!emitc.lvalue>) -> !emitc.lvalue - %1 = "emitc.member_of_ptr" (%arg1) {member = "a"} : (!emitc.lvalue>) -> !emitc.lvalue - %2 = "emitc.member_of_ptr" (%arg2) {member = "a"} : (!emitc.lvalue>>) -> !emitc.lvalue + %1 = "emitc.member" (%arg0) {member = "b"} : (!emitc.lvalue>) -> !emitc.array<2xi32> + %2 = "emitc.member_of_ptr" (%arg1) {member = "a"} : (!emitc.lvalue>) -> !emitc.lvalue + %3 = "emitc.member_of_ptr" (%arg1) {member = "b"} : (!emitc.lvalue>) -> !emitc.array<2xi32> + %4 = "emitc.member_of_ptr" (%arg2) {member = "a"} : (!emitc.lvalue>>) -> !emitc.lvalue + %5 = "emitc.member_of_ptr" (%arg2) {member = "b"} : (!emitc.lvalue>>) -> !emitc.array<2xi32> return } diff --git a/mlir/test/Target/Cpp/member.mlir b/mlir/test/Target/Cpp/member.mlir index 20589fe5b00b8..6e0395250afbd 100644 --- a/mlir/test/Target/Cpp/member.mlir +++ b/mlir/test/Target/Cpp/member.mlir @@ -1,6 +1,6 @@ // RUN: mlir-translate -mlir-to-cpp %s | FileCheck %s -check-prefix=CPP-DEFAULT -func.func @member(%arg0: !emitc.opaque<"mystruct">, %arg1: i32) { +func.func @member(%arg0: !emitc.opaque<"mystruct">, %arg1: i32, %arg2: index) { %var0 = "emitc.variable"() <{value = #emitc.opaque<"">}> : () -> !emitc.lvalue> emitc.assign %arg0 : !emitc.opaque<"mystruct"> to %var0 : !emitc.lvalue> @@ -12,19 +12,31 @@ func.func @member(%arg0: !emitc.opaque<"mystruct">, %arg1: i32) { %3 = "emitc.variable"() <{value = #emitc.opaque<"">}> : () -> !emitc.lvalue emitc.assign %2 : i32 to %3 : !emitc.lvalue + %4 = "emitc.member" (%var0) {member = "c"} : (!emitc.lvalue>) -> !emitc.array<2xi32> + %5 = emitc.subscript %4[%arg2] : (!emitc.array<2xi32>, index) -> !emitc.lvalue + %6 = emitc.load %5 : + emitc.assign %6 : i32 to %3 : !emitc.lvalue + + %7 = "emitc.member" (%var0) {member = "d"} : (!emitc.lvalue>) -> !emitc.array<2xi32> + %8 = emitc.subscript %7[%arg2] : (!emitc.array<2xi32>, index) -> !emitc.lvalue + emitc.assign %arg1 : i32 to %8 : !emitc.lvalue + return } -// CPP-DEFAULT: void member(mystruct [[V0:[^ ]*]], int32_t [[V1:[^ ]*]]) { +// CPP-DEFAULT: void member(mystruct [[V0:[^ ]*]], int32_t [[V1:[^ ]*]], size_t [[Index:[^ ]*]]) { // CPP-DEFAULT-NEXT: mystruct [[V2:[^ ]*]]; // CPP-DEFAULT-NEXT: [[V2]] = [[V0]]; // CPP-DEFAULT-NEXT: [[V2]].a = [[V1]]; // CPP-DEFAULT-NEXT: int32_t [[V3:[^ ]*]] = [[V2]].b; // CPP-DEFAULT-NEXT: int32_t [[V4:[^ ]*]]; // CPP-DEFAULT-NEXT: [[V4]] = [[V3]]; +// CPP-DEFAULT-NEXT: int32_t [[V5:[^ ]*]] = [[V2]].c[[[Index]]]; +// CPP-DEFAULT-NEXT: [[V4]] = [[V5]]; +// CPP-DEFAULT-NEXT: [[V2]].d[[[Index]]] = [[V1]]; -func.func @member_of_pointer(%arg0: !emitc.ptr>, %arg1: i32) { +func.func @member_of_pointer(%arg0: !emitc.ptr>, %arg1: i32, %arg2: index) { %var0 = "emitc.variable"() <{value = #emitc.opaque<"">}> : () -> !emitc.lvalue>> emitc.assign %arg0 : !emitc.ptr> to %var0 : !emitc.lvalue>> @@ -36,14 +48,25 @@ func.func @member_of_pointer(%arg0: !emitc.ptr>, %arg1 %3 = "emitc.variable"() <{value = #emitc.opaque<"">}> : () -> !emitc.lvalue emitc.assign %2 : i32 to %3 : !emitc.lvalue + %4 = "emitc.member_of_ptr" (%var0) {member = "c"} : (!emitc.lvalue>>) -> !emitc.array<2xi32> + %5 = emitc.subscript %4[%arg2] : (!emitc.array<2xi32>, index) -> !emitc.lvalue + %6 = emitc.load %5 : + emitc.assign %6 : i32 to %3 : !emitc.lvalue + + %7 = "emitc.member_of_ptr" (%var0) {member = "d"} : (!emitc.lvalue>>) -> !emitc.array<2xi32> + %8 = emitc.subscript %7[%arg2] : (!emitc.array<2xi32>, index) -> !emitc.lvalue + emitc.assign %arg1 : i32 to %8 : !emitc.lvalue + return } -// CPP-DEFAULT: void member_of_pointer(mystruct* [[V0:[^ ]*]], int32_t [[V1:[^ ]*]]) { +// CPP-DEFAULT: void member_of_pointer(mystruct* [[V0:[^ ]*]], int32_t [[V1:[^ ]*]], size_t [[Index:[^ ]*]]) { // CPP-DEFAULT-NEXT: mystruct* [[V2:[^ ]*]]; // CPP-DEFAULT-NEXT: [[V2]] = [[V0]]; // CPP-DEFAULT-NEXT: [[V2]]->a = [[V1]]; // CPP-DEFAULT-NEXT: int32_t [[V3:[^ ]*]] = [[V2]]->b; // CPP-DEFAULT-NEXT: int32_t [[V4:[^ ]*]]; // CPP-DEFAULT-NEXT: [[V4]] = [[V3]]; - +// CPP-DEFAULT-NEXT: int32_t [[V5:[^ ]*]] = [[V2]]->c[[[Index]]]; +// CPP-DEFAULT-NEXT: [[V4]] = [[V5]]; +// CPP-DEFAULT-NEXT: [[V2]]->d[[[Index]]] = [[V1]];