From 25645fa404cc2c39f6a74d303600b6ddadd81f56 Mon Sep 17 00:00:00 2001 From: Rick van Voorden Date: Thu, 4 Sep 2025 17:38:09 -0700 Subject: [PATCH 1/3] inclusive language --- bolt/lib/Passes/CMOVConversion.cpp | 2 +- bolt/lib/Passes/IndirectCallPromotion.cpp | 2 +- bolt/lib/Profile/YAMLProfileReader.cpp | 2 +- bolt/lib/Rewrite/RewriteInstance.cpp | 4 ++-- bolt/runtime/instr.cpp | 2 +- bolt/test/AArch64/hook-fini.s | 2 +- .../binary-analysis/AArch64/gs-pacret-autiasp.s | 2 +- bolt/test/runtime/AArch64/hook-fini.test | 2 +- bolt/tools/merge-fdata/merge-fdata.cpp | 2 +- .../clang-tidy/google/ExplicitMakePairCheck.cpp | 2 +- .../clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp | 2 +- .../clang-tidy/misc/NoRecursionCheck.cpp | 2 +- .../FunctionCognitiveComplexityCheck.cpp | 2 +- .../clang-tidy/readability/NamedParameterCheck.cpp | 2 +- clang-tools-extra/clangd/CodeCompletionStrings.cpp | 4 ++-- clang-tools-extra/clangd/Compiler.cpp | 2 +- clang-tools-extra/clangd/XRefs.cpp | 2 +- clang-tools-extra/clangd/index/IndexAction.cpp | 2 +- .../clangd/unittests/BackgroundIndexTests.cpp | 2 +- clang-tools-extra/clangd/unittests/ClangdTests.cpp | 2 +- clang-tools-extra/clangd/unittests/QualityTests.cpp | 2 +- clang-tools-extra/clangd/unittests/RenameTests.cpp | 2 +- .../expand-modular-headers-ppcallbacks.cpp | 2 +- clang/docs/AutomaticReferenceCounting.rst | 2 +- clang/docs/InternalsManual.rst | 2 +- clang/docs/Modules.rst | 2 +- clang/docs/UsersManual.rst | 2 +- clang/include/clang/Sema/Sema.h | 2 +- clang/lib/AST/ASTStructuralEquivalence.cpp | 4 ++-- clang/lib/AST/CommentSema.cpp | 2 +- clang/lib/AST/TypePrinter.cpp | 2 +- clang/lib/CodeGen/CGCXXABI.cpp | 2 +- clang/lib/CodeGen/CGCall.cpp | 4 ++-- clang/lib/CodeGen/CGExpr.cpp | 2 +- clang/lib/CodeGen/CGStmt.cpp | 2 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Frontend/PrintPreprocessedOutput.cpp | 4 ++-- clang/lib/Index/USRGeneration.cpp | 2 +- clang/lib/Parse/ParseStmtAsm.cpp | 4 ++-- clang/lib/Sema/SemaOpenACC.cpp | 2 +- clang/lib/Sema/SemaOverload.cpp | 4 ++-- clang/lib/Sema/SemaTemplateDeduction.cpp | 2 +- .../StaticAnalyzer/Checkers/ArrayBoundChecker.cpp | 2 +- .../StaticAnalyzer/Checkers/PthreadLockChecker.cpp | 2 +- clang/test/AST/ByteCode/cxx11.cpp | 2 +- clang/test/Analysis/return-value-guaranteed.cpp | 2 +- clang/test/Analysis/std-variant-checker.cpp | 2 +- clang/test/CodeGen/AArch64/inline-asm.c | 2 +- clang/test/CodeGen/alloc-align-attr.c | 2 +- clang/test/CodeGen/arm-target-features.c | 2 +- clang/test/CodeGen/atomic-ops.c | 2 +- .../test/CodeGen/strictfp-elementwise-builtins.cpp | 2 +- clang/test/CodeGen/union-init2.c | 2 +- .../simple-vtable-definition.cpp | 2 +- .../test/CodeGenCXX/cxx11-user-defined-literal.cpp | 2 +- clang/test/CodeGenCXX/type-aware-allocators.cpp | 2 +- clang/test/CodeGenHLSL/GlobalDestructors.hlsl | 2 +- clang/test/CodeGenHLSL/RootSignature.hlsl | 2 +- clang/test/Driver/aix-as.c | 2 +- clang/test/Driver/aix-ld.c | 2 +- clang/test/Driver/as-dwarf-cie.s | 2 +- clang/test/Driver/fopenmp.c | 2 +- clang/test/Driver/linux-header-search.cpp | 2 +- clang/test/Driver/linux-ld.c | 2 +- clang/test/Driver/solaris-ld-values.c | 2 +- clang/test/Driver/solaris-ld-values.cpp | 2 +- clang/test/Driver/solaris-ld.c | 2 +- clang/test/PCH/floating-literal.c | 2 +- clang/test/SemaCXX/constant-expression-cxx11.cpp | 2 +- clang/test/SemaCXX/constant-expression-cxx14.cpp | 2 +- clang/test/SemaCXX/enable_if.cpp | 2 +- .../overload-resolution-deferred-templates.cpp | 2 +- .../vtable_pointer_authentication_attribute.cpp | 4 ++-- clang/test/SemaTemplate/canonical-expr-type.cpp | 2 +- .../utils/update_cc_test_checks/check-globals.test | 2 +- .../global-hex-value-regex.test | 2 +- .../update_cc_test_checks/global-value-regex.test | 2 +- clang/unittests/Analysis/CFGTest.cpp | 2 +- clang/unittests/Basic/SourceManagerTest.cpp | 2 +- clang/utils/TableGen/ClangAttrEmitter.cpp | 2 +- cmake/Modules/EnableLanguageNolink.cmake | 4 ++-- .../cmake/Modules/CompilerRTDarwinUtils.cmake | 2 +- compiler-rt/cmake/Modules/CompilerRTUtils.cmake | 2 +- compiler-rt/lib/asan/asan_internal.h | 2 +- compiler-rt/lib/asan/asan_poisoning.cpp | 6 +++--- compiler-rt/lib/asan/asan_stats.cpp | 4 ++-- compiler-rt/lib/builtins/negdi2.c | 2 +- compiler-rt/lib/builtins/negti2.c | 2 +- compiler-rt/lib/fuzzer/tests/FuzzerUnittest.cpp | 2 +- compiler-rt/lib/hwasan/hwasan_linux.cpp | 2 +- compiler-rt/lib/memprof/memprof_stats.cpp | 4 ++-- .../sanitizer_common_interceptors_ioctl.inc | 8 ++++---- .../lib/sanitizer_common/sanitizer_flag_parser.cpp | 2 +- .../sanitizer_interceptors_ioctl_netbsd.inc | 8 ++++---- compiler-rt/lib/sanitizer_common/sanitizer_libc.cpp | 2 +- .../lib/sanitizer_common/sanitizer_linux.cpp | 2 +- compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp | 2 +- .../sanitizer_common/sanitizer_posix_libcdep.cpp | 2 +- .../lib/sanitizer_common/sanitizer_stacktrace.cpp | 4 ++-- .../sanitizer_common/sanitizer_stacktrace_sparc.cpp | 4 ++-- compiler-rt/lib/sanitizer_common/sanitizer_win.cpp | 2 +- .../tests/sanitizer_procmaps_test.cpp | 2 +- compiler-rt/lib/scudo/standalone/report.h | 2 +- compiler-rt/lib/tsan/rtl/CMakeLists.txt | 2 +- compiler-rt/lib/tsan/rtl/tsan_rtl.cpp | 6 +++--- compiler-rt/lib/tsan/rtl/tsan_rtl_access.cpp | 2 +- compiler-rt/lib/ubsan/ubsan_type_hash.h | 2 +- compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp | 2 +- compiler-rt/lib/xray/tests/CMakeLists.txt | 2 +- compiler-rt/test/BlocksRuntime/byrefsanity.c | 2 +- compiler-rt/test/asan/TestCases/Linux/syscalls.cpp | 2 +- .../TestCases/Posix/unpoison-alternate-stack.cpp | 2 +- .../test/asan/TestCases/sanity_check_pure_c.c | 4 ++-- compiler-rt/test/builtins/Unit/atomic_test.c | 2 +- compiler-rt/test/builtins/Unit/lit.cfg.py | 2 +- compiler-rt/test/fuzzer/fuzzer-custommutator.test | 2 +- compiler-rt/test/fuzzer/reload.test | 2 +- .../test/hwasan/TestCases/Linux/syscalls.cpp | 2 +- .../test/hwasan/TestCases/sanitizer_malloc.cpp | 2 +- compiler-rt/test/msan/Linux/syscalls.cpp | 2 +- compiler-rt/test/safestack/canary.c | 2 +- compiler-rt/utils/generate_netbsd_ioctls.awk | 6 +++--- compiler-rt/utils/generate_netbsd_syscalls.awk | 2 +- flang-rt/unittests/Runtime/CharacterTest.cpp | 2 +- flang-rt/unittests/Runtime/ExternalIOTest.cpp | 2 +- flang/lib/Decimal/decimal-to-binary.cpp | 2 +- flang/lib/Evaluate/fold-character.cpp | 2 +- flang/lib/Evaluate/formatting.cpp | 2 +- flang/lib/Evaluate/integer.cpp | 2 +- flang/lib/Frontend/CompilerInstance.cpp | 2 +- flang/lib/Lower/Bridge.cpp | 2 +- flang/lib/Lower/ConvertVariable.cpp | 2 +- flang/lib/Optimizer/Builder/FIRBuilder.cpp | 2 +- flang/lib/Parser/preprocessor.cpp | 2 +- flang/test/Driver/fopenmp.f90 | 2 +- flang/test/Fir/convert-to-llvm.fir | 2 +- flang/test/Semantics/modfile55.cuf | 2 +- flang/test/Semantics/resolve59.f90 | 2 +- flang/test/Semantics/symbol19.f90 | 2 +- flang/unittests/Frontend/CompilerInstanceTest.cpp | 2 +- libcxx/docs/DesignDocs/FileTimeType.rst | 4 ++-- libcxx/docs/Status/Cxx20Papers.csv | 2 +- libcxx/include/__cxx03/__hash_table | 2 +- libcxx/include/__cxx03/__tree | 2 +- libcxx/include/__hash_table | 2 +- libcxx/include/__tree | 2 +- libcxx/test/libcxx-03/numerics/bit.ops.pass.cpp | 2 +- .../mdspan/extents/assert.ctor_from_span.pass.cpp | 2 +- .../mdspan/layout_stride/assert.conversion.pass.cpp | 2 +- .../views/mdspan/mdspan/assert.size.pass.cpp | 2 +- .../sequence_container_iterators.pass.cpp | 2 +- .../filesystems/convert_file_time.pass.cpp | 2 +- libcxx/test/libcxx/numerics/bit.ops.pass.cpp | 2 +- .../atomics.lockfree/is_always_lock_free.pass.cpp | 2 +- .../atomics.ref/is_always_lock_free.pass.cpp | 2 +- .../concept.convertible/convertible_to.pass.cpp | 2 +- .../concept.swappable/swappable.pass.cpp | 2 +- .../ctor_iter_constraint.compile.pass.cpp | 2 +- .../std/containers/sequences/array/empty.pass.cpp | 2 +- .../containers/sequences/array/max_size.pass.cpp | 2 +- .../views/mdspan/extents/conversion.pass.cpp | 6 +++--- .../views/mdspan/layout_left/comparison.pass.cpp | 2 +- .../mdspan/layout_left/ctor.layout_right.pass.cpp | 4 ++-- .../views/mdspan/layout_left/ctor.mapping.pass.cpp | 6 +++--- .../views/mdspan/layout_right/comparison.pass.cpp | 2 +- .../mdspan/layout_right/ctor.layout_left.pass.cpp | 4 ++-- .../views/mdspan/layout_right/ctor.mapping.pass.cpp | 6 +++--- .../views/mdspan/layout_stride/comparison.pass.cpp | 2 +- .../layout_stride/ctor.strided_mapping.pass.cpp | 6 +++--- .../views/mdspan/mdspan/ctor.dh_array.pass.cpp | 6 +++--- .../views/mdspan/mdspan/ctor.dh_extents.pass.cpp | 6 +++--- .../views/mdspan/mdspan/ctor.dh_integers.pass.cpp | 8 ++++---- .../views/mdspan/mdspan/ctor.dh_map.pass.cpp | 2 +- .../views/mdspan/mdspan/ctor.dh_map_acc.pass.cpp | 2 +- .../views/mdspan/mdspan/ctor.dh_span.pass.cpp | 6 +++--- .../containers/views/mdspan/mdspan/types.pass.cpp | 2 +- .../fs.op.funcs/fs.op.space/space.pass.cpp | 2 +- .../str.allocator_propagation.pass.cpp | 2 +- .../str.allocator_propagation.pass.cpp | 2 +- .../str.allocator_propagation.pass.cpp | 2 +- .../cmp.alg/compare_strong_order_fallback.pass.cpp | 2 +- .../cmp.alg/compare_weak_order_fallback.pass.cpp | 2 +- .../cmp/cmp.alg/strong_order.pass.cpp | 2 +- .../cmp/cmp.alg/weak_order.pass.cpp | 2 +- .../utf_sanity_check.pass.cpp | 2 +- libcxx/test/std/numerics/c.math/hermite.pass.cpp | 2 +- .../exclusive.scan/exclusive_scan.pass.cpp | 2 +- .../inclusive.scan/inclusive_scan.pass.cpp | 2 +- .../inclusive.scan/inclusive_scan_op.pass.cpp | 2 +- .../inclusive.scan/inclusive_scan_op_init.pass.cpp | 2 +- .../numeric.ops.midpoint/midpoint.float.pass.cpp | 4 ++-- .../transform_exclusive_scan_init_bop_uop.pass.cpp | 2 +- .../transform_inclusive_scan_bop_uop.pass.cpp | 2 +- .../transform_inclusive_scan_bop_uop_init.pass.cpp | 2 +- .../string.view.capacity/capacity.pass.cpp | 2 +- .../thread.lock.shared.cons/mutex.pass.cpp | 2 +- .../thread.lock.shared.locking/lock.pass.cpp | 2 +- .../thread.lock.shared.locking/try_lock.pass.cpp | 2 +- .../is_always_equal.pass.cpp | 2 +- .../meta.const.eval/is_constant_evaluated.pass.cpp | 2 +- libcxx/test/support/filesystem_test_helper.h | 2 +- libcxx/test/support/test_comparisons.h | 2 +- libcxxabi/src/stdlib_new_delete.cpp | 2 +- libcxxabi/test/guard_threaded_test.pass.cpp | 2 +- lld/ELF/InputSection.cpp | 2 +- lld/ELF/ScriptParser.cpp | 2 +- lld/include/lld/Common/ErrorHandler.h | 2 +- lld/test/COFF/guard-warnings.s | 2 +- lld/test/ELF/gc-sections-no-undef-error.s | 2 +- lld/test/ELF/lto/save-temps-eq.ll | 2 +- lld/test/MachO/eh-frame-personality-dedup.s | 2 +- lld/test/MachO/icf-only-lsda-folded.s | 2 +- lldb/examples/summaries/cocoa/objc_runtime.py | 8 ++++---- lldb/packages/Python/lldbsuite/test/dotest.py | 2 +- lldb/source/API/SBCommandInterpreter.cpp | 4 ++-- lldb/source/Commands/CommandCompletions.cpp | 2 +- lldb/source/Commands/CommandObjectWatchpoint.cpp | 4 ++-- .../Commands/CommandObjectWatchpointCommand.cpp | 2 +- lldb/source/Core/SourceManager.cpp | 2 +- lldb/source/Expression/FunctionCaller.cpp | 2 +- lldb/source/Expression/REPL.cpp | 2 +- lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp | 2 +- lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp | 2 +- lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp | 2 +- lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp | 2 +- .../MacOSX-DYLD/DynamicLoaderMacOS.cpp | 2 +- .../MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp | 2 +- .../Clang/CppModuleConfiguration.cpp | 2 +- .../Process/FreeBSD/NativeProcessFreeBSD.cpp | 2 +- .../Plugins/Process/Linux/NativeProcessLinux.cpp | 2 +- .../Plugins/Process/NetBSD/NativeProcessNetBSD.cpp | 2 +- .../Plugins/Process/elf-core/ProcessElfCore.cpp | 2 +- .../Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | 4 ++-- .../SymbolFile/DWARF/DWARFASTParserClang.cpp | 4 ++-- .../Trace/intel-pt/TraceIntelPTBundleLoader.cpp | 2 +- .../Plugins/TypeSystem/Clang/TypeSystemClang.cpp | 2 +- .../UnwindAssembly/x86/UnwindAssembly-x86.cpp | 4 ++-- lldb/source/Symbol/Symbol.cpp | 4 ++-- lldb/source/Target/RegisterContextUnwind.cpp | 2 +- lldb/source/Target/ThreadPlanStepInRange.cpp | 2 +- lldb/source/Target/ThreadPlanStepOverRange.cpp | 4 ++-- lldb/source/Utility/ZipFile.cpp | 6 +++--- .../TestPublicAPIHeaders.py | 2 +- .../frame/recognizer/TestFrameRecognizer.py | 2 +- .../test/API/commands/memory/read/TestMemoryRead.py | 2 +- .../TestDataFormatterLibcxxInvalidString.py | 2 +- .../data-formatter/stringprinter/main.cpp | 2 +- .../limit-debug-info/TestLimitDebugInfo.py | 4 ++-- .../process_crash_info/TestProcessCrashInfo.py | 2 +- lldb/test/API/lang/c/array_types/TestArrayTypes.py | 10 +++++----- .../API/lang/cpp/dynamic-value/TestDynamicValue.py | 2 +- .../members/TestCppIncompleteTypeMembers.py | 2 +- .../no-nlist-memory-module/TestNoNlistsDylib.py | 2 +- .../API/macosx/simulator/TestSimulatorPlatform.py | 2 +- .../value/linked_list/TestValueAPILinkedList.py | 4 ++-- lldb/test/API/sanity/TestModuleCacheSanity.py | 2 +- lldb/test/API/sanity/TestReprStrEquality.py | 2 +- lldb/test/API/sanity/TestSettingSkipping.py | 2 +- .../memory-tagging/TestGdbRemoteMemoryTagging.py | 4 ++-- lldb/test/Shell/REPL/Basic.test | 2 +- lldb/test/Shell/Settings/TestModuleCacheSanity.test | 2 +- .../source/MacOSX/arm64/DNBArchImplARM64.cpp | 2 +- .../lldb-rpc-gen/server/RPCServerSourceEmitter.cpp | 2 +- lldb/unittests/Interpreter/TestCompletion.cpp | 2 +- llvm/CMakeLists.txt | 2 +- llvm/cmake/platforms/WinMsvc.cmake | 2 +- llvm/docs/Atomics.rst | 2 +- llvm/docs/CMake.rst | 2 +- llvm/docs/CodingStandards.rst | 2 +- llvm/docs/Contributing.rst | 2 +- llvm/docs/Frontend/PerformanceTips.rst | 2 +- llvm/docs/GettingStarted.rst | 2 +- llvm/docs/LibFuzzer.rst | 2 +- llvm/include/llvm-c/Core.h | 2 +- llvm/include/llvm/ADT/APSInt.h | 2 +- llvm/include/llvm/ADT/IntervalMap.h | 4 ++-- llvm/include/llvm/CodeGen/MachineRegisterInfo.h | 2 +- llvm/include/llvm/CodeGen/SelectionDAG.h | 2 +- llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h | 2 +- llvm/include/llvm/IR/IntrinsicsARM.td | 2 +- llvm/include/llvm/ProfileData/MemProfReader.h | 6 +++--- llvm/include/llvm/Support/CommandLine.h | 2 +- llvm/lib/Analysis/MemoryDependenceAnalysis.cpp | 2 +- llvm/lib/Analysis/MemorySSA.cpp | 2 +- llvm/lib/Analysis/ScalarEvolution.cpp | 2 +- llvm/lib/Analysis/TargetLibraryInfo.cpp | 4 ++-- llvm/lib/CodeGen/CodeGenPrepare.cpp | 2 +- llvm/lib/CodeGen/ImplicitNullChecks.cpp | 4 ++-- llvm/lib/CodeGen/MIRParser/MIRParser.cpp | 4 ++-- llvm/lib/CodeGen/MachineLoopInfo.cpp | 2 +- llvm/lib/CodeGen/MachineVerifier.cpp | 2 +- llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp | 2 +- llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp | 4 ++-- .../CodeGen/SelectionDAG/SelectionDAGPrinter.cpp | 2 +- .../LogicalView/Readers/LVCodeViewReader.cpp | 2 +- llvm/lib/ExecutionEngine/Orc/Core.cpp | 2 +- llvm/lib/FuzzMutate/Operations.cpp | 2 +- llvm/lib/MC/MCWin64EH.cpp | 2 +- llvm/lib/ProfileData/MemProfReader.cpp | 4 ++-- llvm/lib/ProfileData/MemProfSummary.cpp | 3 ++- .../Target/AArch64/AArch64Arm64ECCallLowering.cpp | 2 +- llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | 2 +- .../Target/AArch64/AsmParser/AArch64AsmParser.cpp | 2 +- llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp | 2 +- .../lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | 2 +- llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp | 13 +++++++------ llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp | 2 +- llvm/lib/Target/ARM/ARMISelLowering.cpp | 2 +- llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 2 +- llvm/lib/Target/AVR/AVRISelLowering.cpp | 2 +- llvm/lib/Target/README.txt | 2 +- llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp | 2 +- llvm/lib/Target/Sparc/SparcISelDAGToDAG.cpp | 2 +- llvm/lib/Target/X86/X86OptimizeLEAs.cpp | 2 +- llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp | 6 +++--- llvm/lib/TargetParser/Triple.cpp | 2 +- .../Transforms/IPO/MemProfContextDisambiguation.cpp | 12 ++++++------ .../Transforms/InstCombine/InstCombineVectorOps.cpp | 2 +- llvm/lib/Transforms/Scalar/LoopFlatten.cpp | 2 +- llvm/lib/Transforms/Scalar/LoopPredication.cpp | 2 +- llvm/lib/Transforms/Scalar/NewGVN.cpp | 2 +- llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp | 2 +- .../Transforms/Utils/ScalarEvolutionExpander.cpp | 2 +- llvm/test/Analysis/BlockFrequencyInfo/precision.ll | 2 +- llvm/test/Analysis/MemorySSA/function-mem-attrs.ll | 2 +- llvm/test/Analysis/MemorySSA/multi-edges.ll | 2 +- llvm/test/CodeGen/AArch64/arm64-promote-const.ll | 4 ++-- llvm/test/CodeGen/AArch64/arm64-simplest-elf.ll | 2 +- .../CodeGen/AArch64/global-merge-group-by-use.ll | 4 ++-- llvm/test/CodeGen/AArch64/landingpad-ifcvt.ll | 2 +- llvm/test/CodeGen/AArch64/local_vars.ll | 2 +- llvm/test/CodeGen/AArch64/wineh-try-catch-cbz.ll | 2 +- llvm/test/CodeGen/AArch64/wineh-try-catch-vla.ll | 2 +- .../CodeGen/AMDGPU/buffer-fat-pointers-memcpy.ll | 2 +- llvm/test/CodeGen/ARM/vext.ll | 2 +- llvm/test/CodeGen/Hexagon/PR33749.ll | 2 +- llvm/test/CodeGen/Hexagon/bit-bitsplit-src.ll | 2 +- llvm/test/CodeGen/Hexagon/bit-has.ll | 2 +- llvm/test/CodeGen/Hexagon/cfgopt-fall-through.ll | 2 +- llvm/test/CodeGen/Hexagon/copy-to-combine-dbg.ll | 2 +- llvm/test/CodeGen/Hexagon/hexagon-tfr-add.ll | 2 +- .../CodeGen/Hexagon/loop-idiom/pmpy-long-loop.ll | 2 +- .../Hexagon/loop-idiom/pmpy-shiftconv-fail.ll | 2 +- llvm/test/CodeGen/Hexagon/rdf-cover-use.ll | 2 +- llvm/test/CodeGen/Hexagon/rdf-def-mask.ll | 2 +- llvm/test/CodeGen/Hexagon/regalloc-block-overlap.ll | 2 +- llvm/test/CodeGen/M68k/Arith/mul64.ll | 2 +- llvm/test/CodeGen/MLRegAlloc/interactive-mode.ll | 2 +- llvm/test/CodeGen/RISCV/rvv/zve32-types.ll | 3 ++- .../CodeGen/X86/2011-11-07-LegalizeBuildVector.ll | 2 +- llvm/test/CodeGen/X86/frame-base.ll | 2 +- llvm/test/CodeGen/X86/hipe-cc.ll | 2 +- llvm/test/CodeGen/X86/hipe-cc64.ll | 2 +- llvm/test/CodeGen/X86/misched-balance.ll | 2 +- llvm/test/CodeGen/X86/pr23246.ll | 2 +- llvm/test/CodeGen/X86/splat-const.ll | 2 +- llvm/test/CodeGen/X86/x32-va_start.ll | 2 +- llvm/test/DebugInfo/AArch64/eh_frame_personality.ll | 2 +- .../DebugInfo/Generic/dbg-value-lower-linenos.ll | 2 +- .../DebugInfo/X86/debug-line-in-one-fragment.ll | 2 +- llvm/test/FileCheck/opt-color.txt | 2 +- llvm/test/MC/AArch64/basic-a64-instructions.s | 4 ++-- llvm/test/Transforms/Coroutines/coro-debug.ll | 2 +- .../GlobalOpt/localize-constexpr-debuginfo.ll | 2 +- .../Transforms/InferAddressSpaces/AMDGPU/select.ll | 2 +- llvm/test/Transforms/InstCombine/allocsize-32.ll | 2 +- llvm/test/Transforms/JumpThreading/crash.ll | 2 +- .../Transforms/LoopStrengthReduce/X86/bin_power.ll | 2 +- .../tools/dsymutil/ARM/dwarf5-addrx-0x0-last.test | 2 +- .../tools/dsymutil/X86/basic-linking-bundle.test | 4 ++-- .../tools/dsymutil/X86/remarks-linking-archive.text | 4 ++-- .../tools/dsymutil/X86/remarks-linking-bundle.test | 4 ++-- .../dsymutil/X86/remarks-linking-fat-bundle.test | 4 ++-- .../llvm-dwarfdump/X86/stats-inlining-single-cu.ll | 2 +- llvm/tools/dsymutil/dsymutil.cpp | 2 +- llvm/tools/lli/lli.cpp | 2 +- llvm/tools/llvm-exegesis/lib/SnippetGenerator.h | 2 +- llvm/tools/llvm-profgen/PerfReader.cpp | 2 +- llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp | 2 +- llvm/tools/llvm-readobj/COFFDumper.cpp | 2 +- llvm/tools/llvm-readobj/ELFDumper.cpp | 2 +- llvm/unittests/ADT/APFloatTest.cpp | 4 ++-- .../DebugInfo/CodeView/TypeHashingTest.cpp | 2 +- .../DebugInfo/DWARF/DWARFFormValueTest.cpp | 2 +- llvm/unittests/FuzzMutate/OperationsTest.cpp | 2 +- llvm/unittests/IR/MetadataTest.cpp | 2 +- llvm/unittests/ProfileData/InstrProfTest.cpp | 6 +++--- llvm/unittests/Support/raw_ostream_test.cpp | 2 +- llvm/unittests/Support/xxhashTest.cpp | 2 +- .../Transforms/Utils/FunctionComparatorTest.cpp | 2 +- llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp | 11 ++++++----- llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp | 2 +- llvm/utils/abtest.py | 4 ++-- llvm/utils/bugpoint/RemoteRunSafely.sh | 2 +- llvm/utils/lit/tests/usage.py | 2 +- mlir/examples/toy/Ch1/include/toy/Parser.h | 2 +- mlir/examples/toy/Ch2/include/toy/Parser.h | 2 +- mlir/examples/toy/Ch3/include/toy/Parser.h | 2 +- mlir/examples/toy/Ch4/include/toy/Parser.h | 2 +- mlir/examples/toy/Ch5/include/toy/Parser.h | 2 +- mlir/examples/toy/Ch6/include/toy/Parser.h | 2 +- mlir/examples/toy/Ch7/include/toy/Parser.h | 2 +- .../mlir/Dialect/SparseTensor/IR/SparseTensorOps.td | 4 ++-- mlir/include/mlir/IR/Builders.h | 2 +- mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp | 4 ++-- mlir/lib/Dialect/Affine/Analysis/Utils.cpp | 2 +- .../Dialect/Affine/Transforms/SuperVectorize.cpp | 2 +- .../Dialect/GPU/TransformOps/GPUTransformOps.cpp | 2 +- mlir/lib/Dialect/LLVMIR/IR/LLVMMemorySlot.cpp | 2 +- .../Linalg/TransformOps/LinalgTransformOps.cpp | 2 +- .../Linalg/Transforms/ElementwiseOpFusion.cpp | 6 +++--- mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp | 4 ++-- .../lib/Dialect/Linalg/Transforms/Vectorization.cpp | 2 +- mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp | 2 +- mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp | 2 +- mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp | 2 +- .../Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp | 4 ++-- mlir/test/CAPI/ir.c | 2 +- .../Dialect/Affine/memref-dependence-check.mlir | 2 +- .../Dialect/GPU/value-bounds-op-interface-impl.mlir | 2 +- .../CPU/microbench-linalg-async-parallel-for.mlir | 2 +- .../CPU/microbench-scf-async-parallel-for.mlir | 2 +- .../Dialect/SparseTensor/CPU/sparse_matmul.mlir | 2 +- .../Dialect/SparseTensor/CPU/sparse_tensor_ops.mlir | 2 +- .../GPU/CUDA/sm80-lt/sparse-matmul-2-4-hand.mlir | 4 ++-- .../GPU/CUDA/sm80-lt/sparse-matmul-2-4-lib.mlir | 4 ++-- .../SparseTensor/GPU/CUDA/sparse-matmul-lib.mlir | 2 +- .../SparseTensor/GPU/CUDA/sparse-matvec-const.mlir | 2 +- .../SparseTensor/GPU/CUDA/sparse-matvec-lib.mlir | 2 +- .../SparseTensor/GPU/CUDA/sparse-matvec.mlir | 2 +- .../SparseTensor/GPU/CUDA/sparse-mma-2-4-f16.mlir | 4 ++-- .../Dialect/SparseTensor/python/test_SDDMM.py | 2 +- .../Dialect/SparseTensor/python/test_SpMM.py | 2 +- .../X86Vector/math-polynomial-approx-avx2.mlir | 2 +- mlir/test/python/ir/context_lifecycle.py | 2 +- mlir/unittests/Analysis/Presburger/SimplexTest.cpp | 2 +- offload/test/offloading/disable_default_device.c | 2 +- offload/test/offloading/runtime_init.c | 2 +- openmp/runtime/src/kmp_debugger.cpp | 2 +- openmp/runtime/src/kmp_dispatch.cpp | 2 +- openmp/runtime/src/kmp_omp.h | 2 +- .../omptest/test/unittests/asserter-seq-test.cpp | 2 +- polly/lib/External/isl/isl_scheduler.c | 2 +- 443 files changed, 557 insertions(+), 553 deletions(-) diff --git a/bolt/lib/Passes/CMOVConversion.cpp b/bolt/lib/Passes/CMOVConversion.cpp index cdd99b55207e0..10372416a9acd 100644 --- a/bolt/lib/Passes/CMOVConversion.cpp +++ b/bolt/lib/Passes/CMOVConversion.cpp @@ -66,7 +66,7 @@ bool isIfThenSubgraph(const BinaryBasicBlock &LHS, if (LHS.pred_size() != 2 || RHS.pred_size() != 1) return false; - // Sanity check + // Soundness check BinaryBasicBlock *Predecessor = *RHS.pred_begin(); assert(Predecessor && LHS.isPredecessor(Predecessor) && "invalid subgraph"); (void)Predecessor; diff --git a/bolt/lib/Passes/IndirectCallPromotion.cpp b/bolt/lib/Passes/IndirectCallPromotion.cpp index 8a01cb974c5da..dff1989c016b5 100644 --- a/bolt/lib/Passes/IndirectCallPromotion.cpp +++ b/bolt/lib/Passes/IndirectCallPromotion.cpp @@ -597,7 +597,7 @@ IndirectCallPromotion::findCallTargetSymbols(std::vector &Targets, std::vector({JTIndex}).swap(NewTargets.back().JTIndices); llvm::erase(Target.JTIndices, JTIndex); - // Keep fixCFG counts sane if more indices use this same target later + // Keep fixCFG counts sound if more indices use this same target later assert(IndicesPerTarget[Target.To.Sym] > 0 && "wrong map"); NewTargets.back().Branches = Target.Branches / IndicesPerTarget[Target.To.Sym]; diff --git a/bolt/lib/Profile/YAMLProfileReader.cpp b/bolt/lib/Profile/YAMLProfileReader.cpp index 086e47b661e10..62190397b2be3 100644 --- a/bolt/lib/Profile/YAMLProfileReader.cpp +++ b/bolt/lib/Profile/YAMLProfileReader.cpp @@ -385,7 +385,7 @@ Error YAMLProfileReader::preprocessProfile(BinaryContext &BC) { return errorCodeToError(YamlInput.error()); } - // Sanity check. + // Soundness check. if (YamlBP.Header.Version != 1) return make_error( Twine("cannot read profile : unsupported version"), diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp index a6e4dbc9c192f..871453b0ec5db 100644 --- a/bolt/lib/Rewrite/RewriteInstance.cpp +++ b/bolt/lib/Rewrite/RewriteInstance.cpp @@ -637,7 +637,7 @@ Error RewriteInstance::discoverStorage() { // If user specified a custom address where we should start writing new // data, honor that. NextAvailableAddress = opts::CustomAllocationVMA; - // Sanity check the user-supplied address and emit warnings if something + // Soundness check the user-supplied address and emit warnings if something // seems off. for (const ELF64LE::Phdr &Phdr : PHs) { switch (Phdr.p_type) { @@ -2985,7 +2985,7 @@ void RewriteInstance::handleRelocation(const SectionRef &RelocatedSection, } if (BinaryData *BD = BC->getBinaryDataContainingAddress(SymbolAddress)) { - // Note: this assertion is trying to check sanity of BinaryData objects + // Note: this assertion is trying to check soundness of BinaryData objects // but AArch64 and RISCV has inferred and incomplete object locations // coming from GOT/TLS or any other non-trivial relocation (that requires // creation of sections and whose symbol address is not really what should diff --git a/bolt/runtime/instr.cpp b/bolt/runtime/instr.cpp index 1f54a500dbf98..97b49327ac484 100644 --- a/bolt/runtime/instr.cpp +++ b/bolt/runtime/instr.cpp @@ -819,7 +819,7 @@ ProfileWriterContext readDescriptions() { #endif #if !defined(__APPLE__) -/// Debug by printing overall metadata global numbers to check it is sane +/// Debug by printing overall metadata global numbers to check it is sound void printStats(const ProfileWriterContext &Ctx) { char StatMsg[BufSize]; char *StatPtr = StatMsg; diff --git a/bolt/test/AArch64/hook-fini.s b/bolt/test/AArch64/hook-fini.s index 4f321d463ef32..4051546724748 100644 --- a/bolt/test/AArch64/hook-fini.s +++ b/bolt/test/AArch64/hook-fini.s @@ -4,7 +4,7 @@ ## dynamic). ## All tests perform the following steps: ## - Compile and link for the case to be tested -## - Some sanity-checks on the dynamic section and relocations in the binary to +## - Some soundness-checks on the dynamic section and relocations in the binary to ## verify it has the shape we want for testing: ## - DT_FINI or DT_FINI_ARRAY in dynamic section ## - No relative relocations for non-PIE diff --git a/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s b/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s index 8e991fade2c86..c0a69a75b0d1b 100644 --- a/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s +++ b/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s @@ -272,7 +272,7 @@ lr_clobbered_nocfg: ret .size lr_clobbered_nocfg, .-lr_clobbered_nocfg -/// Now do a basic sanity check on every different Authentication instruction: +/// Now do a basic soundness check on every different Authentication instruction: .globl f_autiasp .type f_autiasp,@function diff --git a/bolt/test/runtime/AArch64/hook-fini.test b/bolt/test/runtime/AArch64/hook-fini.test index 8d23b21b6d612..43cc832e429ed 100644 --- a/bolt/test/runtime/AArch64/hook-fini.test +++ b/bolt/test/runtime/AArch64/hook-fini.test @@ -4,7 +4,7 @@ # dynamic). # All tests perform the following steps: # - Compile and link for the case to be tested -# - Some sanity-checks on the dynamic section and relocations in the binary to +# - Some soundness-checks on the dynamic section and relocations in the binary to # verify it has the shape we want for testing: # - DT_FINI or DT_FINI_ARRAY in dynamic section # - No relative relocations for non-PIE diff --git a/bolt/tools/merge-fdata/merge-fdata.cpp b/bolt/tools/merge-fdata/merge-fdata.cpp index cfcb9373548a1..9e55ad39427d4 100644 --- a/bolt/tools/merge-fdata/merge-fdata.cpp +++ b/bolt/tools/merge-fdata/merge-fdata.cpp @@ -428,7 +428,7 @@ int main(int argc, char **argv) { if (YamlInput.error()) report_error(InputDataFilename, YamlInput.error()); - // Sanity check. + // Soundness check. if (BP.Header.Version != 1) { errs() << "Unable to merge data from profile using version " << BP.Header.Version << '\n'; diff --git a/clang-tools-extra/clang-tidy/google/ExplicitMakePairCheck.cpp b/clang-tools-extra/clang-tidy/google/ExplicitMakePairCheck.cpp index d911b58cb8b7e..4b8b411bcc2ef 100644 --- a/clang-tools-extra/clang-tidy/google/ExplicitMakePairCheck.cpp +++ b/clang-tools-extra/clang-tidy/google/ExplicitMakePairCheck.cpp @@ -40,7 +40,7 @@ void ExplicitMakePairCheck::check(const MatchFinder::MatchResult &Result) { const auto *Call = Result.Nodes.getNodeAs("call"); const auto *DeclRef = Result.Nodes.getNodeAs("declref"); - // Sanity check: The use might have overriden ::std::make_pair. + // Soundness check: The use might have overriden ::std::make_pair. if (Call->getNumArgs() != 2) return; diff --git a/clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp b/clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp index 3f5cd4b473903..ac66c5bc5d66a 100644 --- a/clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp +++ b/clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp @@ -99,7 +99,7 @@ void MultiwayPathsCoveredCheck::check(const MatchFinder::MatchResult &Result) { bool SwitchHasDefault = false; std::tie(SwitchCaseCount, SwitchHasDefault) = countCaseLabels(Switch); - // Checks the sanity of 'switch' statements that actually do define + // Checks the soundness of 'switch' statements that actually do define // a default branch but might be degenerated by having no or only one case. if (SwitchHasDefault) { handleSwitchWithDefault(Switch, SwitchCaseCount); diff --git a/clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp b/clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp index 712f390765957..f22118d5cb7e4 100644 --- a/clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp @@ -92,7 +92,7 @@ template class SmartSmallSetVector { void populateSet() { assert(Set.empty() && "Should not have already utilized the Set."); // Magical growth factor prediction - to how many elements do we expect to - // sanely grow after switching away from small-size storage? + // soundly grow after switching away from small-size storage? const size_t NewMaxElts = 4 * Vector.size(); Vector.reserve(NewMaxElts); Set.reserve(NewMaxElts); diff --git a/clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp b/clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp index 2f59aaa86b157..b0e4efcbc5cba 100644 --- a/clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp @@ -133,7 +133,7 @@ struct CognitiveComplexity final { "that in terms of stack usage. " "Thus, it is good to minimize the size of the Detail struct."); SmallVector Details; // 25 elements is 200 bytes. - // Yes, 25 is a magic number. This is the seemingly-sane default for the + // Yes, 25 is a magic number. This is the seemingly-sound default for the // upper limit for function cognitive complexity. Thus it would make sense // to avoid allocations for any function that does not violate the limit. diff --git a/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp b/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp index 6bb8c394f75cc..1aaad01dea13f 100644 --- a/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp @@ -61,7 +61,7 @@ void NamedParameterCheck::check(const MatchFinder::MatchResult &Result) { Parm->getType()->isSpecificBuiltinType(BuiltinType::Int)) continue; - // Sanity check the source locations. + // Soundness check the source locations. if (!Parm->getLocation().isValid() || Parm->getLocation().isMacroID() || !SM.isWrittenInSameFile(Parm->getBeginLoc(), Parm->getLocation())) continue; diff --git a/clang-tools-extra/clangd/CodeCompletionStrings.cpp b/clang-tools-extra/clangd/CodeCompletionStrings.cpp index 9c4241b54057a..a26b36db7ecad 100644 --- a/clang-tools-extra/clangd/CodeCompletionStrings.cpp +++ b/clang-tools-extra/clangd/CodeCompletionStrings.cpp @@ -123,7 +123,7 @@ std::string getDeclComment(const ASTContext &Ctx, const NamedDecl &Decl) { if (!RC) return ""; - // Sanity check that the comment does not come from the PCH. We choose to + // Soundness check that the comment does not come from the PCH. We choose to // not write them into PCH, because they are racy and slow to load. assert(!Ctx.getSourceManager().isLoadedSourceLocation(RC->getBeginLoc())); @@ -146,7 +146,7 @@ std::string getDeclComment(const ASTContext &Ctx, const NamedDecl &Decl) { RC = getCompletionComment(Ctx, &Decl); if (!RC) return ""; - // Sanity check that the comment does not come from the PCH. We choose to + // Soundness check that the comment does not come from the PCH. We choose to // not write them into PCH, because they are racy and slow to load. assert(!Ctx.getSourceManager().isLoadedSourceLocation(RC->getBeginLoc())); Doc = RC->getFormattedText(Ctx.getSourceManager(), Ctx.getDiagnostics()); diff --git a/clang-tools-extra/clangd/Compiler.cpp b/clang-tools-extra/clangd/Compiler.cpp index 8b3865c8a8e5c..ba8766663c411 100644 --- a/clang-tools-extra/clangd/Compiler.cpp +++ b/clang-tools-extra/clangd/Compiler.cpp @@ -100,7 +100,7 @@ buildCompilerInvocation(const ParseInputs &Inputs, clang::DiagnosticConsumer &D, std::vector ArgStrs; ArgStrs.reserve(Argv.size() + 1); // In asserts builds, CompilerInvocation redundantly reads/parses cc1 args as - // a sanity test. This is not useful to clangd, and costs 10% of test time. + // a soundness test. This is not useful to clangd, and costs 10% of test time. // To avoid mismatches between assert/production builds, disable it always. ArgStrs = {Argv.front().c_str(), "-Xclang", "-no-round-trip-args"}; for (const auto &S : Argv.drop_front()) diff --git a/clang-tools-extra/clangd/XRefs.cpp b/clang-tools-extra/clangd/XRefs.cpp index e1c50f906de08..17141a52afc6c 100644 --- a/clang-tools-extra/clangd/XRefs.cpp +++ b/clang-tools-extra/clangd/XRefs.cpp @@ -972,7 +972,7 @@ class ReferenceFinder : public index::IndexDataConsumer { llvm::dyn_cast_or_null(ASTNode.OrigD)) { OMD->getSelectorLocs(Locs); } - // Sanity check: we expect the *first* token to match the reported loc. + // Soundness check: we expect the *first* token to match the reported loc. // Otherwise, maybe it was e.g. some other kind of reference to a Decl. if (!Locs.empty() && Locs.front() != Loc) Locs.clear(); // First token doesn't match, assume our guess was wrong. diff --git a/clang-tools-extra/clangd/index/IndexAction.cpp b/clang-tools-extra/clangd/index/IndexAction.cpp index ed56c2a9d2e81..d9d9cd0f40942 100644 --- a/clang-tools-extra/clangd/index/IndexAction.cpp +++ b/clang-tools-extra/clangd/index/IndexAction.cpp @@ -106,7 +106,7 @@ struct IncludeGraphCollector : public PPCallbacks { NodeForIncluding.first->getValue().DirectIncludes.push_back(NodeForInclude); } - // Sanity check to ensure we have already populated a skipped file. + // Soundness check to ensure we have already populated a skipped file. void FileSkipped(const FileEntryRef &SkippedFile, const Token &FilenameTok, SrcMgr::CharacteristicKind FileType) override { #ifndef NDEBUG diff --git a/clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp b/clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp index ada14c9939318..1c443c50866e2 100644 --- a/clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp +++ b/clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp @@ -854,7 +854,7 @@ TEST(BackgroundQueueTest, Progress) { using testing::AnyOf; BackgroundQueue::Stats S; BackgroundQueue Q([&](BackgroundQueue::Stats New) { - // Verify values are sane. + // Verify values are sound. // Items are enqueued one at a time (at least in this test). EXPECT_THAT(New.Enqueued, AnyOf(S.Enqueued, S.Enqueued + 1)); // Items are completed one at a time. diff --git a/clang-tools-extra/clangd/unittests/ClangdTests.cpp b/clang-tools-extra/clangd/unittests/ClangdTests.cpp index 9ea7c3e02411d..63c92671a621a 100644 --- a/clang-tools-extra/clangd/unittests/ClangdTests.cpp +++ b/clang-tools-extra/clangd/unittests/ClangdTests.cpp @@ -919,7 +919,7 @@ int d; StartSecond.wait(); Server.addDocument(FooCpp, SourceContentsWithoutErrors); ASSERT_TRUE(Server.blockUntilIdleForTest()) << "Waiting for diagnostics"; - ASSERT_EQ(DiagConsumer.Count, 2); // Sanity check - we actually ran both? + ASSERT_EQ(DiagConsumer.Count, 2); // Soundness check - we actually ran both? } TEST(ClangdServerTest, FormatCode) { diff --git a/clang-tools-extra/clangd/unittests/QualityTests.cpp b/clang-tools-extra/clangd/unittests/QualityTests.cpp index 4954659a45e02..1e6d34d58fcc1 100644 --- a/clang-tools-extra/clangd/unittests/QualityTests.cpp +++ b/clang-tools-extra/clangd/unittests/QualityTests.cpp @@ -10,7 +10,7 @@ // For interesting cases, both exact scores and "X beats Y" are too brittle to // make good hard assertions. // -// Here we test the signal extraction and sanity-check that signals point in +// Here we test the signal extraction and soundness-check that signals point in // the right direction. This should be supplemented by quality metrics which // we can compute from a corpus of queries and preferred rankings. // diff --git a/clang-tools-extra/clangd/unittests/RenameTests.cpp b/clang-tools-extra/clangd/unittests/RenameTests.cpp index 5d2a77b62a219..b23d62e37e068 100644 --- a/clang-tools-extra/clangd/unittests/RenameTests.cpp +++ b/clang-tools-extra/clangd/unittests/RenameTests.cpp @@ -1444,7 +1444,7 @@ TEST(RenameTest, IndexMergeMainFile) { EXPECT_THAT(Results.GlobalChanges[Main].asTextEdits(), ElementsAre(newText("xPrime"))); - // Sanity check: we do expect to see index results! + // Soundness check: we do expect to see index results! TU.Filename = "other.cc"; Results = Rename(TU.index().get()); EXPECT_THAT(Results.GlobalChanges.keys(), diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/expand-modular-headers-ppcallbacks.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/expand-modular-headers-ppcallbacks.cpp index 4d1ca669b8d03..c846291329831 100644 --- a/clang-tools-extra/test/clang-tidy/infrastructure/expand-modular-headers-ppcallbacks.cpp +++ b/clang-tools-extra/test/clang-tidy/infrastructure/expand-modular-headers-ppcallbacks.cpp @@ -1,4 +1,4 @@ -// Sanity-check. Run without modules: +// Soundness-check. Run without modules: // RUN: rm -rf %t // RUN: mkdir %t // RUN: cp %S/Inputs/expand-modular-headers-ppcallbacks/* %t/ diff --git a/clang/docs/AutomaticReferenceCounting.rst b/clang/docs/AutomaticReferenceCounting.rst index 80bbd25121148..b10e3635e1d5b 100644 --- a/clang/docs/AutomaticReferenceCounting.rst +++ b/clang/docs/AutomaticReferenceCounting.rst @@ -1993,7 +1993,7 @@ A program is ill-formed if it refers to the ``NSAutoreleasePool`` class. dependencies between two calls. It is also very easy to accidentally forget to drain an autorelease pool when using the manual API, and this can significantly inflate the process's high-water-mark. The introduction of a - new scope is unfortunate but basically required for sane interaction with the + new scope is unfortunate but basically required for sound interaction with the rest of the language. Not draining the pool during an unwind is apparently required by the Objective-C exceptions implementation. diff --git a/clang/docs/InternalsManual.rst b/clang/docs/InternalsManual.rst index bd742273f4ed5..411d3ee3ecec0 100644 --- a/clang/docs/InternalsManual.rst +++ b/clang/docs/InternalsManual.rst @@ -82,7 +82,7 @@ using it. From this file, :program:`tblgen` generates the unique ID of the diagnostic, the severity of the diagnostic and the English translation + format string. -There is little sanity with the naming of the unique ID's right now. Some +There is little soundness with the naming of the unique ID's right now. Some start with ``err_``, ``warn_``, ``ext_`` to encode the severity into the name. Since the enum is referenced in the C++ code that produces the diagnostic, it is somewhat useful for it to be reasonably short. diff --git a/clang/docs/Modules.rst b/clang/docs/Modules.rst index acbe45e0be970..515f5838dbe49 100644 --- a/clang/docs/Modules.rst +++ b/clang/docs/Modules.rst @@ -1099,7 +1099,7 @@ The module maps will be written using the `module map language`_, which provides Headers are often missing ``#include`` directives for headers that they actually depend on. As with the problem of conflicting definitions, this only affects unlucky users who don't happen to include headers in the right order. With modules, the headers of a particular module will be parsed in isolation, so the module may fail to build if there are missing includes. **Headers that vend multiple APIs at different times** - Some systems have headers that contain a number of different kinds of API definitions, only some of which are made available with a given include. For example, the header may vend ``size_t`` only when the macro ``__need_size_t`` is defined before that header is included, and also vend ``wchar_t`` only when the macro ``__need_wchar_t`` is defined. Such headers are often included many times in a single translation unit, and will have no include guards. There is no sane way to map this header to a submodule. One can either eliminate the header (e.g., by splitting it into separate headers, one per actual API) or simply ``exclude`` it in the module map. + Some systems have headers that contain a number of different kinds of API definitions, only some of which are made available with a given include. For example, the header may vend ``size_t`` only when the macro ``__need_size_t`` is defined before that header is included, and also vend ``wchar_t`` only when the macro ``__need_wchar_t`` is defined. Such headers are often included many times in a single translation unit, and will have no include guards. There is no sound way to map this header to a submodule. One can either eliminate the header (e.g., by splitting it into separate headers, one per actual API) or simply ``exclude`` it in the module map. To detect and help address some of these problems, the ``clang-tools-extra`` repository contains a ``modularize`` tool that parses a set of given headers and attempts to detect these problems and produce a report. See the tool's in-source documentation for information on how to check your system or library headers. diff --git a/clang/docs/UsersManual.rst b/clang/docs/UsersManual.rst index 0e85c8109fd5e..cb5eb07d23b65 100644 --- a/clang/docs/UsersManual.rst +++ b/clang/docs/UsersManual.rst @@ -2382,7 +2382,7 @@ are listed below. .. option:: -fno-assume-sane-operator-new - Don't assume that the C++'s new operator is sane. + Don't assume that the C++'s new operator is sound. This option tells the compiler to do not assume that C++'s global new operator will always return a pointer that does not alias any diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h index 88b67eed5fd37..ae84e31b6656c 100644 --- a/clang/include/clang/Sema/Sema.h +++ b/clang/include/clang/Sema/Sema.h @@ -6628,7 +6628,7 @@ class Sema final : public SemaBase { /// CheckParamExceptionSpec - Check if the parameter and return types of the /// two functions have equivalent exception specs. This is part of the /// assignment and override compatibility check. We do not check the - /// parameters of parameter function pointers recursively, as no sane + /// parameters of parameter function pointers recursively, as no sound /// programmer would even be able to write such a function type. bool CheckParamExceptionSpec( const PartialDiagnostic &NestedDiagID, const PartialDiagnostic &NoteID, diff --git a/clang/lib/AST/ASTStructuralEquivalence.cpp b/clang/lib/AST/ASTStructuralEquivalence.cpp index 1292c30d47589..21745c6e7ee38 100644 --- a/clang/lib/AST/ASTStructuralEquivalence.cpp +++ b/clang/lib/AST/ASTStructuralEquivalence.cpp @@ -879,10 +879,10 @@ static bool IsStructurallyEquivalent(StructuralEquivalenceContext &Context, // class comparison. if (T1->getTypeClass() == Type::Enum) { T1 = cast(T1)->getOriginalDecl()->getIntegerType(); - assert(T2->isBuiltinType() && !T1.isNull()); // Sanity check + assert(T2->isBuiltinType() && !T1.isNull()); // Soundness check } else if (T2->getTypeClass() == Type::Enum) { T2 = cast(T2)->getOriginalDecl()->getIntegerType(); - assert(T1->isBuiltinType() && !T2.isNull()); // Sanity check + assert(T1->isBuiltinType() && !T2.isNull()); // Soundness check } TC = Type::Builtin; } else diff --git a/clang/lib/AST/CommentSema.cpp b/clang/lib/AST/CommentSema.cpp index 649fba94a2b76..49d8286a6a048 100644 --- a/clang/lib/AST/CommentSema.cpp +++ b/clang/lib/AST/CommentSema.cpp @@ -249,7 +249,7 @@ void Sema::actOnParamCommandDirectionArg(ParamCommandComment *Command, << ArgRange << FixItHint::CreateReplacement(ArgRange, FixedName); } else { Diag(ArgLocBegin, diag::warn_doc_param_invalid_direction) << ArgRange; - Direction = ParamCommandPassDirection::In; // Sane fall back. + Direction = ParamCommandPassDirection::In; // Sound fall back. } } Command->setDirection(Direction, diff --git a/clang/lib/AST/TypePrinter.cpp b/clang/lib/AST/TypePrinter.cpp index 54ca42d2035ad..baaa0ea1bd475 100644 --- a/clang/lib/AST/TypePrinter.cpp +++ b/clang/lib/AST/TypePrinter.cpp @@ -968,7 +968,7 @@ void TypePrinter::printFunctionProtoAfter(const FunctionProtoType *T, if (Policy.UseHLSLTypes) { // This is a bit of a hack because we _do_ use reference types in the // AST for representing inout and out parameters so that code - // generation is sane, but when re-printing these for HLSL we need to + // generation is sound, but when re-printing these for HLSL we need to // skip the reference. print(T->getParamType(i).getNonReferenceType(), OS, StringRef()); continue; diff --git a/clang/lib/CodeGen/CGCXXABI.cpp b/clang/lib/CodeGen/CGCXXABI.cpp index 30e5dc2b6cbd9..0364f38c5c695 100644 --- a/clang/lib/CodeGen/CGCXXABI.cpp +++ b/clang/lib/CodeGen/CGCXXABI.cpp @@ -196,7 +196,7 @@ bool CGCXXABI::isEmittedWithConstantInitializer( // translation unit will emit the value as a constant. We rely on the // variable being constant-initialized in every translation unit if it's // constant-initialized in any translation unit, which isn't actually - // guaranteed by the standard but is necessary for sanity. + // guaranteed by the standard but is necessary for soundness. return InitDecl->hasConstantInitialization(); } diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp index a94a7ed51521c..463a962f27f0b 100644 --- a/clang/lib/CodeGen/CGCall.cpp +++ b/clang/lib/CodeGen/CGCall.cpp @@ -2469,7 +2469,7 @@ void CodeGenModule::ConstructAttributeList(StringRef Name, AddAttributesFromFunctionProtoType( getContext(), FuncAttrs, Fn->getType()->getAs()); if (AttrOnCallSite && Fn->isReplaceableGlobalAllocationFunction()) { - // A sane operator new returns a non-aliasing pointer. + // A sound operator new returns a non-aliasing pointer. auto Kind = Fn->getDeclName().getCXXOverloadedOperator(); if (getCodeGenOpts().AssumeSaneOperatorNew && (Kind == OO_New || Kind == OO_Array_New)) @@ -3620,7 +3620,7 @@ static llvm::Value *tryEmitFusedAutoreleaseOfResult(CodeGenFunction &CGF, result = call->getArgOperand(0); InstsToKill.push_back(call); - // Keep killing bitcasts, for sanity. Note that we no longer care + // Keep killing bitcasts, for soundness. Note that we no longer care // about precise ordering as long as there's exactly one use. while (llvm::BitCastInst *bitcast = dyn_cast(result)) { if (!bitcast->hasOneUse()) diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index 26fba751e6f9d..e45992a671c70 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -3553,7 +3553,7 @@ llvm::Constant *CodeGenFunction::EmitCheckTypeDescriptor(QualType T) { // So we can write the exact amount of bits in TypeName after '\0' // making it .'\0'.<32-bit width>. if (T->isSignedIntegerType() && T->getAs()) { - // Do a sanity checks as we are using 32-bit type to store bit length. + // Do a soundness check as we are using 32-bit type to store bit length. assert(getContext().getTypeSize(T) > 0 && " non positive amount of bits in __BitInt type"); assert(getContext().getTypeSize(T) <= 0xFFFFFFFF && diff --git a/clang/lib/CodeGen/CGStmt.cpp b/clang/lib/CodeGen/CGStmt.cpp index aeff73d525c10..8ba7604882742 100644 --- a/clang/lib/CodeGen/CGStmt.cpp +++ b/clang/lib/CodeGen/CGStmt.cpp @@ -2217,7 +2217,7 @@ static bool FindCaseStatementsForValue(const SwitchStmt &S, // Ok, we know which case is being jumped to, try to collect all the // statements that follow it. This can fail for a variety of reasons. Also, // check to see that the recursive walk actually found our case statement. - // Insane cases like this can fail to find it in the recursive walk since we + // Unsound cases like this can fail to find it in the recursive walk since we // don't handle every stmt kind: // switch (4) { // while (1) { diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp index f110dbab3e5a5..ef87348e1c6e6 100644 --- a/clang/lib/Driver/Driver.cpp +++ b/clang/lib/Driver/Driver.cpp @@ -212,7 +212,7 @@ Driver::Driver(StringRef ClangExecutable, StringRef TargetTriple, TargetTriple(TargetTriple), Saver(Alloc), PrependArg(nullptr), PreferredLinker(CLANG_DEFAULT_LINKER), CheckInputsExist(true), ProbePrecompiled(true), SuppressMissingInputWarning(false) { - // Provide a sane fallback if no VFS is specified. + // Provide a sound fallback if no VFS is specified. if (!this->VFS) this->VFS = llvm::vfs::getRealFileSystem(); diff --git a/clang/lib/Frontend/PrintPreprocessedOutput.cpp b/clang/lib/Frontend/PrintPreprocessedOutput.cpp index 9e046633328d7..2550a46d7d8f8 100644 --- a/clang/lib/Frontend/PrintPreprocessedOutput.cpp +++ b/clang/lib/Frontend/PrintPreprocessedOutput.cpp @@ -1148,8 +1148,8 @@ void clang::DoPrintPreprocessedInput(Preprocessor &PP, raw_ostream *OS, PrintPreprocessedTokens(PP, Tok, Callbacks); *OS << '\n'; - // Remove the handlers we just added to leave the preprocessor in a sane state - // so that it can be reused (for example by a clang::Parser instance). + // Remove the handlers we just added to leave the preprocessor in a sound + // state so that it can be reused (for example by a clang::Parser instance). PP.RemovePragmaHandler(MicrosoftExtHandler.get()); PP.RemovePragmaHandler("GCC", GCCHandler.get()); PP.RemovePragmaHandler("clang", ClangHandler.get()); diff --git a/clang/lib/Index/USRGeneration.cpp b/clang/lib/Index/USRGeneration.cpp index c78d66f9502dd..69a6761ac4bae 100644 --- a/clang/lib/Index/USRGeneration.cpp +++ b/clang/lib/Index/USRGeneration.cpp @@ -1228,7 +1228,7 @@ bool clang::index::generateUSRForMacro(StringRef MacroName, SourceLocation Loc, llvm::raw_svector_ostream Out(Buf); - // Assume that system headers are sane. Don't put source location + // Assume that system headers are sound. Don't put source location // information into the USR if the macro comes from a system header. bool ShouldGenerateLocation = Loc.isValid() && !SM.isInSystemHeader(Loc); diff --git a/clang/lib/Parse/ParseStmtAsm.cpp b/clang/lib/Parse/ParseStmtAsm.cpp index c679aa6fe7b27..a290b83bfb941 100644 --- a/clang/lib/Parse/ParseStmtAsm.cpp +++ b/clang/lib/Parse/ParseStmtAsm.cpp @@ -176,9 +176,9 @@ ClangAsmParserCallback::translateLocation(const llvm::SourceMgr &LSM, unsigned TokIndex = TokOffsetPtr - AsmTokOffsets.begin(); unsigned TokOffset = *TokOffsetPtr; - // If we come up with an answer which seems sane, use it; otherwise, + // If we come up with an answer which seems sound, use it; otherwise, // just point at the __asm keyword. - // FIXME: Assert the answer is sane once we handle .macro correctly. + // FIXME: Assert the answer is sound once we handle .macro correctly. SourceLocation Loc = AsmLoc; if (TokIndex < AsmToks.size()) { const Token &Tok = AsmToks[TokIndex]; diff --git a/clang/lib/Sema/SemaOpenACC.cpp b/clang/lib/Sema/SemaOpenACC.cpp index fbd8022cd68ba..33b7d24382bc9 100644 --- a/clang/lib/Sema/SemaOpenACC.cpp +++ b/clang/lib/Sema/SemaOpenACC.cpp @@ -2672,7 +2672,7 @@ Expr *GenerateReductionInitRecipeExpr(ASTContext &Context, // discussions/designs are ongoing on how to express this behavior, // particularly since they probably need the 'bounds' passed to them // correctly. A future patch/patch set will go through all of the pointer - // values for all of the recipes to make sure we have a sane behavior. + // values for all of the recipes to make sure we have a sound behavior. // For now, this will result in a NYI during code generation for // no-initializer. diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp index 14fa8478fe317..f00c353020cb7 100644 --- a/clang/lib/Sema/SemaOverload.cpp +++ b/clang/lib/Sema/SemaOverload.cpp @@ -7561,8 +7561,8 @@ bool Sema::diagnoseArgDependentDiagnoseIfAttrs(const FunctionDecl *Function, *this, Function, /*ArgDependent=*/true, Loc, [&](const DiagnoseIfAttr *DIA) { APValue Result; - // It's sane to use the same Args for any redecl of this function, since - // EvaluateWithSubstitution only cares about the position of each + // It's sound to use the same Args for any redecl of this function, + // since EvaluateWithSubstitution only cares about the position of each // argument in the arg list, not the ParmVarDecl* it maps to. if (!DIA->getCond()->EvaluateWithSubstitution( Result, Context, cast(DIA->getParent()), Args, ThisArg)) diff --git a/clang/lib/Sema/SemaTemplateDeduction.cpp b/clang/lib/Sema/SemaTemplateDeduction.cpp index cce40c0c91f95..55a006e9018a6 100644 --- a/clang/lib/Sema/SemaTemplateDeduction.cpp +++ b/clang/lib/Sema/SemaTemplateDeduction.cpp @@ -6167,7 +6167,7 @@ UnresolvedSetIterator Sema::getMostSpecialized( if (Complain) { Diag(Loc, AmbigDiag); - // FIXME: Can we order the candidates in some sane way? + // FIXME: Can we order the candidates in some sound way? for (UnresolvedSetIterator I = SpecBegin; I != SpecEnd; ++I) { PartialDiagnostic PD = CandidateDiag; const auto *FD = cast(*I); diff --git a/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp index d35031b5c22df..60789520ec313 100644 --- a/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp @@ -613,7 +613,7 @@ void ArrayBoundChecker::performCheck(const Expr *E, CheckerContext &C) const { // TODO: Currently the analyzer ignores many casts (e.g. signed -> // unsigned casts), so it can easily reach states where it will load a - // signed (and negative) value from an unsigned variable. This sanity + // signed (and negative) value from an unsigned variable. This soundness // check is a duct tape "solution" that silences most of the ugly false // positives that are caused by this buggy behavior. Note that this is // not a complete solution: this cannot silence reports where pointer diff --git a/clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp index 86530086ff1b2..0dc52d3c3acbf 100644 --- a/clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp @@ -477,7 +477,7 @@ void PthreadLockChecker::AcquireLockAux(const CallEvent &Call, SVal RetVal = Call.getReturnValue(); if (auto DefinedRetVal = RetVal.getAs()) { // FIXME: If the lock function was inlined and returned true, - // we need to behave sanely - at least generate sink. + // we need to behave soundly - at least generate sink. lockSucc = state->assume(*DefinedRetVal, false); assert(lockSucc); } diff --git a/clang/test/AST/ByteCode/cxx11.cpp b/clang/test/AST/ByteCode/cxx11.cpp index 72bc7622eb6d8..abdb8f78ff5bc 100644 --- a/clang/test/AST/ByteCode/cxx11.cpp +++ b/clang/test/AST/ByteCode/cxx11.cpp @@ -350,7 +350,7 @@ namespace GH150709 { constexpr auto mp = static_cast(&D::f); - // sanity checks for fix of GH150709 (unchanged behavior) + // soundness checks for fix of GH150709 (unchanged behavior) static_assert((c1.*mp)() == 1, ""); // both-error {{constant expression}} static_assert((d1.*mp)() == 1, ""); static_assert((f.*mp)() == 1, ""); diff --git a/clang/test/Analysis/return-value-guaranteed.cpp b/clang/test/Analysis/return-value-guaranteed.cpp index 3b010ffba3600..e89a1e7a7c139 100644 --- a/clang/test/Analysis/return-value-guaranteed.cpp +++ b/clang/test/Analysis/return-value-guaranteed.cpp @@ -52,7 +52,7 @@ bool parseFile() { } // namespace test_normal -// Sanity check for the highly unlikely case where the implementation of the +// Soundness check for the highly unlikely case where the implementation of the // method breaks the convention. namespace test_break { struct MCAsmParser { diff --git a/clang/test/Analysis/std-variant-checker.cpp b/clang/test/Analysis/std-variant-checker.cpp index 7f136c06b19cc..a7d91b6d73838 100644 --- a/clang/test/Analysis/std-variant-checker.cpp +++ b/clang/test/Analysis/std-variant-checker.cpp @@ -45,7 +45,7 @@ using var_tt = var_t; using int_t = int; using char_t = char; -// A quick sanity check to see that std::variant's std::get +// A quick soundness check to see that std::variant's std::get // is not being confused with std::pairs std::get. void wontConfuseStdGets() { std::pair p{15, '1'}; diff --git a/clang/test/CodeGen/AArch64/inline-asm.c b/clang/test/CodeGen/AArch64/inline-asm.c index 8ddee560b11da..5f1fe99131004 100644 --- a/clang/test/CodeGen/AArch64/inline-asm.c +++ b/clang/test/CodeGen/AArch64/inline-asm.c @@ -2,7 +2,7 @@ // The only part clang really deals with is the lvalue/rvalue // distinction on constraints. It's sufficient to emit llvm and make -// sure that's sane. +// sure that's sound. long var; diff --git a/clang/test/CodeGen/alloc-align-attr.c b/clang/test/CodeGen/alloc-align-attr.c index c4c4e76eaaa04..3a0d2ca771e78 100644 --- a/clang/test/CodeGen/alloc-align-attr.c +++ b/clang/test/CodeGen/alloc-align-attr.c @@ -71,7 +71,7 @@ __INT32_TYPE__ test4(__SIZE_TYPE__ a) { struct Empty {}; struct MultiArgs { __INT64_TYPE__ a, b;}; // Struct parameter doesn't take up an IR parameter, 'i' takes up 1. -// Truncation to i64 is permissible, since alignments of greater than 2^64 are insane. +// Truncation to i64 is permissible, since alignments of greater than 2^64 are unsound. __INT32_TYPE__ *m3(struct Empty s, __int128_t i) __attribute__((alloc_align(2))); // CHECK-LABEL: @test5( // CHECK-NEXT: entry: diff --git a/clang/test/CodeGen/arm-target-features.c b/clang/test/CodeGen/arm-target-features.c index 95ae27bd2db6c..63fd459154d0a 100644 --- a/clang/test/CodeGen/arm-target-features.c +++ b/clang/test/CodeGen/arm-target-features.c @@ -63,7 +63,7 @@ // CHECK-THUMB-DIV-M3: "target-features"="+armv7-m,+hwdiv,+thumb-mode" // (The following test with no arch specified shouldn't happen; the driver -// rewrites triples. Just make sure it does something sane.) +// rewrites triples. Just make sure it does something sound.) // RUN: %clang_cc1 -triple arm-linux-gnueabi -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK-ARM-NOARCH-LINUX // CHECK-ARM-NOARCH-LINUX: "target-features"="-thumb-mode" diff --git a/clang/test/CodeGen/atomic-ops.c b/clang/test/CodeGen/atomic-ops.c index b6060dcc540f9..84158b85cf691 100644 --- a/clang/test/CodeGen/atomic-ops.c +++ b/clang/test/CodeGen/atomic-ops.c @@ -600,7 +600,7 @@ void generalWeakness(int *ptr, int *ptr2, _Bool weak) { } // Having checked the flow in the previous two cases, we'll trust clang to -// combine them sanely. +// combine them soundly. void EMIT_ALL_THE_THINGS(int *ptr, int *ptr2, int new, _Bool weak, int success, int fail) { __atomic_compare_exchange(ptr, ptr2, &new, weak, success, fail); diff --git a/clang/test/CodeGen/strictfp-elementwise-builtins.cpp b/clang/test/CodeGen/strictfp-elementwise-builtins.cpp index b250512efc5c7..076f6e9ec409a 100644 --- a/clang/test/CodeGen/strictfp-elementwise-builtins.cpp +++ b/clang/test/CodeGen/strictfp-elementwise-builtins.cpp @@ -6,7 +6,7 @@ typedef float float4 __attribute__((ext_vector_type(4))); -// Sanity check we're getting constrained ops for a non-builtin. +// Soundness check we're getting constrained ops for a non-builtin. // CHECK-LABEL: define dso_local noundef <4 x float> @_Z11strict_faddDv4_fS_ // CHECK-SAME: (<4 x float> noundef [[A:%.*]], <4 x float> noundef [[B:%.*]]) local_unnamed_addr #[[ATTR0:[0-9]+]] { // CHECK-NEXT: entry: diff --git a/clang/test/CodeGen/union-init2.c b/clang/test/CodeGen/union-init2.c index ee35e78a4f301..79f481240d0bc 100644 --- a/clang/test/CodeGen/union-init2.c +++ b/clang/test/CodeGen/union-init2.c @@ -1,7 +1,7 @@ // RUN: %clang_cc1 -emit-llvm %s -o - -triple i686-pc-linux-gnu | FileCheck %s // RUN: %clang_cc1 -x c++ %s -emit-llvm -triple x86_64-linux-gnu -o - | FileCheck %s --check-prefixes=CHECK-CXX -// Make sure we generate something sane instead of a ptrtoint +// Make sure we generate something sound instead of a ptrtoint // CHECK: @r, [4 x i8] zeroinitializer union x {long long b;union x* a;} r = {.a = &r}; diff --git a/clang/test/CodeGenCXX/OmitRTTIComponentABI/simple-vtable-definition.cpp b/clang/test/CodeGenCXX/OmitRTTIComponentABI/simple-vtable-definition.cpp index 75fd72af11d72..a2177cc9d6163 100644 --- a/clang/test/CodeGenCXX/OmitRTTIComponentABI/simple-vtable-definition.cpp +++ b/clang/test/CodeGenCXX/OmitRTTIComponentABI/simple-vtable-definition.cpp @@ -15,7 +15,7 @@ // RELATIVE: @_ZTV1A = unnamed_addr alias { [2 x i32] }, ptr @_ZTV1A.local /// None of these supplementary symbols should be emitted with -fno-rtti, but -/// as a sanity check lets make sure they're not emitted also. +/// as a soundness check lets make sure they're not emitted also. // RTTI-NOT: @_ZTVN10__cxxabiv117__class_type_infoE // RTTI-NOT: @_ZTS1A // RTTI-NOT: @_ZTI1A diff --git a/clang/test/CodeGenCXX/cxx11-user-defined-literal.cpp b/clang/test/CodeGenCXX/cxx11-user-defined-literal.cpp index c8ab43194350e..0073c15c0ad76 100644 --- a/clang/test/CodeGenCXX/cxx11-user-defined-literal.cpp +++ b/clang/test/CodeGenCXX/cxx11-user-defined-literal.cpp @@ -37,7 +37,7 @@ void f() { 123_r, 4.9_r, 0xffff\ eeee_r; - // FIXME: This mangling is insane. Maybe we should have a special case for + // FIXME: This mangling is unsound. Maybe we should have a special case for // char parameter packs? // CHECK: call void @_Zli2_tIJLc48ELc120ELc49ELc50ELc51ELc52ELc53ELc54ELc55ELc56EEE1Sv({{.*}}) // CHECK: call void @_ZN1SD1Ev({{.*}}) diff --git a/clang/test/CodeGenCXX/type-aware-allocators.cpp b/clang/test/CodeGenCXX/type-aware-allocators.cpp index cce9197ed0d12..839d842382184 100644 --- a/clang/test/CodeGenCXX/type-aware-allocators.cpp +++ b/clang/test/CodeGenCXX/type-aware-allocators.cpp @@ -19,7 +19,7 @@ namespace std { using size_t = __SIZE_TYPE__; -// Sanity check to esure the semantics of the selected compiler mode +// Soundness check to esure the semantics of the selected compiler mode // will trigger the exception handlers we are expecting, before // involving type aware allocation. // We duplicate the struct definitions so we don't trigger diagnostics diff --git a/clang/test/CodeGenHLSL/GlobalDestructors.hlsl b/clang/test/CodeGenHLSL/GlobalDestructors.hlsl index 9d8c2e65a9598..3ad8f386b3a37 100644 --- a/clang/test/CodeGenHLSL/GlobalDestructors.hlsl +++ b/clang/test/CodeGenHLSL/GlobalDestructors.hlsl @@ -75,7 +75,7 @@ void main(unsigned GI : SV_GroupIndex) { // INLINE-NOT: call {{[^@]*}} @{{[^l][^l][^v][^m][^\.]}} // INLINE: ret void -// This is really just a sanity check I needed for myself to verify that +// This is really just a soundness check I needed for myself to verify that // function scope static variables also get destroyed properly. // NOINLINE-DXIL: define internal void @_GLOBAL__D_a() [[IntAttr:\#[0-9]+]] diff --git a/clang/test/CodeGenHLSL/RootSignature.hlsl b/clang/test/CodeGenHLSL/RootSignature.hlsl index bc40bdd79ce59..00b2cace26e7b 100644 --- a/clang/test/CodeGenHLSL/RootSignature.hlsl +++ b/clang/test/CodeGenHLSL/RootSignature.hlsl @@ -101,7 +101,7 @@ void RootDescriptorsEntry() {} [numthreads(1,1,1)] void StaticSamplerEntry() {} -// Sanity test to ensure no root is added for this function as there is only +// Soundness test to ensure no root is added for this function as there is only // two entries in !dx.roosignatures [shader("compute")] [numthreads(1,1,1)] diff --git a/clang/test/Driver/aix-as.c b/clang/test/Driver/aix-as.c index 4164348b60127..4923b59f10a6b 100644 --- a/clang/test/Driver/aix-as.c +++ b/clang/test/Driver/aix-as.c @@ -1,4 +1,4 @@ -// General tests that as(1) invocations on AIX targets are sane. Note that we +// General tests that as(1) invocations on AIX targets are sound. Note that we // only test assembler functionalities in this suite. // Check powerpc-ibm-aix7.1.0.0, system assembler is used for assembly files, 32-bit. diff --git a/clang/test/Driver/aix-ld.c b/clang/test/Driver/aix-ld.c index 1dae61d91c4e3..abafbed4327e3 100644 --- a/clang/test/Driver/aix-ld.c +++ b/clang/test/Driver/aix-ld.c @@ -1,4 +1,4 @@ -// General tests that ld invocations on AIX targets are sane. Note that we use +// General tests that ld invocations on AIX targets are sound. Note that we use // sysroot to make these tests independent of the host system. // Check powerpc-ibm-aix7.1.0.0, 32-bit. diff --git a/clang/test/Driver/as-dwarf-cie.s b/clang/test/Driver/as-dwarf-cie.s index 1ffb23cb05d36..d9bdcc2a96d18 100644 --- a/clang/test/Driver/as-dwarf-cie.s +++ b/clang/test/Driver/as-dwarf-cie.s @@ -1,5 +1,5 @@ # REQUIRES: x86-registered-target -# Test that there is a sane default CIE version. +# Test that there is a sound default CIE version. # RUN: %clang -cc1as -triple i386-apple-darwin -filetype obj %s -o %t # RUN: llvm-objdump --dwarf=frames %t | FileCheck %s # CHECK: .debug_frame contents: diff --git a/clang/test/Driver/fopenmp.c b/clang/test/Driver/fopenmp.c index 7d343eeee0f3f..7c5e45efe5860 100644 --- a/clang/test/Driver/fopenmp.c +++ b/clang/test/Driver/fopenmp.c @@ -178,7 +178,7 @@ // CHECK-CC1-OPENMPIRBUILDER-SAME: "-fopenmp" // CHECK-CC1-OPENMPIRBUILDER-SAME: "-fopenmp-enable-irbuilder" // -// We'd like to check that the default is sane, but until we have the ability +// We'd like to check that the default is sound, but until we have the ability // to *always* semantically analyze OpenMP without always generating runtime // calls (in the event of an unsupported runtime), we don't have a good way to // test the CC1 invocation. Instead, just ensure we do eventually link *some* diff --git a/clang/test/Driver/linux-header-search.cpp b/clang/test/Driver/linux-header-search.cpp index 70a85deac89e4..312c800d692a1 100644 --- a/clang/test/Driver/linux-header-search.cpp +++ b/clang/test/Driver/linux-header-search.cpp @@ -1,5 +1,5 @@ // General tests that the header search paths detected by the driver and passed -// to CC1 are sane. +// to CC1 are sound. // // Test a simulated installation of libc++ on Linux, both through sysroot and // the installation path of Clang. diff --git a/clang/test/Driver/linux-ld.c b/clang/test/Driver/linux-ld.c index be3293cdc253e..f0f74d05ef6f3 100644 --- a/clang/test/Driver/linux-ld.c +++ b/clang/test/Driver/linux-ld.c @@ -1,5 +1,5 @@ // UNSUPPORTED: system-windows -// General tests that ld invocations on Linux targets sane. Note that we use +// General tests that ld invocations on Linux targets sound. Note that we use // sysroot to make these tests independent of the host system. // // RUN: %clang -### -Werror %s -no-pie 2>&1 \ diff --git a/clang/test/Driver/solaris-ld-values.c b/clang/test/Driver/solaris-ld-values.c index 6f0a5b5957f01..4de1caeebf314 100644 --- a/clang/test/Driver/solaris-ld-values.c +++ b/clang/test/Driver/solaris-ld-values.c @@ -1,5 +1,5 @@ // General tests that the correct versions of values-*.o are used on -// Solaris targets sane. Note that we use sysroot to make these tests +// Solaris targets sound. Note that we use sysroot to make these tests // independent of the host system. // Check sparc-sun-solaris2.11, 32bit diff --git a/clang/test/Driver/solaris-ld-values.cpp b/clang/test/Driver/solaris-ld-values.cpp index 566252f551d51..17115967fa3c2 100644 --- a/clang/test/Driver/solaris-ld-values.cpp +++ b/clang/test/Driver/solaris-ld-values.cpp @@ -1,5 +1,5 @@ // General tests that the correct versions of values-*.o are used on -// Solaris targets sane. Note that we use sysroot to make these tests +// Solaris targets sound. Note that we use sysroot to make these tests // independent of the host system. // Check sparc-sun-solaris2.11, 32bit diff --git a/clang/test/Driver/solaris-ld.c b/clang/test/Driver/solaris-ld.c index 5940ee2add769..ea09dbfd6895d 100644 --- a/clang/test/Driver/solaris-ld.c +++ b/clang/test/Driver/solaris-ld.c @@ -1,4 +1,4 @@ -// General tests that ld invocations on Solaris targets sane. Note that we use +// General tests that ld invocations on Solaris targets sound. Note that we use // sysroot to make these tests independent of the host system. // Check sparc-sun-solaris2.11, 32bit diff --git a/clang/test/PCH/floating-literal.c b/clang/test/PCH/floating-literal.c index b5ff6fe84b88c..bb0e0c1730f76 100644 --- a/clang/test/PCH/floating-literal.c +++ b/clang/test/PCH/floating-literal.c @@ -10,7 +10,7 @@ long double foo = 1.0E4000L; // CHECK: long double foo = 1.00000000000000000000000000000000004E+4000L; -// Just as well check the others are still sane while we're here... +// Just as well check the others are still sound while we're here... double bar = 1.0E300; // CHECK: double bar = 1.0000000000000001E+300; diff --git a/clang/test/SemaCXX/constant-expression-cxx11.cpp b/clang/test/SemaCXX/constant-expression-cxx11.cpp index 91c4ff1cb520d..a211277bcb023 100644 --- a/clang/test/SemaCXX/constant-expression-cxx11.cpp +++ b/clang/test/SemaCXX/constant-expression-cxx11.cpp @@ -2633,7 +2633,7 @@ namespace GH150709 { constexpr auto mp = static_cast(&D::f); - // sanity checks for fix of GH150709 (unchanged behavior) + // soundness checks for fix of GH150709 (unchanged behavior) static_assert((c1.*mp)() == 1, ""); // expected-error {{constant expression}} static_assert((d1.*mp)() == 1, ""); static_assert((f.*mp)() == 1, ""); diff --git a/clang/test/SemaCXX/constant-expression-cxx14.cpp b/clang/test/SemaCXX/constant-expression-cxx14.cpp index 1743e0e3ac4b5..87df31b40910d 100644 --- a/clang/test/SemaCXX/constant-expression-cxx14.cpp +++ b/clang/test/SemaCXX/constant-expression-cxx14.cpp @@ -1234,7 +1234,7 @@ namespace ObjectsUnderConstruction { }; constexpr Aggregate aggr1; static_assert(aggr1.x == 1 && aggr1.y == 1, ""); - // FIXME: This is not specified by the standard, but sanity requires it. + // FIXME: This is not specified by the standard, but soundness requires it. constexpr Aggregate aggr2 = {}; static_assert(aggr2.x == 1 && aggr2.y == 1, ""); diff --git a/clang/test/SemaCXX/enable_if.cpp b/clang/test/SemaCXX/enable_if.cpp index 1c307881e5d4a..7afca4fade4b0 100644 --- a/clang/test/SemaCXX/enable_if.cpp +++ b/clang/test/SemaCXX/enable_if.cpp @@ -387,7 +387,7 @@ void runFoo() { } } -// Ideally, we should be able to handle value-dependent expressions sanely. +// Ideally, we should be able to handle value-dependent expressions soundly. // Sadly, that isn't the case at the moment. namespace dependent { int error(int N) __attribute__((enable_if(N, ""))); // expected-note{{candidate disabled}} diff --git a/clang/test/SemaCXX/overload-resolution-deferred-templates.cpp b/clang/test/SemaCXX/overload-resolution-deferred-templates.cpp index 135865c8450f5..36176cb45f326 100644 --- a/clang/test/SemaCXX/overload-resolution-deferred-templates.cpp +++ b/clang/test/SemaCXX/overload-resolution-deferred-templates.cpp @@ -22,7 +22,7 @@ struct Invalid { static_assert(false, "instantiated Invalid"); }; // #err-invali template int f(T a, Invalid = {}); // #note-f -// sanity check +// soundness check int e1 = f(0); //expected-error@#err-invalid {{static assertion failed: instantiated Invalid}} //expected-note@-2 {{in instantiation of default function argument expression for 'f' required here}} diff --git a/clang/test/SemaCXX/vtable_pointer_authentication_attribute.cpp b/clang/test/SemaCXX/vtable_pointer_authentication_attribute.cpp index 390305f5cb73d..a1084d6393fd9 100644 --- a/clang/test/SemaCXX/vtable_pointer_authentication_attribute.cpp +++ b/clang/test/SemaCXX/vtable_pointer_authentication_attribute.cpp @@ -5,7 +5,7 @@ namespace basic { #define authenticated(a, b, c...) [[clang::ptrauth_vtable_pointer(a, b, c)]] -// Basic sanity tests +// Basic soundness tests #define TEST_AUTH(name, auth...) \ struct [[clang::ptrauth_vtable_pointer(auth)]] name { \ virtual ~name() {} \ @@ -90,7 +90,7 @@ UnauthedPolymorphicTemplateClass test7; UnauthedPolymorphicTemplateClass test8; // Just use a different policy from the generic macro to verify we won't complain -// about the insanity +// about the unsoundness struct authenticated(process_independent, no_address_discrimination, type_discrimination) SecondAuthenticatedPolymorphic { virtual ~SecondAuthenticatedPolymorphic(){}; }; diff --git a/clang/test/SemaTemplate/canonical-expr-type.cpp b/clang/test/SemaTemplate/canonical-expr-type.cpp index f8d7d7ec1a271..cbd5740495ad6 100644 --- a/clang/test/SemaTemplate/canonical-expr-type.cpp +++ b/clang/test/SemaTemplate/canonical-expr-type.cpp @@ -12,7 +12,7 @@ void f0(T x, __typeof__((f)(x)) y) { } template void f0(U u, __typeof__(f(u))) { } // expected-error{{redefinition}} -// Test insane typeof(expr) overload set canonicalization +// Test unsound typeof(expr) overload set canonicalization void f(int); void f(double); diff --git a/clang/test/utils/update_cc_test_checks/check-globals.test b/clang/test/utils/update_cc_test_checks/check-globals.test index 5f527fa122322..f5a5f6eb1ed22 100644 --- a/clang/test/utils/update_cc_test_checks/check-globals.test +++ b/clang/test/utils/update_cc_test_checks/check-globals.test @@ -31,7 +31,7 @@ RUN: rm %t/igf-again.c RUN: cp %S/Inputs/lit.cfg.example %t/lit.cfg # Show lit failures while avoiding confusing FileCheck input dump nesting. RUN: %lit %t -# Lit was successful. Sanity-check the results with deterministic test order. +# Lit was successful. Soundness-check the results with deterministic test order. RUN: rm %t/.lit_test_times.txt RUN: %lit %t 2>&1 | FileCheck -check-prefix=LIT-RUN %s diff --git a/clang/test/utils/update_cc_test_checks/global-hex-value-regex.test b/clang/test/utils/update_cc_test_checks/global-hex-value-regex.test index 6ff06b4028d82..94d4df1d4c304 100644 --- a/clang/test/utils/update_cc_test_checks/global-hex-value-regex.test +++ b/clang/test/utils/update_cc_test_checks/global-hex-value-regex.test @@ -11,7 +11,7 @@ RUN: diff -u %S/Inputs/global-hex-value-regex.c.expected %t/test.c RUN: cp %S/Inputs/lit.cfg.example %t/lit.cfg # Show lit failures while avoiding confusing FileCheck input dump nesting. RUN: %lit %t -# Lit was successful. Sanity-check the results with deterministic test order. +# Lit was successful. Soundness-check the results with deterministic test order. RUN: rm %t/.lit_test_times.txt RUN: %lit %t 2>&1 | FileCheck %s diff --git a/clang/test/utils/update_cc_test_checks/global-value-regex.test b/clang/test/utils/update_cc_test_checks/global-value-regex.test index 33103e101794d..d3b99d55038ee 100644 --- a/clang/test/utils/update_cc_test_checks/global-value-regex.test +++ b/clang/test/utils/update_cc_test_checks/global-value-regex.test @@ -10,7 +10,7 @@ RUN: diff -u %S/Inputs/global-value-regex.c.expected %t/test.c RUN: cp %S/Inputs/lit.cfg.example %t/lit.cfg # Show lit failures while avoiding confusing FileCheck input dump nesting. RUN: %lit %t -# Lit was successful. Sanity-check the results with deterministic test order. +# Lit was successful. Soundness-check the results with deterministic test order. RUN: rm %t/.lit_test_times.txt RUN: %lit %t 2>&1 | FileCheck %s diff --git a/clang/unittests/Analysis/CFGTest.cpp b/clang/unittests/Analysis/CFGTest.cpp index 46a6751391cf5..83e696c26f454 100644 --- a/clang/unittests/Analysis/CFGTest.cpp +++ b/clang/unittests/Analysis/CFGTest.cpp @@ -141,7 +141,7 @@ TEST(CFG, ElementRefIterator) { constexpr CFGBlock::ref_iterator::difference_type MainBlockSize = 4; - // The rest of this test looks totally insane, but there iterators are + // The rest of this test looks totally unsound, but there iterators are // templates under the hood, to it's important to instantiate everything for // proper converage. diff --git a/clang/unittests/Basic/SourceManagerTest.cpp b/clang/unittests/Basic/SourceManagerTest.cpp index 04b23dd13ba3e..eb48caad2b6db 100644 --- a/clang/unittests/Basic/SourceManagerTest.cpp +++ b/clang/unittests/Basic/SourceManagerTest.cpp @@ -197,7 +197,7 @@ TEST_F(SourceManagerTest, isBeforeInTranslationUnitWithTokenSplit) { // Make sure we got the tokens that we expected. ASSERT_EQ(4U, toks.size()) << "a >> b c"; - // Sanity check their order. + // Soundness check their order. for (unsigned I = 0; I < toks.size() - 1; ++I) { EXPECT_TRUE(SourceMgr.isBeforeInTranslationUnit(toks[I].getLocation(), toks[I + 1].getLocation())); diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp index d63e79a5f5155..d70b814d1f071 100644 --- a/clang/utils/TableGen/ClangAttrEmitter.cpp +++ b/clang/utils/TableGen/ClangAttrEmitter.cpp @@ -1846,7 +1846,7 @@ enum class LateAttrParseKind { Never = 0, Standard = 1, ExperimentalExt = 2 }; static LateAttrParseKind getLateAttrParseKind(const Record *Attr) { // This function basically does // `Attr->getValueAsDef("LateParsed")->getValueAsInt("Kind")` but does a bunch - // of sanity checking to ensure that `LateAttrParseMode` in `Attr.td` is in + // of soundness checking to ensure that `LateAttrParseMode` in `Attr.td` is in // sync with the `LateAttrParseKind` enum in this source file. static constexpr StringRef LateParsedStr = "LateParsed"; diff --git a/cmake/Modules/EnableLanguageNolink.cmake b/cmake/Modules/EnableLanguageNolink.cmake index 18668c6d0476f..fdd115966de91 100644 --- a/cmake/Modules/EnableLanguageNolink.cmake +++ b/cmake/Modules/EnableLanguageNolink.cmake @@ -1,7 +1,7 @@ macro(llvm_enable_language_nolink) # Set CMAKE_TRY_COMPILE_TARGET_TYPE to STATIC_LIBRARY to disable linking - # in the compiler sanity checks. When bootstrapping the toolchain, - # the toolchain itself is still incomplete and sanity checks that include + # in the compiler soundness checks. When bootstrapping the toolchain, + # the toolchain itself is still incomplete and soundness checks that include # linking may fail. set(__SAVED_TRY_COMPILE_TARGET_TYPE ${CMAKE_TRY_COMPILE_TARGET_TYPE}) set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY) diff --git a/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake b/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake index c6777bda9f0d1..6b89b42eb47e7 100644 --- a/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake +++ b/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake @@ -72,7 +72,7 @@ function(find_darwin_sdk_version var sdk_name) message(FATAL_ERROR "Failed to determine SDK version for \"${sdk_name}\" SDK") endif() - # Check reported version looks sane. + # Check reported version looks sound. if (NOT "${var_internal}" MATCHES "^[0-9]+\\.[0-9]+(\\.[0-9]+)?$") message(FATAL_ERROR "Reported SDK version \"${var_internal}\" does not look like a version") diff --git a/compiler-rt/cmake/Modules/CompilerRTUtils.cmake b/compiler-rt/cmake/Modules/CompilerRTUtils.cmake index 03db38fa4cdc1..d124ee3d183f5 100644 --- a/compiler-rt/cmake/Modules/CompilerRTUtils.cmake +++ b/compiler-rt/cmake/Modules/CompilerRTUtils.cmake @@ -275,7 +275,7 @@ function(get_compiler_rt_root_source_dir ROOT_DIR_VAR) message(FATAL_ERROR "Path \"${ROOT_DIR}\" doesn't exist") endif() - # Sanity check: Make sure we can locate the current source file via the + # Soundness check: Make sure we can locate the current source file via the # computed path. set(PATH_TO_CURRENT_FILE "${ROOT_DIR}/cmake/Modules/CompilerRTUtils.cmake") if (NOT EXISTS "${PATH_TO_CURRENT_FILE}") diff --git a/compiler-rt/lib/asan/asan_internal.h b/compiler-rt/lib/asan/asan_internal.h index 35c887eaf851c..129499dbb6b1e 100644 --- a/compiler-rt/lib/asan/asan_internal.h +++ b/compiler-rt/lib/asan/asan_internal.h @@ -91,7 +91,7 @@ bool PlatformUnpoisonStacks(); // asan_rtl.cpp // Unpoison a region containing a stack. -// Performs a sanity check and warns if the bounds don't look right. +// Performs a soundness check and warns if the bounds don't look right. // The warning contains the type string to identify the stack type. void UnpoisonStack(uptr bottom, uptr top, const char *type); diff --git a/compiler-rt/lib/asan/asan_poisoning.cpp b/compiler-rt/lib/asan/asan_poisoning.cpp index 897a2be13e242..85f73b496ebf9 100644 --- a/compiler-rt/lib/asan/asan_poisoning.cpp +++ b/compiler-rt/lib/asan/asan_poisoning.cpp @@ -494,7 +494,7 @@ void __sanitizer_annotate_contiguous_container(const void *beg_p, old_end, new_end, &stack); } CHECK_LE(storage_end - storage_beg, - FIRST_32_SECOND_64(1UL << 30, 1ULL << 40)); // Sanity check. + FIRST_32_SECOND_64(1UL << 30, 1ULL << 40)); // Soundness check. if (old_end == new_end) return; // Nothing to do here. @@ -508,7 +508,7 @@ void __sanitizer_annotate_contiguous_container(const void *beg_p, // uptr d2 = RoundUpTo(old_mid, granularity); // Currently we should be in this state: // [a, d1) is good, [d2, c) is bad, [d1, d2) is partially good. - // Make a quick sanity check that we are indeed in this state. + // Make a quick soundness check that we are indeed in this state. // // FIXME: Two of these three checks are disabled until we fix // https://github.com/google/sanitizers/issues/258. @@ -568,7 +568,7 @@ void __sanitizer_annotate_double_ended_contiguous_container( storage_beg, storage_end, old_beg, old_end, new_beg, new_end, &stack); } CHECK_LE(storage_end - storage_beg, - FIRST_32_SECOND_64(1UL << 30, 1ULL << 40)); // Sanity check. + FIRST_32_SECOND_64(1UL << 30, 1ULL << 40)); // Soundness check. if ((old_beg == old_end && new_beg == new_end) || (old_beg == new_beg && old_end == new_end)) diff --git a/compiler-rt/lib/asan/asan_stats.cpp b/compiler-rt/lib/asan/asan_stats.cpp index 78cb30ec763d8..aa5e19270d7de 100644 --- a/compiler-rt/lib/asan/asan_stats.cpp +++ b/compiler-rt/lib/asan/asan_stats.cpp @@ -140,7 +140,7 @@ uptr __sanitizer_get_current_allocated_bytes() { GetAccumulatedStats(&stats); uptr malloced = stats.malloced; uptr freed = stats.freed; - // Return sane value if malloced < freed due to racy + // Return sound value if malloced < freed due to racy // way we update accumulated stats. return (malloced > freed) ? malloced - freed : 0; } @@ -159,7 +159,7 @@ uptr __sanitizer_get_free_bytes() { + stats.really_freed; uptr total_used = stats.malloced + stats.malloced_redzones; - // Return sane value if total_free < total_used due to racy + // Return sound value if total_free < total_used due to racy // way we update accumulated stats. return (total_free > total_used) ? total_free - total_used : 0; } diff --git a/compiler-rt/lib/builtins/negdi2.c b/compiler-rt/lib/builtins/negdi2.c index 714ac8ca66d30..c6953b5ba921e 100644 --- a/compiler-rt/lib/builtins/negdi2.c +++ b/compiler-rt/lib/builtins/negdi2.c @@ -15,7 +15,7 @@ // Returns: -a COMPILER_RT_ABI di_int __negdi2(di_int a) { - // Note: this routine is here for API compatibility; any sane compiler + // Note: this routine is here for API compatibility; any sound compiler // should expand it inline. return -(du_int)a; } diff --git a/compiler-rt/lib/builtins/negti2.c b/compiler-rt/lib/builtins/negti2.c index ab6e09ded819f..aade83074cdc6 100644 --- a/compiler-rt/lib/builtins/negti2.c +++ b/compiler-rt/lib/builtins/negti2.c @@ -17,7 +17,7 @@ // Returns: -a COMPILER_RT_ABI ti_int __negti2(ti_int a) { - // Note: this routine is here for API compatibility; any sane compiler + // Note: this routine is here for API compatibility; any sound compiler // should expand it inline. return -(tu_int)a; } diff --git a/compiler-rt/lib/fuzzer/tests/FuzzerUnittest.cpp b/compiler-rt/lib/fuzzer/tests/FuzzerUnittest.cpp index 5315a8ec0167d..bf706ce0f0510 100644 --- a/compiler-rt/lib/fuzzer/tests/FuzzerUnittest.cpp +++ b/compiler-rt/lib/fuzzer/tests/FuzzerUnittest.cpp @@ -647,7 +647,7 @@ TEST(Corpus, Distribution) { Hist[C->ChooseUnitIdxToMutate(Rand)]++; } for (size_t i = 0; i < N; i++) { - // A weak sanity check that every unit gets invoked. + // A weak soundness check that every unit gets invoked. EXPECT_GT(Hist[i], TriesPerUnit / N / 3); } } diff --git a/compiler-rt/lib/hwasan/hwasan_linux.cpp b/compiler-rt/lib/hwasan/hwasan_linux.cpp index 68651d3d39d03..c9cbfa5f55e89 100644 --- a/compiler-rt/lib/hwasan/hwasan_linux.cpp +++ b/compiler-rt/lib/hwasan/hwasan_linux.cpp @@ -251,7 +251,7 @@ bool InitShadow() { // High memory starts where allocated shadow allows. kHighMemStart = ShadowToMem(kHighShadowStart); - // Check the sanity of the defined memory ranges (there might be gaps). + // Check the soundness of the defined memory ranges (there might be gaps). CHECK_EQ(kHighMemStart % GetMmapGranularity(), 0); CHECK_GT(kHighMemStart, kHighShadowEnd); CHECK_GT(kHighShadowEnd, kHighShadowStart); diff --git a/compiler-rt/lib/memprof/memprof_stats.cpp b/compiler-rt/lib/memprof/memprof_stats.cpp index c8faebfa12de1..a3fa3470197e7 100644 --- a/compiler-rt/lib/memprof/memprof_stats.cpp +++ b/compiler-rt/lib/memprof/memprof_stats.cpp @@ -131,7 +131,7 @@ uptr __sanitizer_get_current_allocated_bytes() { GetAccumulatedStats(&stats); uptr malloced = stats.malloced; uptr freed = stats.freed; - // Return sane value if malloced < freed due to racy + // Return sound value if malloced < freed due to racy // way we update accumulated stats. return (malloced > freed) ? malloced - freed : 1; } @@ -147,7 +147,7 @@ uptr __sanitizer_get_free_bytes() { GetAccumulatedStats(&stats); uptr total_free = stats.mmaped - stats.munmaped + stats.really_freed; uptr total_used = stats.malloced; - // Return sane value if total_free < total_used due to racy + // Return sound value if total_free < total_used due to racy // way we update accumulated stats. return (total_free > total_used) ? total_free - total_used : 1; } diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc b/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc index 673f284b6a043..5ca5f8f48eb8e 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc +++ b/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc @@ -539,7 +539,7 @@ static bool ioctl_decode(unsigned req, ioctl_desc *desc) { desc->req = req; desc->name = ""; desc->size = IOC_SIZE(req); - // Sanity check. + // Soundness check. if (desc->size > 0xFFFF) return false; unsigned dir = IOC_DIR(req); switch (dir) { @@ -560,7 +560,7 @@ static bool ioctl_decode(unsigned req, ioctl_desc *desc) { } // Size can be 0 iff type is NONE. if ((desc->type == IOC_NONE) != (desc->size == 0)) return false; - // Sanity check. + // Soundness check. if (IOC_TYPE(req) == 0) return false; return true; } @@ -572,8 +572,8 @@ static const ioctl_desc *ioctl_lookup(unsigned req) { // Try stripping access size from the request id. desc = ioctl_table_lookup(req & ~(IOC_SIZEMASK << IOC_SIZESHIFT)); - // Sanity check: requests that encode access size are either read or write and - // have size of 0 in the table. + // Soundness check: requests that encode access size are either read or write + // and have size of 0 in the table. if (desc && desc->size == 0 && (desc->type == ioctl_desc::READWRITE || desc->type == ioctl_desc::WRITE || desc->type == ioctl_desc::READ)) diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp index ca37df348580a..0d12e52ddd242 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp @@ -120,7 +120,7 @@ void FlagParser::parse_flags(const char *env_option_name) { parse_flag(env_option_name); } - // Do a sanity check for certain flags. + // Do a soundness check for certain flags. if (common_flags_dont_use.malloc_context_size < 1) common_flags_dont_use.malloc_context_size = 1; } diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc b/compiler-rt/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc index 16b2a10d8b069..3ba177af11ddd 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc +++ b/compiler-rt/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc @@ -1455,7 +1455,7 @@ static bool ioctl_decode(unsigned req, ioctl_desc *desc) { desc->req = req; desc->name = ""; desc->size = IOC_SIZE(req); - // Sanity check. + // Soundness check. if (desc->size > 0xFFFF) return false; unsigned dir = IOC_DIR(req); @@ -1478,7 +1478,7 @@ static bool ioctl_decode(unsigned req, ioctl_desc *desc) { // Size can be 0 iff type is NONE. if ((desc->type == IOC_NONE) != (desc->size == 0)) return false; - // Sanity check. + // Soundness check. if (IOC_TYPE(req) == 0) return false; return true; @@ -1491,8 +1491,8 @@ static const ioctl_desc *ioctl_lookup(unsigned req) { // Try stripping access size from the request id. desc = ioctl_table_lookup(req & ~(IOC_SIZEMASK << IOC_SIZESHIFT)); - // Sanity check: requests that encode access size are either read or write and - // have size of 0 in the table. + // Soundness check: requests that encode access size are either read or write + // and have size of 0 in the table. if (desc && desc->size == 0 && (desc->type == ioctl_desc::READWRITE || desc->type == ioctl_desc::WRITE || desc->type == ioctl_desc::READ)) diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_libc.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_libc.cpp index 9318066afed20..2ad2c8fa9d923 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_libc.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_libc.cpp @@ -296,7 +296,7 @@ uptr internal_wcsnlen(const wchar_t *s, uptr maxlen) { } bool mem_is_zero(const char *beg, uptr size) { - CHECK_LE(size, 1ULL << FIRST_32_SECOND_64(30, 40)); // Sanity check. + CHECK_LE(size, 1ULL << FIRST_32_SECOND_64(30, 40)); // Soundness check. const char *end = beg + size; uptr *aligned_beg = (uptr *)RoundUpTo((uptr)beg, sizeof(uptr)); uptr *aligned_end = (uptr *)RoundDownTo((uptr)end, sizeof(uptr)); diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp index 87a18b1120af6..882e445d681aa 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp @@ -626,7 +626,7 @@ bool FileExists(const char *filename) { struct stat st; if (internal_stat(filename, &st)) return false; - // Sanity check: filename is a regular file. + // Soundness check: filename is a regular file. return S_ISREG(st.st_mode); } diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp index d4811ff4ed217..83dc2025ed35a 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp @@ -383,7 +383,7 @@ bool FileExists(const char *filename) { struct stat st; if (stat(filename, &st)) return false; - // Sanity check: filename is a regular file. + // Soundness check: filename is a regular file. return S_ISREG(st.st_mode); } diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp index b1eb2009cf157..5f7190d2effd8 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp @@ -205,7 +205,7 @@ void UnsetAlternateSignalStack() { stack_t altstack, oldstack; altstack.ss_sp = nullptr; altstack.ss_flags = SS_DISABLE; - altstack.ss_size = GetAltStackSize(); // Some sane value required on Darwin. + altstack.ss_size = GetAltStackSize(); // Some sound value required on Darwin. CHECK_EQ(0, sigaltstack(&altstack, &oldstack)); UnmapOrDie(oldstack.ss_sp, oldstack.ss_size); } diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp index d24fae98213aa..969818694746f 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp @@ -96,12 +96,12 @@ static inline uhwptr *GetCanonicFrame(uptr bp, void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top, uptr stack_bottom, u32 max_depth) { - // TODO(yln): add arg sanity check for stack_top/stack_bottom + // TODO(yln): add arg soundness check for stack_top/stack_bottom CHECK_GE(max_depth, 2); const uptr kPageSize = GetPageSizeCached(); trace_buffer[0] = pc; size = 1; - if (stack_top < 4096) return; // Sanity check for stack top. + if (stack_top < 4096) return; // Soundness check for stack top. uhwptr *frame = GetCanonicFrame(bp, stack_top, stack_bottom); // Lowest possible address that makes sense as the next frame pointer. // Goes up as we walk the stack. diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_sparc.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_sparc.cpp index 74f435287af3c..71251167d0cb3 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_sparc.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_sparc.cpp @@ -27,12 +27,12 @@ namespace __sanitizer { void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top, uptr stack_bottom, u32 max_depth) { - // TODO(yln): add arg sanity check for stack_top/stack_bottom + // TODO(yln): add arg soundness check for stack_top/stack_bottom CHECK_GE(max_depth, 2); const uptr kPageSize = GetPageSizeCached(); trace_buffer[0] = pc; size = 1; - if (stack_top < 4096) return; // Sanity check for stack top. + if (stack_top < 4096) return; // Soundness check for stack top. // Flush register windows to memory #if defined(__sparc_v9__) || defined(__sparcv9__) || defined(__sparcv9) asm volatile("flushw" ::: "memory"); diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp index ed4f60deeffc8..2ee43e82fa456 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp @@ -382,7 +382,7 @@ bool MprotectReadWrite(uptr addr, uptr size) { void ReleaseMemoryPagesToOS(uptr beg, uptr end) { uptr beg_aligned = RoundDownTo(beg, GetPageSizeCached()), end_aligned = RoundDownTo(end, GetPageSizeCached()); - CHECK(beg < end); // make sure the region is sane + CHECK(beg < end); // make sure the region is sound if (beg_aligned == end_aligned) // make sure we're freeing at least 1 page; return; UnmapOrDie((void *)beg, end_aligned - beg_aligned); diff --git a/compiler-rt/lib/sanitizer_common/tests/sanitizer_procmaps_test.cpp b/compiler-rt/lib/sanitizer_common/tests/sanitizer_procmaps_test.cpp index 00542b944f516..e6f3fa8344877 100644 --- a/compiler-rt/lib/sanitizer_common/tests/sanitizer_procmaps_test.cpp +++ b/compiler-rt/lib/sanitizer_common/tests/sanitizer_procmaps_test.cpp @@ -47,7 +47,7 @@ TEST(MemoryMappingLayout, DumpListOfModules) { bool found = false; for (uptr i = 0; i < modules.size(); ++i) { if (modules[i].containsAddress((uptr)&noop)) { - // Verify that the module name is sane. + // Verify that the module name is sound. if (strstr(modules[i].full_name(), binary_name) != 0) found = true; } diff --git a/compiler-rt/lib/scudo/standalone/report.h b/compiler-rt/lib/scudo/standalone/report.h index c397dd3fc9c65..333952852a66f 100644 --- a/compiler-rt/lib/scudo/standalone/report.h +++ b/compiler-rt/lib/scudo/standalone/report.h @@ -26,7 +26,7 @@ void NORETURN reportInvalidFlag(const char *FlagType, const char *Value); // Chunk header related errors. void NORETURN reportHeaderCorruption(void *Header, const void *Ptr); -// Sanity checks related error. +// Soundness checks related error. void NORETURN reportSanityCheckError(const char *Field); // Combined allocator errors. diff --git a/compiler-rt/lib/tsan/rtl/CMakeLists.txt b/compiler-rt/lib/tsan/rtl/CMakeLists.txt index d7d84706bfd58..bf7d2e79e6129 100644 --- a/compiler-rt/lib/tsan/rtl/CMakeLists.txt +++ b/compiler-rt/lib/tsan/rtl/CMakeLists.txt @@ -118,7 +118,7 @@ endif() if(APPLE) # Ideally we would check the SDK version for the actual platform we are # building for here. To make our lifes easier we assume the host SDK setup is - # sane and use the macOS SDK version as a proxy for aligned SDKs. + # sound and use the macOS SDK version as a proxy for aligned SDKs. find_darwin_sdk_version(macosx_sdk_version "macosx") if ("${macosx_sdk_version}" VERSION_LESS 10.12) message(FATAL_ERROR "Building the TSan runtime requires at least macOS SDK 10.12 (or aligned SDK on other platforms)") diff --git a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp index 0d7247a56a4c2..8641ee05da943 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp +++ b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp @@ -537,11 +537,11 @@ void DontNeedShadowFor(uptr addr, uptr size) { #if !SANITIZER_GO // We call UnmapShadow before the actual munmap, at that point we don't yet -// know if the provided address/size are sane. We can't call UnmapShadow +// know if the provided address/size are sound. We can't call UnmapShadow // after the actual munmap becuase at that point the memory range can // already be reused for something else, so we can't rely on the munmap -// return value to understand is the values are sane. -// While calling munmap with insane values (non-canonical address, negative +// return value to understand is the values are sound. +// While calling munmap with unsound values (non-canonical address, negative // size, etc) is an error, the kernel won't crash. We must also try to not // crash as the failure mode is very confusing (paging fault inside of the // runtime on some derived shadow address). diff --git a/compiler-rt/lib/tsan/rtl/tsan_rtl_access.cpp b/compiler-rt/lib/tsan/rtl/tsan_rtl_access.cpp index b2e70475e0b73..6fa618366f7cd 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_rtl_access.cpp +++ b/compiler-rt/lib/tsan/rtl/tsan_rtl_access.cpp @@ -554,7 +554,7 @@ static void MemoryRangeSet(uptr addr, uptr size, RawShadow val) { return; DCHECK_EQ(addr % kShadowCell, 0); DCHECK_EQ(size % kShadowCell, 0); - // If a user passes some insane arguments (memset(0)), + // If a user passes some unsound arguments (memset(0)), // let it just crash as usual. if (!IsAppMem(addr) || !IsAppMem(addr + size - 1)) return; diff --git a/compiler-rt/lib/ubsan/ubsan_type_hash.h b/compiler-rt/lib/ubsan/ubsan_type_hash.h index e42884b765a0a..fe96aaf3a1bc1 100644 --- a/compiler-rt/lib/ubsan/ubsan_type_hash.h +++ b/compiler-rt/lib/ubsan/ubsan_type_hash.h @@ -52,7 +52,7 @@ bool checkDynamicType(void *Object, void *Type, HashValue Hash); const unsigned VptrTypeCacheSize = 128; -/// A sanity check for Vtable. Offsets to top must be reasonably small +/// A soundness check for Vtable. Offsets to top must be reasonably small /// numbers (by absolute value). It's a weak check for Vtable corruption. const int VptrMaxOffsetToTop = 1<<20; diff --git a/compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp b/compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp index 106fa1b85a558..e0fbab3ac84b1 100644 --- a/compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp +++ b/compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp @@ -47,7 +47,7 @@ __ubsan::getDynamicTypeInfoFromVtable(void *VtablePtr) { // The virtual table may not have a complete object locator if the object // was compiled without RTTI (i.e. we might be reading from some other global // laid out before the virtual table), so we need to carefully validate each - // pointer dereference and perform sanity checks. + // pointer dereference and perform soundness checks. CompleteObjectLocator **obj_locator_ptr = ((CompleteObjectLocator**)VtablePtr)-1; if (!IsAccessibleMemoryRange((uptr)obj_locator_ptr, sizeof(void*))) diff --git a/compiler-rt/lib/xray/tests/CMakeLists.txt b/compiler-rt/lib/xray/tests/CMakeLists.txt index 6b9d9ced9a1df..8795cb8470230 100644 --- a/compiler-rt/lib/xray/tests/CMakeLists.txt +++ b/compiler-rt/lib/xray/tests/CMakeLists.txt @@ -3,7 +3,7 @@ include_directories(..) add_custom_target(XRayUnitTests) set_target_properties(XRayUnitTests PROPERTIES FOLDER "Compiler-RT/Tests") -# Sanity check XRAY_ALL_SOURCE_FILES_ABS_PATHS +# Soundness check XRAY_ALL_SOURCE_FILES_ABS_PATHS list(LENGTH XRAY_ALL_SOURCE_FILES_ABS_PATHS XASFAP_LENGTH) if (${XASFAP_LENGTH} EQUAL 0) message(FATAL_ERROR "XRAY_ALL_SOURCE_FILES_ABS_PATHS cannot be empty") diff --git a/compiler-rt/test/BlocksRuntime/byrefsanity.c b/compiler-rt/test/BlocksRuntime/byrefsanity.c index a37fa2571d472..4be3dfe360af7 100644 --- a/compiler-rt/test/BlocksRuntime/byrefsanity.c +++ b/compiler-rt/test/BlocksRuntime/byrefsanity.c @@ -17,7 +17,7 @@ main(int argc, char *argv[]) __block int var = 0; void (^b)(void) = ^{ var++; }; - //sanity(b); + //soundness(b); b(); printf("%s: success!\n", argv[0]); return 0; diff --git a/compiler-rt/test/asan/TestCases/Linux/syscalls.cpp b/compiler-rt/test/asan/TestCases/Linux/syscalls.cpp index b4cb1a08dcfa1..2782ba4eb1ed5 100644 --- a/compiler-rt/test/asan/TestCases/Linux/syscalls.cpp +++ b/compiler-rt/test/asan/TestCases/Linux/syscalls.cpp @@ -10,7 +10,7 @@ #include /* Test the presence of __sanitizer_syscall_ in the tool runtime, and general - sanity of their behaviour. */ + soundness of their behaviour. */ int main(int argc, char *argv[]) { char buf[1000]; diff --git a/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp b/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp index 8e7d5082d0b5d..6d3b0095aad42 100644 --- a/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp +++ b/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp @@ -99,7 +99,7 @@ void setSignalAlternateStack(void *AltStack) { // We want to test reliably that __asan_handle_no_return can properly unpoison // the signal alternate stack. void *threadFun(void *AltStack) { - // first test on default stack (sanity check), no signal alternate stack set + // first test on default stack (soundness check), no signal alternate stack set testOnCurrentStack(); setSignalAlternateStack(AltStack); diff --git a/compiler-rt/test/asan/TestCases/sanity_check_pure_c.c b/compiler-rt/test/asan/TestCases/sanity_check_pure_c.c index 9d74996e43c55..d35b7511eddac 100644 --- a/compiler-rt/test/asan/TestCases/sanity_check_pure_c.c +++ b/compiler-rt/test/asan/TestCases/sanity_check_pure_c.c @@ -1,8 +1,8 @@ -// Sanity checking a test in pure C. +// Soundness checking a test in pure C. // RUN: %clang_asan -O2 %s -o %t // RUN: not %run %t 2>&1 | FileCheck %s -// Sanity checking a test in pure C with -pie. +// Soundness checking a test in pure C with -pie. // RUN: %clang_asan -O2 %s %pie %fPIE -o %t // RUN: not %run %t 2>&1 | FileCheck %s // REQUIRES: stable-runtime diff --git a/compiler-rt/test/builtins/Unit/atomic_test.c b/compiler-rt/test/builtins/Unit/atomic_test.c index 346c9b3be55a7..059451d267dff 100644 --- a/compiler-rt/test/builtins/Unit/atomic_test.c +++ b/compiler-rt/test/builtins/Unit/atomic_test.c @@ -9,7 +9,7 @@ //===----------------------------------------------------------------------===// // // This file performs some simple testing of the support functions for the -// atomic builtins. All tests are single-threaded, so this is only a sanity +// atomic builtins. All tests are single-threaded, so this is only a soundness // check. // //===----------------------------------------------------------------------===// diff --git a/compiler-rt/test/builtins/Unit/lit.cfg.py b/compiler-rt/test/builtins/Unit/lit.cfg.py index 59da054848f3c..c87d6cde4399d 100644 --- a/compiler-rt/test/builtins/Unit/lit.cfg.py +++ b/compiler-rt/test/builtins/Unit/lit.cfg.py @@ -189,7 +189,7 @@ def build_invocation(compile_flags): # Add features for available sources builtins_source_features = config.builtins_lit_source_features.split(";") -# Sanity checks +# Soundness checks if not builtins_source_features: lit_config.fatal("builtins_source_features cannot be empty") builtins_source_features_set = set() diff --git a/compiler-rt/test/fuzzer/fuzzer-custommutator.test b/compiler-rt/test/fuzzer/fuzzer-custommutator.test index 314530415746c..1082a8b40f2cd 100644 --- a/compiler-rt/test/fuzzer/fuzzer-custommutator.test +++ b/compiler-rt/test/fuzzer/fuzzer-custommutator.test @@ -12,7 +12,7 @@ LLVMFuzzerCustomMutatorWithLenControl: In LLVMFuzzerCustomMutator LLVMFuzzerCustomMutatorWithLenControl: {{.*}} lim: {{[1-9][0-9]?}} {{.*}} LLVMFuzzerCustomMutatorWithLenControl: BINGO -# sanity check: verify that we do get long lines with verbose printing on +# soundness check: verify that we do get long lines with verbose printing on RUN: %cpp_compiler %S/CustomMutatorWithLongSequencesTest.cpp -o %t-CustomMutatorWithLongSequencesTest RUN: not %run %t-CustomMutatorWithLongSequencesTest -verbosity=2 2>&1 | FileCheck %s --check-prefix=LLVMFuzzerCustomMutatorLongSequence LLVMFuzzerCustomMutatorLongSequence: Flag: verbosity 2 diff --git a/compiler-rt/test/fuzzer/reload.test b/compiler-rt/test/fuzzer/reload.test index 62321cec3b04f..2b74a4a441952 100644 --- a/compiler-rt/test/fuzzer/reload.test +++ b/compiler-rt/test/fuzzer/reload.test @@ -8,6 +8,6 @@ RUN: not %run %t-ReloadTest %t.crash 2>&1 | FileCheck %s --check-prefix=ARTIFACT ARTIFACT: Running: {{.*}}reload.test.tmp.crash ARTIFACT: ERROR: libFuzzer: deadly signal -# Sanity check that altered artifact is not going to crash +# Soundness check that altered artifact is not going to crash RUN: echo z >> %t.crash RUN: %run %t-ReloadTest %t.crash diff --git a/compiler-rt/test/hwasan/TestCases/Linux/syscalls.cpp b/compiler-rt/test/hwasan/TestCases/Linux/syscalls.cpp index 154b698989935..e7380097d97d6 100644 --- a/compiler-rt/test/hwasan/TestCases/Linux/syscalls.cpp +++ b/compiler-rt/test/hwasan/TestCases/Linux/syscalls.cpp @@ -15,7 +15,7 @@ #include /* Test the presence of __sanitizer_syscall_ in the tool runtime, and general - sanity of their behaviour. */ + soundness of their behaviour. */ int main(int argc, char *argv[]) { // lit.cfg.py currently sets 'disable_allocator_tagging=1' diff --git a/compiler-rt/test/hwasan/TestCases/sanitizer_malloc.cpp b/compiler-rt/test/hwasan/TestCases/sanitizer_malloc.cpp index cf1dc0741bead..382cee750e335 100644 --- a/compiler-rt/test/hwasan/TestCases/sanitizer_malloc.cpp +++ b/compiler-rt/test/hwasan/TestCases/sanitizer_malloc.cpp @@ -23,7 +23,7 @@ int main() { sink = (void *)&__sanitizer_reallocarray; sink = (void *)&__sanitizer_malloc; - // sanity check + // soundness check void *p = __sanitizer_malloc(100); p = __sanitizer_realloc(p, 200); __sanitizer_free(p); diff --git a/compiler-rt/test/msan/Linux/syscalls.cpp b/compiler-rt/test/msan/Linux/syscalls.cpp index e9525a5796ec4..71a199cd6d4dc 100644 --- a/compiler-rt/test/msan/Linux/syscalls.cpp +++ b/compiler-rt/test/msan/Linux/syscalls.cpp @@ -18,7 +18,7 @@ #include /* Test the presence of __sanitizer_syscall_ in the tool runtime, and general - sanity of their behaviour. */ + soundness of their behaviour. */ int main(int argc, char *argv[]) { char buf[1000] __attribute__((aligned(8))); diff --git a/compiler-rt/test/safestack/canary.c b/compiler-rt/test/safestack/canary.c index 1ceaa50656f60..cdea34829fb42 100644 --- a/compiler-rt/test/safestack/canary.c +++ b/compiler-rt/test/safestack/canary.c @@ -18,7 +18,7 @@ __attribute__((noinline)) void f(unsigned *y) { char *volatile p = &x; char *volatile q = (char *)y; assert(p < q); - assert(q - p < 1024); // sanity + assert(q - p < 1024); // soundness // This has technically undefined behavior, but we know the actual layout of // the unsafe stack and this should not touch anything important. memset(&x, 0xab, q - p + sizeof(*y)); diff --git a/compiler-rt/utils/generate_netbsd_ioctls.awk b/compiler-rt/utils/generate_netbsd_ioctls.awk index 89c32ae32aa24..1a7760b52fe82 100755 --- a/compiler-rt/utils/generate_netbsd_ioctls.awk +++ b/compiler-rt/utils/generate_netbsd_ioctls.awk @@ -387,7 +387,7 @@ END { pcmd(" desc->req = req;") pcmd(" desc->name = \"\";") pcmd(" desc->size = IOC_SIZE(req);") - pcmd(" // Sanity check.") + pcmd(" // Soundness check.") pcmd(" if (desc->size > 0xFFFF) return false;") pcmd(" unsigned dir = IOC_DIR(req);") pcmd(" switch (dir) {") @@ -408,7 +408,7 @@ END { pcmd(" }") pcmd(" // Size can be 0 iff type is NONE.") pcmd(" if ((desc->type == IOC_NONE) != (desc->size == 0)) return false;") - pcmd(" // Sanity check.") + pcmd(" // Soundness check.") pcmd(" if (IOC_TYPE(req) == 0) return false;") pcmd(" return true;") pcmd("}") @@ -419,7 +419,7 @@ END { pcmd("") pcmd(" // Try stripping access size from the request id.") pcmd(" desc = ioctl_table_lookup(req & ~(IOC_SIZEMASK << IOC_SIZESHIFT));") - pcmd(" // Sanity check: requests that encode access size are either read or write and") + pcmd(" // Soundness check: requests that encode access size are either read or write and") pcmd(" // have size of 0 in the table.") pcmd(" if (desc && desc->size == 0 &&") pcmd(" (desc->type == ioctl_desc::READWRITE || desc->type == ioctl_desc::WRITE ||") diff --git a/compiler-rt/utils/generate_netbsd_syscalls.awk b/compiler-rt/utils/generate_netbsd_syscalls.awk index 5a3be0a7d2dc9..3db3c29e0892b 100755 --- a/compiler-rt/utils/generate_netbsd_syscalls.awk +++ b/compiler-rt/utils/generate_netbsd_syscalls.awk @@ -45,7 +45,7 @@ BEGIN { usage() } - # sanity check that the path ends with "syscall.master" + # soundness check that the path ends with "syscall.master" if (ARGV[1] !~ /syscalls\.master$/) { usage() } diff --git a/flang-rt/unittests/Runtime/CharacterTest.cpp b/flang-rt/unittests/Runtime/CharacterTest.cpp index 2c7af27b9da77..e353e42577676 100644 --- a/flang-rt/unittests/Runtime/CharacterTest.cpp +++ b/flang-rt/unittests/Runtime/CharacterTest.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// -// Basic sanity tests of CHARACTER API; exhaustive testing will be done +// Basic soundness tests of CHARACTER API; exhaustive testing will be done // in Fortran. #include "flang/Runtime/character.h" diff --git a/flang-rt/unittests/Runtime/ExternalIOTest.cpp b/flang-rt/unittests/Runtime/ExternalIOTest.cpp index 6c148b1de6f82..16fffe49577ba 100644 --- a/flang-rt/unittests/Runtime/ExternalIOTest.cpp +++ b/flang-rt/unittests/Runtime/ExternalIOTest.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // -// Sanity test for all external I/O modes +// Soundness test for all external I/O modes // //===----------------------------------------------------------------------===// diff --git a/flang/lib/Decimal/decimal-to-binary.cpp b/flang/lib/Decimal/decimal-to-binary.cpp index 94c5177423739..ec35f98abe263 100644 --- a/flang/lib/Decimal/decimal-to-binary.cpp +++ b/flang/lib/Decimal/decimal-to-binary.cpp @@ -367,7 +367,7 @@ BigRadixFloatingPointNumber::ConvertToBinary() { // Shift our perspective on the radix (& decimal) point so that // it sits to the *left* of the digits: i.e., x = .D * 10.**E exponent_ += digits_ * log10Radix; - // Sanity checks for ridiculous exponents + // Soundness checks for ridiculous exponents static constexpr int crazy{2 * Real::decimalRange + log10Radix}; if (exponent_ < -crazy) { enum ConversionResultFlags flags { diff --git a/flang/lib/Evaluate/fold-character.cpp b/flang/lib/Evaluate/fold-character.cpp index a43742ae8dc68..e091813a741d9 100644 --- a/flang/lib/Evaluate/fold-character.cpp +++ b/flang/lib/Evaluate/fold-character.cpp @@ -102,7 +102,7 @@ Expr> FoldIntrinsicFunction( "NCOPIES= argument to REPEAT() should be nonnegative, but is %jd"_err_en_US, static_cast(n)); } else if (static_cast(n) * str.size() > - (1 << 20)) { // sanity limit of 1MiB + (1 << 20)) { // soundness limit of 1MiB context.Warn(common::UsageWarning::FoldingLimit, "Result of REPEAT() is too large to compute at compilation time (%g characters)"_port_en_US, static_cast(n) * str.size()); diff --git a/flang/lib/Evaluate/formatting.cpp b/flang/lib/Evaluate/formatting.cpp index ec5dc0baaa5cb..8c9cae8ee5fb9 100644 --- a/flang/lib/Evaluate/formatting.cpp +++ b/flang/lib/Evaluate/formatting.cpp @@ -292,7 +292,7 @@ llvm::raw_ostream &ProcedureRef::AsFortran(llvm::raw_ostream &o) const { // Operator precedence formatting; insert parentheses around operands // only when necessary. -enum class Precedence { // in increasing order for sane comparisons +enum class Precedence { // in increasing order for sound comparisons DefinedBinary, Or, And, diff --git a/flang/lib/Evaluate/integer.cpp b/flang/lib/Evaluate/integer.cpp index 17a38fa17a67c..416f0cd66502c 100644 --- a/flang/lib/Evaluate/integer.cpp +++ b/flang/lib/Evaluate/integer.cpp @@ -18,7 +18,7 @@ template class Integer<80, isHostLittleEndian, 16, std::uint16_t, std::uint32_t, 128>; template class Integer<128>; -// Sanity checks against misconfiguration bugs +// Soundness checks against misconfiguration bugs static_assert(Integer<8>::partBits == 8); static_assert(std::is_same_v::Part, std::uint8_t>); static_assert(Integer<16>::partBits == 16); diff --git a/flang/lib/Frontend/CompilerInstance.cpp b/flang/lib/Frontend/CompilerInstance.cpp index d97b4b8af6d61..bcdf5444dea2c 100644 --- a/flang/lib/Frontend/CompilerInstance.cpp +++ b/flang/lib/Frontend/CompilerInstance.cpp @@ -154,7 +154,7 @@ bool CompilerInstance::executeAction(FrontendAction &act) { llvm::Triple targetTriple{llvm::Triple(invoc.getTargetOpts().triple)}; - // Set some sane defaults for the frontend. + // Set some sound defaults for the frontend. invoc.setDefaultFortranOpts(); // Update the fortran options based on user-based input. invoc.setFortranOpts(); diff --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp index e91fa2db15fa2..290073cfe727c 100644 --- a/flang/lib/Lower/Bridge.cpp +++ b/flang/lib/Lower/Bridge.cpp @@ -2202,7 +2202,7 @@ class FirConverter : public Fortran::lower::AbstractConverter { *this, bridge.getSemanticsContext(), localSymbols, doConstruct, eval); bool success = loopOp != nullptr; if (success) { - // Sanity check that the builder insertion point is inside the newly + // Soundness check that the builder insertion point is inside the newly // generated loop. assert( loopOp->getRegion(0).isAncestor( diff --git a/flang/lib/Lower/ConvertVariable.cpp b/flang/lib/Lower/ConvertVariable.cpp index 88fc3128d21f7..9448839aacc36 100644 --- a/flang/lib/Lower/ConvertVariable.cpp +++ b/flang/lib/Lower/ConvertVariable.cpp @@ -351,7 +351,7 @@ static mlir::Value genComponentDefaultInit( // Pointer or allocatable without initialization. // Create deallocated/disassociated value. // From a standard point of view, pointer without initialization do not - // need to be disassociated, but for sanity and simplicity, do it in + // need to be disassociated, but for soundness and simplicity, do it in // global constructor since this has no runtime cost. componentValue = fir::factory::createUnallocatedBox(builder, loc, componentTy, {}); diff --git a/flang/lib/Optimizer/Builder/FIRBuilder.cpp b/flang/lib/Optimizer/Builder/FIRBuilder.cpp index b6501fd530992..bee9ef6388136 100644 --- a/flang/lib/Optimizer/Builder/FIRBuilder.cpp +++ b/flang/lib/Optimizer/Builder/FIRBuilder.cpp @@ -1185,7 +1185,7 @@ fir::factory::getTypeParams(mlir::Location loc, fir::FirOpBuilder &builder, if (box.isDerivedWithLenParameters()) { // This should generate code to read the type parameters from the box. // This requires some consideration however as MutableBoxValues need to be - // in a sane state to be provide the correct values. + // in a sound state to be provide the correct values. TODO(loc, "derived type with type parameters"); } return {}; diff --git a/flang/lib/Parser/preprocessor.cpp b/flang/lib/Parser/preprocessor.cpp index 9176b4db3408a..340e2cd57d216 100644 --- a/flang/lib/Parser/preprocessor.cpp +++ b/flang/lib/Parser/preprocessor.cpp @@ -177,7 +177,7 @@ static TokenSequence TokenPasting(TokenSequence &&text) { bool doPaste{false}; char last{before->back()}; char first{after.front()}; - // Apply basic sanity checking to pasting so avoid constructing a bogus + // Apply basic soundness checking to pasting so avoid constructing a bogus // token that might cause macro replacement to fail, like "macro(". if (IsLegalInIdentifier(last) && IsLegalInIdentifier(first)) { doPaste = true; diff --git a/flang/test/Driver/fopenmp.f90 b/flang/test/Driver/fopenmp.f90 index f7e83e0eeb734..11bf897d2c36a 100644 --- a/flang/test/Driver/fopenmp.f90 +++ b/flang/test/Driver/fopenmp.f90 @@ -51,7 +51,7 @@ ! CHECK-LD-IOMP5MD: "{{.*}}ld{{(.exe)?}}" ! CHECK-LD-IOMP5MD: "-liomp5md" ! -! We'd like to check that the default is sane, but until we have the ability +! We'd like to check that the default is sound, but until we have the ability ! to *always* semantically analyze OpenMP without always generating runtime ! calls (in the event of an unsupported runtime), we don't have a good way to ! test the FC1 invocation. Instead, just ensure we do eventually link *some* diff --git a/flang/test/Fir/convert-to-llvm.fir b/flang/test/Fir/convert-to-llvm.fir index cd87bf8d28ed5..c7bb65fe08b2e 100644 --- a/flang/test/Fir/convert-to-llvm.fir +++ b/flang/test/Fir/convert-to-llvm.fir @@ -2806,7 +2806,7 @@ func.func @test_coordinate_of_tuple(%tup : !fir.ref>>) { // Test `fir.coordinate_of` conversion - items inside `!fir.ptr`. This should // be almost identical to `!fir.ref` (i.e. it's the same code path in the code -// gen). Instead of duplicating the tests, only one for sanity-checking is added. +// gen). Instead of duplicating the tests, only one for soundness-checking is added. // 6.1. `fir.array` func.func @coordinate_array_unknown_size_1d(%arg0: !fir.ptr>, %arg1 : index) { diff --git a/flang/test/Semantics/modfile55.cuf b/flang/test/Semantics/modfile55.cuf index 2338b745d8355..36d4ea9d3ff09 100644 --- a/flang/test/Semantics/modfile55.cuf +++ b/flang/test/Semantics/modfile55.cuf @@ -1,5 +1,5 @@ ! RUN: %python %S/test_modfile.py %s %flang_fc1 -! Sanity check for CUDA Fortran attributes in module files +! Soundness check for CUDA Fortran attributes in module files module m attributes(device) dd real, managed, allocatable :: md diff --git a/flang/test/Semantics/resolve59.f90 b/flang/test/Semantics/resolve59.f90 index a598fbe1849f3..14e128ddb4189 100644 --- a/flang/test/Semantics/resolve59.f90 +++ b/flang/test/Semantics/resolve59.f90 @@ -58,7 +58,7 @@ real function rfunc(x) !ERROR: Actual argument for 'x=' may not be a procedure x = acos(f5) end function - ! Sanity test: f18 handles C1560 violation by ignoring RESULT + ! Soundness test: f18 handles C1560 violation by ignoring RESULT !WARNING: The function name should not appear in RESULT; references to 'f6' inside the function will be considered as references to the result only [-Whomonymous-result] function f6() result(f6) end function diff --git a/flang/test/Semantics/symbol19.f90 b/flang/test/Semantics/symbol19.f90 index 541c5ccbf9468..829f6e3e32301 100644 --- a/flang/test/Semantics/symbol19.f90 +++ b/flang/test/Semantics/symbol19.f90 @@ -25,7 +25,7 @@ subroutine expect_intrinsic call system_clock(icount) end subroutine -! Sanity check that the EXTERNAL attribute is not bypassed by +! Soundness check that the EXTERNAL attribute is not bypassed by ! implicit intrinsic resolution, even if it otherwise perfectly ! matches an intrinsic call. diff --git a/flang/unittests/Frontend/CompilerInstanceTest.cpp b/flang/unittests/Frontend/CompilerInstanceTest.cpp index 8621c14029c15..6600fe863f313 100644 --- a/flang/unittests/Frontend/CompilerInstanceTest.cpp +++ b/flang/unittests/Frontend/CompilerInstanceTest.cpp @@ -50,7 +50,7 @@ TEST(CompilerInstance, SanityCheckForFileManager) { compInst.getAllSources().Open(testFilePath, errorStream); // 3. Verify the content of the input file - // This is just a sanity check to make sure that CompilerInstance is capable + // This is just a soundness check to make sure that CompilerInstance is capable // of reading input files. llvm::ArrayRef fileContent = sf->content(); EXPECT_FALSE(fileContent.size() == 0); diff --git a/libcxx/docs/DesignDocs/FileTimeType.rst b/libcxx/docs/DesignDocs/FileTimeType.rst index 946c9e515fb9b..b3560ee46c9fa 100644 --- a/libcxx/docs/DesignDocs/FileTimeType.rst +++ b/libcxx/docs/DesignDocs/FileTimeType.rst @@ -82,7 +82,7 @@ and with nanosecond resolution). To get the same range, we would need to drop our resolution to that of seconds to come close to having the same range. -This begs the question, is the range problem "really a problem"? Sane usages +This begs the question, is the range problem "really a problem"? Sound usages of file time stamps shouldn't exceed +/- 300 years, so should we care to support it? I believe the answer is yes. We're not designing the filesystem time API, we're @@ -110,7 +110,7 @@ to throw in cases where the user was confident the call should succeed. (See bel assert(result != -1); } - // Called elsewhere to set the file time to something insane, and way + // Called elsewhere to set the file time to something unsound, and way // out of the 300 year range we might expect. void some_bad_persons_code() { struct timespec new_times; diff --git a/libcxx/docs/Status/Cxx20Papers.csv b/libcxx/docs/Status/Cxx20Papers.csv index 91fcd9ee08315..07ad9d2ac7630 100644 --- a/libcxx/docs/Status/Cxx20Papers.csv +++ b/libcxx/docs/Status/Cxx20Papers.csv @@ -59,7 +59,7 @@ "`P0591R4 `__","Utility functions to implement uses-allocator construction","2018-11 (San Diego)","|Partial|","","The changes in [mem.poly.allocator.mem] are missing" "`P0595R2 `__","std::is_constant_evaluated()","2018-11 (San Diego)","|Complete|","9","" "`P0602R4 `__","variant and optional should propagate copy/move triviality","2018-11 (San Diego)","|Complete|","8","" -"`P0608R3 `__","A sane variant converting constructor","2018-11 (San Diego)","|Complete|","9","" +"`P0608R3 `__","A sound variant converting constructor","2018-11 (San Diego)","|Complete|","9","" "`P0655R1 `__","visit: Explicit Return Type for visit","2018-11 (San Diego)","|Complete|","12","" "`P0771R1 `__","std::function move constructor should be noexcept","2018-11 (San Diego)","|Complete|","6","" "`P0896R4 `__","The One Ranges Proposal","2018-11 (San Diego)","|Complete|","15","" diff --git a/libcxx/include/__cxx03/__hash_table b/libcxx/include/__cxx03/__hash_table index 30c0fbf4049da..eff5c2a52d8b7 100644 --- a/libcxx/include/__cxx03/__hash_table +++ b/libcxx/include/__cxx03/__hash_table @@ -658,7 +658,7 @@ public: typedef typename _NodeTypes::__next_pointer __next_pointer; private: - // check for sane allocator pointer rebinding semantics. Rebinding the + // check for sound allocator pointer rebinding semantics. Rebinding the // allocator for a new pointer type should be exactly the same as rebinding // the pointer using 'pointer_traits'. static_assert(is_same<__node_pointer, typename __node_traits::pointer>::value, diff --git a/libcxx/include/__cxx03/__tree b/libcxx/include/__cxx03/__tree index 3773fb485f488..3c7b165cfecbf 100644 --- a/libcxx/include/__cxx03/__tree +++ b/libcxx/include/__cxx03/__tree @@ -897,7 +897,7 @@ public: typedef allocator_traits<__node_allocator> __node_traits; private: - // check for sane allocator pointer rebinding semantics. Rebinding the + // check for sound allocator pointer rebinding semantics. Rebinding the // allocator for a new pointer type should be exactly the same as rebinding // the pointer using 'pointer_traits'. static_assert(is_same<__node_pointer, typename __node_traits::pointer>::value, diff --git a/libcxx/include/__hash_table b/libcxx/include/__hash_table index 91f660d3491e8..5a904e6e44ddb 100644 --- a/libcxx/include/__hash_table +++ b/libcxx/include/__hash_table @@ -675,7 +675,7 @@ public: typedef typename _NodeTypes::__next_pointer __next_pointer; private: - // check for sane allocator pointer rebinding semantics. Rebinding the + // check for sound allocator pointer rebinding semantics. Rebinding the // allocator for a new pointer type should be exactly the same as rebinding // the pointer using 'pointer_traits'. static_assert(is_same<__node_pointer, typename __node_traits::pointer>::value, diff --git a/libcxx/include/__tree b/libcxx/include/__tree index c5f52f404eff3..b0aee3e36f59c 100644 --- a/libcxx/include/__tree +++ b/libcxx/include/__tree @@ -814,7 +814,7 @@ public: #endif private: - // check for sane allocator pointer rebinding semantics. Rebinding the + // check for sound allocator pointer rebinding semantics. Rebinding the // allocator for a new pointer type should be exactly the same as rebinding // the pointer using 'pointer_traits'. static_assert(is_same<__node_pointer, typename __node_traits::pointer>::value, diff --git a/libcxx/test/libcxx-03/numerics/bit.ops.pass.cpp b/libcxx/test/libcxx-03/numerics/bit.ops.pass.cpp index 0b82f352ffe3d..4d5d36ef96c39 100644 --- a/libcxx/test/libcxx-03/numerics/bit.ops.pass.cpp +++ b/libcxx/test/libcxx-03/numerics/bit.ops.pass.cpp @@ -7,7 +7,7 @@ //===----------------------------------------------------------------------===// // Test the __XXXX routines in the header. -// These are not supposed to be exhaustive tests, just sanity checks. +// These are not supposed to be exhaustive tests, just soundness checks. #include <__cxx03/__bit/countl.h> #include <__cxx03/__bit/rotate.h> diff --git a/libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp b/libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp index 650fecf62128c..e12fd6168e28e 100644 --- a/libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp +++ b/libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp @@ -36,7 +36,7 @@ int main(int, char**) { constexpr size_t D = std::dynamic_extent; - // working case sanity check + // working case soundness check { std::array args{1000, 5}; [[maybe_unused]] std::extents e1(std::span{args}); diff --git a/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp b/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp index 7deb1215de0de..1aa7cfb357f2f 100644 --- a/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp +++ b/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp @@ -92,7 +92,7 @@ int main(int, char**) { // required span size = (3-1)*50 + (10-1) * 3 + 1 = 128 std::extents arg_exts{3, 10}; std::layout_stride::mapping> arg(arg_exts, std::array{50, 3}); - // sanity check: + // soundness check: assert(arg.required_span_size() == 128); // check extents would be constructible [[maybe_unused]] std::extents e(arg_exts); diff --git a/libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.size.pass.cpp b/libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.size.pass.cpp index 9af82701cd4be..31154f05367e6 100644 --- a/libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.size.pass.cpp +++ b/libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.size.pass.cpp @@ -39,7 +39,7 @@ int main(int, char**) { layout_wrapping_integral<4>::mapping> map( std::dextents(100, 3), not_extents_constructible_tag()); std::mdspan, layout_wrapping_integral<4>> mds(data.data(), map); - // sanity check + // soundness check assert(map.required_span_size() == static_cast(12)); // 100 x 3 exceeds 256 { diff --git a/libcxx/test/libcxx/debug/containers/sequence_container_iterators.pass.cpp b/libcxx/test/libcxx/debug/containers/sequence_container_iterators.pass.cpp index c456ff1282d4b..a594933282d3b 100644 --- a/libcxx/test/libcxx/debug/containers/sequence_container_iterators.pass.cpp +++ b/libcxx/test/libcxx/debug/containers/sequence_container_iterators.pass.cpp @@ -66,7 +66,7 @@ struct SequenceContainerChecks : BasicContainerChecks { private: static void SanityTest() { - // sanity test + // soundness test Container C = {1, 1, 1, 1}; ::DoNotOptimize(&C); } diff --git a/libcxx/test/libcxx/input.output/filesystems/convert_file_time.pass.cpp b/libcxx/test/libcxx/input.output/filesystems/convert_file_time.pass.cpp index c501969c31167..9cfe2608ea4b4 100644 --- a/libcxx/test/libcxx/input.output/filesystems/convert_file_time.pass.cpp +++ b/libcxx/test/libcxx/input.output/filesystems/convert_file_time.pass.cpp @@ -289,7 +289,7 @@ int main(int, char**) { TestTimeSpec >::test())); } { - // Test that insane platforms like ppc64 linux, which use long double as time_t, + // Test that unsound platforms like ppc64 linux, which use long double as time_t, // at least compile. assert((test_case, double, TestTimeSpec >::test())); diff --git a/libcxx/test/libcxx/numerics/bit.ops.pass.cpp b/libcxx/test/libcxx/numerics/bit.ops.pass.cpp index 7f502d6e01d1e..9ef00ca81a87a 100644 --- a/libcxx/test/libcxx/numerics/bit.ops.pass.cpp +++ b/libcxx/test/libcxx/numerics/bit.ops.pass.cpp @@ -7,7 +7,7 @@ //===----------------------------------------------------------------------===// // Test the __XXXX routines in the header. -// These are not supposed to be exhaustive tests, just sanity checks. +// These are not supposed to be exhaustive tests, just soundness checks. #include <__bit/bit_log2.h> #include <__bit/countl.h> diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp index abb12d6a3c247..03b20a0edae68 100644 --- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp +++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp @@ -49,7 +49,7 @@ void check_always_lock_free(std::atomic const& a) { } } - // In all cases, also sanity-check it based on the implication always-lock-free => lock-free. + // In all cases, also soundness-check it based on the implication always-lock-free => lock-free. if (is_always_lock_free) { auto is_lock_free = a.is_lock_free(); ASSERT_SAME_TYPE(decltype(is_lock_free), bool); diff --git a/libcxx/test/std/atomics/atomics.ref/is_always_lock_free.pass.cpp b/libcxx/test/std/atomics/atomics.ref/is_always_lock_free.pass.cpp index 78e46c0397951..da7c3e36110fc 100644 --- a/libcxx/test/std/atomics/atomics.ref/is_always_lock_free.pass.cpp +++ b/libcxx/test/std/atomics/atomics.ref/is_always_lock_free.pass.cpp @@ -43,7 +43,7 @@ void check_always_lock_free(std::atomic_ref const& a) { } } - // In all cases, also sanity-check it based on the implication always-lock-free => lock-free. + // In all cases, also soundness-check it based on the implication always-lock-free => lock-free. if (is_always_lock_free) { std::same_as decltype(auto) is_lock_free = a.is_lock_free(); assert(is_lock_free); diff --git a/libcxx/test/std/concepts/concepts.lang/concept.convertible/convertible_to.pass.cpp b/libcxx/test/std/concepts/concepts.lang/concept.convertible/convertible_to.pass.cpp index acc3758944034..df0c593d9739b 100644 --- a/libcxx/test/std/concepts/concepts.lang/concept.convertible/convertible_to.pass.cpp +++ b/libcxx/test/std/concepts/concepts.lang/concept.convertible/convertible_to.pass.cpp @@ -38,7 +38,7 @@ void CheckNotConvertibleTo() { template void CheckIsConvertibleButNotConvertibleTo() { - // Sanity check T is either implicitly xor explicitly convertible to U. + // Soundness check T is either implicitly xor explicitly convertible to U. static_assert(std::is_convertible_v); static_assert(std::is_convertible_v); static_assert(std::is_convertible_v); diff --git a/libcxx/test/std/concepts/concepts.lang/concept.swappable/swappable.pass.cpp b/libcxx/test/std/concepts/concepts.lang/concept.swappable/swappable.pass.cpp index ee8283501569d..b3088d088a7f7 100644 --- a/libcxx/test/std/concepts/concepts.lang/concept.swappable/swappable.pass.cpp +++ b/libcxx/test/std/concepts/concepts.lang/concept.swappable/swappable.pass.cpp @@ -200,7 +200,7 @@ static_assert(std::swappable); static_assert(std::swappable); // All tests for std::swappable are implicitly confirmed by `check_swap`, so we only need to -// sanity check for a few positive cases. +// soundness check for a few positive cases. static_assert(std::swappable); static_assert(std::swappable); static_assert(std::swappable); diff --git a/libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_iter_constraint.compile.pass.cpp b/libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_iter_constraint.compile.pass.cpp index 913e944b3f04c..7c47e27bc2e4f 100644 --- a/libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_iter_constraint.compile.pass.cpp +++ b/libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_iter_constraint.compile.pass.cpp @@ -29,7 +29,7 @@ #include #include -// Sanity-check that std::vector is constructible from two ints... +// Soundness-check that std::vector is constructible from two ints... static_assert(std::is_constructible, int*, int*>::value, ""); static_assert(std::is_constructible, int, int >::value, ""); diff --git a/libcxx/test/std/containers/sequences/array/empty.pass.cpp b/libcxx/test/std/containers/sequences/array/empty.pass.cpp index a2289760b2e96..3d8eea1ecf7d2 100644 --- a/libcxx/test/std/containers/sequences/array/empty.pass.cpp +++ b/libcxx/test/std/containers/sequences/array/empty.pass.cpp @@ -41,7 +41,7 @@ int main(int, char**) { #endif #if TEST_STD_VER >= 11 - // Sanity check for constexpr in C++11 + // Soundness check for constexpr in C++11 { constexpr std::array array = {}; static_assert(!array.empty(), ""); diff --git a/libcxx/test/std/containers/sequences/array/max_size.pass.cpp b/libcxx/test/std/containers/sequences/array/max_size.pass.cpp index af6f25559b8dd..db97b6bfa440f 100644 --- a/libcxx/test/std/containers/sequences/array/max_size.pass.cpp +++ b/libcxx/test/std/containers/sequences/array/max_size.pass.cpp @@ -41,7 +41,7 @@ int main(int, char**) { #endif #if TEST_STD_VER >= 11 - // Sanity check for constexpr in C++11 + // Soundness check for constexpr in C++11 { constexpr std::array array = {}; static_assert(array.max_size() == 3, ""); diff --git a/libcxx/test/std/containers/views/mdspan/extents/conversion.pass.cpp b/libcxx/test/std/containers/views/mdspan/extents/conversion.pass.cpp index 4b6b1a63b80f9..ac21948594923 100644 --- a/libcxx/test/std/containers/views/mdspan/extents/conversion.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/extents/conversion.pass.cpp @@ -75,7 +75,7 @@ constexpr void test_conversion() { constexpr void test_no_implicit_conversion() { constexpr size_t D = std::dynamic_extent; - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, std::extents>, ""); static_assert(std::is_convertible_v, std::extents>, ""); @@ -83,7 +83,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, std::extents>, ""); static_assert(!std::is_convertible_v, std::extents>, ""); - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, std::extents>, ""); static_assert(std::is_convertible_v, std::extents>, ""); @@ -91,7 +91,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, std::extents>, ""); static_assert(!std::is_convertible_v, std::extents>, ""); - // Sanity check that smaller index_type to larger index_type conversion works + // Soundness check that smaller index_type to larger index_type conversion works static_assert(std::is_constructible_v, std::extents>, ""); static_assert(std::is_convertible_v, std::extents>, ""); diff --git a/libcxx/test/std/containers/views/mdspan/layout_left/comparison.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_left/comparison.pass.cpp index 6db8fa48f5def..57bf172c515be 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_left/comparison.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_left/comparison.pass.cpp @@ -46,7 +46,7 @@ template constexpr void test_comparison_different_rank() { constexpr size_t D = std::dynamic_extent; - // sanity check same rank + // soundness check same rank static_assert(compare_layout_mappings(std::extents(5), std::extents(5))); static_assert(compare_layout_mappings(std::extents(), std::extents(5))); static_assert(compare_layout_mappings(std::extents(5), std::extents())); diff --git a/libcxx/test/std/containers/views/mdspan/layout_left/ctor.layout_right.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_left/ctor.layout_right.pass.cpp index f7ea39acf0179..853a1cf9c5156 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_left/ctor.layout_right.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_left/ctor.layout_right.pass.cpp @@ -72,7 +72,7 @@ using ll_mapping_t = std::layout_left::mapping>; constexpr void test_no_implicit_conversion() { constexpr size_t D = std::dynamic_extent; - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, lr_mapping_t>); static_assert(std::is_convertible_v, ll_mapping_t>); @@ -80,7 +80,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, lr_mapping_t>); static_assert(!std::is_convertible_v, ll_mapping_t>); - // Sanity check that smaller index_type to larger index_type conversion works + // Soundness check that smaller index_type to larger index_type conversion works static_assert(std::is_constructible_v, lr_mapping_t>); static_assert(std::is_convertible_v, ll_mapping_t>); diff --git a/libcxx/test/std/containers/views/mdspan/layout_left/ctor.mapping.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_left/ctor.mapping.pass.cpp index 28749327033aa..01e3a1ed5e37f 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_left/ctor.mapping.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_left/ctor.mapping.pass.cpp @@ -77,7 +77,7 @@ using mapping_t = std::layout_left::mapping>; constexpr void test_no_implicit_conversion() { constexpr size_t D = std::dynamic_extent; - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, mapping_t>); static_assert(std::is_convertible_v, mapping_t>); @@ -85,7 +85,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, mapping_t>); static_assert(!std::is_convertible_v, mapping_t>); - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, mapping_t>); static_assert(std::is_convertible_v, mapping_t>); @@ -93,7 +93,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, mapping_t>); static_assert(!std::is_convertible_v, mapping_t>); - // Sanity check that smaller index_type to larger index_type conversion works + // Soundness check that smaller index_type to larger index_type conversion works static_assert(std::is_constructible_v, mapping_t>); static_assert(std::is_convertible_v, mapping_t>); diff --git a/libcxx/test/std/containers/views/mdspan/layout_right/comparison.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_right/comparison.pass.cpp index bcf26e0f53866..7f0e747217665 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_right/comparison.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_right/comparison.pass.cpp @@ -46,7 +46,7 @@ template constexpr void test_comparison_different_rank() { constexpr size_t D = std::dynamic_extent; - // sanity check same rank + // soundness check same rank static_assert(compare_layout_mappings(std::extents(5), std::extents(5))); static_assert(compare_layout_mappings(std::extents(), std::extents(5))); static_assert(compare_layout_mappings(std::extents(5), std::extents())); diff --git a/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_left.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_left.pass.cpp index 8f49b37732616..5083222474d02 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_left.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_left.pass.cpp @@ -72,7 +72,7 @@ using ll_mapping_t = std::layout_left::mapping>; constexpr void test_no_implicit_conversion() { constexpr size_t D = std::dynamic_extent; - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, ll_mapping_t>); static_assert(std::is_convertible_v, lr_mapping_t>); @@ -80,7 +80,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, ll_mapping_t>); static_assert(!std::is_convertible_v, lr_mapping_t>); - // Sanity check that smaller index_type to larger index_type conversion works + // Soundness check that smaller index_type to larger index_type conversion works static_assert(std::is_constructible_v, ll_mapping_t>); static_assert(std::is_convertible_v, lr_mapping_t>); diff --git a/libcxx/test/std/containers/views/mdspan/layout_right/ctor.mapping.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_right/ctor.mapping.pass.cpp index 7a08f694f3103..eed5c4dda5436 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_right/ctor.mapping.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_right/ctor.mapping.pass.cpp @@ -77,7 +77,7 @@ using mapping_t = std::layout_right::mapping>; constexpr void test_no_implicit_conversion() { constexpr size_t D = std::dynamic_extent; - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, mapping_t>); static_assert(std::is_convertible_v, mapping_t>); @@ -85,7 +85,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, mapping_t>); static_assert(!std::is_convertible_v, mapping_t>); - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, mapping_t>); static_assert(std::is_convertible_v, mapping_t>); @@ -93,7 +93,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, mapping_t>); static_assert(!std::is_convertible_v, mapping_t>); - // Sanity check that smaller index_type to larger index_type conversion works + // Soundness check that smaller index_type to larger index_type conversion works static_assert(std::is_constructible_v, mapping_t>); static_assert(std::is_convertible_v, mapping_t>); diff --git a/libcxx/test/std/containers/views/mdspan/layout_stride/comparison.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_stride/comparison.pass.cpp index 37e20a3061f5f..80d4a473ea2de 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_stride/comparison.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_stride/comparison.pass.cpp @@ -44,7 +44,7 @@ template constexpr void test_comparison_different_rank() { constexpr size_t D = std::dynamic_extent; - // sanity check same rank + // soundness check same rank static_assert(layout_mapping_comparable, std::extents>); static_assert(layout_mapping_comparable, std::extents>); static_assert(layout_mapping_comparable, std::extents>); diff --git a/libcxx/test/std/containers/views/mdspan/layout_stride/ctor.strided_mapping.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_stride/ctor.strided_mapping.pass.cpp index 66946d2b77b65..92741a603a5ca 100644 --- a/libcxx/test/std/containers/views/mdspan/layout_stride/ctor.strided_mapping.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/layout_stride/ctor.strided_mapping.pass.cpp @@ -115,7 +115,7 @@ template constexpr void test_no_implicit_conversion() { constexpr size_t D = std::dynamic_extent; - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, FromM>); static_assert(std::is_convertible_v, ToM>); @@ -123,7 +123,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, FromM>); static_assert(!std::is_convertible_v, ToM>); - // Sanity check that one static to dynamic conversion works + // Soundness check that one static to dynamic conversion works static_assert(std::is_constructible_v, FromM>); static_assert(std::is_convertible_v, ToM>); @@ -131,7 +131,7 @@ constexpr void test_no_implicit_conversion() { static_assert(std::is_constructible_v, FromM>); static_assert(!std::is_convertible_v, ToM>); - // Sanity check that smaller index_type to larger index_type conversion works + // Soundness check that smaller index_type to larger index_type conversion works static_assert(std::is_constructible_v, FromM>); static_assert(std::is_convertible_v, ToM>); diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_array.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_array.pass.cpp index f4ceb862d66bc..770869e9a4b49 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_array.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_array.pass.cpp @@ -117,12 +117,12 @@ constexpr void mixin_layout(const H& handle, const A& acc) { mixin_extents(handle, std::layout_left(), acc); mixin_extents(handle, std::layout_right(), acc); - // Sanity check that this layouts mapping is constructible from extents (via its move constructor) + // Soundness check that this layouts mapping is constructible from extents (via its move constructor) static_assert(std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); mixin_extents(handle, layout_wrapping_integral<8>(), acc); - // Sanity check that this layouts mapping is not constructible from extents + // Soundness check that this layouts mapping is not constructible from extents static_assert(!std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); @@ -153,7 +153,7 @@ constexpr bool test() { // test non-constructibility from wrong array type constexpr size_t D = std::dynamic_extent; using mds_t = std::mdspan>; - // sanity check + // soundness check static_assert(std::is_constructible_v>); static_assert(std::is_constructible_v>); // wrong size diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_extents.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_extents.pass.cpp index 4b94dcfed169b..a26711964bc83 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_extents.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_extents.pass.cpp @@ -82,12 +82,12 @@ constexpr void mixin_layout(const H& handle, const A& acc) { mixin_extents(handle, std::layout_right(), acc); // Use weird layout, make sure it has the properties we want to test - // Sanity check that this layouts mapping is constructible from extents (via its move constructor) + // Soundness check that this layouts mapping is constructible from extents (via its move constructor) static_assert(std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); mixin_extents(handle, layout_wrapping_integral<8>(), acc); - // Sanity check that this layouts mapping is not constructible from extents + // Soundness check that this layouts mapping is not constructible from extents static_assert(!std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); @@ -118,7 +118,7 @@ constexpr bool test() { // test non-constructibility from wrong extents type constexpr size_t D = std::dynamic_extent; using mds_t = std::mdspan>; - // sanity check + // soundness check static_assert(std::is_constructible_v>); // wrong size static_assert(!std::is_constructible_v>); diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_integers.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_integers.pass.cpp index ebed92da74138..264241884a982 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_integers.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_integers.pass.cpp @@ -62,7 +62,7 @@ constexpr void test_mdspan_types(const H& handle, const M& map, const A&, Idxs.. } } - // sanity check that concept works + // soundness check that concept works static_assert(check_mdspan_ctor_implicit>); // check that the constructor from integral is explicit static_assert(!check_mdspan_ctor_implicit); @@ -105,12 +105,12 @@ constexpr void mixin_layout(const H& handle, const A& acc) { mixin_extents(handle, std::layout_right(), acc); // Use weird layout, make sure it has the properties we want to test - // Sanity check that this layouts mapping is constructible from extents (via its move constructor) + // Soundness check that this layouts mapping is constructible from extents (via its move constructor) static_assert(std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); mixin_extents(handle, layout_wrapping_integral<8>(), acc); - // Sanity check that this layouts mapping is not constructible from extents + // Soundness check that this layouts mapping is not constructible from extents static_assert(!std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); @@ -141,7 +141,7 @@ constexpr bool test() { // test non-constructibility from wrong integer types constexpr size_t D = std::dynamic_extent; using mds_t = std::mdspan>; - // sanity check + // soundness check static_assert(std::is_constructible_v); static_assert(std::is_constructible_v); // wrong number of arguments diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map.pass.cpp index 2260e679aa288..b0a8b8bc675a1 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map.pass.cpp @@ -106,7 +106,7 @@ constexpr bool test() { constexpr size_t D = std::dynamic_extent; using mds_t = std::mdspan>; - // sanity check + // soundness check static_assert(std::is_constructible_v>>); // test non-constructibility from wrong mapping type diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map_acc.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map_acc.pass.cpp index 8ca1bf5eafb57..200d3cff81c66 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map_acc.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_map_acc.pass.cpp @@ -102,7 +102,7 @@ constexpr bool test() { using mds_t = std::mdspan>; using acc_t = std::default_accessor; - // sanity check + // soundness check static_assert(std::is_constructible_v>, acc_t>); // test non-constructibility from wrong accessor diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_span.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_span.pass.cpp index 383a490082d73..b6ebe517e8656 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_span.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/ctor.dh_span.pass.cpp @@ -118,12 +118,12 @@ constexpr void mixin_layout(const H& handle, const A& acc) { mixin_extents(handle, std::layout_left(), acc); mixin_extents(handle, std::layout_right(), acc); - // Sanity check that this layouts mapping is constructible from extents (via its move constructor) + // Soundness check that this layouts mapping is constructible from extents (via its move constructor) static_assert(std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); mixin_extents(handle, layout_wrapping_integral<8>(), acc); - // Sanity check that this layouts mapping is not constructible from extents + // Soundness check that this layouts mapping is not constructible from extents static_assert(!std::is_constructible_v::mapping>, std::extents>); static_assert( !std::is_constructible_v::mapping>, const std::extents&>); @@ -154,7 +154,7 @@ constexpr bool test() { // test non-constructibility from wrong span type constexpr size_t D = std::dynamic_extent; using mds_t = std::mdspan>; - // sanity check + // soundness check static_assert(std::is_constructible_v>); static_assert(std::is_constructible_v>); // wrong size diff --git a/libcxx/test/std/containers/views/mdspan/mdspan/types.pass.cpp b/libcxx/test/std/containers/views/mdspan/mdspan/types.pass.cpp index b576419828b71..04de5df482821 100644 --- a/libcxx/test/std/containers/views/mdspan/mdspan/types.pass.cpp +++ b/libcxx/test/std/containers/views/mdspan/mdspan/types.pass.cpp @@ -166,7 +166,7 @@ int main(int, char**) { mixin_accessor(); mixin_accessor(); - // sanity checks for triviality + // soundness checks for triviality check_triviality>, false, true, true, true, true, true>(); check_triviality>, false, true, true, true, true, true>(); check_triviality, std::layout_right, checked_accessor>, diff --git a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.space/space.pass.cpp b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.space/space.pass.cpp index 60e9ac778967e..4fa3839f27da9 100644 --- a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.space/space.pass.cpp +++ b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.space/space.pass.cpp @@ -83,7 +83,7 @@ static void basic_space_test() // All the test cases should reside on the same filesystem and therefore // should have the same expected result. Compute this expected result - // one and check that it looks semi-sane. + // one and check that it looks semi-sound. const std::uintmax_t bad_value = static_cast(-1); std::uintmax_t expect_capacity; std::uintmax_t expect_free; diff --git a/libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/str.allocator_propagation.pass.cpp b/libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/str.allocator_propagation.pass.cpp index 0effb69be2272..014d4f35c8e9c 100644 --- a/libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/str.allocator_propagation.pass.cpp +++ b/libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/str.allocator_propagation.pass.cpp @@ -43,7 +43,7 @@ void test_soccc_behavior() { assert(ss.rdbuf()->get_allocator().count_ == 10); assert(copied.empty()); - // sanity-check that SOCCC does in fact work + // soundness-check that SOCCC does in fact work assert(S(copied).get_allocator().count_ == 11); // [stringbuf.members]/10 doesn't specify the allocator to use, diff --git a/libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.members/str.allocator_propagation.pass.cpp b/libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.members/str.allocator_propagation.pass.cpp index dc57c912121dd..a3f5c6986f6eb 100644 --- a/libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.members/str.allocator_propagation.pass.cpp +++ b/libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.members/str.allocator_propagation.pass.cpp @@ -42,7 +42,7 @@ void test_soccc_behavior() { assert(ss.rdbuf()->get_allocator().count_ == 10); assert(copied.empty()); - // sanity-check that SOCCC does in fact work + // soundness-check that SOCCC does in fact work assert(S(copied).get_allocator().count_ == 11); // [stringbuf.members]/10 doesn't specify the allocator to use, diff --git a/libcxx/test/std/input.output/string.streams/stringstream/stringstream.members/str.allocator_propagation.pass.cpp b/libcxx/test/std/input.output/string.streams/stringstream/stringstream.members/str.allocator_propagation.pass.cpp index 7aa51254974fe..46924870ec21c 100644 --- a/libcxx/test/std/input.output/string.streams/stringstream/stringstream.members/str.allocator_propagation.pass.cpp +++ b/libcxx/test/std/input.output/string.streams/stringstream/stringstream.members/str.allocator_propagation.pass.cpp @@ -43,7 +43,7 @@ void test_soccc_behavior() { assert(ss.rdbuf()->get_allocator().count_ == 10); assert(copied.empty()); - // sanity-check that SOCCC does in fact work + // soundness-check that SOCCC does in fact work assert(S(copied).get_allocator().count_ == 11); // [stringbuf.members]/10 doesn't specify the allocator to use, diff --git a/libcxx/test/std/language.support/cmp/cmp.alg/compare_strong_order_fallback.pass.cpp b/libcxx/test/std/language.support/cmp/cmp.alg/compare_strong_order_fallback.pass.cpp index e1e7bc37b1d79..1ec941378bebc 100644 --- a/libcxx/test/std/language.support/cmp/cmp.alg/compare_strong_order_fallback.pass.cpp +++ b/libcxx/test/std/language.support/cmp/cmp.alg/compare_strong_order_fallback.pass.cpp @@ -134,7 +134,7 @@ constexpr bool test_1_3() static_assert(std::size(v) == 14); - // Sanity-check that array 'v' is indeed in the right order. + // Soundness-check that array 'v' is indeed in the right order. for (int i=0; i < 14; ++i) { for (int j=0; j < 14; ++j) { auto naturalOrder = (v[i] <=> v[j]); diff --git a/libcxx/test/std/language.support/cmp/cmp.alg/compare_weak_order_fallback.pass.cpp b/libcxx/test/std/language.support/cmp/cmp.alg/compare_weak_order_fallback.pass.cpp index 07b5fcd0a6d17..e69b2d8041189 100644 --- a/libcxx/test/std/language.support/cmp/cmp.alg/compare_weak_order_fallback.pass.cpp +++ b/libcxx/test/std/language.support/cmp/cmp.alg/compare_weak_order_fallback.pass.cpp @@ -133,7 +133,7 @@ constexpr bool test_1_3() static_assert(std::size(v) == 14); - // Sanity-check that array 'v' is indeed in the right order. + // Soundness-check that array 'v' is indeed in the right order. for (int i=0; i < 14; ++i) { for (int j=0; j < 14; ++j) { auto naturalOrder = (v[i] <=> v[j]); diff --git a/libcxx/test/std/language.support/cmp/cmp.alg/strong_order.pass.cpp b/libcxx/test/std/language.support/cmp/cmp.alg/strong_order.pass.cpp index e384ea289bb5b..d8404e491fb8a 100644 --- a/libcxx/test/std/language.support/cmp/cmp.alg/strong_order.pass.cpp +++ b/libcxx/test/std/language.support/cmp/cmp.alg/strong_order.pass.cpp @@ -134,7 +134,7 @@ constexpr bool test_1_3() static_assert(std::size(v) == 14); - // Sanity-check that array 'v' is indeed in the right order. + // Soundness-check that array 'v' is indeed in the right order. for (int i=0; i < 14; ++i) { for (int j=0; j < 14; ++j) { auto naturalOrder = (v[i] <=> v[j]); diff --git a/libcxx/test/std/language.support/cmp/cmp.alg/weak_order.pass.cpp b/libcxx/test/std/language.support/cmp/cmp.alg/weak_order.pass.cpp index 09d720196e0b2..2f172d8302e6d 100644 --- a/libcxx/test/std/language.support/cmp/cmp.alg/weak_order.pass.cpp +++ b/libcxx/test/std/language.support/cmp/cmp.alg/weak_order.pass.cpp @@ -133,7 +133,7 @@ constexpr bool test_1_3() static_assert(std::size(v) == 14); - // Sanity-check that array 'v' is indeed in the right order. + // Soundness-check that array 'v' is indeed in the right order. for (int i=0; i < 14; ++i) { for (int j=0; j < 14; ++j) { auto naturalOrder = (v[i] <=> v[j]); diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/utf_sanity_check.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/utf_sanity_check.pass.cpp index 62fce70052c2a..16b5ece284237 100644 --- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/utf_sanity_check.pass.cpp +++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/utf_sanity_check.pass.cpp @@ -19,7 +19,7 @@ // template <> class codecvt // C++20 // template <> class codecvt // extension -// sanity check +// soundness check #include #include diff --git a/libcxx/test/std/numerics/c.math/hermite.pass.cpp b/libcxx/test/std/numerics/c.math/hermite.pass.cpp index 2905950942581..55cff3e8de4c6 100644 --- a/libcxx/test/std/numerics/c.math/hermite.pass.cpp +++ b/libcxx/test/std/numerics/c.math/hermite.pass.cpp @@ -277,7 +277,7 @@ void test() { } } - { // sanity checks: hermite polynoms need to change signs at (simple) roots. checked upto order n<=20. + { // soundness checks: hermite polynoms need to change signs at (simple) roots. checked upto order n<=20. // root tolerance: must be smaller than the smallest difference between adjacent roots Real tol = []() -> Real { diff --git a/libcxx/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp b/libcxx/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp index f6cac33e94438..3297cba9d7cb0 100644 --- a/libcxx/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp @@ -58,7 +58,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan.pass.cpp b/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan.pass.cpp index 1c79eebb8ee2c..2fc57c76501c2 100644 --- a/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan.pass.cpp @@ -59,7 +59,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp b/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp index fb39b4f06ece7..9081bd255f391 100644 --- a/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp @@ -64,7 +64,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op_init.pass.cpp b/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op_init.pass.cpp index 4e07306c29311..d622043c0fd77 100644 --- a/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op_init.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op_init.pass.cpp @@ -64,7 +64,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp b/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp index 0d28cff511dee..9e15631bb9138 100644 --- a/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp @@ -91,8 +91,8 @@ void fp_test() T d1 = T(3.14); T d0 = std::nextafter(d1, T(2)); T d2 = std::nextafter(d1, T(5)); - assert(d0 < d1); // sanity checking - assert(d1 < d2); // sanity checking + assert(d0 < d1); // soundness checking + assert(d1 < d2); // soundness checking #if defined(__PPC__) && (defined(__LONG_DOUBLE_128__) && __LONG_DOUBLE_128__) && \ !(defined(__LONG_DOUBLE_IEEE128__) && __LONG_DOUBLE_IEEE128__) diff --git a/libcxx/test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp b/libcxx/test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp index 7e1017d4e3040..2a7947eaff1fd 100644 --- a/libcxx/test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp @@ -89,7 +89,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop.pass.cpp b/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop.pass.cpp index 1dd7661bb42ed..c01f7e16de723 100644 --- a/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop.pass.cpp @@ -78,7 +78,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop_init.pass.cpp b/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop_init.pass.cpp index 1269c3f68236b..fb11807260d09 100644 --- a/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop_init.pass.cpp +++ b/libcxx/test/std/numerics/numeric.ops/transform.inclusive.scan/transform_inclusive_scan_bop_uop_init.pass.cpp @@ -91,7 +91,7 @@ test() constexpr std::size_t triangle(size_t n) { return n*(n+1)/2; } -// Basic sanity +// Basic soundness TEST_CONSTEXPR_CXX20 void basic_tests() { diff --git a/libcxx/test/std/strings/string.view/string.view.capacity/capacity.pass.cpp b/libcxx/test/std/strings/string.view/string.view.capacity/capacity.pass.cpp index 05dad28b71786..4f42caeb44c4e 100644 --- a/libcxx/test/std/strings/string.view/string.view.capacity/capacity.pass.cpp +++ b/libcxx/test/std/strings/string.view/string.view.capacity/capacity.pass.cpp @@ -47,7 +47,7 @@ void test1() { assert(sv1.max_size() > sv1.size()); } - // Sanity check max_size() -- a string_view can't store more bytes than a single object + // Soundness check max_size() -- a string_view can't store more bytes than a single object // can contain. Any implementation that fails this check is certainly lying. { typedef typename SV::value_type CharT; diff --git a/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp b/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp index 45d694ed5c257..7f9e8ef920bd6 100644 --- a/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp +++ b/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp @@ -48,7 +48,7 @@ struct TrackedMutex { template void test() { - // Basic sanity test + // Basic soundness test { Mutex mutex; std::vector threads; diff --git a/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp b/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp index d36ca1d38f8f1..3e5990ec42a17 100644 --- a/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp +++ b/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp @@ -46,7 +46,7 @@ struct TrackedMutex { template void test() { - // Basic sanity test + // Basic soundness test { Mutex mutex; std::vector threads; diff --git a/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock.pass.cpp b/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock.pass.cpp index b6146680b6e35..59296f9db89ca 100644 --- a/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock.pass.cpp +++ b/libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock.pass.cpp @@ -47,7 +47,7 @@ struct TrackedMutex { template void test() { - // Basic sanity test + // Basic soundness test { Mutex mutex; std::vector threads; diff --git a/libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.types/is_always_equal.pass.cpp b/libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.types/is_always_equal.pass.cpp index a091647a69002..64f85c00ab11a 100644 --- a/libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.types/is_always_equal.pass.cpp +++ b/libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.types/is_always_equal.pass.cpp @@ -23,7 +23,7 @@ #include "min_allocator.h" int main(int, char**) { - // sanity checks + // soundness checks static_assert((std::is_same< std::allocator_traits>::is_always_equal, std::false_type>::value), ""); static_assert((std::is_same< std::allocator_traits>::is_always_equal, std::true_type>::value), ""); diff --git a/libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.pass.cpp b/libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.pass.cpp index 832fda32975c2..462ff8bcb050e 100644 --- a/libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.pass.cpp +++ b/libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.pass.cpp @@ -39,7 +39,7 @@ int main(int, char**) constexpr bool p = std::is_constant_evaluated(); assert(p); } - // Test the return value of the builtin for basic sanity only. It's the + // Test the return value of the builtin for basic soundness only. It's the // compiler's job to test the builtin for correctness. { static_assert(std::is_constant_evaluated(), ""); diff --git a/libcxx/test/support/filesystem_test_helper.h b/libcxx/test/support/filesystem_test_helper.h index 2ad9efb32c60f..e7c796043e8d4 100644 --- a/libcxx/test/support/filesystem_test_helper.h +++ b/libcxx/test/support/filesystem_test_helper.h @@ -641,7 +641,7 @@ inline fs::path GetWindowsInaccessibleDir() { for (const auto &ent : fs::directory_iterator(root, ec)) { if (ent != dir) continue; - // Basic sanity checks on the directory_entry + // Basic soundness checks on the directory_entry if (!ent.exists() || !ent.is_directory()) { std::fprintf(stderr, "The expected inaccessible directory \"%s\" was found " "but doesn't behave as expected, skipping tests " diff --git a/libcxx/test/support/test_comparisons.h b/libcxx/test/support/test_comparisons.h index e37ab44828c70..2f5f0c7ea9632 100644 --- a/libcxx/test/support/test_comparisons.h +++ b/libcxx/test/support/test_comparisons.h @@ -174,7 +174,7 @@ TEST_NODISCARD constexpr bool testOrderValues(Param val1, Param val2) { #endif -// Test all two comparison operations for sanity +// Test all two comparison operations for soundness template TEST_NODISCARD TEST_CONSTEXPR_CXX14 bool testEquality(const T& t1, const U& t2, bool isEqual) { diff --git a/libcxxabi/src/stdlib_new_delete.cpp b/libcxxabi/src/stdlib_new_delete.cpp index b5ed59958d17e..6914a481ae9da 100644 --- a/libcxxabi/src/stdlib_new_delete.cpp +++ b/libcxxabi/src/stdlib_new_delete.cpp @@ -14,7 +14,7 @@ #include #include -// Perform a few sanity checks on libc++ and libc++abi macros to ensure that +// Perform a few soundness checks on libc++ and libc++abi macros to ensure that // the code below can be an exact copy of the code in libcxx/src/new.cpp. #if !defined(_THROW_BAD_ALLOC) # error The _THROW_BAD_ALLOC macro should be already defined by libc++ diff --git a/libcxxabi/test/guard_threaded_test.pass.cpp b/libcxxabi/test/guard_threaded_test.pass.cpp index 78dafba7f7ecd..264f2f3273252 100644 --- a/libcxxabi/test/guard_threaded_test.pass.cpp +++ b/libcxxabi/test/guard_threaded_test.pass.cpp @@ -379,7 +379,7 @@ void test_futex_syscall() { int main(int, char**) { // Test each multi-threaded implementation with real threads. test_all_impls(); - // Test the basic sanity of the futex syscall wrappers. + // Test the basic soundness of the futex syscall wrappers. test_futex_syscall(); return 0; diff --git a/lld/ELF/InputSection.cpp b/lld/ELF/InputSection.cpp index 784ff7cc79912..56b9f6114276a 100644 --- a/lld/ELF/InputSection.cpp +++ b/lld/ELF/InputSection.cpp @@ -101,7 +101,7 @@ InputSectionBase::InputSectionBase(ObjFile &file, getFlags(file.ctx, hdr.sh_flags), hdr.sh_link, hdr.sh_info, hdr.sh_addralign, hdr.sh_entsize, getSectionContents(file, hdr), sectionKind) { - // We reject object files having insanely large alignments even though + // We reject object files having unsoundly large alignments even though // they are allowed by the spec. I think 4GB is a reasonable limitation. // We might want to relax this in the future. if (hdr.sh_addralign > UINT32_MAX) { diff --git a/lld/ELF/ScriptParser.cpp b/lld/ELF/ScriptParser.cpp index ddfa24d9cacf5..45772e1b0607d 100644 --- a/lld/ELF/ScriptParser.cpp +++ b/lld/ELF/ScriptParser.cpp @@ -555,7 +555,7 @@ void ScriptParser::readSearchDir() { // This reads an overlay description. Overlays are used to describe output // sections that use the same virtual memory range and normally would trigger -// linker's sections sanity check failures. +// linker's sections soundness check failures. // https://sourceware.org/binutils/docs/ld/Overlay-Description.html#Overlay-Description SmallVector ScriptParser::readOverlay() { Expr addrExpr; diff --git a/lld/include/lld/Common/ErrorHandler.h b/lld/include/lld/Common/ErrorHandler.h index 4db1fec268d76..0bb6f79d59f9e 100644 --- a/lld/include/lld/Common/ErrorHandler.h +++ b/lld/include/lld/Common/ErrorHandler.h @@ -42,7 +42,7 @@ // as if it were alignment 1 (which is the simplest reasonable value). // // Note that you should not continue with an invalid value; that breaks the -// internal consistency. You need to maintain all variables have some sane +// internal consistency. You need to maintain all variables have some sound // value even after an error occurred. So, when you have to continue with // some value, always use a dummy value. // diff --git a/lld/test/COFF/guard-warnings.s b/lld/test/COFF/guard-warnings.s index 092871597d1f8..4722b7cbe21b0 100644 --- a/lld/test/COFF/guard-warnings.s +++ b/lld/test/COFF/guard-warnings.s @@ -44,7 +44,7 @@ # RUN: lld-link %t/main.obj %t/loadcfg-full.obj -guard:cf,longjmp,ehcont -out:%t.exe -entry:main %basename_t-exp.lib 2>&1 | FileCheck %s --check-prefix=NOWARN --allow-empty # NOWARN-NOT: warning -# Sanity check to make sure the no-warn version has the expected data. +# Soundness check to make sure the no-warn version has the expected data. # RUN: llvm-readobj --file-headers --coff-load-config %t.exe | FileCheck --check-prefix=CHECK %s # CHECK: ImageBase: 0x140000000 # CHECK: LoadConfig [ diff --git a/lld/test/ELF/gc-sections-no-undef-error.s b/lld/test/ELF/gc-sections-no-undef-error.s index d142998b7f501..350ca466726b9 100644 --- a/lld/test/ELF/gc-sections-no-undef-error.s +++ b/lld/test/ELF/gc-sections-no-undef-error.s @@ -2,7 +2,7 @@ # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o -# Sanity check that the link will fail with the undefined error without +# Soundness check that the link will fail with the undefined error without # gc-sections. # RUN: not ld.lld %t.o -o /dev/null 2>&1 | FileCheck %s # CHECK: error: undefined symbol: undefined diff --git a/lld/test/ELF/lto/save-temps-eq.ll b/lld/test/ELF/lto/save-temps-eq.ll index 9befc99af9253..f4062211d65aa 100644 --- a/lld/test/ELF/lto/save-temps-eq.ll +++ b/lld/test/ELF/lto/save-temps-eq.ll @@ -15,7 +15,7 @@ ;; with the output from individualized save-temps later ; RUN: ld.lld main.o thin1.o --save-temps -o %t/all/a.out ; RUN: mv a.out.lto.* *.o.*.bc %t/all -;; Sanity check that everything got moved +;; Soundness check that everything got moved ; RUN: ls | count 2 ;; Check precedence if both --save-temps and --save-temps= are present diff --git a/lld/test/MachO/eh-frame-personality-dedup.s b/lld/test/MachO/eh-frame-personality-dedup.s index 8a2cabb369a10..1d2e4dcb9914d 100644 --- a/lld/test/MachO/eh-frame-personality-dedup.s +++ b/lld/test/MachO/eh-frame-personality-dedup.s @@ -4,7 +4,7 @@ # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin19.0.0 -emit-compact-unwind-non-canonical=true %t/cu.s -o %t/cu.o # RUN: %lld -dylib %t/cu.o %t/eh-frame.o -o %t/out -## Sanity check: we want our input to contain a section (and not symbol) +## Soundness check: we want our input to contain a section (and not symbol) ## relocation for the personality reference. # RUN: llvm-readobj --relocations %t/cu.o | FileCheck %s --check-prefix=SECT-RELOC # SECT-RELOC: Section __compact_unwind { diff --git a/lld/test/MachO/icf-only-lsda-folded.s b/lld/test/MachO/icf-only-lsda-folded.s index fb4296d3d3774..a84b49b8a7bc2 100644 --- a/lld/test/MachO/icf-only-lsda-folded.s +++ b/lld/test/MachO/icf-only-lsda-folded.s @@ -16,7 +16,7 @@ # RUN: llvm-objdump --macho --syms --unwind-info %t/test | FileCheck %s # CHECK: SYMBOL TABLE: -## Sanity check: Verify that the LSDAs are dedup'ed +## Soundness check: Verify that the LSDAs are dedup'ed # CHECK-NEXT: [[#%.16x, EXC:]] l O __TEXT,__gcc_except_tab _exception0 # CHECK-NEXT: [[#EXC]] l O __TEXT,__gcc_except_tab _exception1 ## But that the functions themselves aren't diff --git a/lldb/examples/summaries/cocoa/objc_runtime.py b/lldb/examples/summaries/cocoa/objc_runtime.py index 4299e57b81f6c..d25ee6aaff0fe 100644 --- a/lldb/examples/summaries/cocoa/objc_runtime.py +++ b/lldb/examples/summaries/cocoa/objc_runtime.py @@ -143,7 +143,7 @@ def __init__(self, rot_pointer, params): logger >> "Marking as invalid - name is invalid" self.valid = 0 - # perform sanity checks on the contents of this class_ro_t + # perform soundness checks on the contents of this class_ro_t def check_valid(self): self.valid = 1 # misaligned pointers seem to be possible for this field @@ -214,7 +214,7 @@ def __init__(self, rwt_pointer, params): # self.rot = self.valobj.CreateValueFromAddress("rot",self.roPointer,self.sys_params.types_cache.addr_ptr_type).AddressOf() self.data = RoT_Data(self.rot, self.sys_params) - # perform sanity checks on the contents of this class_rw_t + # perform soundness checks on the contents of this class_rw_t def check_valid(self): logger = lldb.formatters.Logger.Logger() self.valid = 1 @@ -264,7 +264,7 @@ def __init__(self, isa_pointer, params): # self.rwt = self.valobj.CreateValueFromAddress("rwt",self.dataPointer,self.sys_params.types_cache.addr_ptr_type).AddressOf() self.data = RwT_Data(self.rwt, self.sys_params) - # perform sanity checks on the contents of this class_t + # perform soundness checks on the contents of this class_t # this call tries to minimize the amount of data fetched- as soon as we have "proven" # that we have an invalid object, we stop reading def check_valid(self): @@ -441,7 +441,7 @@ def __init__(self, isa_pointer, params): logger >> "Marking as invalid - name is not valid" self.valid = 0 - # perform sanity checks on the contents of this class_t + # perform sanisoundnessty checks on the contents of this class_t def check_valid(self): logger = lldb.formatters.Logger.Logger() self.valid = 1 diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py index 2966ac04227cb..6b0425b2fc264 100644 --- a/lldb/packages/Python/lldbsuite/test/dotest.py +++ b/lldb/packages/Python/lldbsuite/test/dotest.py @@ -760,7 +760,7 @@ def getVersionForSDK(sdk): def checkCompiler(): - # Add some intervention here to sanity check that the compiler requested is sane. + # Add some intervention here to soundness check that the compiler requested is sound. # If found not to be an executable program, we abort. c = configuration.compiler if which(c): diff --git a/lldb/source/API/SBCommandInterpreter.cpp b/lldb/source/API/SBCommandInterpreter.cpp index 4ea79d336e08d..655a0e577692d 100644 --- a/lldb/source/API/SBCommandInterpreter.cpp +++ b/lldb/source/API/SBCommandInterpreter.cpp @@ -247,8 +247,8 @@ int SBCommandInterpreter::HandleCompletionWithDescriptions( LLDB_INSTRUMENT_VA(this, current_line, cursor, last_char, match_start_point, max_return_elements, matches, descriptions); - // Sanity check the arguments that are passed in: cursor & last_char have to - // be within the current_line. + // Soundness check the arguments that are passed in: cursor & last_char have + // to be within the current_line. if (current_line == nullptr || cursor == nullptr || last_char == nullptr) return 0; diff --git a/lldb/source/Commands/CommandCompletions.cpp b/lldb/source/Commands/CommandCompletions.cpp index b2fc893e13fe3..ad695cca2cb62 100644 --- a/lldb/source/Commands/CommandCompletions.cpp +++ b/lldb/source/Commands/CommandCompletions.cpp @@ -238,7 +238,7 @@ class SymbolCompleter : public Completer { ConstString func_name = sc.GetFunctionName(Mangled::ePreferDemangled); // Ensure that the function name matches the regex. This is more than - // a sanity check. It is possible that the demangled function name + // a soundness check. It is possible that the demangled function name // does not start with the prefix, for example when it's in an // anonymous namespace. if (!func_name.IsEmpty() && m_regex.Execute(func_name.GetStringRef())) diff --git a/lldb/source/Commands/CommandObjectWatchpoint.cpp b/lldb/source/Commands/CommandObjectWatchpoint.cpp index e79c3b8939fa6..2266989c9f8f0 100644 --- a/lldb/source/Commands/CommandObjectWatchpoint.cpp +++ b/lldb/source/Commands/CommandObjectWatchpoint.cpp @@ -820,7 +820,7 @@ corresponding to the byte size of the data type."); m_option_watchpoint.watch_type = OptionGroupWatchpoint::eWatchModify; } - // We passed the sanity check for the command. Proceed to set the + // We passed the soundness check for the command. Proceed to set the // watchpoint now. size_t size = 0; @@ -1014,7 +1014,7 @@ class CommandObjectWatchpointSetExpression : public CommandObjectRaw { m_option_watchpoint.watch_type = OptionGroupWatchpoint::eWatchModify; } - // We passed the sanity check for the command. Proceed to set the + // We passed the soundness check for the command. Proceed to set the // watchpoint now. lldb::addr_t addr = 0; size_t size = 0; diff --git a/lldb/source/Commands/CommandObjectWatchpointCommand.cpp b/lldb/source/Commands/CommandObjectWatchpointCommand.cpp index 32cb80b421fd6..e79458697d4fc 100644 --- a/lldb/source/Commands/CommandObjectWatchpointCommand.cpp +++ b/lldb/source/Commands/CommandObjectWatchpointCommand.cpp @@ -386,7 +386,7 @@ are no syntax errors may indicate that a function was declared but never called. uint32_t cur_wp_id = valid_wp_ids.at(i); if (cur_wp_id != LLDB_INVALID_WATCH_ID) { Watchpoint *wp = target.GetWatchpointList().FindByID(cur_wp_id).get(); - // Sanity check wp first. + // Soundness check wp first. if (wp == nullptr) continue; diff --git a/lldb/source/Core/SourceManager.cpp b/lldb/source/Core/SourceManager.cpp index f786866a18137..9af2fa23399e8 100644 --- a/lldb/source/Core/SourceManager.cpp +++ b/lldb/source/Core/SourceManager.cpp @@ -653,7 +653,7 @@ size_t SourceManager::File::DisplaySourceLines(uint32_t line, if (!s) return 0; - // Sanity check m_data_sp before proceeding. + // Soundness check m_data_sp before proceeding. if (!m_data_sp) return 0; diff --git a/lldb/source/Expression/FunctionCaller.cpp b/lldb/source/Expression/FunctionCaller.cpp index 6c93d94f691cb..d26f28e469c50 100644 --- a/lldb/source/Expression/FunctionCaller.cpp +++ b/lldb/source/Expression/FunctionCaller.cpp @@ -196,7 +196,7 @@ bool FunctionCaller::WriteFunctionArguments( } for (size_t i = 0; i < num_args; i++) { - // FIXME: We should sanity check sizes. + // FIXME: We should soundness check sizes. uint64_t offset = m_member_offsets[i + 1]; // Clang sizes are in bytes. Value *arg_value = arg_values.GetValueAtIndex(i); diff --git a/lldb/source/Expression/REPL.cpp b/lldb/source/Expression/REPL.cpp index 92017d271a2df..4952b154892f4 100644 --- a/lldb/source/Expression/REPL.cpp +++ b/lldb/source/Expression/REPL.cpp @@ -25,7 +25,7 @@ using namespace lldb_private; char REPL::ID; REPL::REPL(Target &target) : m_target(target) { - // Make sure all option values have sane defaults + // Make sure all option values have sound defaults Debugger &debugger = m_target.GetDebugger(); debugger.SetShowProgress(false); auto exe_ctx = debugger.GetCommandInterpreter().GetExecutionContext(); diff --git a/lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp b/lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp index baefbfc363d99..f105b790ee436 100644 --- a/lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp +++ b/lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp @@ -1001,7 +1001,7 @@ ValueObjectSP ABISysV_mips64::GetReturnValueObjectImpl( copy_from_extractor = &f2_data; } - // Sanity check to avoid crash + // Soundness check to avoid crash if (!copy_from_extractor || *field_byte_width > copy_from_extractor->GetByteSize()) return return_valobj_sp; diff --git a/lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp b/lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp index e4bdc44c59c10..719cf3383a057 100644 --- a/lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp +++ b/lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp @@ -815,7 +815,7 @@ ValueObjectSP ABISysV_ppc::GetReturnValueObjectImpl( } } - // These two tests are just sanity checks. If I somehow get the type + // These two tests are just soundness checks. If I somehow get the type // calculation wrong above it is better to just return nothing than to // assert or crash. if (!copy_from_extractor) diff --git a/lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp b/lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp index 7646ccda010d0..cae7059bc11aa 100644 --- a/lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp +++ b/lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp @@ -817,7 +817,7 @@ ValueObjectSP ABISysV_x86_64::GetReturnValueObjectImpl( } } } - // These two tests are just sanity checks. If I somehow get the type + // These two tests are just soundness checks. If I somehow get the type // calculation wrong above it is better to just return nothing than to // assert or crash. if (!copy_from_extractor) diff --git a/lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp b/lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp index 56df6f6b5e97c..0c1e79cb64819 100644 --- a/lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp +++ b/lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp @@ -696,7 +696,7 @@ ValueObjectSP ABIWindows_x86_64::GetReturnValueObjectImpl( copy_from_offset = used_bytes; used_bytes += field_byte_width; } - // These two tests are just sanity checks. If I somehow get the type + // These two tests are just soundness checks. If I somehow get the type // calculation wrong above it is better to just return nothing than to // assert or crash. if (!copy_from_extractor) { diff --git a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp index efb9ccc76b507..7762417a16dc1 100644 --- a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp +++ b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp @@ -249,7 +249,7 @@ bool DynamicLoaderMacOS::NotifyBreakpointHit(void *baton, ExecutionContext exe_ctx(context->exe_ctx_ref); Process *process = exe_ctx.GetProcessPtr(); - // This is a sanity check just in case this dyld_instance is an old dyld + // This is a soundness check just in case this dyld_instance is an old dyld // plugin's breakpoint still lying around. if (process != dyld_instance->m_process) return false; diff --git a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp index f839948660aa0..dfe1d48b23aa7 100644 --- a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp +++ b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp @@ -349,7 +349,7 @@ bool DynamicLoaderMacOSXDYLD::NotifyBreakpointHit( ExecutionContext exe_ctx(context->exe_ctx_ref); Process *process = exe_ctx.GetProcessPtr(); - // This is a sanity check just in case this dyld_instance is an old dyld + // This is a soundness check just in case this dyld_instance is an old dyld // plugin's breakpoint still lying around. if (process != dyld_instance->m_process) return false; diff --git a/lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp b/lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp index f3aabc12f92b7..aa309937631f3 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp @@ -109,7 +109,7 @@ bool CppModuleConfiguration::hasValidConfig() { if (!m_c_inc.Valid() || !m_std_inc.Valid()) return false; - // Do some basic sanity checks on the directories that we don't activate + // Do some basic soundness checks on the directories that we don't activate // the module when it's clear that it's not usable. const std::vector files_to_check = { // * Check that the C library contains at least one random C standard diff --git a/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp b/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp index a22083a8a0903..e15fe409f9fd8 100644 --- a/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp +++ b/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp @@ -607,7 +607,7 @@ Status NativeProcessFreeBSD::GetMemoryRegionInfo(lldb::addr_t load_addr, for (auto it = m_mem_region_cache.begin(); it != m_mem_region_cache.end(); ++it) { MemoryRegionInfo &proc_entry_info = it->first; - // Sanity check assumption that memory map entries are ascending. + // Soundness check assumption that memory map entries are ascending. assert((proc_entry_info.GetRange().GetRangeBase() >= prev_base_address) && "descending memory map entries detected, unexpected"); prev_base_address = proc_entry_info.GetRange().GetRangeBase(); diff --git a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp index 9c798cb1cc8f2..32042acb0075c 100644 --- a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp +++ b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp @@ -1230,7 +1230,7 @@ Status NativeProcessLinux::GetMemoryRegionInfo(lldb::addr_t load_addr, ++it) { MemoryRegionInfo &proc_entry_info = it->first; - // Sanity check assumption that /proc/{pid}/maps entries are ascending. + // Soundness check assumption that /proc/{pid}/maps entries are ascending. assert((proc_entry_info.GetRange().GetRangeBase() >= prev_base_address) && "descending /proc/pid/maps entries detected, unexpected"); prev_base_address = proc_entry_info.GetRange().GetRangeBase(); diff --git a/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp b/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp index 8fb15d83117f4..6b95e717d8dbd 100644 --- a/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp +++ b/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp @@ -639,7 +639,7 @@ Status NativeProcessNetBSD::GetMemoryRegionInfo(lldb::addr_t load_addr, for (auto it = m_mem_region_cache.begin(); it != m_mem_region_cache.end(); ++it) { MemoryRegionInfo &proc_entry_info = it->first; - // Sanity check assumption that memory map entries are ascending. + // Soundness check assumption that memory map entries are ascending. assert((proc_entry_info.GetRange().GetRangeBase() >= prev_base_address) && "descending memory map entries detected, unexpected"); prev_base_address = proc_entry_info.GetRange().GetRangeBase(); diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp index 88eeddf178788..23768e6143868 100644 --- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp +++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp @@ -695,7 +695,7 @@ llvm::Error ProcessElfCore::parseNetBSDNotes(llvm::ArrayRef notes) { bool had_nt_regs = false; // To be extracted from struct netbsd_elfcore_procinfo - // Used to sanity check of the LWPs of the process + // Used to soundness check of the LWPs of the process uint32_t nlwps = 0; uint32_t signo = 0; // killing signal uint32_t siglwp = 0; // LWP target of killing signal diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp index 91f3a6ce383b1..fe1d55603dac7 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -2703,7 +2703,7 @@ size_t ProcessGDBRemote::DoReadMemory(addr_t addr, void *buf, size_t size, ? m_max_memory_size : m_max_memory_size / 2; if (size > max_memory_size) { - // Keep memory read sizes down to a sane limit. This function will be + // Keep memory read sizes down to a sound limit. This function will be // called multiple times in order to complete the task by // lldb_private::Process so it is ok to do this. size = max_memory_size; @@ -2943,7 +2943,7 @@ size_t ProcessGDBRemote::DoWriteMemory(addr_t addr, const void *buf, // M and m packets take 2 bytes for 1 byte of memory size_t max_memory_size = m_max_memory_size / 2; if (size > max_memory_size) { - // Keep memory read sizes down to a sane limit. This function will be + // Keep memory read sizes down to a sound limit. This function will be // called multiple times in order to complete the task by // lldb_private::Process so it is ok to do this. size = max_memory_size; diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp index 0f1f41baced86..b4c37ec859d66 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -2763,8 +2763,8 @@ DWARFASTParserClang::MemberAttributes::MemberAttributes( // DW_AT_bit_size( 0x40 ) // DW_AT_bit_offset( 0xffffffffffffffc0 ) // - // So check the bit offset to make sure it is sane, and if the values - // are not sane, remove them. If we don't do this then we will end up + // So check the bit offset to make sure it is sound, and if the values + // are not sound, remove them. If we don't do this then we will end up // with a crash if we try to use this type in an expression when clang // becomes unhappy with its recycled debug info. if (byte_size.value_or(0) == 0 && bit_offset < 0) { diff --git a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp index c00eebc823a8c..9d9bd63612398 100644 --- a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp +++ b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp @@ -267,7 +267,7 @@ StringRef TraceIntelPTBundleLoader::GetSchema() { "loadAddress": integer | string decimal | hex string, // Lowest address of the sections of the module loaded on memory. "uuid"?: string, - // Build UUID for the file for sanity checks. + // Build UUID for the file for soundness checks. } ] } diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp index 39aacdb58e694..093ce6df51b05 100644 --- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp +++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp @@ -801,7 +801,7 @@ TypeSystemClang::GetBuiltinTypeForEncodingAndBitSize(Encoding encoding, break; case eEncodingVector: - // Sanity check that bit_size is a multiple of 8's. + // Soundness check that bit_size is a multiple of 8's. if (bit_size && !(bit_size & 0x7u)) return GetType(ast.getExtVectorType(ast.UnsignedCharTy, bit_size / 8)); break; diff --git a/lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp b/lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp index f5279758a147c..487b7ebc0d0ab 100644 --- a/lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp +++ b/lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp @@ -133,8 +133,8 @@ bool UnwindAssembly_x86::AugmentUnwindPlanFromCallSite( if (last_row_pc_loc.IsAtCFAPlusOffset() && first_row_pc_loc.GetOffset() == last_row_pc_loc.GetOffset()) { - // One last sanity check: Is the unwind rule for getting the caller - // pc value "deref the CFA-4" or "deref the CFA-8"? + // One last soundness check: Is the unwind rule for getting the + // caller pc value "deref the CFA-4" or "deref the CFA-8"? // If so, we have an UnwindPlan that already describes the epilogue // and we don't need to modify it at all. diff --git a/lldb/source/Symbol/Symbol.cpp b/lldb/source/Symbol/Symbol.cpp index 40497dbccc5c3..6bc3a5fa7c915 100644 --- a/lldb/source/Symbol/Symbol.cpp +++ b/lldb/source/Symbol/Symbol.cpp @@ -363,8 +363,8 @@ uint32_t Symbol::GetPrologueByteSize() { break; } - // Sanity check - this may be a function in the middle of code that - // has debug information, but not for this symbol. So the line + // Soundness check - this may be a function in the middle of code + // that has debug information, but not for this symbol. So the line // entries surrounding us won't lie inside our function. In that // case, the line entry will be bigger than we are, so we do that // quick check and if that is true, we just return 0. diff --git a/lldb/source/Target/RegisterContextUnwind.cpp b/lldb/source/Target/RegisterContextUnwind.cpp index bcf1297f2114f..e7933ac390f04 100644 --- a/lldb/source/Target/RegisterContextUnwind.cpp +++ b/lldb/source/Target/RegisterContextUnwind.cpp @@ -450,7 +450,7 @@ void RegisterContextUnwind::InitializeNonZerothFrame() { ReadFrameAddress(row_register_kind, row->GetAFAValue(), m_afa); - // A couple of sanity checks.. + // A couple of soundness checks.. if (m_cfa == LLDB_INVALID_ADDRESS || m_cfa == 0 || m_cfa == 1) { UnwindLogMsg("could not find a valid cfa address"); m_frame_type = eNotAValidFrame; diff --git a/lldb/source/Target/ThreadPlanStepInRange.cpp b/lldb/source/Target/ThreadPlanStepInRange.cpp index 0e93691de68af..a8a385c4e6e9c 100644 --- a/lldb/source/Target/ThreadPlanStepInRange.cpp +++ b/lldb/source/Target/ThreadPlanStepInRange.cpp @@ -300,7 +300,7 @@ void ThreadPlanStepInRange::SetAvoidRegexp(const char *name) { } void ThreadPlanStepInRange::SetDefaultFlagValue(uint32_t new_value) { - // TODO: Should we test this for sanity? + // TODO: Should we test this for soundness? ThreadPlanStepInRange::s_default_flag_values = new_value; } diff --git a/lldb/source/Target/ThreadPlanStepOverRange.cpp b/lldb/source/Target/ThreadPlanStepOverRange.cpp index 643ee827c865c..fd36496e0ac7c 100644 --- a/lldb/source/Target/ThreadPlanStepOverRange.cpp +++ b/lldb/source/Target/ThreadPlanStepOverRange.cpp @@ -109,8 +109,8 @@ bool ThreadPlanStepOverRange::IsEquivalentContext( language->AreEqualForFrameComparison(context, m_addr_context)) return *maybe_equivalent; // Match as much as is specified in the m_addr_context: This is a fairly - // loose sanity check. Note, sometimes the target doesn't get filled in so I - // left out the target check. And sometimes the module comes in as the .o + // loose soundness check. Note, sometimes the target doesn't get filled in so + // I left out the target check. And sometimes the module comes in as the .o // file from the inlined range, so I left that out too... if (m_addr_context.comp_unit) { if (m_addr_context.comp_unit != context.comp_unit) diff --git a/lldb/source/Utility/ZipFile.cpp b/lldb/source/Utility/ZipFile.cpp index b8ed956cbfcb2..24c615da01aae 100644 --- a/lldb/source/Utility/ZipFile.cpp +++ b/lldb/source/Utility/ZipFile.cpp @@ -93,7 +93,7 @@ const EocdRecord *FindEocdRecord(lldb::DataBufferSP zip_data) { auto eocd = reinterpret_cast(p); if (::memcmp(eocd->signature, EocdRecord::kSignature, sizeof(EocdRecord::kSignature)) == 0) { - // Found the end of central directory. Sanity check the values. + // Found the end of central directory. Soundness check the values. if (eocd->cd_records * sizeof(CdRecord) > eocd->cd_size || zip_data->GetBytes() + eocd->cd_offset + eocd->cd_size > p) return nullptr; @@ -141,7 +141,7 @@ bool FindFile(lldb::DataBufferSP zip_data, const EocdRecord *eocd, sizeof(CdRecord::kSignature)) != 0) return false; - // Sanity check the file name values. + // Soundness check the file name values. auto file_name = reinterpret_cast(cd + 1); size_t file_name_length = cd->file_name_length; if (file_name + file_name_length >= reinterpret_cast(eocd) || @@ -158,7 +158,7 @@ bool FindFile(lldb::DataBufferSP zip_data, const EocdRecord *eocd, cd = reinterpret_cast( reinterpret_cast(cd) + sizeof(CdRecord) + cd->file_name_length + cd->extra_field_length + cd->comment_length); - // Sanity check the pointer. + // Soundness check the pointer. if (reinterpret_cast(cd) >= reinterpret_cast(eocd)) return false; diff --git a/lldb/test/API/api/check_public_api_headers/TestPublicAPIHeaders.py b/lldb/test/API/api/check_public_api_headers/TestPublicAPIHeaders.py index 60ca8557d60b9..366fadeec2b7b 100644 --- a/lldb/test/API/api/check_public_api_headers/TestPublicAPIHeaders.py +++ b/lldb/test/API/api/check_public_api_headers/TestPublicAPIHeaders.py @@ -30,7 +30,7 @@ def test_sb_api_directory(self): self.sanity_check_executable(exe_name) def sanity_check_executable(self, exe_name): - """Sanity check executable compiled from the auto-generated program.""" + """Soundness check executable compiled from the auto-generated program.""" exe = self.getBuildArtifact(exe_name) self.runCmd("file %s" % exe, CURRENT_EXECUTABLE_SET) diff --git a/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py b/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py index 3e9dbfe6d8555..f4e80c097892d 100644 --- a/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py +++ b/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py @@ -168,7 +168,7 @@ def test_frame_recognizer_hiding(self): target, process, thread, _ = lldbutil.run_to_name_breakpoint(self, "nested") frame = thread.selected_frame - # Sanity check. + # Soundness check. self.expect( "thread backtrace", patterns=["frame.*nested", "frame.*baz", "frame.*main"] ) diff --git a/lldb/test/API/commands/memory/read/TestMemoryRead.py b/lldb/test/API/commands/memory/read/TestMemoryRead.py index 67b28ee79067b..450925d7f84db 100644 --- a/lldb/test/API/commands/memory/read/TestMemoryRead.py +++ b/lldb/test/API/commands/memory/read/TestMemoryRead.py @@ -150,7 +150,7 @@ def check_file_content(expected): expected = [s.strip() for s in expected] self.assertEqual(lines, expected) - # Sanity check. + # Soundness check. self.runCmd("memory read -f d -c 1 -o '{}' `&argc`".format(memory_read_file)) check_file_content([golden_output]) diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py index ae8e0ac08c2b0..861750adfee0d 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py @@ -1,5 +1,5 @@ """ -Test lldb behaves sanely when formatting corrupted `std::string`s. +Test lldb behaves soundly when formatting corrupted `std::string`s. """ import lldb diff --git a/lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp b/lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp index 6b39e4bf6e846..d0f266f1b8c0b 100644 --- a/lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp +++ b/lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp @@ -81,6 +81,6 @@ int main (int argc, char const *argv[]) //% self.expect_var_path('charwithtabs', summary='"Hello\t\tWorld\nI am here\t\tto say hello\n"') //% self.assertTrue(self.frame().FindVariable('longstring').GetSummary().endswith('"...')) //% self.assertTrue(self.frame().FindVariable('longconstcharstar').GetSummary().endswith('"...')) - // FIXME: make "b.data" and "c.data" work sanely + // FIXME: make "b.data" and "c.data" work soundly } diff --git a/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py b/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py index 18371669462e2..22f1c2b5838db 100644 --- a/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py +++ b/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py @@ -24,8 +24,8 @@ def _check_type(self, target, name): def _check_debug_info_is_limited(self, target): # Without other shared libraries we should only see the member declared - # in the derived class. This serves as a sanity check that we are truly - # building with limited debug info. + # in the derived class. This serves as a soundness check that we are + # truly building with limited debug info. self._check_type(target, "InheritsFromOne") self._check_type(target, "InheritsFromTwo") diff --git a/lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py b/lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py index c143da2bf94fb..19b7ee19e26cb 100644 --- a/lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py +++ b/lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py @@ -82,7 +82,7 @@ def test_api(self): @skipIfDarwinEmbedded def test_on_sane_process(self): """Test that lldb doesn't fetch the extended crash information - dictionary from a 'sane' stopped process.""" + dictionary from a 'sound' stopped process.""" self.build() target, _, _, _ = lldbutil.run_to_line_breakpoint( self, lldb.SBFileSpec(self.source), self.line diff --git a/lldb/test/API/lang/c/array_types/TestArrayTypes.py b/lldb/test/API/lang/c/array_types/TestArrayTypes.py index fc234f5842508..6490cacba617b 100644 --- a/lldb/test/API/lang/c/array_types/TestArrayTypes.py +++ b/lldb/test/API/lang/c/array_types/TestArrayTypes.py @@ -92,7 +92,7 @@ def test_and_python_api(self): breakpoint = target.BreakpointCreateByLocation("main.c", self.line) self.assertTrue(breakpoint, VALID_BREAKPOINT) - # Sanity check the print representation of breakpoint. + # Soundness check the print representation of breakpoint. bp = str(breakpoint) self.expect( bp, @@ -112,7 +112,7 @@ def test_and_python_api(self): process = target.LaunchSimple(None, None, self.get_process_working_directory()) self.assertTrue(process, PROCESS_IS_VALID) - # Sanity check the print representation of process. + # Soundness check the print representation of process. proc = str(process) self.expect( proc, @@ -125,7 +125,7 @@ def test_and_python_api(self): thread = lldbutil.get_stopped_thread(process, lldb.eStopReasonBreakpoint) self.assertIsNotNone(thread) - # Sanity check the print representation of thread. + # Soundness check the print representation of thread. thr = str(thread) # TODO(zturner): Whether the TID is printed in hex or decimal should be controlled by a setting, # and this test should read the value of the setting. This check is currently hardcoded to @@ -154,7 +154,7 @@ def test_and_python_api(self): substrs=["file = 'main.c'", "line = %d" % self.line, "locations = 1"], ) - # Sanity check the print representation of frame. + # Soundness check the print representation of frame. frame = thread.GetFrameAtIndex(0) frm = str(frame) self.expect( @@ -164,7 +164,7 @@ def test_and_python_api(self): substrs=["#%d" % frame.GetFrameID()], ) - # Lookup the "strings" string array variable and sanity check its print + # Lookup the "strings" string array variable and soundness check its print # representation. variable = frame.FindVariable("strings") var = str(variable) diff --git a/lldb/test/API/lang/cpp/dynamic-value/TestDynamicValue.py b/lldb/test/API/lang/cpp/dynamic-value/TestDynamicValue.py index a230d07219b9a..bf13ed4daa721 100644 --- a/lldb/test/API/lang/cpp/dynamic-value/TestDynamicValue.py +++ b/lldb/test/API/lang/cpp/dynamic-value/TestDynamicValue.py @@ -317,7 +317,7 @@ def test_from_core_file(self): self.target().LoadCore(core, error) self.assertSuccess(error) - # Sanity check -- the process should be able to read the object but not + # Soundness check -- the process should be able to read the object but not # its vtable.. self.process().ReadPointerFromMemory(a, error) self.assertSuccess(error) diff --git a/lldb/test/API/lang/cpp/incomplete-types/members/TestCppIncompleteTypeMembers.py b/lldb/test/API/lang/cpp/incomplete-types/members/TestCppIncompleteTypeMembers.py index 35a8a87cec8ea..07db03cc731fd 100644 --- a/lldb/test/API/lang/cpp/incomplete-types/members/TestCppIncompleteTypeMembers.py +++ b/lldb/test/API/lang/cpp/incomplete-types/members/TestCppIncompleteTypeMembers.py @@ -17,7 +17,7 @@ def test(self): self, "// break here", lldb.SBFileSpec("f.cpp") ) - # Sanity check that we really have to debug info for this type. + # Soundness check that we really have to debug info for this type. this = self.expect_var_path("this", type="A *") self.assertEqual( this.GetType().GetPointeeType().GetNumberOfFields(), 0, str(this) diff --git a/lldb/test/API/macosx/no-nlist-memory-module/TestNoNlistsDylib.py b/lldb/test/API/macosx/no-nlist-memory-module/TestNoNlistsDylib.py index 9216cf2eab164..fc96f294bbb0e 100644 --- a/lldb/test/API/macosx/no-nlist-memory-module/TestNoNlistsDylib.py +++ b/lldb/test/API/macosx/no-nlist-memory-module/TestNoNlistsDylib.py @@ -62,7 +62,7 @@ def test_no_nlist_symbols(self): self.assertFalse(m_has_nlist.IsFileBacked()) self.assertGreater(m_has_nlist.GetNumSymbols(), 0) - # And as a sanity check, get the main binary's module, + # And as a soundness check, get the main binary's module, # test that it is file backed and that it has more than # zero symbols. m_exe = target.FindModule(lldb.SBFileSpec("a.out")) diff --git a/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py b/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py index b17ee83ea04fe..1c334e8caec1b 100644 --- a/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py +++ b/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py @@ -9,7 +9,7 @@ class TestSimulatorPlatformLaunching(TestBase): NO_DEBUG_INFO_TESTCASE = True def check_load_commands(self, expected_load_command): - """sanity check the built binary for the expected number of load commands""" + """soundness check the built binary for the expected number of load commands""" load_cmds = subprocess.check_output( ["otool", "-l", self.getBuildArtifact()] ).decode("utf-8") diff --git a/lldb/test/API/python_api/value/linked_list/TestValueAPILinkedList.py b/lldb/test/API/python_api/value/linked_list/TestValueAPILinkedList.py index 2053583c04475..b1b187e2846de 100644 --- a/lldb/test/API/python_api/value/linked_list/TestValueAPILinkedList.py +++ b/lldb/test/API/python_api/value/linked_list/TestValueAPILinkedList.py @@ -67,7 +67,7 @@ def test(self): print(cvf.format(t)) list.append(int(t.GetChildMemberWithName("id").GetValue())) - # Sanity checks that the we visited all the items (no more, no less). + # Soundness checks that the we visited all the items (no more, no less). if self.TraceOn(): print("visited IDs:", list) self.assertEqual(visitedIDs, list) @@ -98,7 +98,7 @@ def eol(val): print(cvf.format(t)) list.append(int(t.GetChildMemberWithName("id").GetValue())) - # Sanity checks that the we visited all the items (no more, no less). + # Soundness checks that the we visited all the items (no more, no less). if self.TraceOn(): print("visited IDs:", list) self.assertEqual(visitedIDs, list) diff --git a/lldb/test/API/sanity/TestModuleCacheSanity.py b/lldb/test/API/sanity/TestModuleCacheSanity.py index 1d3a6b3158898..ce81efce08e4f 100644 --- a/lldb/test/API/sanity/TestModuleCacheSanity.py +++ b/lldb/test/API/sanity/TestModuleCacheSanity.py @@ -1,5 +1,5 @@ """ -This is a sanity check that verifies that the module cache path is set +This is a soundness check that verifies that the module cache path is set correctly and points inside the default test build directory. """ diff --git a/lldb/test/API/sanity/TestReprStrEquality.py b/lldb/test/API/sanity/TestReprStrEquality.py index 96eeacdd07480..8d54de6263cb1 100644 --- a/lldb/test/API/sanity/TestReprStrEquality.py +++ b/lldb/test/API/sanity/TestReprStrEquality.py @@ -1,5 +1,5 @@ """ -This is a sanity check that verifies that `repr(sbobject)` and `str(sbobject)` +This is a soundness check that verifies that `repr(sbobject)` and `str(sbobject)` produce the same string. """ diff --git a/lldb/test/API/sanity/TestSettingSkipping.py b/lldb/test/API/sanity/TestSettingSkipping.py index f0d4d266073e0..ca6b959094ddb 100644 --- a/lldb/test/API/sanity/TestSettingSkipping.py +++ b/lldb/test/API/sanity/TestSettingSkipping.py @@ -1,5 +1,5 @@ """ -This is a sanity check that verifies that test can be skipped based on settings. +This is a soundness check that verifies that test can be skipped based on settings. """ import lldb diff --git a/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py b/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py index 87507583724e6..f7f438215ac51 100644 --- a/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py +++ b/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py @@ -88,7 +88,7 @@ def test_tag_read_qMemTags_packets(self): """Test that qMemTags packets are parsed correctly and/or rejected.""" buf_address, page_size = self.prep_memtags_test() - # Sanity check that address is correct + # Soundness check that address is correct self.check_tag_read("{:x},20:1".format(buf_address), "m0001") # Invalid packets @@ -158,7 +158,7 @@ def test_tag_write_QMemTags_packets(self): """Test that QMemTags packets are parsed correctly and/or rejected.""" buf_address, page_size = self.prep_memtags_test() - # Sanity check that address is correct + # Soundness check that address is correct self.check_tag_write("{:x},10:1:0e".format(buf_address), "OK") self.check_tag_read("{:x},10:1".format(buf_address), "m0e") diff --git a/lldb/test/Shell/REPL/Basic.test b/lldb/test/Shell/REPL/Basic.test index 39791133d5f2c..98d6226416831 100644 --- a/lldb/test/Shell/REPL/Basic.test +++ b/lldb/test/Shell/REPL/Basic.test @@ -1,4 +1,4 @@ -// Basic sanity checking of the REPL. +// Basic soundness checking of the REPL. // RUN: %lldb --repl --repl-language c++ 2>&1 | FileCheck %s --check-prefix=CPP // CPP: error: must have a target to create a REPL diff --git a/lldb/test/Shell/Settings/TestModuleCacheSanity.test b/lldb/test/Shell/Settings/TestModuleCacheSanity.test index f16f40d47a6bf..cd865d2db7b2b 100644 --- a/lldb/test/Shell/Settings/TestModuleCacheSanity.test +++ b/lldb/test/Shell/Settings/TestModuleCacheSanity.test @@ -1,4 +1,4 @@ -# This is a sanity check that verifies that the module cache path is set +# This is a soundness check that verifies that the module cache path is set # correctly and points inside the default test build directory. RUN: %lldb -o 'settings show symbols.clang-modules-cache-path' | FileCheck %s CHECK: lldb-test-build.noindex{{.*}}module-cache-lldb diff --git a/lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp b/lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp index e30e02a911529..0b65e92a77643 100644 --- a/lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp +++ b/lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp @@ -1569,7 +1569,7 @@ uint32_t DNBArchMachARM64::GetHardwareWatchpointHit(nub_addr_t &addr) { } if (is_bas_watchpoint) { - // Sanity check the bas_bits + // Soundness check the bas_bits uint32_t lsb = LowestBitSet(bas_bits); if (lsb < 0) continue; diff --git a/lldb/tools/lldb-rpc-gen/server/RPCServerSourceEmitter.cpp b/lldb/tools/lldb-rpc-gen/server/RPCServerSourceEmitter.cpp index a6d2528fe2c3c..c645ce9e8ba4e 100644 --- a/lldb/tools/lldb-rpc-gen/server/RPCServerSourceEmitter.cpp +++ b/lldb/tools/lldb-rpc-gen/server/RPCServerSourceEmitter.cpp @@ -463,7 +463,7 @@ void RPCServerSourceEmitter::EmitCallbackFunction(const Method &method) { IndentLevel++; // Emit Function Body - EmitLine("// RPC connection setup and sanity checking"); + EmitLine("// RPC connection setup and soundness checking"); EmitLine("CallbackInfo *callback_info = (CallbackInfo *)baton;"); EmitLine("rpc_common::ConnectionSP connection_sp = " "rpc_common::Connection::GetConnectionFromID(callback_info->" diff --git a/lldb/unittests/Interpreter/TestCompletion.cpp b/lldb/unittests/Interpreter/TestCompletion.cpp index 3d4942787fdf5..637a881017c06 100644 --- a/lldb/unittests/Interpreter/TestCompletion.cpp +++ b/lldb/unittests/Interpreter/TestCompletion.cpp @@ -155,7 +155,7 @@ TEST_F(CompletionTest, DirCompletionAbsolute) { // When a directory is specified that doesn't end in a slash, it searches // for that directory, not items under it. - // Sanity check that the path we complete on exists and isn't too long. + // Soundness check that the path we complete on exists and isn't too long. CommandCompletions::DiskDirectories(Twine(BaseDir) + "/fooa", Results, Resolver); ASSERT_EQ(1u, Results.GetSize()); diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index b98192968a3ab..a7685b1e52573 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -459,7 +459,7 @@ if(WIN32 AND NOT UNIX) endif() include(CPack) -# Sanity check our source directory to make sure that we are not trying to +# Soundness check our source directory to make sure that we are not trying to # generate an in-source build (unless on MSVC_IDE, where it is ok), and to make # sure that we don't have any stray generated files lying around in the tree # (which would end up getting picked up by header search, instead of the correct diff --git a/llvm/cmake/platforms/WinMsvc.cmake b/llvm/cmake/platforms/WinMsvc.cmake index dfaac5048fa7a..75f73933c4bac 100644 --- a/llvm/cmake/platforms/WinMsvc.cmake +++ b/llvm/cmake/platforms/WinMsvc.cmake @@ -207,7 +207,7 @@ else() message(SEND_ERROR "Unknown host architecture ${HOST_ARCH}. Must be aarch64 (or arm64), armv7 (or arm), i686 (or x86), or x86_64 (or x64).") endif() -# Do some sanity checking to make sure we can find a native toolchain and +# Do some soundness checking to make sure we can find a native toolchain and # that the Windows SDK / MSVC STL directories look kosher. if(NOT EXISTS "${LLVM_NATIVE_TOOLCHAIN}/bin/clang-cl" OR NOT EXISTS "${LLVM_NATIVE_TOOLCHAIN}/bin/lld-link") diff --git a/llvm/docs/Atomics.rst b/llvm/docs/Atomics.rst index 4dee3e6bd9f4f..d6966c3130b28 100644 --- a/llvm/docs/Atomics.rst +++ b/llvm/docs/Atomics.rst @@ -185,7 +185,7 @@ Unordered --------- Unordered is the lowest level of atomicity. It essentially guarantees that races -produce somewhat sane results instead of having undefined behavior. It also +produce somewhat sound results instead of having undefined behavior. It also guarantees the operation to be lock-free, so it does not depend on the data being part of a special atomic structure or depend on a separate per-process global lock. Note that code generation will fail for unsupported atomic diff --git a/llvm/docs/CMake.rst b/llvm/docs/CMake.rst index ce83552919315..a3b5802f7119a 100644 --- a/llvm/docs/CMake.rst +++ b/llvm/docs/CMake.rst @@ -60,7 +60,7 @@ We use here the command-line, non-interactive CMake interface. a list of build parameters that you can modify. This can fail if CMake can't detect your toolset, or if it thinks that the - environment is not sane enough. In this case, make sure that the toolset that + environment is not sound enough. In this case, make sure that the toolset that you intend to use is the only one reachable from the shell, and that the shell itself is the correct one for your development environment. CMake will refuse to build MinGW makefiles if you have a POSIX shell reachable through the PATH diff --git a/llvm/docs/CodingStandards.rst b/llvm/docs/CodingStandards.rst index e48af0ee3054f..7a301010daf89 100644 --- a/llvm/docs/CodingStandards.rst +++ b/llvm/docs/CodingStandards.rst @@ -1557,7 +1557,7 @@ Namespace Indentation In general, we strive to reduce indentation wherever possible. This is useful because we want code to `fit into 80 columns`_ without excessive wrapping, but also because it makes it easier to understand the code. To facilitate this and -avoid some insanely deep nesting on occasion, don't indent namespaces. If it +avoid some unsoundly deep nesting on occasion, don't indent namespaces. If it helps readability, feel free to add a comment indicating what namespace is being closed by a ``}``. For example: diff --git a/llvm/docs/Contributing.rst b/llvm/docs/Contributing.rst index 28b28ffda4290..25d441cda7764 100644 --- a/llvm/docs/Contributing.rst +++ b/llvm/docs/Contributing.rst @@ -173,7 +173,7 @@ Please ask for help if you're having trouble with your particular git workflow. Git pre-push hook ^^^^^^^^^^^^^^^^^ -We include an optional pre-push hook that run some sanity checks on the revisions +We include an optional pre-push hook that run some soundness checks on the revisions you are about to push and ask confirmation if you push multiple commits at once. You can set it up (on Unix systems) by running from the repository root: diff --git a/llvm/docs/Frontend/PerformanceTips.rst b/llvm/docs/Frontend/PerformanceTips.rst index b81df707a31a6..79c1be93ab44c 100644 --- a/llvm/docs/Frontend/PerformanceTips.rst +++ b/llvm/docs/Frontend/PerformanceTips.rst @@ -289,7 +289,7 @@ couple specific suggestions: #. If your language uses range checks, consider using the IRCE pass. It is not currently part of the standard pass order. -#. A useful sanity check to run is to run your optimized IR back through the +#. A useful soundness check to run is to run your optimized IR back through the -O2 pipeline again. If you see noticeable improvement in the resulting IR, you likely need to adjust your pass order. diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst index 8d0adf3585a78..1ca35ef815fc0 100644 --- a/llvm/docs/GettingStarted.rst +++ b/llvm/docs/GettingStarted.rst @@ -881,7 +881,7 @@ build system. ``llvm/test`` ------------- -Feature and regression tests and other sanity checks on LLVM infrastructure. These +Feature and regression tests and other soundness checks on LLVM infrastructure. These are intended to run quickly and cover a lot of territory without being exhaustive. ``test-suite`` diff --git a/llvm/docs/LibFuzzer.rst b/llvm/docs/LibFuzzer.rst index 2137740896ddb..2ef56c7e99c3f 100644 --- a/llvm/docs/LibFuzzer.rst +++ b/llvm/docs/LibFuzzer.rst @@ -118,7 +118,7 @@ LibFuzzer will work without any initial seeds, but will be less efficient if the library under test accepts complex, structured inputs. -The corpus can also act as a sanity/regression check, to confirm that the +The corpus can also act as a soundness/regression check, to confirm that the fuzzing entrypoint still works and that all of the sample inputs run through the code under test without problems. diff --git a/llvm/include/llvm-c/Core.h b/llvm/include/llvm-c/Core.h index d02cf984167c9..515571eb51d71 100644 --- a/llvm/include/llvm-c/Core.h +++ b/llvm/include/llvm-c/Core.h @@ -334,7 +334,7 @@ typedef enum { typedef enum { LLVMAtomicOrderingNotAtomic = 0, /**< A load or store which is not atomic */ LLVMAtomicOrderingUnordered = 1, /**< Lowest level of atomicity, guarantees - somewhat sane results, lock free. */ + somewhat sound results, lock free. */ LLVMAtomicOrderingMonotonic = 2, /**< guarantees that if you take all the operations affecting a specific address, a consistent ordering exists */ diff --git a/llvm/include/llvm/ADT/APSInt.h b/llvm/include/llvm/ADT/APSInt.h index 88a7a6e71c817..732f853d2a1e2 100644 --- a/llvm/include/llvm/ADT/APSInt.h +++ b/llvm/include/llvm/ADT/APSInt.h @@ -90,7 +90,7 @@ class [[nodiscard]] APSInt : public APInt { bool isRepresentableByInt64() const { // For unsigned values with 64 active bits, they technically fit into a // int64_t, but the user may get negative numbers and has to manually cast - // them to unsigned. Let's not bet the user has the sanity to do that and + // them to unsigned. Let's not bet the user has the soundness to do that and // not give them a vague value at the first place. return isSigned() ? isSignedIntN(64) : isIntN(63); } diff --git a/llvm/include/llvm/ADT/IntervalMap.h b/llvm/include/llvm/ADT/IntervalMap.h index cb5943dc60e0e..1c28594330c95 100644 --- a/llvm/include/llvm/ADT/IntervalMap.h +++ b/llvm/include/llvm/ADT/IntervalMap.h @@ -554,7 +554,7 @@ class NodeRef { // // These constraints are always satisfied: // -// - Traits::stopLess(start(i), stop(i)) - Non-empty, sane intervals. +// - Traits::stopLess(start(i), stop(i)) - Non-empty, sound intervals. // // - Traits::stopLess(stop(i), start(i + 1) - Sorted. // @@ -696,7 +696,7 @@ insertFrom(unsigned &Pos, unsigned Size, KeyT a, KeyT b, ValT y) { // // When all of the leaf nodes from all the subtrees are concatenated, they must // satisfy the same constraints as a single leaf node. They must be sorted, -// sane, and fully coalesced. +// sound, and fully coalesced. // //===----------------------------------------------------------------------===// diff --git a/llvm/include/llvm/CodeGen/MachineRegisterInfo.h b/llvm/include/llvm/CodeGen/MachineRegisterInfo.h index 27b30bd5929ff..060bbcf4e1db4 100644 --- a/llvm/include/llvm/CodeGen/MachineRegisterInfo.h +++ b/llvm/include/llvm/CodeGen/MachineRegisterInfo.h @@ -262,7 +262,7 @@ class MachineRegisterInfo { LLVM_ABI void moveOperands(MachineOperand *Dst, MachineOperand *Src, unsigned NumOps); - /// Verify the sanity of the use list for Reg. + /// Verify the soundness of the use list for Reg. LLVM_ABI void verifyUseList(Register Reg) const; /// Verify the use list of all registers. diff --git a/llvm/include/llvm/CodeGen/SelectionDAG.h b/llvm/include/llvm/CodeGen/SelectionDAG.h index 8a834315646a1..25b3f7a481326 100644 --- a/llvm/include/llvm/CodeGen/SelectionDAG.h +++ b/llvm/include/llvm/CodeGen/SelectionDAG.h @@ -523,7 +523,7 @@ class SelectionDAG { /// FileName expects absolute path. If provided /// without any path separators then the file /// will be created in the current directory. - /// Error will be emitted if the path is insane. + /// Error will be emitted if the path is unsound. #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void dumpDotGraph(const Twine &FileName, const Twine &Title); #endif diff --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h index 65189916b41f1..0506fdeb05bc2 100644 --- a/llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h +++ b/llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h @@ -194,7 +194,7 @@ class DWARFDebugFrame { const Triple::ArchType Arch; // True if this is parsing an eh_frame section. const bool IsEH; - // Not zero for sane pointer values coming out of eh_frame + // Not zero for sound pointer values coming out of eh_frame const uint64_t EHFrameAddress; std::vector> Entries; diff --git a/llvm/include/llvm/IR/IntrinsicsARM.td b/llvm/include/llvm/IR/IntrinsicsARM.td index 1219ce2f86da8..2423a2a7e1d15 100644 --- a/llvm/include/llvm/IR/IntrinsicsARM.td +++ b/llvm/include/llvm/IR/IntrinsicsARM.td @@ -581,7 +581,7 @@ def int_arm_neon_vpminu : Neon_2Arg_Intrinsic; // shifts, where the constant is replicated. For consistency with VSHL (and // other variable shift instructions), left shifts have positive shift counts // and right shifts have negative shift counts. This convention is also used -// for constant right shift intrinsics, and to help preserve sanity, the +// for constant right shift intrinsics, and to help preserve soundness, the // intrinsic names use "shift" instead of either "shl" or "shr". Where // applicable, signed and unsigned versions of the intrinsics are // distinguished with "s" and "u" suffixes. A few NEON shift instructions, diff --git a/llvm/include/llvm/ProfileData/MemProfReader.h b/llvm/include/llvm/ProfileData/MemProfReader.h index 25578ecd06f12..5d4a1c2f34577 100644 --- a/llvm/include/llvm/ProfileData/MemProfReader.h +++ b/llvm/include/llvm/ProfileData/MemProfReader.h @@ -122,8 +122,8 @@ class LLVM_ABI RawMemProfReader final : public MemProfReader { // a raw binary memprof profile. static bool hasFormat(const StringRef Path); - // Create a RawMemProfReader after sanity checking the contents of the file at - // \p Path or the \p Buffer. The binary from which the profile has been + // Create a RawMemProfReader after soundness checking the contents of the file + // at \p Path or the \p Buffer. The binary from which the profile has been // collected is specified via a path in \p ProfiledBinary. static Expected> create(const Twine &Path, StringRef ProfiledBinary, bool KeepName = false); @@ -222,7 +222,7 @@ class YAMLMemProfReader final : public MemProfReader { // buffer. LLVM_ABI static bool hasFormat(const StringRef Path); - // Create a YAMLMemProfReader after sanity checking the contents of the file + // Create a YAMLMemProfReader after soundness checking the contents of the file // at \p Path or the \p Buffer. LLVM_ABI static Expected> create(const Twine &Path); diff --git a/llvm/include/llvm/Support/CommandLine.h b/llvm/include/llvm/Support/CommandLine.h index ca725b8ac8712..0be2537987732 100644 --- a/llvm/include/llvm/Support/CommandLine.h +++ b/llvm/include/llvm/Support/CommandLine.h @@ -2049,7 +2049,7 @@ LLVM_ABI void printBuildConfig(raw_ostream &OS); /// llvm::cl::ParseCommandLineOptions(). /// /// Hopefully this API can be deprecated soon. Any situation where options need -/// to be modified by tools or libraries should be handled by sane APIs rather +/// to be modified by tools or libraries should be handled by sound APIs rather /// than just handing around a global list. LLVM_ABI StringMap