diff --git a/flang/lib/Optimizer/CodeGen/CodeGen.cpp b/flang/lib/Optimizer/CodeGen/CodeGen.cpp index 76f3cbd421cb9..0800ed4db8c31 100644 --- a/flang/lib/Optimizer/CodeGen/CodeGen.cpp +++ b/flang/lib/Optimizer/CodeGen/CodeGen.cpp @@ -329,6 +329,31 @@ struct AllocaOpConversion : public fir::FIROpConversion { } // namespace namespace { + +static bool isInGlobalOp(mlir::ConversionPatternRewriter &rewriter) { + auto *thisBlock = rewriter.getInsertionBlock(); + return thisBlock && mlir::isa(thisBlock->getParentOp()); +} + +// Inside a fir.global, the input box was produced as an llvm.struct<> +// because objects cannot be handled in memory inside a fir.global body that +// must be constant foldable. However, the type translation are not +// contextual, so the fir.box type of the operation that produced the +// fir.box was translated to an llvm.ptr> and the MLIR pass +// manager inserted a builtin.unrealized_conversion_cast that was inserted +// and needs to be removed here. +// This should be called by any pattern operating on operations that are +// accepting fir.box inputs and are used in fir.global. +static mlir::Value +fixBoxInputInsideGlobalOp(mlir::ConversionPatternRewriter &rewriter, + mlir::Value box) { + if (isInGlobalOp(rewriter)) + if (auto unrealizedCast = + box.getDefiningOp()) + return unrealizedCast.getInputs()[0]; + return box; +} + /// Lower `fir.box_addr` to the sequence of operations to extract the first /// element of the box. struct BoxAddrOpConversion : public fir::FIROpConversion { @@ -341,6 +366,7 @@ struct BoxAddrOpConversion : public fir::FIROpConversion { auto loc = boxaddr.getLoc(); if (auto argty = mlir::dyn_cast(boxaddr.getVal().getType())) { + a = fixBoxInputInsideGlobalOp(rewriter, a); TypePair boxTyPair = getBoxTypePair(argty); rewriter.replaceOp(boxaddr, getBaseAddrFromBox(loc, boxTyPair, a, rewriter)); @@ -1737,12 +1763,6 @@ struct EmboxCommonConversion : public fir::FIROpConversion { xbox.getSubcomponent().size()); } - static bool isInGlobalOp(mlir::ConversionPatternRewriter &rewriter) { - auto *thisBlock = rewriter.getInsertionBlock(); - return thisBlock && - mlir::isa(thisBlock->getParentOp()); - } - /// If the embox is not in a globalOp body, allocate storage for the box; /// store the value inside and return the generated alloca. Return the input /// value otherwise. @@ -2076,21 +2096,10 @@ struct XReboxOpConversion : public EmboxCommonConversion { mlir::ConversionPatternRewriter &rewriter) const override { mlir::Location loc = rebox.getLoc(); mlir::Type idxTy = lowerTy().indexType(); - mlir::Value loweredBox = adaptor.getOperands()[0]; + mlir::Value loweredBox = + fixBoxInputInsideGlobalOp(rewriter, adaptor.getBox()); mlir::ValueRange operands = adaptor.getOperands(); - // Inside a fir.global, the input box was produced as an llvm.struct<> - // because objects cannot be handled in memory inside a fir.global body that - // must be constant foldable. However, the type translation are not - // contextual, so the fir.box type of the operation that produced the - // fir.box was translated to an llvm.ptr> and the MLIR pass - // manager inserted a builtin.unrealized_conversion_cast that was inserted - // and needs to be removed here. - if (isInGlobalOp(rewriter)) - if (auto unrealizedCast = - loweredBox.getDefiningOp()) - loweredBox = unrealizedCast.getInputs()[0]; - TypePair inputBoxTyPair = getBoxTypePair(rebox.getBox().getType()); // Create new descriptor and fill its non-shape related data. diff --git a/flang/test/Fir/box_addr-codegen-in-global.fir b/flang/test/Fir/box_addr-codegen-in-global.fir new file mode 100644 index 0000000000000..2e0b41b8cc805 --- /dev/null +++ b/flang/test/Fir/box_addr-codegen-in-global.fir @@ -0,0 +1,24 @@ +// Test codegen of fir.box_addr inside fir.global +// RUN: tco %s | FileCheck %s + +fir.global @x_addr constant : !fir.type { + %c-1 = arith.constant -1 : index + %c5 = arith.constant 5 : index + %c3 = arith.constant 3 : index + %c-3 = arith.constant -3 : index + %c2 = arith.constant 2 : index + %c1 = arith.constant 1 : index + %0 = fir.undefined !fir.type + %1 = fir.address_of(@_QFEx) : !fir.ref>> + %2 = fir.shape_shift %c1, %c2, %c-3, %c3, %c1, %c5 : (index, index, index, index, index, index) -> !fir.shapeshift<3> + %3 = fir.field_index c, !fir.type<_QFTt1{c:i32}> + %4 = fir.slice %c1, %c2, %c1, %c-3, %c-1, %c1, %c1, %c5, %c1 path %3 : (index, index, index, index, index, index, index, index, index, !fir.field) -> !fir.slice<3> + %5 = fir.embox %1(%2) [%4] : (!fir.ref>>, !fir.shapeshift<3>, !fir.slice<3>) -> !fir.box>> + %6 = fir.box_addr %5 : (!fir.box>>) -> !fir.ref> + %7 = fir.convert %6 : (!fir.ref>) -> i64 + %8 = fir.insert_value %0, %7, ["p", !fir.type] : (!fir.type, i64) -> !fir.type + fir.has_value %8 : !fir.type +} +fir.global @_QFEx target : !fir.array<2x3x5x!fir.type<_QFTt1{c:i32}>> + +// CHECK: @x_addr = constant %sometype { i64 ptrtoint (ptr @_QFEx to i64) }