From da7ed13e2bd0a7d4776135b5886a24d3e0bb9f92 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 17 Sep 2025 00:52:27 -0700 Subject: [PATCH] Fix the formatting script: do not try to update a GitHub PR without checking for should_update_gh --- llvm/utils/git/code-format-helper.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py index 7a5311d668f79..6f809c5977c75 100755 --- a/llvm/utils/git/code-format-helper.py +++ b/llvm/utils/git/code-format-helper.py @@ -173,7 +173,8 @@ def run(self, changed_files: List[str], args: FormatArgs) -> bool: f":warning: The {self.friendly_name} failed without printing " "a diff. Check the logs for stderr output. :warning:" ) - self.update_pr(comment_text, args, create_new=False) + if should_update_gh: + self.update_pr(comment_text, args, create_new=False) return False