From 016347f43430188a861dd9db33df898099de206d Mon Sep 17 00:00:00 2001 From: Daniel Paoliello Date: Wed, 17 Sep 2025 10:13:47 -0700 Subject: [PATCH] Use internal linkage for __NoopCoro_ResumeDestroy --- llvm/lib/Transforms/Coroutines/CoroEarly.cpp | 2 +- llvm/test/Transforms/Coroutines/coro-noop-pacbti.ll | 2 +- llvm/test/Transforms/Coroutines/coro-noop.ll | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Transforms/Coroutines/CoroEarly.cpp b/llvm/lib/Transforms/Coroutines/CoroEarly.cpp index 6561b1cd4ade1..471b9ebb1626d 100644 --- a/llvm/lib/Transforms/Coroutines/CoroEarly.cpp +++ b/llvm/lib/Transforms/Coroutines/CoroEarly.cpp @@ -132,7 +132,7 @@ void Lowerer::lowerCoroNoop(IntrinsicInst *II) { // Create a Noop function that does nothing. Function *NoopFn = Function::createWithDefaultAttr( - FnTy, GlobalValue::LinkageTypes::PrivateLinkage, + FnTy, GlobalValue::LinkageTypes::InternalLinkage, M.getDataLayout().getProgramAddressSpace(), "__NoopCoro_ResumeDestroy", &M); NoopFn->setCallingConv(CallingConv::Fast); diff --git a/llvm/test/Transforms/Coroutines/coro-noop-pacbti.ll b/llvm/test/Transforms/Coroutines/coro-noop-pacbti.ll index 4f302a6acc649..41a01bea48369 100644 --- a/llvm/test/Transforms/Coroutines/coro-noop-pacbti.ll +++ b/llvm/test/Transforms/Coroutines/coro-noop-pacbti.ll @@ -1,7 +1,7 @@ ; RUN: opt < %s -S -passes=coro-early | FileCheck %s -; CHECK: define private fastcc void @__NoopCoro_ResumeDestroy(ptr %0) #1 { +; CHECK: define internal fastcc void @__NoopCoro_ResumeDestroy(ptr %0) #1 { ; CHECK-NEXT: entry: ; CHECK-NEXT: ret void ; CHECK-NEXT: } diff --git a/llvm/test/Transforms/Coroutines/coro-noop.ll b/llvm/test/Transforms/Coroutines/coro-noop.ll index 1e4f19a2ef66e..7156835e5b2d5 100644 --- a/llvm/test/Transforms/Coroutines/coro-noop.ll +++ b/llvm/test/Transforms/Coroutines/coro-noop.ll @@ -26,7 +26,7 @@ declare ptr @llvm.coro.noop() !4 = !{i32 2, !"Debug Info Version", i32 3} -; CHECK: define private fastcc void @__NoopCoro_ResumeDestroy(ptr %0) !dbg ![[RESUME:[0-9]+]] { +; CHECK: define internal fastcc void @__NoopCoro_ResumeDestroy(ptr %0) !dbg ![[RESUME:[0-9]+]] { ; CHECK-NEXT: entry ; CHECK-NEXT: ret void