From 09b208f9df57c064882d8a4fb037e53d84535d58 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 23 Sep 2025 00:48:41 -0700 Subject: [PATCH] [AMDGPU] Fix sub-dword atomic flat saddr store with no D16. NFCI The pattern does not factor saddr. There is no way to write a test for it because gfx1200 does not have sram-ecc but also no saddr, and gfx1250 does not fall into this preserving category while has sram-ecc. Nevertheless, the day we could fix it that would become a problem. For now it is OK that change does not fail. That was untested before and it is untested now, but at least t16 block uses t16 patterns. --- llvm/lib/Target/AMDGPU/FLATInstructions.td | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/llvm/lib/Target/AMDGPU/FLATInstructions.td b/llvm/lib/Target/AMDGPU/FLATInstructions.td index 7e5ae25ff30e6..9f33bac4c56ea 100644 --- a/llvm/lib/Target/AMDGPU/FLATInstructions.td +++ b/llvm/lib/Target/AMDGPU/FLATInstructions.td @@ -2009,8 +2009,8 @@ let OtherPredicates = [D16PreservesUnusedBits, HasFlatAddressSpace], True16Predi defm : FlatLoadPats_D16_t16; defm : FlatStorePats_t16 ; defm : FlatStorePats_t16 ; - def : FlatStorePat ; - def : FlatStorePat ; + defm : FlatStorePats_t16 ; + defm : FlatStorePats_t16 ; } // End let OtherPredicates = [D16PreservesUnusedBits, HasFlatAddressSpace], True16Predicate = UseRealTrue16Insts defm : FlatLoadPats ;