From e3bbae3c11c27f5bb6bc04e6bd6c4a0232064425 Mon Sep 17 00:00:00 2001 From: Mark Danial Date: Fri, 26 Sep 2025 03:21:23 -0400 Subject: [PATCH 1/2] Revert changes to llvm-string stdin test and XFAIL on AIX --- llvm/test/tools/llvm-strings/stdin.test | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/llvm/test/tools/llvm-strings/stdin.test b/llvm/test/tools/llvm-strings/stdin.test index 3c60123ca8921..ef6cd131f5879 100644 --- a/llvm/test/tools/llvm-strings/stdin.test +++ b/llvm/test/tools/llvm-strings/stdin.test @@ -1,13 +1,13 @@ +; XFAIL: target={{.*}}-aix{{.*}} + ## Show that llvm-strings can handle stdin input properly. ## Case 1: output with single string. -RUN: echo -n "abcdefg" > %t -RUN: llvm-strings %t - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}} +RUN: echo -n "abcdefg" | llvm-strings - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}} CASE1: abcdefg ## Case 2: output too short for string. -RUN: echo -n "abc" > %t -RUN: llvm-strings %t - | FileCheck %s --implicit-check-not={{.}} --allow-empty +RUN: echo -n "abc" | llvm-strings - | FileCheck %s --implicit-check-not={{.}} --allow-empty ## Case 3: output with new line. RUN: printf "abcd\nefgh" | llvm-strings - | FileCheck %s --check-prefix=CASE3 --implicit-check-not={{.}} @@ -21,5 +21,4 @@ CASE4-NEXT: ghij CASE4-NEXT: klmn ## Case 5: no file name specified is equivalent to explicitly requesting stdin. -RUN: echo -n "abcdefg" > %t -RUN: llvm-strings %t - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}} +RUN: echo -n "abcdefg" | llvm-strings | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}} From 0b030e963c3ae9e2534b02262ddf684f1b1e6599 Mon Sep 17 00:00:00 2001 From: Mark Danial Date: Fri, 26 Sep 2025 03:38:33 -0400 Subject: [PATCH 2/2] Address review comment --- llvm/test/tools/llvm-strings/stdin.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/test/tools/llvm-strings/stdin.test b/llvm/test/tools/llvm-strings/stdin.test index ef6cd131f5879..63f7194ab973d 100644 --- a/llvm/test/tools/llvm-strings/stdin.test +++ b/llvm/test/tools/llvm-strings/stdin.test @@ -1,4 +1,4 @@ -; XFAIL: target={{.*}}-aix{{.*}} +# XFAIL: system-aix ## Show that llvm-strings can handle stdin input properly.