[llvm][tools][opt-viewer] Remove Python2 compatability code in optrecord.py #163744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

DavidSpickett merged 1 commit into llvm:main from DavidSpickett:llvm-optrecord

Oct 31, 2025

Collaborator

DavidSpickett commented Oct 16, 2025

LLVM requires Python >= 3.8.

itervalues was unused so I have removed it.


          [llvm][tools][opt-viewer] Remove Python2 compatability code in optrec…

5a471f8

…ord.py

LLVM requires Python >= 3.8.

itervalues was unused so I have removed it.

DavidSpickett requested a review from tru

October 16, 2025 10:53

DavidSpickett merged commit 35e1a2f into llvm:main

11 checks passed

DavidSpickett deleted the llvm-optrecord branch

October 31, 2025 09:50

Collaborator

llvm-ci commented Oct 31, 2025

LLVM Buildbot has detected a new failure on builder ml-opt-dev-x86-64 running on ml-opt-dev-x86-64-b1 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/28145

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: tools/opt-viewer/filter.test' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 5
/usr/bin/python3 /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /b/ml-opt-dev-x86-64-b1/build/test/tools/opt-viewer/Output/filter.test.tmp /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/b/ml-opt-dev-x86-64-b1/build/bin/llvm-cxxfilt
# executed command: /usr/bin/python3 /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /b/ml-opt-dev-x86-64-b1/build/test/tools/opt-viewer/Output/filter.test.tmp /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/b/ml-opt-dev-x86-64-b1/build/bin/llvm-cxxfilt
# .---command stdout------------
# | Reading YAML files...
# | 
# | 	1 of 1
# `-----------------------------
# .---command stderr------------
# | Traceback (most recent call last):
# |   File "/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 471, in <module>
# |     main()
# |   File "/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 455, in main
# |     map_remarks(all_remarks)
# |   File "/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 299, in map_remarks
# |     for remark in optrecord.itervalues(all_remarks):
# |                   ^^^^^^^^^^^^^^^^^^^^
# | AttributeError: module 'optrecord' has no attribute 'itervalues'
# `-----------------------------
# error: command failed with exit status: 1

--

********************

Collaborator

llvm-ci commented Oct 31, 2025

LLVM Buildbot has detected a new failure on builder ml-opt-devrel-x86-64 running on ml-opt-devrel-x86-64-b2 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/27962

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: tools/opt-viewer/basic.test' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 5
/usr/bin/python3 /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py -s /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /b/ml-opt-devrel-x86-64-b1/build/test/tools/opt-viewer/Output/basic.test.tmp /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/b/ml-opt-devrel-x86-64-b1/build/bin/llvm-cxxfilt
# executed command: /usr/bin/python3 /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py -s /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /b/ml-opt-devrel-x86-64-b1/build/test/tools/opt-viewer/Output/basic.test.tmp /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/b/ml-opt-devrel-x86-64-b1/build/bin/llvm-cxxfilt
# .---command stdout------------
# | Reading YAML files...
# | 
# | 	1 of 1
# `-----------------------------
# .---command stderr------------
# | Traceback (most recent call last):
# |   File "/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 471, in <module>
# |     main()
# |   File "/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 455, in main
# |     map_remarks(all_remarks)
# |   File "/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 299, in map_remarks
# |     for remark in optrecord.itervalues(all_remarks):
# |                   ^^^^^^^^^^^^^^^^^^^^
# | AttributeError: module 'optrecord' has no attribute 'itervalues'
# `-----------------------------
# error: command failed with exit status: 1

--

********************

Collaborator

llvm-ci commented Oct 31, 2025

LLVM Buildbot has detected a new failure on builder lld-x86_64-ubuntu-fast running on as-builder-4 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/25664

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: tools/opt-viewer/suppress.test' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/usr/bin/python3 /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/opt-viewer/opt-viewer.py -s /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/test/tools/opt-viewer/Inputs/suppress -o /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/test/tools/opt-viewer/Output/suppress.test.tmp /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/test/tools/opt-viewer/Inputs/suppress/s.opt.yaml --no-highlight --demangler=/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/bin/llvm-cxxfilt
# executed command: /usr/bin/python3 /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/opt-viewer/opt-viewer.py -s /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/test/tools/opt-viewer/Inputs/suppress -o /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/test/tools/opt-viewer/Output/suppress.test.tmp /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/test/tools/opt-viewer/Inputs/suppress/s.opt.yaml --no-highlight --demangler=/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/bin/llvm-cxxfilt
# .---command stdout------------
# | Reading YAML files...
# | 
# | 	1 of 1
# `-----------------------------
# .---command stderr------------
# | /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/opt-viewer/opt-viewer.py:138: SyntaxWarning: invalid escape sequence '\S'
# |   indent = re.sub("\S", " ", indent)
# | Traceback (most recent call last):
# |   File "/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 471, in <module>
# |     main()
# |   File "/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 455, in main
# |     map_remarks(all_remarks)
# |   File "/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 299, in map_remarks
# |     for remark in optrecord.itervalues(all_remarks):
# |                   ^^^^^^^^^^^^^^^^^^^^
# | AttributeError: module 'optrecord' has no attribute 'itervalues'
# `-----------------------------
# error: command failed with exit status: 1

--

********************

Collaborator

llvm-ci commented Oct 31, 2025

LLVM Buildbot has detected a new failure on builder ml-opt-rel-x86-64 running on ml-opt-rel-x86-64-b2 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/185/builds/27981

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: tools/opt-viewer/filter.test' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 5
/usr/bin/python3 /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /b/ml-opt-rel-x86-64-b1/build/test/tools/opt-viewer/Output/filter.test.tmp /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/b/ml-opt-rel-x86-64-b1/build/bin/llvm-cxxfilt
# executed command: /usr/bin/python3 /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /b/ml-opt-rel-x86-64-b1/build/test/tools/opt-viewer/Output/filter.test.tmp /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/b/ml-opt-rel-x86-64-b1/build/bin/llvm-cxxfilt
# .---command stdout------------
# | Reading YAML files...
# | 
# | 	1 of 1
# `-----------------------------
# .---command stderr------------
# | Traceback (most recent call last):
# |   File "/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 471, in <module>
# |     main()
# |   File "/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 455, in main
# |     map_remarks(all_remarks)
# |   File "/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 299, in map_remarks
# |     for remark in optrecord.itervalues(all_remarks):
# |                   ^^^^^^^^^^^^^^^^^^^^
# | AttributeError: module 'optrecord' has no attribute 'itervalues'
# `-----------------------------
# error: command failed with exit status: 1

--

********************

Collaborator

llvm-ci commented Oct 31, 2025

LLVM Buildbot has detected a new failure on builder llvm-nvptx64-nvidia-ubuntu running on as-builder-7 while building llvm at step 6 "test-build-unified-tree-check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/27460

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-llvm) failure: test (failure)
******************** TEST 'LLVM :: tools/opt-viewer/filter.test' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 5
/usr/bin/python3 /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/build/test/tools/opt-viewer/Output/filter.test.tmp /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/build/bin/llvm-cxxfilt
# executed command: /usr/bin/python3 /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/build/test/tools/opt-viewer/Output/filter.test.tmp /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/build/bin/llvm-cxxfilt
# .---command stdout------------
# | Reading YAML files...
# | 
# | 	1 of 1
# `-----------------------------
# .---command stderr------------
# | /home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py:138: SyntaxWarning: invalid escape sequence '\S'
# |   indent = re.sub("\S", " ", indent)
# | Traceback (most recent call last):
# |   File "/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 471, in <module>
# |     main()
# |   File "/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 455, in main
# |     map_remarks(all_remarks)
# |   File "/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 299, in map_remarks
# |     for remark in optrecord.itervalues(all_remarks):
# |                   ^^^^^^^^^^^^^^^^^^^^
# | AttributeError: module 'optrecord' has no attribute 'itervalues'
# `-----------------------------
# error: command failed with exit status: 1

--

********************

Collaborator

llvm-ci commented Oct 31, 2025

LLVM Buildbot has detected a new failure on builder llvm-nvptx-nvidia-ubuntu running on as-builder-7 while building llvm at step 6 "test-build-unified-tree-check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/27600

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-llvm) failure: test (failure)
******************** TEST 'LLVM :: tools/opt-viewer/filter.test' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 5
/usr/bin/python3 /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/test/tools/opt-viewer/Output/filter.test.tmp /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/bin/llvm-cxxfilt
# executed command: /usr/bin/python3 /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py --filter inline -s /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs -o /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/test/tools/opt-viewer/Output/filter.test.tmp /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/test/tools/opt-viewer/Inputs/basic/or.yaml --no-highlight --demangler=/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/bin/llvm-cxxfilt
# .---command stdout------------
# | Reading YAML files...
# | 
# | 	1 of 1
# `-----------------------------
# .---command stderr------------
# | /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py:138: SyntaxWarning: invalid escape sequence '\S'
# |   indent = re.sub("\S", " ", indent)
# | Traceback (most recent call last):
# |   File "/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 471, in <module>
# |     main()
# |   File "/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 455, in main
# |     map_remarks(all_remarks)
# |   File "/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/tools/opt-viewer/opt-viewer.py", line 299, in map_remarks
# |     for remark in optrecord.itervalues(all_remarks):
# |                   ^^^^^^^^^^^^^^^^^^^^
# | AttributeError: module 'optrecord' has no attribute 'itervalues'
# `-----------------------------
# error: command failed with exit status: 1

--

********************

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet