Fix build failures related to PR #164551 #164962
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CMake change lgtm to fix the error we are seeing on our buildbot. |
|
Can we get this checked in soon if it fixes the bots? This has been causing failures for 6 hours already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build failures in LibraryResolverTest and silence symlink warning
This commit resolves two issues observed in the build bots:
Silences the -Wunused-result warning by handling the return value
of ::symlink in LibraryResolverTest.cpp. Previously, ignoring
the return value triggered compiler warnings.
Fixes a linker error in OrcJITTests caused by an undefined
symbol:
llvm::yaml::convertYAML. The test setup inLibraryResolverTest.cpp now correctly links against the required
LLVM YAML library symbols.
This resolves the build failures for PR #164551 on the affected bots.