Skip to content

Conversation

@dominik-wojt-2311446
Copy link

When OMPT is enabled, the stack pointer was not saved to frame pointer register immediately after storing the frame pointer to the stack. Therefore the frame pointers did not constitute a proper chain.
Fixes #163352

When OMPT is enabled, the stack pointer was not saved to frame pointer
register immediately after storing the frame pointer to the stack.
Therefore the frame pointers did not constitute a proper chain.
@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Oct 27, 2025
Copy link
Member

@MacDue MacDue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I've tagged some reviewers who have worked on/reviewed OpenMP changes before.

Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the AArch64 asm very well, but I don't see any issue from OpenMP's perspective. Would be good to have some tests if possible.

@jprotze
Copy link
Collaborator

jprotze commented Oct 30, 2025

Running the ompt/tasks/task_types.c test should tell you whether the change broke something for OMPT:

LIT_FILTER=ompt/tasks/task_types.c make check-openmp
or
LIT_FILTER=ompt/tasks/task_types.c ninja check-openmp

If check-openmp cannot be found for a runtime build of openmp, you might need to go to BUILD/runtimes/runtimes-bin/ and start the test from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openmp:libomp OpenMP host runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OpenMP][Aarch64] Invalid frame pointers break profiling with nsight

5 participants