From ab745dccf4953a4bc63af9654df329f721df6bb8 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Mon, 27 Oct 2025 13:57:45 -0700 Subject: [PATCH 1/2] The test added for PR#164905 doesn't run on Windows. --- lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py b/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py index cff97b822db81..45a59f7839964 100644 --- a/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py +++ b/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py @@ -20,6 +20,9 @@ class TestDriverWithClosedSTDIO(TestBase): # each debug info format. NO_DEBUG_INFO_TESTCASE = True + # Windows doesn't have the fcntl module, so we can't run this + # test there. + @skipIf(oslist=["windows"]) def test_run_lldb_and_wait(self): """This test forks, closes the stdio channels and exec's lldb. Then it waits for it to exit and asserts it did that successfully""" From cad983aa54a5b86ea7cd002b2652c0f63800a2c5 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Mon, 27 Oct 2025 15:19:38 -0700 Subject: [PATCH 2/2] Remember to import the decorators module before using it... --- lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py b/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py index 45a59f7839964..751926b116002 100644 --- a/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py +++ b/lldb/test/API/driver/stdio_closed/TestDriverWithClosedSTDIO.py @@ -12,7 +12,7 @@ import lldbsuite.test.lldbutil as lldbutil from lldbsuite.test.lldbtest import * - +from lldbsuite.test.decorators import * class TestDriverWithClosedSTDIO(TestBase): # If your test case doesn't stress debug info, then