From 4e7b4c71c82443a56325281fbf4d5727e75633d2 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 6 Nov 2025 13:30:32 -0800 Subject: [PATCH] [BOLT] Remove redundant declarations (NFC) In C++17, static constexpr members are implicitly inline, so they no longer require an out-of-line definition. Identified with readability-redundant-declaration. --- bolt/lib/Core/BinaryBasicBlock.cpp | 2 -- bolt/lib/Core/DynoStats.cpp | 2 -- bolt/lib/Profile/DataAggregator.cpp | 2 -- bolt/lib/Rewrite/RewriteInstance.cpp | 1 - 4 files changed, 7 deletions(-) diff --git a/bolt/lib/Core/BinaryBasicBlock.cpp b/bolt/lib/Core/BinaryBasicBlock.cpp index d680850bf2ea9..a6d0ca9481154 100644 --- a/bolt/lib/Core/BinaryBasicBlock.cpp +++ b/bolt/lib/Core/BinaryBasicBlock.cpp @@ -22,8 +22,6 @@ namespace llvm { namespace bolt { -constexpr uint32_t BinaryBasicBlock::INVALID_OFFSET; - bool operator<(const BinaryBasicBlock &LHS, const BinaryBasicBlock &RHS) { return LHS.Index < RHS.Index; } diff --git a/bolt/lib/Core/DynoStats.cpp b/bolt/lib/Core/DynoStats.cpp index 1d9818777596e..64a6d12b76e82 100644 --- a/bolt/lib/Core/DynoStats.cpp +++ b/bolt/lib/Core/DynoStats.cpp @@ -51,8 +51,6 @@ PrintDynoOpcodeStat("print-dyno-opcode-stats", namespace llvm { namespace bolt { -constexpr const char *DynoStats::Desc[]; - bool DynoStats::operator<(const DynoStats &Other) const { return std::lexicographical_compare( &Stats[FIRST_DYNO_STAT], &Stats[LAST_DYNO_STAT], diff --git a/bolt/lib/Profile/DataAggregator.cpp b/bolt/lib/Profile/DataAggregator.cpp index 8554683bc3cf8..cafe4bfebf19d 100644 --- a/bolt/lib/Profile/DataAggregator.cpp +++ b/bolt/lib/Profile/DataAggregator.cpp @@ -159,8 +159,6 @@ std::vector getTextSections(const BinaryContext *BC) { } } -constexpr uint64_t DataAggregator::KernelBaseAddr; - DataAggregator::~DataAggregator() { deleteTempFiles(); } namespace { diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp index 77e5688781d57..ab3431ef8bd5e 100644 --- a/bolt/lib/Rewrite/RewriteInstance.cpp +++ b/bolt/lib/Rewrite/RewriteInstance.cpp @@ -295,7 +295,6 @@ cl::bits GadgetScannersToRun( } // namespace opts // FIXME: implement a better way to mark sections for replacement. -constexpr const char *RewriteInstance::SectionsToOverwrite[]; std::vector RewriteInstance::DebugSectionsToOverwrite = { ".debug_abbrev", ".debug_aranges", ".debug_line", ".debug_line_str", ".debug_loc", ".debug_loclists", ".debug_ranges", ".debug_rnglists",