[MLIR][Linalg] fix linalg.pack description #167045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix formula describing the mapping from inner_tiles to result shape. When the comment says "tiles are added to the end of the result tensor" it is meant to say tile dimensions are after the dimension that have been tiled.
RoboTux
requested review from
dcaballe,
nicolasvasilache and
rengolin
as code owners
Member
|
@llvm/pr-subscribers-mlir Author: Thomas Preud'homme (RoboTux) ChangesFix formula describing the mapping from inner_tiles to result shape. Full diff: https://github.com/llvm/llvm-project/pull/167045.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td
index 6504ca8664d49..4b735521072af 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td
@@ -108,7 +108,7 @@ def Linalg_PackOp : Linalg_RelayoutOp<"pack", [
within [0, n).
- The tiled dimensions (of size `inner_tiles`) are added to the end of the
result tensor in the order in which they appear, i.e.
- `shape(result)[rank(result) + i] = inner_tiles[i]` for `0 <= i < k`.
+ `shape(result)[rank(source) + i] = inner_tiles[i]` for `0 <= i < k`.
- The following relationship for the tiled dimensions holds:
`shape(result)[inner_dims_pos[i]] = shape(source)[inner_dims_pos[i]] / inner_tiles[i]`,
where (⌈/⌉ indicates CeilDiv).
|
Member
|
@llvm/pr-subscribers-mlir-linalg Author: Thomas Preud'homme (RoboTux) ChangesFix formula describing the mapping from inner_tiles to result shape. Full diff: https://github.com/llvm/llvm-project/pull/167045.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td
index 6504ca8664d49..4b735521072af 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td
@@ -108,7 +108,7 @@ def Linalg_PackOp : Linalg_RelayoutOp<"pack", [
within [0, n).
- The tiled dimensions (of size `inner_tiles`) are added to the end of the
result tensor in the order in which they appear, i.e.
- `shape(result)[rank(result) + i] = inner_tiles[i]` for `0 <= i < k`.
+ `shape(result)[rank(source) + i] = inner_tiles[i]` for `0 <= i < k`.
- The following relationship for the tiled dimensions holds:
`shape(result)[inner_dims_pos[i]] = shape(source)[inner_dims_pos[i]] / inner_tiles[i]`,
where (⌈/⌉ indicates CeilDiv).
|
banach-space
approved these changes
Nov 11, 2025
Contributor
banach-space
left a comment
banach-space
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix and apologies for the delay reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix formula describing the mapping from inner_tiles to result shape.
When the comment says "tiles are added to the end of the result tensor"
it is meant to say tile dimensions are after the dimension that have
been tiled.