[mlir] Remove unused local variables (NFC) #167107
Merged
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified with bugprone-unused-local-non-trivial-variable.
Member
|
@llvm/pr-subscribers-mlir-openacc @llvm/pr-subscribers-mlir-scf Author: Kazu Hirata (kazutakahirata) ChangesIdentified with bugprone-unused-local-non-trivial-variable. Full diff: https://github.com/llvm/llvm-project/pull/167107.diff 4 Files Affected:
diff --git a/mlir/lib/Dialect/Affine/Utils/Utils.cpp b/mlir/lib/Dialect/Affine/Utils/Utils.cpp
index 845be20d15b69..deba1600e28a0 100644
--- a/mlir/lib/Dialect/Affine/Utils/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Utils/Utils.cpp
@@ -1327,9 +1327,6 @@ LogicalResult mlir::affine::replaceAllMemRefUsesWith(
assert(cast<MemRefType>(oldMemRef.getType()).getElementType() ==
cast<MemRefType>(newMemRef.getType()).getElementType());
- std::unique_ptr<DominanceInfo> domInfo;
- std::unique_ptr<PostDominanceInfo> postDomInfo;
-
// Walk all uses of old memref; collect ops to perform replacement. We use a
// DenseSet since an operation could potentially have multiple uses of a
// memref (although rare), and the replacement later is going to erase ops.
diff --git a/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp b/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
index 57b610b31e964..8a0440bcc6fb9 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
@@ -216,8 +216,6 @@ struct LinalgOpTilingInterface
SmallVectorImpl<OpFoldResult> &iterDomainSizes) const {
auto linalgOp = cast<LinalgOp>(op);
- std::optional<SmallVector<OpFoldResult>> iterationSpaceOffsets,
- iterationSpaceSizes;
SmallVector<AffineMap> indexingMaps =
llvm::map_to_vector(operandNumbers, [&](unsigned operandNumber) {
OpOperand &opOperand = linalgOp->getOpOperand(operandNumber);
diff --git a/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp b/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
index a99e4846eea20..91262bd76ca31 100644
--- a/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
+++ b/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
@@ -571,7 +571,6 @@ Operation *ACCImplicitData::generateDataClauseOpForCandidate(
/*structured=*/true, /*implicit=*/true,
accSupport.getVariableName(var));
} else {
- SmallVector<Value> bounds;
auto copyinOp =
acc::CopyinOp::create(builder, loc, var,
/*structured=*/true, /*implicit=*/true,
diff --git a/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp b/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp
index 8f7d5e308f433..c469a991fff64 100644
--- a/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp
+++ b/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp
@@ -44,7 +44,6 @@ mlir::scf::parallelForToNestedFors(RewriterBase &rewriter,
lowerBounds.size() == steps.size() &&
"Mismatched parallel loop bounds");
- SmallVector<Value> ivs;
scf::LoopNest loopNest =
scf::buildLoopNest(rewriter, loc, lowerBounds, upperBounds, steps);
|
Member
|
@llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesIdentified with bugprone-unused-local-non-trivial-variable. Full diff: https://github.com/llvm/llvm-project/pull/167107.diff 4 Files Affected:
diff --git a/mlir/lib/Dialect/Affine/Utils/Utils.cpp b/mlir/lib/Dialect/Affine/Utils/Utils.cpp
index 845be20d15b69..deba1600e28a0 100644
--- a/mlir/lib/Dialect/Affine/Utils/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Utils/Utils.cpp
@@ -1327,9 +1327,6 @@ LogicalResult mlir::affine::replaceAllMemRefUsesWith(
assert(cast<MemRefType>(oldMemRef.getType()).getElementType() ==
cast<MemRefType>(newMemRef.getType()).getElementType());
- std::unique_ptr<DominanceInfo> domInfo;
- std::unique_ptr<PostDominanceInfo> postDomInfo;
-
// Walk all uses of old memref; collect ops to perform replacement. We use a
// DenseSet since an operation could potentially have multiple uses of a
// memref (although rare), and the replacement later is going to erase ops.
diff --git a/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp b/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
index 57b610b31e964..8a0440bcc6fb9 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
@@ -216,8 +216,6 @@ struct LinalgOpTilingInterface
SmallVectorImpl<OpFoldResult> &iterDomainSizes) const {
auto linalgOp = cast<LinalgOp>(op);
- std::optional<SmallVector<OpFoldResult>> iterationSpaceOffsets,
- iterationSpaceSizes;
SmallVector<AffineMap> indexingMaps =
llvm::map_to_vector(operandNumbers, [&](unsigned operandNumber) {
OpOperand &opOperand = linalgOp->getOpOperand(operandNumber);
diff --git a/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp b/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
index a99e4846eea20..91262bd76ca31 100644
--- a/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
+++ b/mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
@@ -571,7 +571,6 @@ Operation *ACCImplicitData::generateDataClauseOpForCandidate(
/*structured=*/true, /*implicit=*/true,
accSupport.getVariableName(var));
} else {
- SmallVector<Value> bounds;
auto copyinOp =
acc::CopyinOp::create(builder, loc, var,
/*structured=*/true, /*implicit=*/true,
diff --git a/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp b/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp
index 8f7d5e308f433..c469a991fff64 100644
--- a/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp
+++ b/mlir/lib/Dialect/SCF/Transforms/ParallelForToNestedFors.cpp
@@ -44,7 +44,6 @@ mlir::scf::parallelForToNestedFors(RewriterBase &rewriter,
lowerBounds.size() == steps.size() &&
"Mismatched parallel loop bounds");
- SmallVector<Value> ivs;
scf::LoopNest loopNest =
scf::buildLoopNest(rewriter, loc, lowerBounds, upperBounds, steps);
|
tgymnich
approved these changes
Nov 8, 2025
kuhar
approved these changes
Nov 8, 2025
kazutakahirata
deleted the
cleanup_20251107_clang_tidy_bugprone-unused-local-non-trivial-variable_mlir
branch
vinay-deshmukh
pushed a commit
to vinay-deshmukh/llvm-project
that referenced
this pull request
Nov 8, 2025
Identified with bugprone-unused-local-non-trivial-variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified with bugprone-unused-local-non-trivial-variable.