Skip to content

[clang][SPIRV] Don't addrspacecast nullptr for function pointer types #167379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
+19 −3
Merged

[clang][SPIRV] Don't addrspacecast nullptr for function pointer types #167379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion clang/lib/CodeGen/Targets/SPIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,16 @@ CommonSPIRTargetCodeGenInfo::getNullPointer(const CodeGen::CodeGenModule &CGM,
LangAS AS = QT->getUnqualifiedDesugaredType()->isNullPtrType()
? LangAS::Default
: QT->getPointeeType().getAddressSpace();
unsigned ASAsInt = static_cast<unsigned>(AS);
unsigned FirstTargetASAsInt =
static_cast<unsigned>(LangAS::FirstTargetAddressSpace);
unsigned CodeSectionINTELAS = FirstTargetASAsInt + 9;
// As per SPV_INTEL_function_pointers, it is illegal to addrspacecast
// function pointers to/from the generic AS.
bool IsFunctionPtrAS =
CGM.getTriple().isSPIRV() && ASAsInt == CodeSectionINTELAS;
if (AS == LangAS::Default || AS == LangAS::opencl_generic ||
AS == LangAS::opencl_constant)
AS == LangAS::opencl_constant || IsFunctionPtrAS)
return llvm::ConstantPointerNull::get(PT);

auto &Ctx = CGM.getContext();
Expand Down
12 changes: 10 additions & 2 deletions clang/test/CodeGenSPIRV/spirv-intel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: %clang_cc1 -triple spirv64-intel %s -emit-llvm -o - | FileCheck -check-prefix=CHECK-WITH-64 %s
// RUN: %clang_cc1 -triple spirv32-intel %s -emit-llvm -o - | FileCheck -check-prefix=CHECK-WITH-32 %s
// RUN: %clang_cc1 -triple spirv64-intel %s -emit-llvm -o - | FileCheck -check-prefixes=CHECK-WITH,CHECK-WITH-64 %s
// RUN: %clang_cc1 -triple spirv32-intel %s -emit-llvm -o - | FileCheck -check-prefixes=CHECK-WITH,CHECK-WITH-32 %s
// RUN: %clang_cc1 -triple spir-intel %s -emit-llvm -o - | FileCheck -check-prefix=CHECK-WITHOUT %s
// RUN: %clang_cc1 -triple spir64-intel %s -emit-llvm -o - | FileCheck -check-prefix=CHECK-WITHOUT %s

Expand All @@ -9,3 +9,11 @@
// CHECK-WITHOUT: spir_func void @foo(ptr noundef %param) #0 {
void foo(int *param) {
}

typedef __attribute__((address_space(9))) void * FnPtrTy;

// CHECK-WITH: %{{.*}} = icmp eq ptr addrspace(9) %{{.*}}, null
int bar() {
FnPtrTy FnPtr = (FnPtrTy)foo;
return FnPtr == 0;
}
Loading